13730 Commits

Author SHA1 Message Date
tjt263
b47b528859
Fix CaskAlreadyCreatedError message output
Minor edit.
2018-04-30 05:29:28 +08:00
Mike McQuaid
03dd26c5fa
Merge pull request #4113 from commitay/post_install
components_order_cop: add post_install
2018-04-29 08:51:28 +01:00
Mike McQuaid
ef32524fa3
Merge pull request #4118 from MikeMcQuaid/consistent-runtime-dependencies
formula: read runtime dependencies from more tabs.
2018-04-29 08:49:07 +01:00
Mike McQuaid
8f3ddf968f linkage_checker: correctly handle multiple taps.
Fix upgrades of formulae with the same name in multiple taps.

As reported in:
https://github.com/Homebrew/brew/pull/3789#issuecomment-384890624
2018-04-28 17:24:48 +01:00
Mike McQuaid
191724ce83 formula: read runtime dependencies from more tabs.
The fixes the issue mentioned in:
https://github.com/Homebrew/brew/pull/4066#issuecomment-381308153
where `brew missing` was not reading from a tab of an outdated formula.

The `installed_prefix.directory?` check is unnecessary as the following
`opt_or_installed_prefix_keg` call is already checking that when it is
necessary. In this case it's not necessary anyway as `opt_prefix` is
preferred and makes more sense on outdated formulae.
2018-04-28 15:29:19 +01:00
commitay
44937fcf95 components_order_cop: add post_install 2018-04-27 10:26:58 +10:00
ilovezfs
ae6ae30857
Merge pull request #4110 from commitay/desc_cop
formula_desc_cop desclength: make non-strict
2018-04-25 06:01:42 -07:00
Mike McQuaid
8035afcc36 linkage_checker: fix generic pathname calls. 2018-04-25 12:08:33 +01:00
Mike McQuaid
3454d6a961 runtime_deps: improve documentation and consistency. 2018-04-25 11:44:29 +01:00
Mike McQuaid
598bbd4c72
Merge branch 'master' into undeclared_runtime_dependencies 2018-04-25 10:41:43 +01:00
Mike McQuaid
c167614797 linkage_checker: handle missing formulae. 2018-04-25 10:26:02 +01:00
Mike McQuaid
71f4f522d7 missing_formula: improve migration messaging.
Particularly in the cask case we can do a better job of communicating
how the new formula can be installed.

Fixes #4089.
2018-04-25 10:16:22 +01:00
Mike McQuaid
9089ea4df3
Merge pull request #4109 from commitay/components_redundancy_cop
components_redundancy_cop: make non-strict
2018-04-25 08:32:35 +01:00
Mike McQuaid
56124f2918
Merge pull request #4108 from commitay/urls_cop_pypi
urls_cop pypiurls: make non-strict
2018-04-25 08:32:30 +01:00
Mike McQuaid
8f546918df
Merge pull request #4105 from commitay/components_order
components_order_cop: make non-strict
2018-04-25 08:28:03 +01:00
commitay
156451bd4b formula_desc_cop desclength: make non-strict 2018-04-25 16:38:40 +10:00
commitay
1b7e6f7eb2 urls_cop pypiurls: make non-strict 2018-04-25 12:18:22 +10:00
commitay
9e24cb9c62 components_redundancy_cop: make non-strict 2018-04-25 07:58:01 +10:00
Markus Reiter
5195e72242
Merge pull request #4064 from elyscape/tap-autoupdate
Support enabling auto-updates for non-GitHub taps
2018-04-24 20:54:08 +02:00
Eli Young
8734848829 Support enabling auto-updates for non-GitHub taps 2018-04-24 11:10:48 -07:00
commitay
1d3ed256a0 components_order_cop: make non-strict 2018-04-24 19:32:53 +10:00
Mike McQuaid
4a03145c1c linkage: fix --test exit code.
Ensure that a non-zero exit code is set both for missing random dylibs
and random missing dependencies.

Additionally, while we are here, drastically trim down the public
interface for this class to the bare minimum and allow getting the
output from `display_test_output` as a variable.

Fixes issue mentioned by @ilovezfs in:
https://github.com/Homebrew/brew/pull/3940#issuecomment-383794520
2018-04-24 09:52:51 +01:00
Markus Reiter
33a9521576 Fix MissingFormula namespacing. 2018-04-22 17:27:44 +02:00
Markus Reiter
54166f9886 Update Gemfile.lock. 2018-04-20 19:11:22 +02:00
Markus Reiter
9f1b64a9d4 Add additional specs for PATH. 2018-04-20 19:11:22 +02:00
Markus Reiter
0432feabd3 Add missing blacklisted Formulae. 2018-04-20 19:11:22 +02:00
Markus Reiter
16fb563d49 Refactor MissingFormula spec. 2018-04-20 19:11:22 +02:00
Markus Reiter
5e2d4d52ba Refactor OsxfuseRequirement spec. 2018-04-20 19:11:22 +02:00
Markus Reiter
b91628a614 Refactor Hardware::CPU spec. 2018-04-20 19:11:22 +02:00
Markus Reiter
d0d7116dc8 Refactor Formulary spec. 2018-04-20 19:11:22 +02:00
Markus Reiter
db747b1651 Refactor requirement specs. 2018-04-20 19:11:22 +02:00
Markus Reiter
e169b87f9e Use expect { }.to output. 2018-04-20 19:11:22 +02:00
Markus Reiter
77c9c1ddf0 Use described_class in Formulary spec. 2018-04-20 19:11:22 +02:00
Mike McQuaid
1d9746db84
Merge pull request #4092 from MikeMcQuaid/x11_requirement_download_base
x11_requirement: move download to base class.
2018-04-18 15:06:23 +01:00
Mike McQuaid
6fab4e1805 x11_requirement: move download to base class.
No reason to have it in macOS class and keeps consistent output with
`brew info` on Linux.
2018-04-18 11:18:29 +01:00
Mike McQuaid
63c0706190 formula: sort aliases in to_hash.
Otherwise the ordering varies based on the filesystem.
2018-04-18 11:17:57 +01:00
Mike McQuaid
a4bada575a requirements: define cask on base class.
The `cask` attribute doesn't make as much sense on Linux but can be
ignored there. The advantage of this change is that (like #4086) it
allows figuring out the relevant cask for a formulae requirement on a
Linux machine.
2018-04-18 09:55:44 +01:00
Mike McQuaid
55486383a9
Merge pull request #4086 from MikeMcQuaid/linux-hash-tweaks
formula: tweak to_hash bottle output.
2018-04-18 09:49:39 +01:00
Ray Hamel
1ee40e831a
Don't splat 2nd arg to ErrorDuringExecution::new 2018-04-17 19:09:54 -04:00
Mike McQuaid
a34c11874b formula: tweak to_hash bottle output.
Make some changes required to have `brew info --json=v1` whether there
is any bottle block rather than a bottle checksum for the given system.

This provides more consistent output.
2018-04-17 21:44:50 +01:00
ilovezfs
807a383bc5 Xcode 9.3 2018-04-17 06:26:12 -07:00
Mike McQuaid
7166289ad7 os/mac/xcode: revert an installed? guard removal.
Fixes #4084.
2018-04-17 12:05:09 +01:00
Mike McQuaid
9580afb222 formula_support: deprecate more keg_only reasons.
It's unnecessary extra complexity to have versions that are keg-only on
some versions of macOS and not others.

Initially this was to only do so on old versions of OS X and Xcode but
the discussion in https://github.com/Homebrew/brew/pull/4081 meant that
it made more sense to remove them all.
2018-04-17 11:17:18 +01:00
Mike McQuaid
d08a4accfb
Merge pull request #4083 from MikeMcQuaid/remove-xcode-installed-guards
Remove Xcode.installed? guards.
2018-04-17 11:16:43 +01:00
Mike McQuaid
85edbd28b1 Remove Xcode.installed? guards.
It's safe since 600d58f4ca3d85894c66a38802965fd94d4ea469 when
MacOS::Xcode.version started returning `Version::NULL` where
appropriate.
2018-04-17 10:58:51 +01:00
Mike McQuaid
0a00312b71 Autocorrect new RuboCop 0.55.0 style violations. 2018-04-17 10:54:58 +01:00
Markus Reiter
5cf8fa5727
Update rubocop-cask to 0.19. 2018-04-17 10:59:25 +02:00
Mike McQuaid
1f64c50167 RuboCop 0.55.0. 2018-04-17 09:03:57 +01:00
Markus Reiter
6233b9d199
Merge pull request #4072 from reitermarkus/cask-refactoring
Cask Refactoring
2018-04-17 06:17:04 +02:00
Mike McQuaid
5a2817cb02
Merge pull request #4066 from scpeters/missing_fail
missing: exit nonzero if missing deps are found
2018-04-16 13:17:22 +01:00