admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
24,092 Commits 15 Branches 471 Tags
Commit Graph

1603 Commits

Author SHA1 Message Date
Mike McQuaid
c4f72312ce
Fixup brew style failures. 2019-04-30 09:19:18 +01:00
Mike McQuaid
bc3a4c1897
diagnostic: tweak frozen string handling. 2019-04-23 23:05:28 -07:00
follower
2064b30fce
Fix check_for_unsupported_macos() on outdated releases 
Recent commit 36dbad3922 to default to frozen string literals (via `frozen_string_literal`) broke `check_for_unsupported_macos()` on outdated releases--due to attempted modification of a frozen string literal.

This breaks `install` and `doctor`.

It's like the change wasn't tested on an unsupported outdated release or something... :D

Adding a `+` prefix is apparently one way around this issue according to https://stackoverflow.com/questions/37799296/what-does-the-comment-frozen-string-literal-true-do#37799399. The change worked for me.
 2019-04-24 15:02:13 +12:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files. 2019-04-20 13:27:36 +09:00
Mike McQuaid
d1ea6f38d3
Fix mutable constants violations. 2019-04-19 21:46:20 +09:00
Mike McQuaid
86f43f79ee
Enable/fix optional Ruby frozen string literal usage 
Combined with https://github.com/Homebrew/homebrew-test-bot/pull/247
this will test Homebrew's use of frozen strings in CI. After this we
will then enable it for Homebrew developers and eventually all Homebrew
users.
 2019-04-19 10:30:41 +09:00
Mike McQuaid
18630c7032
extend/ARGV: remove unused methods. 2019-04-17 21:08:26 +09:00
Mike McQuaid
356f72dcc6
Merge pull request #6012 from amyspark/hotpatch-fix-atomic_write 
atomic_write: repair permissions after writing
 2019-04-14 10:02:15 +01:00
EricFromCanada
89f0fcedbe whitespace fixes 2019-04-13 21:32:04 -04:00
EricFromCanada
15c38a2d8b formatting fixes 2019-04-13 21:29:32 -04:00
EricFromCanada
fa6404e0f5 grammar fixes 2019-04-13 21:29:32 -04:00
L. E. Segovia
f9fcdec795
pathname.rb: style fixes 2019-04-13 17:18:14 +00:00
L. E. Segovia
f706fffc6c
atomic_write: repair permissions after writing 
This restores the original file uid, gid and permissions separately.
(ActiveSupport does it in a single step - atomically. This is not
useful in our use case because it may lead to ACL changes.)

Fixes #5916
 2019-04-12 18:46:57 +00:00
L. E. Segovia
c6894a23c1
Only merge extended attributes if required 2019-04-09 21:45:35 +00:00
L. E. Segovia
e09d4336a9
Unzip Casks w/ extended attributes with ditto 
Fixes Homebrew/homebrew-cask#61386
 2019-04-08 22:54:33 +00:00
Markus Reiter
62a0c2fed9 Retry with ditto when “End-of-central-directory signature not found.”. 2019-04-02 13:27:20 +02:00
Mike McQuaid
3bde17c9f9
Cleanup from dev-cmd test changes 
- Remove added whitespace in `extend/os/linux/keg_relocate`
- Cleanup testball bottles
 2019-03-27 10:31:26 +00:00
Mike McQuaid
59d680a626
dev-cmd: only one integration test per command. 
Integration tests are useful in detecting breakages but much slower so
let's only use one per command and install formula outside the
integration test framework (which is also slow).
 2019-03-27 09:45:48 +00:00
Shaun Jackman
59ee097f8d fix_dynamic_linkage: Check HOMEBREW_RELOCATE_METAVARS 
Only remove RPATH when HOMEBREW_RELOCATE_METAVARS is set.

See PR https://github.com/Homebrew/brew/pull/5413
 2019-03-19 08:29:45 -07:00
Shaun Jackman
5cb458d687 install_symlink_p: Fix when dest includes a symlink 
install_symlink_p does not work as intended when dst includes a symlink in its path.
relative_path_from requires that both src and dst be real paths without symlinks.

From https://ruby-doc.org/stdlib-2.3.7/libdoc/pathname/rdoc/Pathname.html#method-i-relative_path_from
This method doesn't access the filesystem. It assumes no symlinks.
 2019-03-16 23:11:59 -07:00
William Woodruff
02216eedaf
mac/keg_relocate: Don't relocate loader_paths 2019-03-11 20:59:11 -04:00
William Woodruff
82dd5011e2
mac/keg_relocate: Delete loader_paths 
Fix the call to expand_rpath.
 2019-03-10 21:29:59 -04:00
William Woodruff
54aca0d14f
os/mac: Flush RPATHs from Mach-Os when possible 2019-03-10 21:07:04 -04:00
William Woodruff
2e2dea6131
mac/keg_relocate: Style nit 2019-03-10 21:07:04 -04:00
William Woodruff
d2dc4e5599
mac/keg_relocate: Drop unnecessary parens 2019-03-10 21:07:04 -04:00
William Woodruff
c4363e8c58
mac/keg_relocate: Remove short-circuit, cleanup 2019-03-10 21:07:04 -04:00
William Woodruff
a6bcbdb20d
mac/keg_relocate: Prefer String#/, add ENV check 2019-03-10 21:07:04 -04:00
William Woodruff
27d6cfb12e
[WIP] mac/keg_relocate: Emulate dylinker behavior 
Instead of assuming that #{lib} is the correct RPATH expansion,
test all RPATHS and substitute the first one that works.
 2019-03-10 21:07:03 -04:00
William Woodruff
54e6cbb343
mac/keg_relocate: Rewrite rpaths in install names 2019-03-10 21:07:03 -04:00
Mike McQuaid
9b682da37b
Use Homebrew/linuxbrew-core 
This would allow the Linuxbrew core tap to live in the Homebrew
organisation.
 2019-02-25 14:21:13 +00:00
Shaun Jackman
eeed04fdad diagnostic: Fix check_xdg_data_dirs for Linux 
Fix Error: undefined method prepend_variable_in_profile'
for Utils::Shell:Module Did you mean? prepend_path_in_profile
 2019-02-21 10:06:33 -08:00
Mike McQuaid
e095da4d01
rubocop: enable Layout/EmptyLineAfterGuardClause. 2019-02-21 12:55:49 +00:00
Mike McQuaid
d64429a736
rubocop: enable Style/IfUnlessModifier. 2019-02-21 12:55:49 +00:00
Mike McQuaid
cee75b6af2
ARGV: freeze when using CLI::Parser. 
Otherwise `Homebrew.args` values may not match those of modified `ARGV`.
 2019-02-18 16:56:43 +00:00
Mike McQuaid
28fa8a7c97
version: add CPU tests. 
Add a new API inspired by discussion in
https://github.com/Homebrew/homebrew-core/pull/36435 to query if a given
CPU option is supported by a version of macOS.
 2019-01-28 19:31:21 +00:00
Mike McQuaid
1aa8ad09e2
Deprecate macOS versions below Mavericks 
And remove all dead/unneeded code.
 2019-01-27 12:27:47 +00:00
Mike McQuaid
9b5ab7fbb7
Merge pull request #5598 from MikeMcQuaid/odeprecated-odisabled 
Update deprecations and cleanup
 2019-01-27 12:13:26 +00:00
Mike McQuaid
ea1cf52d47
Merge pull request #5614 from MikeMcQuaid/bitdefender 
os/mac/diagnostic: detect Bitdefender.
 2019-01-26 08:43:09 +00:00
Shaun Jackman
d13a287954 Fix check_coretap_git_origin 
check_coretap_git_origin was not working as intended.
Permit Linuxbrew/homebrew-core as a valid origin.
Factor out check_coretap_git_branch.
 2019-01-25 14:01:10 -08:00
Mike McQuaid
ce9856efca
os/mac/diagnostic: detect Bitdefender. 
This has caused us multiple hard-to-diagnose issues so let's complain
about it in `brew doctor`.
 2019-01-25 20:16:35 +00:00
Mike McQuaid
eed1444d61
Update deprecations and cleanup 
- Move `odeprecated` to `odisabled`
- Remove `odisabled`
- Enable automatic cleanup on install/reinstall/upgrade.
 2019-01-23 21:57:40 +00:00
Mike McQuaid
589ed8e17c
Tweak diagnostic checks 
- Make `gist-logs` perform more checks
- Don't complain about a non-/usr/local install at install time unless
  actually building from source.
- Show more checks output on a build error
- Improve naming of checks methods
 2019-01-21 19:23:31 +00:00
Mike McQuaid
3a0e0dca36
Output more warnings on unsupported configurations 2019-01-21 13:58:03 +00:00
Mike McQuaid
c3a46bc570
os/mac/diagnostic: remove some old/unneeded checks. 2019-01-21 12:40:12 +00:00
Mike McQuaid
fda7202a7f
Merge pull request #5507 from MikeMcQuaid/formula-install-options-build-arch 
extend/ARGV: don't warn on --bottle-arch=.
 2019-01-08 19:56:31 +00:00
Mike McQuaid
96207c05d3
Merge pull request #5506 from MikeMcQuaid/no-penryn 
hardware: no special penryn CFLAGS.
 2019-01-08 19:40:03 +00:00
Mike McQuaid
d9a9ceae70
Merge pull request #5477 from MikeMcQuaid/deprecations 
Update deprecations
 2019-01-08 19:28:05 +00:00
Mike McQuaid
e1eb4710e4
extend/ARGV: don't warn on --build-arch=. 
Fixes #5504.
 2019-01-08 19:24:00 +00:00
Mike McQuaid
b1e60f9c76
hardware: no special penryn CFLAGS. 
These are the same as `core2` (at least for `gcc`).

Fixes #5502.
 2019-01-08 19:14:29 +00:00
Mike McQuaid
170c5493a4
Update deprecations 
- Add some `odeprecated`
- Make some `odeprecated` now `odisabled`
- Remove `odisabled` code.
- Remove old update migrations
- Remove GCC 4.0 compiler
- Remove Tiger-only code
- Remove 32-bit-only code
- Remove use of LD64
- Remove GCC 4.3 - 4.8 support.
 2019-01-08 19:13:46 +00:00