1899 Commits

Author SHA1 Message Date
Mike McQuaid
62764485c7 travis.yml: cache Bundler output.
Travis needs some coaxing to find where we put it. This should improve
build reliability due to network issues.
2017-04-22 15:44:47 +01:00
Mike McQuaid
a6df701fad tests: reduce some noise.
- Tweak the way offline skipping happens
- Skip more tests that break when offline
- Hide more stdout output from tests.
2017-04-22 12:49:14 +01:00
Mike McQuaid
69c7a20896 Fix brew edit with environment filtering.
For many people `brew edit` makes use of the `EDITOR` variable to pick a
sensible editor. With environment filtering enabled unless this editor
is found in the default system PATH it'll fall back to e.g. `vim`.

Instead, ensure that we export the original, pre-filtering `PATH` as
`HOMEBREW_PATH` and use that internally to locate the editor. In future
this same approach will likely be used for requirements to be able to
find tools, too, and for other variables which we want to expose to
Homebrew itself but not other build tools.

Note that `HOMEBREW_PATH` is the same as `PATH` when build filtering
hasn't been enabled.
2017-04-21 18:26:12 +01:00
Markus Reiter
75ceed39e6 Merge pull request #2520 from reitermarkus/pkgutil-plist
Partly revert “Fix `uninstall :pkgutil` leaving empty `.app` directories.”.
2017-04-21 17:37:42 +02:00
Markus Reiter
80e09c8dec Partly revert “Fix uninstall :pkgutil leaving empty .app directories.”. 2017-04-21 16:46:39 +02:00
Markus Reiter
5c51c4e23b Fix test for chmod +x on binaries. 2017-04-21 14:52:35 +02:00
Markus Reiter
1cd125e7e7 Refactor cask metadata directory methods. 2017-04-21 01:28:21 +02:00
Mike McQuaid
2be7999878 Merge pull request #2274 from rwhogg/fuse-requirement
Port OsxfuseRequirement to Linux
2017-04-20 17:14:42 +01:00
Reto Kromer
7e76740172 move before dash version style 2017-04-18 11:41:55 +02:00
Mike McQuaid
3f8722c971 audit: allow skipping audit methods.
Add `--only` and `--except` methods which can be used to selectively
enable or disable audit groups.
2017-04-18 08:17:26 +01:00
Reto Kromer
0dc6871d22 add test 2017-04-17 18:11:11 +02:00
Misty De Meo
1deb884314 Merge pull request #2496 from mistydemeo/hardware_cpu_can_run_arch_helper
Hardware cpu can run arch helper
2017-04-17 18:01:33 +08:00
Mike McQuaid
46f6dc4c93 Merge pull request #2446 from mansimarkaur/diagnostic_tests
[WIP] Added test for check_access_lock_dir
2017-04-16 09:30:38 +01:00
Bob W. Hogg
608d72a35f OsxfuseRequirement: Port to Linux 2017-04-15 21:20:09 -07:00
Misty De Meo
944bff4de2 Mac Hardware: provide a more Mac-specific implementation of can_run? 2017-04-15 22:59:55 +08:00
Misty De Meo
d7ff53fa1d Hardware: add helper to determine if an executable can be run 2017-04-15 22:59:55 +08:00
Markus Reiter
4d6e31999a Merge pull request #2434 from JCount/gpg-spec-test-21-compatibility
gpg_spec test add 2.1.x compatibility
2017-04-09 21:08:53 +02:00
JCount
43b64bfed1 gpg_spec: use new version method to directly compare version objects 2017-04-08 20:20:26 -04:00
JCount
14a7ef591b gpg_spec: switch structure to if/else instead of rescue 2017-04-08 20:20:26 -04:00
JCount
239b873fb2 gpg2_requirement_spec: switch test to gnupg 2.1.x 2017-04-08 20:19:57 -04:00
mansimarkaur
7e455a623a Corrected test for access_lock_dir 2017-04-07 18:29:40 +05:30
Mike McQuaid
3f51406212 Merge pull request #2242 from GauthamGoli/audit_custom_cops
Port audit_desc audit rules to a cop
2017-04-05 08:37:43 +01:00
mansimarkaur
fda41919cf Added test for check_access_lock_dir 2017-04-03 07:06:59 +05:30
Mike McQuaid
879b3360d3 Handle missing receipt on brew install.
For example if this is for a really old keg, keg where a user has
manually removed stuff or used `brew diy`.
2017-04-02 17:02:56 +01:00
Eugene Nikolsky
edd9a9717c Fix the 'export PATH' message in link for a keg-only formula
Commit 4cae6a724e6d684eb157dd6d7328755694f228b2 introduced the message,
but it printed the wrong path, e.g. for `brew link sqlite`:

```
If you need to have this software first in your PATH instead consider running:
  echo 'export PATH="/usr/local/opt/sqlite:$PATH"' >> ~/.zshrc/bin
```

where `/bin` is appended at the end, but should be inserted before
`:$PATH`: `echo 'export PATH="/usr/local/opt/sqlite/bin:$PATH"' >> ~/.zshrc`.
This patch fixes that and updates a test to verify it.
2017-04-01 20:12:00 -07:00
JCount
0e1b7ce8ea gpg_spec: make test compatible with gnupg 2.1.x
maintain existing compatibility with gnupg 2.0.x
2017-04-01 21:29:09 -04:00
Vítor Galvão
7c048b6f71 cask: remove pre_bug_report links 2017-03-31 20:24:23 +01:00
Ilya Zverev
f5321d1b0d Remove osmium from blacklisted formulas 2017-03-31 15:59:22 +03:00
Mike McQuaid
80b39bb239 Merge pull request #2374 from joshka/cleanup-command-continue-on-error
Cleanup: Continue on error removing keg
2017-03-31 09:43:47 +01:00
Joshua McKinney
48fdd163bc Brew cleanup: Continue on error removing keg
Fixes #2355
Create unremovable_kegs instance var
Check cellar cleanup failure after full cleanup completes
Use module_function in Homebrew::Cleanup as we never instantiate the
class
2017-03-31 01:44:04 -05:00
Mike McQuaid
a582be06c2 Merge pull request #2421 from MikeMcQuaid/formula-check-alias-exists
formula: check installed_alias_path exists.
2017-03-30 20:25:05 +01:00
Mike McQuaid
b6792fc7be Merge pull request #2401 from wjlroe/print-pinned-on-outdated
Include the pinned version in brew outdated output for pinned formulae
2017-03-30 20:24:30 +01:00
Mike McQuaid
8472d6a40e formula: check installed_alias_path exists.
Otherwise return `nil`.

Fixes https://github.com/Homebrew/brew/issues/2417
2017-03-30 19:39:26 +01:00
Mike McQuaid
51ca9025a5 formula_installer_spec: add default formula test.
Test the situation where a requirement is satisfied by a non-formula
but the `default_formula` is also installed.
2017-03-29 09:34:52 +01:00
William Roe
996dcdee2c Add pinned version to outdated json output
The structure should be consistent, so there are always pinned and
pinned_version fields even if there are no pinned versions for a given formula.
2017-03-27 11:41:08 +01:00
William Roe
70446d9112 Add pinned version to outdated output 2017-03-27 11:30:36 +01:00
William Roe
755d43d46d Add test for verbose brew outdated output
Split the tests up into quiet and verbose output with contexts.
2017-03-27 11:27:48 +01:00
Gautham Goli
a693ca332e Wrap rubocop specific code into methods inside FormulaCop 2017-03-26 15:26:41 +05:30
Gautham Goli
4e57f4279a Add RSpec tests for bottle_block and formula_desc cops 2017-03-26 15:26:41 +05:30
Mike McQuaid
0cc9d93885 formula_installer: tweak req formula additions.
Rather than just checking if a requirement's dependency is installed or
not check if the requirement was actually satisfied by a particular
formula rather than e.g. just having a `default_formula` defined.
2017-03-25 10:59:54 +00:00
Mike McQuaid
f59eb358c2 missing_formula: subsume historic logic.
These methods belong together so combine them in a single class to
provide a simpler API.
2017-03-20 20:37:12 +01:00
Mike McQuaid
80e95b684e blacklist: move to missing_formula class instead.
This will allow extending this class so it can be used by more than
just blacklisting.
2017-03-20 18:20:31 +02:00
Mike McQuaid
623c95b3f8 cmd/log: improve output messaging.
This wasn’t adapted to the new, multiple repository world.
2017-03-20 18:20:31 +02:00
Zhiming Wang
1c10a6260f Hint at new location of migrated formulae
Partial implementation of
https://github.com/Homebrew/brew-evolution/pull/15, along with the ability to
search for deleted formulae in git history (inspired by #1996) which is not
described in the proposal.

See also: #1371.
2017-03-20 18:20:31 +02:00
Joshua McKinney
437db065ca Be a little less specific in cask output tests
These tests seemed a little over-specified and were failing on the CI
server. Reducing the specificity a little to try to get them to pass.
2017-03-19 19:56:41 -05:00
Joshua McKinney
d11e417105 Hide output from brew cask uninstall test
This test showed extraneous info in the test output
2017-03-19 13:14:16 -05:00
Joshua McKinney
3703ef1885 Show messages when (un)installing Casks
Addresses an issue where it can be unclear at times exactly which part
of the (un|re)installation processes is reporting an error. See
https://github.com/caskroom/homebrew-cask/issues/30968
2017-03-19 13:14:16 -05:00
Markus Reiter
ed10135da4 Replace Hbc.load with CaskLoader.load. 2017-03-16 19:16:42 +01:00
Markus Reiter
d7af864be0 Replace Hbc.path with CaskLoader.path. 2017-03-16 12:10:19 +01:00
Markus Reiter
d1995dad4b Use a Formulary-like approach to load Casks. 2017-03-16 12:10:19 +01:00