3122 Commits

Author SHA1 Message Date
Mike McQuaid
58d998e208 postinstall: allow write access to cellars in repository.
If HOMEBREW_CELLAR (or HOMEBREW_PREFIX) are children of
HOMEBREW_REPOSITORY it’s important to deny write to the repository and
enable write to the Cellar/prefix afterwards.
2016-10-11 09:36:20 +01:00
Markus Reiter
9c2420a9ef “Homebrew Cask” -> “Homebrew-Cask” 2016-10-06 18:34:20 +02:00
Markus Reiter
cafe149780 Merge pull request #1145 from reitermarkus/module-function
Use `module_function` for `Homebrew` module.
2016-10-04 10:31:49 +02:00
Bruce Steedman
62e14ea673 invalid build options - fixed conflicts; rename 2016-10-03 09:42:53 +01:00
Mike McQuaid
f7d1f4eca6 Merge pull request #1211 from vladshablinsky/list-version-code
list: fix exit code for --verbose and --pinned
2016-10-02 18:33:01 +01:00
Mike McQuaid
c6f5d24238 update-test: fix tag updating, skip core tap.
Fix updating the `stable` branch used for tagged updates and ensure
that the core tap isn’t retapped (the slowest part by far of this test).
2016-10-02 17:16:35 +01:00
Uladzislau Shablinski
db478fb7b2 list: fix exit code for --verbose and --pinned
`brew list --verbose <formulae>` lists only those kegs that
are installed and exits with 0 if all <formulae> installed.
If one or more formulae from <formulae> are not installed, the
command lists only installed versions and exits with 1.

`brew --pinned formula` exits with 1 if formula is not pinned.

Fixes #1172
2016-10-02 12:35:30 +03:00
Mike McQuaid
f90f52d902 Merge pull request #1205 from MikeMcQuaid/help-external-commands
help: support `#:` help in external commands.
2016-10-02 08:59:32 +01:00
Mike McQuaid
a364c981e4 Merge pull request #1206 from MikeMcQuaid/install-no-updated-warning
install: remove not updated warning.
2016-10-02 08:59:24 +01:00
Markus Reiter
8b06a01e5b Merge pull request #823 from reitermarkus/refactoring-tty
Refactor Tty.
2016-10-02 05:36:50 +02:00
Markus Reiter
c36f42ce95 Remove private_class_method from commands. 2016-10-02 00:24:47 +02:00
Markus Reiter
0ab750bf24 Use module_function for commands. 2016-10-02 00:24:47 +02:00
Mike McQuaid
fa14c26245 Merge pull request #1169 from reitermarkus/rubocop-separate-configs
Use separate RuboCop configs for formulae and core code.
2016-10-01 21:20:18 +01:00
Mike McQuaid
c699597c4c install: remove not updated warning.
This is no longer relevant after moving to taps/tags and if ever
re-added it should probably target homebrew/core.

Fixes #1194.
2016-10-01 19:42:38 +01:00
Markus Reiter
884b268506 Use Formatter for all URLs. 2016-10-01 20:00:49 +02:00
Markus Reiter
75e8b59aad Add Formatter module. 2016-10-01 20:00:49 +02:00
Markus Reiter
6d8ee395fa Refactor Tty. 2016-10-01 20:00:49 +02:00
Mike McQuaid
a4ebda3fc4 help: support #: help in external commands.
Fixes https://github.com/Homebrew/homebrew-test-bot/issues/3
2016-10-01 18:25:16 +01:00
Mike McQuaid
84c29fcf1f Fix JSON output handling. 2016-10-01 17:04:44 +01:00
Mike McQuaid
f17a55b269 upgrade: tell people that --all is a no-op.
Apparently this is still run by people so let's tell them to save
some typing.
2016-10-01 15:11:52 +01:00
Mike McQuaid
98e7fb6b60 Merge pull request #1052 from sjackman/store-formula
Store the formula used to build the keg in the keg
2016-10-01 12:24:19 +01:00
Mike McQuaid
5b31507fda Use Library/.rubocop.yml file.
This allows having a shared style that’s use for Homebrew/brew and taps
which can be overridden by Homebrew/brew.
2016-10-01 12:13:09 +01:00
Markus Reiter
18a9945ad8 cd to HOMEBREW_LIBRARY is not needed anymore for RuboCop. 2016-09-29 22:58:41 +02:00
Markus Reiter
5800f2f084 Use separate .rubocop.yml in Library/Taps and Library/Homebrew. 2016-09-29 22:58:41 +02:00
Markus Reiter
70fc825787 Use separate RuboCop configs for formulae and core code. 2016-09-29 22:58:41 +02:00
Mike McQuaid
d4311fd49f update.sh: use sort instead of git tag --sort.
Older versions of Git don't have this flag and we don't want to block
updates for them when there's a (relatively) simple workaround.
2016-09-29 09:16:15 +01:00
Mike McQuaid
2c50f762ce update.sh: hide GITHUB_HEADERS missing output.
Will only happen once but could be confusing anyway.
2016-09-27 13:55:08 +01:00
Mike McQuaid
b432f8e9cb Merge pull request #1004 from apjanke/print-requirements
info: print requirements
2016-09-27 09:48:14 +01:00
Mike McQuaid
11293bc3c8 Merge pull request #1152 from MikeMcQuaid/doctor-remove-outdated-check
doctor: remove outdated Homebrew check.
2016-09-26 15:07:15 +01:00
Mike McQuaid
2405c3e205 doctor: remove outdated Homebrew check.
This is no longer relevant in the bright, new tagged future.

Fixes #1151.
2016-09-26 12:13:18 +01:00
Mike McQuaid
f6ec63cd8b update.sh: don't restore branch to stable.
Only run for Homebrew developers so assume they don’t want to switch
back to an old stable branch.

Fixes #1141.
2016-09-26 08:22:56 +01:00
Mike McQuaid
1ff2d06cf0 update.sh: use HOMEBREW_UPDATE_TO_TAG.
This makes the code easier to follow rather than having to know
HOMEBREW_NO_UPDATE_CLEANUP implies not updating to a tag.
2016-09-25 21:53:28 +01:00
Markus Reiter
f732278cda Fix search_tap regex/string matching. 2016-09-25 16:27:43 +02:00
Andrew Janke
5aaccba34c info: include versions and other details in Requirements display 2016-09-24 21:39:33 -04:00
Mike McQuaid
87cf4f7f7a update.sh: use GitHub tags API.
Otherwise if we've committed to `master` and someone `brew update`s
before we cut the tag then they won't be updated to the latest version.
2016-09-24 20:43:14 +01:00
Mike McQuaid
2f82837b77 Merge pull request #1121 from MikeMcQuaid/update-stable-branch
update.sh: always use stable branch for tags.
2016-09-24 18:59:10 +01:00
Mike McQuaid
22299cffab update.sh: always use stable branch for tags.
This avoids creating a new branch that’ll never be deleted for each tag
and differentiates between the `master` and `stable` branches.
2016-09-24 17:25:15 +01:00
Mike McQuaid
c0d06e015c Merge pull request #1114 from zmwangx/update-no-restore-stable-branch
update.sh: do not restore stable (tag) branch
2016-09-24 17:19:44 +01:00
Markus Reiter
58e36c7319 Fix Style/GuardClause. 2016-09-24 12:24:35 +02:00
Zhiming Wang
07866f0b54
update.sh: do not restore stable (tag) branch
Restoring stable branch post-update could lead to unsuspecting users
with homebrew.devcmdrun being stuck forever on an old tag.

Fixes #1111.
2016-09-24 05:49:04 -04:00
Shaun Jackman
25df0c03d6 Store the formula used to build the keg in the keg
Store the formula used to build the keg inside the keg in a
file named NAME/VERSION/.brew/NAME.rb after removing the
bottle do ... end block.

See https://github.com/Homebrew/brew-evolution/pull/6.
Closes https://github.com/Homebrew/brew/issues/931.
2016-09-23 17:11:24 -07:00
Markus Reiter
a5b11a6a5c Fix Style/GuardClause. 2016-09-23 15:30:07 +02:00
Markus Reiter
ce6994b001 RuboCop has to be run inside HOMEBREW_LIBRARY. 2016-09-23 15:30:06 +02:00
Markus Reiter
21e0a7efb9 Update rubocop dependency to 0.43.0. 2016-09-23 15:30:06 +02:00
Markus Reiter
52ff988530 Fix RuboCop CaseEquality. 2016-09-23 15:30:06 +02:00
Mike McQuaid
4cbeb1e981 Merge pull request #1103 from MikeMcQuaid/update-upstream-tag-strict
update.sh: only update to semver tags.
2016-09-23 14:26:04 +01:00
Mike McQuaid
b0dfd2d435 update.sh: only update to semver tags.
Otherwise random e.g. `pr-123` tags may cause `brew update` to update
to the wrong version.
2016-09-23 11:26:24 +01:00
Mike McQuaid
536c48e804 sandbox: tweak HOMEBREW_REPOSITORY handling.
If we have a HOMEBREW_REPOSITORY and HOMEBREW_PREFIX mismatch (now the
default) then we can block access to the whole of HOMEBREW_REPOSITORY
rather than just the HOMEBREW_LIBRARY and `.git`.
2016-09-23 08:29:05 +01:00
Mike McQuaid
b33df4d0fa update.sh: don't print "checkout branch" message.
It’ll only get printed for people getting updated to tags now and these
are people who haven’t run a `dev-cmd` so we want to air on the side of
telling them less stuff that will confuse them and assume people who
have manually made another `git` branch will know how to get back to it.
2016-09-22 09:05:07 +01:00
Joseph Frazier
66ca9e79fc uninstall: improve pronoun for multiple version message
When exactly two versions of a package were installed, the uninstall
message should not read "Remove them all with...", since only one
version remains.

"Remove all versions with..." is flexible enough to avoid being
interpreted as grammatically incorrect, and it still accurately
describes the general behavior of `brew uninstall --force`.
2016-09-21 11:37:23 -04:00