438 Commits

Author SHA1 Message Date
Dominyk Tiller
52de5aa984 doctor: remove redundant EOS
Closes Homebrew/homebrew#41667
2015-07-13 18:13:45 +01:00
Mike McQuaid
fe68abf987 doctor: don't point to App Store for Xcode on 10.11.
Closes Homebrew/homebrew#41589.

Closes Homebrew/homebrew#41597.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-07-13 08:11:06 -07:00
Jack Nagel
75642e6271 Use Dir.mktmpdir in doctor
This matches how we create temporary directories elsewhere.
2015-06-23 23:20:31 -04:00
Jack Nagel
a1c1c1e3d3 Whitelist ntfs-3g libs
Closes Homebrew/homebrew#40950.
2015-06-23 23:20:31 -04:00
Jack Nagel
72cb403a56 Move 10.11 warning to doctor, pre-install, and post-failure
Fixes Homebrew/homebrew#40778.
2015-06-16 20:02:10 -04:00
Xu Cheng
d9b1fec14f doctor: fix __check_linked_brew
This fixes the case when multiple versions of a formula are installed.

Closes Homebrew/homebrew#40777.
Fixes Homebrew/homebrew#40781.
Fixes Homebrew/homebrew#40797.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2015-06-16 19:06:52 -04:00
Xu Cheng
0e3c11ea07 doctor: use Formula.installed directly
Before
```
brew doctor  9.83s user 0.52s system 76% cpu 13.563 total
```

After
```
brew doctor  0.25s user 0.16s system 9% cpu 4.332 total
```

Closes Homebrew/homebrew#40770.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-06-16 16:08:52 +08:00
Jack Nagel
bd0f179478 Remove obsolete doctor check
We don't support 10.5 anymore, and tigerbrew doesn't have this check
anymore, either.
2015-06-12 22:58:04 -04:00
Jack Nagel
c4dfacaf0c Fix linked keg-only check when only directories are linked 2015-06-12 20:37:20 -04:00
Xu Cheng
d976e43708 doctor: use Formula#full_name 2015-05-29 17:02:22 +08:00
Xu Cheng
04c274f727 doctor: load formula from rack 2015-05-27 13:53:41 +08:00
Dominyk Tiller
e4db0adf54 doctor: add homebrew_temp sticky bit check
Adds a small check to the Doctor command to ensure HOMEBREW_TEMP
has a sticky bit set. This has become a significant issue lately.

Closes Homebrew/homebrew#39735
Original issue: Homebrew/homebrew#39170

Closes Homebrew/homebrew#39739.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-05-14 21:24:49 +01:00
Xu Cheng
453990f1aa add method to detect shell profile file based on users' preference shell
Closes Homebrew/homebrew#38017.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-03-24 21:18:32 +08:00
Xu Cheng
87a35e3580 doctor: $PATH should be insert as it is
Closes Homebrew/homebrew#37500.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-03-08 17:35:54 +08:00
Xu Cheng
b9c002a7cf doctor: export command should use double quotes
Closes Homebrew/homebrew#37496

Closes Homebrew/homebrew#37497.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-03-08 16:01:17 +08:00
Mike McQuaid
fd8bb8776c doctor: accepting the Xcode license requires sudo. 2015-01-15 15:46:35 +00:00
Jack Nagel
d298e54e50 doctor: check access on HOMEBREW_PREFIX/opt 2015-01-12 21:29:22 -05:00
Jack Nagel
d0a1800e37 doctor: check access on all important HOMEBREW_PREFIX subdirs 2015-01-12 21:26:18 -05:00
Jack Nagel
b1514c1c40 doctor: check cellar access 2015-01-12 21:26:18 -05:00
Jack Nagel
aa4ff175ff doctor: fix grammar 2015-01-12 21:26:18 -05:00
Jack Nagel
9ff211f212 doctor: remove incorrect statement from HOMEBREW_LOGS check 2015-01-12 21:26:18 -05:00
Viktor Szakats
fc2818b7a5 Use more https in urls and updated some lost links
Closes Homebrew/homebrew#35531.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2015-01-04 02:13:16 -05:00
Mike McQuaid
612230a705 doctor: check cache directory is writable.
Fixes Homebrew/homebrew#32304.
Fixes Homebrew/homebrew#34933.
2014-12-14 10:17:29 +00:00
Xu Cheng
5310d16686 brew-doctor: warning the external commands with conflicting names
Closes Homebrew/homebrew#34755.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-12-09 12:59:04 +00:00
Misty De Meo
6017811397 doctor: handle non-extent methods passed as arguments 2014-11-26 17:54:53 -08:00
Jack Nagel
e00a6e4c4d Remove more references to removed external commands 2014-11-16 21:57:08 -06:00
Jack Nagel
824e187803 doctor: more useful comment 2014-11-14 20:32:46 -06:00
himikk
8e68a9724d Tell brew doctor to ignore libTrAPI.dylib
Tell brew doctor to ignore libTrAPI.dylib
TrAPI used by VPN software "Endpoint Security VPN"

Closes Homebrew/homebrew#34129.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-11-14 20:30:52 -06:00
Tim D. Smith
f388992b02 doctor: don't complain if reads_brewed_pth_files? is nil
Closes Homebrew/homebrew#33957.
2014-11-14 16:05:26 -08:00
Tim D. Smith
10d0824483 doctor: check that Python site-packages directory is writable 2014-11-14 16:05:18 -08:00
Dominyk Tiller
ca2c201fb3 doctor: option depreciation
I presume this needs to change to reflect Homebrew/homebrew#34147?

Closes Homebrew/homebrew#34151.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-11-13 08:41:16 +00:00
Jack Nagel
f27468507c Don't warn about config scripts that originate in the cellar
Fixes Homebrew/homebrew-php#1389.
2014-11-11 17:43:38 -06:00
Tim D. Smith
809e048b96 doctor: check for .pth support in Homebrew site-packages 2014-11-02 10:33:35 -08:00
Jack Nagel
ad4edb94d7 Whitelist config scripts from OS X Server
Closes Homebrew/homebrew#33398.
2014-10-28 22:49:40 -05:00
Jack Nagel
f281ea3a57 Simplify config script doctor check 2014-10-28 22:49:40 -05:00
Jack Nagel
d494c9db8e Use start_with? instead of regexp 2014-10-28 22:49:40 -05:00
Jack Nagel
d7de5b6e24 real_cellar cannot be nil 2014-10-28 22:49:40 -05:00
Mike McQuaid
324ea3e481 doctor: Xcode 6.1 is in the App Store. 2014-10-21 14:56:32 +01:00
Jack Nagel
6214b98217 Drop questionable CLT advice
If an outdated Xcode is installed, it really needs to be updated if
possible. Otherwise things that depend on Xcode at build time will have
that dependency satisfied, but will fail to compile. The CLT is enough
if it is installed by itself, in which case Xcode dependencies will not
be satisfied.
2014-10-20 14:20:48 -05:00
Linus Unnebäck
92be5bb193 doctor: Xcode 6.1 is in the App Store
Closes Homebrew/homebrew#33397.

Signed-off-by: Misty De Meo <mistydemeo@gmail.com>
2014-10-20 11:31:32 -07:00
Mike McQuaid
f96c6e5c6c doctor: clarify 10.10 Xcode situation. 2014-10-19 19:40:37 +01:00
Tim D. Smith
e2609385de doctor: warn about libcurl.framework
Closes Homebrew/homebrew#33076.
2014-10-11 00:19:42 -07:00
Jack Nagel
cb862901ea Whitelist more fuse files
Someday this will be finished.
2014-10-07 18:51:02 -05:00
Jack Nagel
7029810c18 Fix install_name_tool check when Xcode license isn't accepted yet
Fixes Homebrew/homebrew#32712.
2014-10-07 17:23:09 -05:00
Jack Nagel
86bb9b3fbb Remove commented-out code 2014-09-30 23:12:20 -05:00
Jack Nagel
95ec1650f4 Whitelist fuse pc files too 2014-09-30 22:37:27 -05:00
Jack Nagel
49d48a36a3 Whitelist more MacFuse headers
I think this is all of them.
2014-09-30 19:07:57 -05:00
Jack Nagel
94c7cc4b35 Fix whitelisted headers 2014-09-28 11:15:25 -05:00
Jack Nagel
799a2a456e Use Dir.glob and array operations to remove whitelisted files 2014-09-24 19:58:10 -05:00
Jack Nagel
586756209c Dir.exist? is not in 1.8 2014-09-24 17:51:36 -05:00