358 Commits

Author SHA1 Message Date
Markus Reiter
7cae29d3d7 Fix locally failing depends_on test. 2016-10-23 21:22:38 +02:00
Martin Schimandl
95d4a25891 Fix linting errors 2016-10-23 20:39:53 +02:00
Eitot
0b176f9cc8 Add dictionary artifact 2016-10-23 17:43:06 +02:00
Markus Reiter
cb8af6d751 Fix failing test caused by repo_info. 2016-10-23 17:07:29 +02:00
Markus Reiter
8d15bddedb Auto-correct block delimiters. 2016-10-23 14:44:14 +02:00
Markus Reiter
8c488de3f6 Remove unnecessary string interpolation. 2016-10-23 14:32:34 +02:00
Markus Reiter
ceec5a82c1 Use guard clauses. 2016-10-23 14:32:04 +02:00
Markus Reiter
9f513cc60c Remove redundant selfs. 2016-10-23 14:32:04 +02:00
Markus Reiter
ad8ae33c1f Fix spacing and indentation. 2016-10-23 14:32:04 +02:00
Markus Reiter
2b7e6c1dcb Don’t use %i literal. 2016-10-23 14:32:04 +02:00
Markus Reiter
ae7b944238 Align end with beginning of line where if/unless is. 2016-10-23 14:32:03 +02:00
Markus Reiter
8e9eae695a Use () as delimiters for %Q and %q literals. 2016-10-23 14:32:03 +02:00
Markus Reiter
1a0f8b8a02 Use slash-delimited regular expressions. 2016-10-23 14:32:03 +02:00
Markus Reiter
40b7e36746 Use 0-only prefix for octal numbers. 2016-10-23 14:13:16 +02:00
Martin Schimandl
31fb996800 Remove unncessary semicolon 2016-10-23 09:57:28 +02:00
Josh Hagins
3bc2c2d087 hbc/cli/list: don't print empty line if nothing to list 2016-10-19 22:15:03 -04:00
Josh Hagins
32f2231cdf hbc/cli/list: don't require Caskroom to be initialized 2016-10-19 22:15:03 -04:00
Josh Hagins
f79cb2ba30 Merge pull request #1325 from vin047/numbered-usernames
fix 'cask info' for external repos with numbers
2016-10-19 20:44:55 -04:00
Markus Reiter
fb29a31c72 Merge pull request #1320 from reitermarkus/which-lsar
Also use `which` to find `lsar` in PATH.
2016-10-19 22:01:06 +02:00
Yoshimasa Niwa
60c4328a17 Use Ruby 2.x style for named arguments. 2016-10-19 11:14:30 -07:00
Josh Hagins
c18441e81b Merge pull request #1315 from jawshooah/cask/load-only-rb
hbc/locations: arg is file only if absolute or .rb file
2016-10-19 12:36:42 -04:00
Markus Reiter
1e92f997c1 Also use which to find lsar in PATH. 2016-10-19 18:20:34 +02:00
Vinoth Ramiah
154237ba8e fix 'cask info' for external repos with numbers
fixes 2 issues: error when username has a number, correct url for repos not on github
2016-10-19 14:59:57 +01:00
Josh Hagins
d08f61a704 Merge pull request #1317 from reitermarkus/refactor-rubocop-cask
Refactor `brew cask style` not to require `.rubocop.yml`.
2016-10-18 19:22:12 -04:00
Josh Hagins
b4fc4acc09 hbc/locations: arg is file only if absolute or .rb file
Handle the case when an argument passed to `brew cask` is both the name
of a Cask and a non-Cask file in the current working directory.

Fixes https://github.com/caskroom/homebrew-cask/issues/25611.
2016-10-18 19:19:33 -04:00
Markus Reiter
6e1c132f99 Remove Cask’s which method. 2016-10-18 17:22:08 +02:00
Markus Reiter
8d83516577 Look for container extraction programs in PATH. 2016-10-18 17:17:19 +02:00
Markus Reiter
143c3ac5c8 Force the use of rubocop-cask’s default configuration. 2016-10-18 16:40:25 +02:00
Markus Reiter
3a22aff1b6 Refactor brew cask style not to require .rubocop.yml. 2016-10-18 16:39:08 +02:00
Naren
5f2929788c following to follow 2016-10-18 09:52:55 -04:00
Naren
6ac54f297f remove empty line and concatenate newline to e.message in cli.rb 2016-10-18 09:52:55 -04:00
Naren
8e9720c5b9 updated cmd to point to prebug steps url 2016-10-18 09:52:55 -04:00
Josh Hagins
e9863a71f6 hbc/cli/style: bump RUBOCOP_CASK_VERSION 2016-10-17 16:43:24 -04:00
Yoshimasa Niwa
5d606dd0a2 Use SystemCommand.run instead of custom wrapper.
There is an existing `SystemCommand.run` that executes command with
`sudo`.  Use that instead of yet another custom wrapper.
2016-10-15 15:19:30 -07:00
Markus Reiter
198bf4d3bd Convert puts_columns to puts Formatter.columns. 2016-10-15 17:13:38 +02:00
Markus Reiter
01d87f8107 Don’t use puts_columns if empty? or single item. 2016-10-15 17:13:38 +02:00
Martin Schimandl
a4e092a1c4 add cask reinstall command 2016-10-14 19:25:44 +02:00
Markus Reiter
1a01a4d42d Merge pull request #1264 from reitermarkus/single-language-audit
Allow auditing of a single language of a cask.
2016-10-12 08:18:35 +02:00
Markus Reiter
bb3c689371 Fix CaskCommandFailedError. 2016-10-11 18:27:01 +02:00
Markus Reiter
9eaf221885 Allow auditing of a single language of a cask. 2016-10-11 15:10:12 +02:00
Markus Reiter
6be6ce33e0 Merge pull request #1245 from reitermarkus/fix-cask-path-for-query
Fix getting cask path for queries.
2016-10-10 23:33:51 +02:00
Yoshimasa Niwa
d51cd15e0c Create caskroom without sudo in writable parent.
In case the parent directory of Caskroom is writable for the user, we
don't need to use `sudo` to execute commands.

Make a generic method to run commands that has an option to switch sudo
so that we can run commands with and without sudo.
2016-10-10 11:17:07 -07:00
Alyssa Ross
6c5b8f0f5e Update URL in qualified_token comment
The homebrew/homebrew wiki no longer exists.
2016-10-10 14:46:00 +01:00
Yoshimasa Niwa
d00f35b8c4 FIX: cask changes /usr/local ownership recursively
Relatively old code in Hbc::Caskroom recursively changes the ownership
of the directory where the Caskroom directory exists, that changes
entire files in /usr/local to user:staff if Homebrew setup with default
configuration.
This is really dangerous because it's easy to trigger (just simply type
`brew cask something` by following some installation documentation.)

This patch removes entire `chown` with -R option and make the logic
simply creating Caskroom directory with default Homebrew directories
ownership and permission.
2016-10-09 13:27:31 -07:00
Markus Reiter
8ded5b690f No need to check if Encoding is defined. 2016-10-09 15:34:12 +02:00
Markus Reiter
67a7d1a64a Fix getting cask path for queries. 2016-10-09 15:34:12 +02:00
Markus Reiter
624a6d0822 Comment out license stanza deprecation warning. 2016-10-08 12:07:12 +02:00
Markus Reiter
415e5f1f78 Merge pull request #1235 from abookyun/deprecate-license
Deprecate license
2016-10-07 17:59:37 +02:00
Markus Reiter
e1ec23eea0 Merge pull request #1220 from reitermarkus/tap-version-string
Make `core_tap_version_string` reusable.
2016-10-07 17:59:06 +02:00
David Yun
ca68085e59 Fix unused argument 2016-10-07 23:12:30 +08:00