213 Commits

Author SHA1 Message Date
Mike McQuaid
8800b85f64
More GitHub Packages bulk upload fixes
- replace invalid non-ASCII characters from the descriptions
- handle invalid macOS versions on attempting to load old formulae from
  old bottles
- let `rubocop` auto-remove a no-longer needed `rubocop:disable`
- fix `skopeo` credentials argument
2021-04-07 17:03:44 +01:00
Mike McQuaid
1942e60a37
formulary: fall back on missing bottle formula.
These aren't available on old macOS version bottles.
2021-04-01 17:37:16 +01:00
Mike McQuaid
d8a2cf9efc
Write tabs to bottle JSON, optionally not bottle
- Write a subset of the tab required for bottles as an annotation.
- Add option on new bottle creation to skip writing tab into bottle
  and instead add it (and other useful metadata) to bottle JSON.
- Read formula information and tab from bottle JSON.
- Write prettier JSON to disk.
- Don't write `HEAD` to tab; this duplicates `HOMEBREW_VERSION`.
- Allow `brew bottle` to use `--json` to generate JSON files from a
  local bottle file.
2021-03-31 09:43:37 +01:00
Mike McQuaid
6be0b57a82
formulary: fix constant redefined warning. 2021-03-31 09:30:38 +01:00
Bo Anderson
90e9d17789 formulary: remove consts if loading failed 2021-02-17 17:38:16 +00:00
Bo Anderson
da9e42f312 formulary: remove consts on cache clear 2021-02-17 17:13:06 +00:00
Nanda H Krishna
b9cbeb3019
Merge pull request #10608 from nandahkrishna/assignment-condition-parentheses
style: use parentheses for assignment in conditions
2021-02-15 18:43:54 +05:30
nandahkrishna
8e5451df2f
style: use parentheses for assignment in conditions 2021-02-12 18:33:37 +05:30
Bo Anderson
323ff660fa rubocop: use consistent array/hash indentation 2021-02-11 13:27:42 +00:00
EricFromCanada
2ed324ebc0 use backticks around suggested input, flags, and binaries 2021-01-26 16:19:47 -05:00
Mike McQuaid
9216d8abe6
rubocop-rails: make fixes. 2020-12-02 10:43:04 +00:00
Markus Reiter
5786a8937d
Merge pull request #9278 from reitermarkus/formulary-backtrace
Don't output backtrace in `Formulary`.
2020-11-26 11:38:28 +01:00
Markus Reiter
0fb9fd2cbe Don't output backtrace in Formulary. 2020-11-24 18:55:17 +01:00
Mike McQuaid
d496f5c121
Deprecations for Homebrew 2.6.0
Do the usual deprecate/disable dance for the Homebrew 2.6.0 release.

Not to be merged until the next release will definitely be 2.6.0.
2020-11-24 16:44:02 +00:00
Markus Reiter
da9289eff0 Add more type signatures. 2020-11-13 12:26:36 +01:00
EricFromCanada
3768b7a6e9 apidoc: update comment wording, punctuation, formatting 2020-11-06 00:21:02 -05:00
EricFromCanada
dddfbf80fc apidoc: add/update yard tags 2020-11-06 00:16:35 -05:00
Markus Reiter
24ae318a3d Move type annotations into files. 2020-10-10 14:59:39 +02:00
Markus Reiter
b4e8bfe716 Fix RuboCop offenses. 2020-10-09 11:17:55 +02:00
Markus Reiter
8fb769e60c Ignore FormulaUnreadableError in Formula.each. 2020-09-03 19:48:18 +02:00
Mike McQuaid
2e5272d04c Deprecate/disable code for Homebrew 2.5.0.
Do the usual "disable deprecations" and "uncomment pending deprecations"
dance and delete/deprecate/disable relevant/related code.
2020-09-03 10:34:22 +01:00
Seeker
687c87d74d formulary: use formula path when installing bottle 2020-08-28 20:23:47 -07:00
Markus Reiter
fc6037ce53 Document Formulary. 2020-08-26 03:13:58 +02:00
Bo Anderson
e3372e2a14 Lazily require some heavy files 2020-08-20 02:05:17 +01:00
Markus Reiter
490e503b1b Replace Homebrew.args with Context. 2020-08-06 16:13:14 +02:00
Markus Reiter
e07b02fde2 Comment BUILD_FLAGS. 2020-07-30 10:12:34 +02:00
Markus Reiter
08e35e9cb4 Refactor FormulaLoader#get_formula. 2020-07-30 10:07:53 +02:00
Markus Reiter
24eff8f81a Pass args in SoftwareSpec instead of using global args. 2020-07-30 03:21:12 +02:00
Michka Popoff
6eb80c67a4 install: add backtrace on failure
The error message might be useless alone
2020-06-27 09:59:56 +02:00
Mike McQuaid
a35825ff23
formulary: further deprecate URLs.
Installation of formulae from URLs has many attack vectors and is
fundamentally insecure, unsupported, regularly recommended against and
generally a terrible idea. There's plenty of ways to take that URL,
manually verify it and put it somewhere that Homebrew does support so
let's deprecate this way of doing things.
2020-05-29 13:15:08 +01:00
Mike McQuaid
bc27e38f18
Remove ARGV.debug?
Replace with `Homebrew.args.debug?`.

Part of #5730.
2020-05-23 14:38:58 +01:00
Mike McQuaid
4f75a77b08
Update deprecations
Add more deprecations, disable deprecations and remove disabled code.
2020-05-18 13:50:46 +01:00
Bob Wombat Hogg
63e6632aa9 docs: Update tap-pin and tap-unpin disable explanations
I interpreted the existing message as meaning "you don't pin
a tap any more, rather you pin a specific formula from that
tap". I.e. the command still worked, but it had to be done
on a per-formula basis (eg. `brew tap-pin linuxbrew/xorg/mesa` instead
of just `brew tap-pin linuxbrew/xorg`)

IMO, this makes it clearer that the command itself is no longer
supported.
2020-05-06 08:54:54 -04:00
Mike McQuaid
3381cbf5c7
Use Homebrew::EnvConfig. 2020-04-07 09:58:26 +01:00
Mike McQuaid
d53176fe13
formulary: fix typo.
"an commit" is not valid English.
2020-03-11 13:12:49 +00:00
Mike McQuaid
dbbf824393
formulary: strengthen commit URL warning.
Inspired by https://github.com/Homebrew/brew/issues/7154
2020-03-11 11:51:12 +00:00
Mike McQuaid
176297d361
Handle 2.2.0 deprecations/disableds
- Make all `odeprecated` from 2.1.0 `odisabled` instead
- Remove dead code that won't be run now
- Remove (unused) `or_later` handling for bottles
2019-11-06 15:25:40 +00:00
Mike McQuaid
893474d037
formulary: add cache to factory. 2019-11-06 10:20:56 +00:00
Jonathan Chang
7ddc185b35 Fix various typos 2019-08-19 16:12:34 +10:00
Mike McQuaid
d7bc5835b9
formulary: recommend brew extract.
This will provide a better experience to users rather than a URL that
will likely break in future.
2019-05-07 10:50:19 +01:00
Mike McQuaid
c4f72312ce
Fixup brew style failures. 2019-04-30 09:19:18 +01:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files. 2019-04-20 13:27:36 +09:00
Mike McQuaid
7d26a61cc8
Deprecate tap pinning
Tap pinning is not used by Homebrew or the Homebrew maintainers so issues relating to pinned taps (#5418, #5796) don’t get fixed. Tap pinning does not work consistently or reliably and is conceptually confusing to encourage users to use fully-scoped user/tap/formula naming or avoid shadowing core tap formulae' names instead.
2019-04-01 15:07:50 +01:00
Mike McQuaid
d64429a736
rubocop: enable Style/IfUnlessModifier. 2019-02-21 12:55:49 +00:00
EricFromCanada
20167e5f1b Adjust comments to tidy API docs output. 2018-10-18 21:42:43 -04:00
Markus Reiter
e9b9ea49a1 Update to RuboCop 0.59.1. 2018-09-17 03:45:59 +02:00
Markus Reiter
769d89dead Resolve formulae in brew cleanup. 2018-09-11 17:44:39 +02:00
Mike McQuaid
9cd637ac20
formulary: NameError makes formulae unreadable.
And `NoMethodError` is a type of `NameError`.
2018-09-03 15:40:07 +01:00
Mike McQuaid
80d75bc0d8
Homebrew/.rubocop: tweak rules.
Adjust the rules based on the current codebase. Remove various enable,
disables and default values that are unnecessary. Add more comments
explaining why. Make minor changes needed to enable a few more rules.
2018-09-02 20:15:09 +01:00
Markus Reiter
9ffc7dd465 Use Resource#downloader for BottleLoader. 2018-08-01 05:40:15 +02:00