6354 Commits

Author SHA1 Message Date
Jack Nagel
f4618f0147 keg: factor out dylib id calculation 2013-12-14 09:35:57 -06:00
Jack Nagel
7a10493387 keg: try to avoid disk IO when possible
Calling Pathname#text_executable? reads in the first 1024 bytes of the
file, so try the basename check (which requires no filesystem access)
first.
2013-12-14 09:35:57 -06:00
Jack Nagel
24d8791dfb keg: use lib helper 2013-12-14 09:35:57 -06:00
Jack Nagel
935091cd8e Pathname#extname returns a string 2013-12-14 09:35:57 -06:00
Misty De Meo
5994fd469c xcode-select check: move after first options 2013-12-13 19:17:56 -08:00
Adam Vandenberg
856266432d fix repo URL for brew search
Closes Homebrew/homebrew#25192.
2013-12-13 18:31:11 -08:00
Misty De Meo
ea646cd428 Adjust bad xcode-select path exit code 2013-12-13 09:29:35 -08:00
Misty De Meo
775406be91 brew: error out if bad xcode-select path given
Since a bad xcode-select path can cause many brew commands to freeze,
it's worth warning users and bailing out as early as possible.

The doctor check wasn't good enough, since the doctor could freeze
before the warning about this was ever printed.
2013-12-13 08:52:29 -08:00
Bovard Tiberi
569bd7c425 doctor: fix PATH issues in comments
Closes Homebrew/homebrew#25170.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2013-12-12 20:07:39 -06:00
Jack Nagel
07006bfdd4 bottle: only chdir into the cellar when tarring up the bottle 2013-12-12 19:46:37 -06:00
Osman Currim
b6f8649496 Add bash completion support for "brew switch"
First autocompletes on the names of installed packages and then
autocompletes on available versions for that specific package

Closes Homebrew/homebrew#25051.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2013-12-12 19:08:23 -06:00
Jack Nagel
bc3ebd8343 Build install summary in a separate method and print all at once
This prevents interleaved output, e.g. when running with Ruby warnings
turned on.
2013-12-12 15:42:35 -06:00
Jack Nagel
3516bb68d3 Combine superenv tests 2013-12-12 15:42:35 -06:00
Jack Nagel
b174012b17 Initialize ivars to silence warnings 2013-12-12 15:42:35 -06:00
Jack Nagel
6c04ccfb3b Remove unused variables 2013-12-12 15:42:35 -06:00
Mike McQuaid
55db2f7e11 uses: fix weird colon output.
Closes Homebrew/homebrew#24145.
2013-12-12 21:24:42 +00:00
Mike McQuaid
38d2ffb2b8 audit: remove deprecated Python features.
These will be removed soon so don't check for them.
2013-12-12 21:07:41 +00:00
Mike McQuaid
16aeb7bca4 example-formula: deprecate some Python features.
These will be removed soon so don't recommend them.
2013-12-12 21:07:41 +00:00
Jack Nagel
1aadc83e70 Put positive case first, drop redundant is_a? check 2013-12-12 14:53:53 -06:00
Jack Nagel
a55f66839a Add another fails_with test 2013-12-12 14:53:53 -06:00
Jack Nagel
00d0de5b24 Report correct file/line in backtraces for attr_rw methods 2013-12-12 14:20:46 -06:00
Mike McQuaid
c0d199759f brew-pull: remove empty if block. 2013-12-12 18:58:47 +00:00
Mike McQuaid
01c2d40f6c brew-pull: add --bottle to pull from BrewTestBot. 2013-12-12 18:45:17 +00:00
Adam Vandenberg
e523262dfa monkey around for emacs' code highlighter
The abv method has a construct that causes emacs to not highlight
the rest of pathname.rb, so move abv lower in the file.

Sorry.
2013-12-12 08:22:39 -08:00
Adam Vandenberg
7516cee374 +x wrapper scripts, so they work during post-install 2013-12-12 08:21:22 -08:00
Jack Nagel
5c18054341 Simplify prefix test 2013-12-11 19:18:23 -06:00
Larry Shaffer
a4355c9f67 brew-bundle: update usage info and move to --help function
Follow-up to 6697ff6c9d0d4301adfbb7c76628808a63f1324b

Closes Homebrew/homebrew#25130.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2013-12-11 08:10:11 +00:00
Jack Nagel
4f158f23b8 Set bottle version rather than re-parse it from the URL 2013-12-11 01:49:00 -06:00
Jack Nagel
8c5a49067e brew-test-bot: fix rsync for bottles with a revision number 2013-12-10 17:43:18 -06:00
Jack Nagel
1b7718f6a7 bottle: determine revision more reliably
Closes Homebrew/homebrew#25100.
2013-12-10 16:39:13 -06:00
Mike McQuaid
1d1bad98b7 brew-test-bot: remember to pull the PR. 2013-12-10 21:41:09 +00:00
Mike McQuaid
418b751aca brew-test-bot: only merge bottles if copy succeeds. 2013-12-10 21:32:29 +00:00
Mike McQuaid
9392e632bc brew-test-bot: fix testing job tag numbering. 2013-12-10 20:56:32 +00:00
Mike McQuaid
fea5fcf25b brew-test-bot: change upload job approach. 2013-12-10 20:52:11 +00:00
Mike McQuaid
b1331e62b1 brew-test-bot: upload job fixes. 2013-12-10 20:35:21 +00:00
Mike McQuaid
50aa91940d brew-test-bot: use global cache again. 2013-12-10 20:20:37 +00:00
Mike McQuaid
67840c691e brew-test-bot: move logic from Jenkins to Ruby. 2013-12-10 20:14:15 +00:00
Jack Nagel
a933b58507 versions: restore original constant
Before:

  f1 = Formula.factory('tree')
  f1.versions
  f2 = Formula.factory('tree')
  f1.class == f2.class # => false

After:

  f1 = Formula.factory('tree')
  f1.versions
  f2 = Formula.factory('tree')
  f1.class == f2.class # => true
2013-12-09 21:13:45 -06:00
Jack Nagel
b6cbd08e93 Implement hash equality for Version 2013-12-09 19:43:07 -06:00
Jack Nagel
8f42185e18 bottle: re-raise interrupt after cleanup 2013-12-09 19:38:20 -06:00
Jack Nagel
4afd633570 bottle: clean up after interrupts 2013-12-09 17:35:05 -06:00
Jack Nagel
c3ac88d8c7 versions: delete unused method 2013-12-09 17:34:04 -06:00
Jack Nagel
291cdea687 Extract constants for checkums in tests 2013-12-09 15:57:50 -06:00
Jack Nagel
5e0a8668fb Silence more warnings 2013-12-09 15:15:53 -06:00
Jack Nagel
bac0536730 keg_only_reason and cc_failures are not DSL methods 2013-12-09 15:15:53 -06:00
Jack Nagel
e1480953e6 Use accessors to silence uninitalized ivar warnings 2013-12-09 15:15:52 -06:00
Jack Nagel
f579d90458 Expand requirements of default deps added by other requirements
Dependencies built from requirements with a default formula may
themselves have requirements, and these requirements may have default
formulae, which may have more requirements, etc., so we have to keep
expanding until this isn't the case.

Fixes Homebrew/homebrew#25025.
Fixes Homebrew/homebrew#25037.
2013-12-09 14:36:10 -06:00
Jack Nagel
08055e1776 Ensure option names are consistent for default formula requirements 2013-12-09 14:36:10 -06:00
Jack Nagel
901902b53b Compute recursive deps for default_formula deps 2013-12-09 14:36:10 -06:00
Jack Nagel
293bde278a Rename filter_deps to expand_dependencies 2013-12-09 14:36:10 -06:00