5954 Commits

Author SHA1 Message Date
Jack Nagel
197dbe5601 Remove dead code
Formula objects are always constructed with an explicit name, so we no
longer need to special case an empty name or the name "__UNKNOWN__".
2014-07-16 18:30:52 -05:00
Jack Nagel
33eed80ccc Rename fetch_bottle_for to fetch_checksum_for 2014-07-16 14:52:18 -05:00
Jack Nagel
68326805ae Implement []= on BottleCollector 2014-07-15 21:55:14 -05:00
Jack Nagel
26f4a78825 No need to set the URL for dependency test 2014-07-15 20:18:25 -05:00
Jack Nagel
8a777e65c4 Ensure that all required keys are passed to bottle_filename 2014-07-15 17:05:15 -05:00
Jack Nagel
a3dad588a8 Remove default tag value from bottle_filename
We always call this method with an explicit tag.
2014-07-15 17:05:15 -05:00
Jack Nagel
5d1977363f Tighten up bottle ruby file glob 2014-07-15 16:11:35 -05:00
Jack Nagel
771bc2978c Eagerly set the download strategy 2014-07-15 13:42:03 -05:00
Adam Vandenberg
de42ad52a5 Move pjsip to the boneyard.
Will accept an updated pull request to update this to the current version.

Closes Homebrew/homebrew#27235.
2014-07-13 22:09:31 -07:00
Jack Nagel
1e18413848 Fix reference to ISSUES_URL
Fixes Homebrew/homebrew#30848.
2014-07-13 21:24:07 -05:00
Jack Nagel
08891e77b6 Remove default value from bottle_url options parameter
To construct a URL, we need options to pass to bottle_filename, so this
method should error out if none are given.
2014-07-13 19:29:36 -05:00
Jack Nagel
272cb4db26 Remove default value from bottle_suffix parameter
We always call this method with an argument, so we can simplify it.
2014-07-13 19:29:36 -05:00
Jack Nagel
644904736e Inline method so we don't merge and unpack options twice 2014-07-13 19:29:36 -05:00
Jack Nagel
0323226256 Inline method that just wraps a constant 2014-07-13 18:41:14 -05:00
Adam Vandenberg
12fe7e2771 nudge formatting
Needed for Emacs' ruby highlighting to work past this point in the file.
2014-07-13 12:04:45 -07:00
Jack Nagel
74ae43c690 Use accessor method in test 2014-07-13 13:07:36 -05:00
Jack Nagel
237fa3164d Use a hash to cache compiler version lookups 2014-07-13 10:50:56 -05:00
Jack Nagel
fe0c018a1a No need to cache lookup that is only done once 2014-07-13 10:50:56 -05:00
Jack Nagel
2bbc98694a Simplify early return condition
Improvements to formula/bottle integration means we can be less
defensive here.
2014-07-12 23:13:32 -05:00
Jack Nagel
7b1ca1d152 Compare cellar and prefix against constants 2014-07-12 22:43:35 -05:00
Jack Nagel
58464287bc Use pkg_version accessor 2014-07-12 22:37:51 -05:00
Jack Nagel
8076f3340a Fix typo 2014-07-12 20:15:57 -05:00
Jack Nagel
1eafe3bc35 Handle conflicts where links point at symlinks
Fixes Homebrew/homebrew#30664.
2014-07-12 19:56:58 -05:00
Jack Nagel
7b26c885bd Always link symlinks directly 2014-07-12 19:56:58 -05:00
Shaun Jackman
1fb1677532 Linuxbrew: Move ISSUES_URL to os from global
Closes Homebrew/linuxbrew#103

Closes Homebrew/homebrew#30830.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-07-12 15:39:59 -05:00
Imtiaz Majeed
83a3b7d2a0 Fix Grammar in example-formula.rb
Fix minor grammar: its -> it's

Closes Homebrew/homebrew#30826.

Signed-off-by: Misty De Meo <mistydemeo@gmail.com>
2014-07-11 22:56:41 -07:00
Jack Nagel
f906d13ef2 Remove dead code 2014-07-11 20:34:33 -05:00
Jack Nagel
a2ef43b2a4 Only compute the log file path once per call 2014-07-11 20:28:17 -05:00
Jack Nagel
a7ca4bc300 Remove intermediate variable 2014-07-11 20:27:57 -05:00
Jack Nagel
3b7c5af431 Add test for InstallRenamed module 2014-07-11 19:01:55 -05:00
Jack Nagel
58b99f2cee Try to workaround gem packaging shenanigans 2014-07-11 17:23:39 -05:00
Matt Hauck
19847285f2 exceptions: fix typo
Closes Homebrew/homebrew#30821.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-07-11 15:08:18 -07:00
Jack Nagel
6cad17caef brew-test-bot: use git to do the diff filtering 2014-07-11 16:15:45 -05:00
Jack Nagel
845c4b7f2f brew-pull: use git to do the diff filtering 2014-07-11 16:12:54 -05:00
Jack Nagel
5c24b7330b Read if no block is passed to Utils.popen_read 2014-07-11 15:52:39 -05:00
Jack Nagel
677cd51977 Use Utils.popen_read in XQuartz version codepath 2014-07-11 15:41:54 -05:00
Jack Nagel
72129668f4 audit: warn when using old-style patches 2014-07-11 12:46:41 -05:00
Jack Nagel
c259866517 Raise Errno::ENOENT instead of RuntimeError from Pathname#install 2014-07-10 22:00:43 -05:00
Jack Nagel
284389a6bd Make comment in Pathname#install more accurate 2014-07-10 15:39:55 -05:00
Jack Nagel
126d2133ab Fix method signature 2014-07-10 12:42:54 -05:00
Jack Nagel
2b9cfe9fa5 Legacy patches are never StringIOs 2014-07-10 12:42:54 -05:00
Mike McQuaid
07f0f60908 Deprecate some contributions.
This is just a starting point to start discussion. I think we have a
few options with contributions:

- Stop accepting them altogether and move the ones we need/use/support
  into core commands
- Accept them on an unsupported basis and require they be added
  manually to the PATH
- Actively support and fix bugs in them all

Closes Homebrew/homebrew#30749.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-07-10 10:24:17 -07:00
Jack Nagel
5fee415d45 Add 10.10 pkgconfig files 2014-07-10 12:21:18 -05:00
Jack Nagel
f6780467c1 Make vendored pkgconfig files match the actual library versions 2014-07-10 12:21:18 -05:00
Adam Vandenberg
724362a77b Move TeXmacs to boneyard.
Does not compile with modern C++ compilers.

Closes Homebrew/homebrew#27386.
2014-07-09 21:39:34 -07:00
Mike McQuaid
2404de68d4 formula_installer: bottle against Homebrew Python. 2014-07-09 16:50:23 -07:00
Jack Nagel
cf8f8dec1f Fix up phrasing of case-sensitive volume warning 2014-07-09 17:04:52 -05:00
Jack Nagel
82ce0be6fd Clean up /bin/df regexp
- remove unnecessary captures
 - '%' is not a metacharacter so it doesn't need to be escaped
 - match using '+' instead of '*'
2014-07-09 17:04:52 -05:00
Jack Nagel
5ab16295e5 Fix getting filesystem mounts 2014-07-09 17:04:52 -05:00
Jack Nagel
7ee49db51e Remove proc handling from BuildEnvironment 2014-07-07 22:02:32 -05:00