Jack Nagel
ddefbe2c85
Use locals instead of repeatedly converting pathnames to strings
2014-07-17 15:01:26 -05:00
Jack Nagel
ecc9407fed
Remove deprecated options from brew-diy
2014-07-17 12:24:03 -05:00
Jack Nagel
8df33f7446
diy: use configure as the heuristic for autotools
...
Closes Homebrew/homebrew#30912 .
2014-07-17 12:14:17 -05:00
Phillip Calvin
d4b6d8ec96
Remove commentary from error message
...
It might be best not to use the word "lame" here, as it's often considered to be an ableist slur.
Closes Homebrew/homebrew#30915 .
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-07-17 12:11:57 -05:00
Jack Nagel
4295e76d3f
Remove more dead code
2014-07-16 23:22:04 -05:00
Jack Nagel
28f0e5c4fd
Don't raise when converting the tag to a version fails
2014-07-16 21:11:48 -05:00
Jack Nagel
596f3ba0a0
Raise ArgumentError when a symbol can't be mapped to a version
...
The fact that this is implemented as a hash lookup is an implementation
detail, so don't let the KeyError bubble up.
2014-07-16 21:11:48 -05:00
Jack Nagel
a554b5c9b7
Rename test
2014-07-16 21:11:48 -05:00
Jack Nagel
ab41071d2b
Separate tag matching and checksum lookup
2014-07-16 21:11:48 -05:00
Jack Nagel
005f41c02a
Use [] on the instance rather than the wrapped hash
2014-07-16 18:54:19 -05:00
Jack Nagel
8044c4524b
Rename variable
2014-07-16 18:54:19 -05:00
Jack Nagel
dc3bcf22a3
Mark private methods as private
2014-07-16 18:54:19 -05:00
Jack Nagel
3c366a56d7
Add key? to BottleCollector
2014-07-16 18:54:19 -05:00
Jack Nagel
197dbe5601
Remove dead code
...
Formula objects are always constructed with an explicit name, so we no
longer need to special case an empty name or the name "__UNKNOWN__".
2014-07-16 18:30:52 -05:00
Jack Nagel
33eed80ccc
Rename fetch_bottle_for to fetch_checksum_for
2014-07-16 14:52:18 -05:00
Jack Nagel
68326805ae
Implement []= on BottleCollector
2014-07-15 21:55:14 -05:00
Jack Nagel
26f4a78825
No need to set the URL for dependency test
2014-07-15 20:18:25 -05:00
Jack Nagel
8a777e65c4
Ensure that all required keys are passed to bottle_filename
2014-07-15 17:05:15 -05:00
Jack Nagel
a3dad588a8
Remove default tag value from bottle_filename
...
We always call this method with an explicit tag.
2014-07-15 17:05:15 -05:00
Jack Nagel
771bc2978c
Eagerly set the download strategy
2014-07-15 13:42:03 -05:00
Adam Vandenberg
de42ad52a5
Move pjsip to the boneyard.
...
Will accept an updated pull request to update this to the current version.
Closes Homebrew/homebrew#27235 .
2014-07-13 22:09:31 -07:00
Jack Nagel
08891e77b6
Remove default value from bottle_url options parameter
...
To construct a URL, we need options to pass to bottle_filename, so this
method should error out if none are given.
2014-07-13 19:29:36 -05:00
Jack Nagel
272cb4db26
Remove default value from bottle_suffix parameter
...
We always call this method with an argument, so we can simplify it.
2014-07-13 19:29:36 -05:00
Jack Nagel
644904736e
Inline method so we don't merge and unpack options twice
2014-07-13 19:29:36 -05:00
Jack Nagel
0323226256
Inline method that just wraps a constant
2014-07-13 18:41:14 -05:00
Adam Vandenberg
12fe7e2771
nudge formatting
...
Needed for Emacs' ruby highlighting to work past this point in the file.
2014-07-13 12:04:45 -07:00
Jack Nagel
74ae43c690
Use accessor method in test
2014-07-13 13:07:36 -05:00
Jack Nagel
237fa3164d
Use a hash to cache compiler version lookups
2014-07-13 10:50:56 -05:00
Jack Nagel
fe0c018a1a
No need to cache lookup that is only done once
2014-07-13 10:50:56 -05:00
Jack Nagel
2bbc98694a
Simplify early return condition
...
Improvements to formula/bottle integration means we can be less
defensive here.
2014-07-12 23:13:32 -05:00
Jack Nagel
7b1ca1d152
Compare cellar and prefix against constants
2014-07-12 22:43:35 -05:00
Jack Nagel
58464287bc
Use pkg_version accessor
2014-07-12 22:37:51 -05:00
Jack Nagel
8076f3340a
Fix typo
2014-07-12 20:15:57 -05:00
Jack Nagel
1eafe3bc35
Handle conflicts where links point at symlinks
...
Fixes Homebrew/homebrew#30664 .
2014-07-12 19:56:58 -05:00
Jack Nagel
7b26c885bd
Always link symlinks directly
2014-07-12 19:56:58 -05:00
Shaun Jackman
1fb1677532
Linuxbrew: Move ISSUES_URL to os from global
...
Closes Homebrew/linuxbrew#103
Closes Homebrew/homebrew#30830 .
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-07-12 15:39:59 -05:00
Jack Nagel
3b7c5af431
Add test for InstallRenamed module
2014-07-11 19:01:55 -05:00
Jack Nagel
58b99f2cee
Try to workaround gem packaging shenanigans
2014-07-11 17:23:39 -05:00
Matt Hauck
19847285f2
exceptions: fix typo
...
Closes Homebrew/homebrew#30821 .
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-07-11 15:08:18 -07:00
Jack Nagel
5c24b7330b
Read if no block is passed to Utils.popen_read
2014-07-11 15:52:39 -05:00
Jack Nagel
677cd51977
Use Utils.popen_read in XQuartz version codepath
2014-07-11 15:41:54 -05:00
Jack Nagel
72129668f4
audit: warn when using old-style patches
2014-07-11 12:46:41 -05:00
Jack Nagel
c259866517
Raise Errno::ENOENT instead of RuntimeError from Pathname#install
2014-07-10 22:00:43 -05:00
Jack Nagel
284389a6bd
Make comment in Pathname#install more accurate
2014-07-10 15:39:55 -05:00
Jack Nagel
126d2133ab
Fix method signature
2014-07-10 12:42:54 -05:00
Jack Nagel
2b9cfe9fa5
Legacy patches are never StringIOs
2014-07-10 12:42:54 -05:00
Adam Vandenberg
724362a77b
Move TeXmacs to boneyard.
...
Does not compile with modern C++ compilers.
Closes Homebrew/homebrew#27386 .
2014-07-09 21:39:34 -07:00
Mike McQuaid
2404de68d4
formula_installer: bottle against Homebrew Python.
2014-07-09 16:50:23 -07:00
Jack Nagel
cf8f8dec1f
Fix up phrasing of case-sensitive volume warning
2014-07-09 17:04:52 -05:00
Jack Nagel
82ce0be6fd
Clean up /bin/df regexp
...
- remove unnecessary captures
- '%' is not a metacharacter so it doesn't need to be escaped
- match using '+' instead of '*'
2014-07-09 17:04:52 -05:00