Jack Nagel
1ef2819979
Use the dependency object as the key in the inherited_options hash
2014-08-24 16:11:51 -05:00
Jack Nagel
8aabba670f
Consider on-disk state when computing dependencies
...
Fixes Homebrew/homebrew#28754 .
Fixes Homebrew/homebrew#29846 .
Fixes Homebrew/homebrew#30920 .
2014-08-24 14:46:34 -05:00
Jack Nagel
b0c1e5f7d6
Fix redefinition of x11 reader method in superenv
2014-08-24 14:32:10 -05:00
Jack Nagel
566442606a
Remove an unnecessary default argument
2014-08-23 22:41:35 -05:00
Jack Nagel
05bb612ce7
Use opt_prefix instead of constructing it manually
2014-08-23 17:42:13 -05:00
Jack Nagel
3a96a1a594
Use a set to track failed downloads
2014-08-22 22:55:10 -05:00
Jack Nagel
fd4f985cb6
Rescue only DownloadError
2014-08-22 22:55:10 -05:00
Jack Nagel
262a503b6f
Decouple IncompatibleCxxStdlibs from its superclass
...
This exception is never used outside of the CxxStdlib class, so we don't
need the Homebrew::InstallationError superclass.
2014-08-22 22:37:35 -05:00
Jack Nagel
3d26b75847
Pull common stdlib checking code into a method
2014-08-22 22:18:03 -05:00
Arne Jørgensen
f936b33279
drush: move to Homebrew/php tap.
...
Closes Homebrew/homebrew#31726 .
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-08-22 16:48:53 +01:00
Jack Nagel
0bf3ec593d
Fix false positive audit warning
2014-08-21 15:13:13 -05:00
Jack Nagel
af3d551de7
Options no longer needs deep-copy semantics
...
Follow-up to 23d90a6a187a57fbdf4eeac146993e3b37c3d4d9.
2014-08-20 19:05:49 -05:00
Jack Nagel
023f02b90a
Make fails_with available in spec blocks
...
Closes Homebrew/homebrew#31706 .
2014-08-19 17:14:02 -05:00
Jack Nagel
00220c40db
Don't overwrite optimization flag map in ENV.clang
2014-08-18 16:02:53 -05:00
Larry Shaffer
b6cca78e05
Upgrade honors build_bottle? and built_as_bottle options
...
Closes Homebrew/homebrew#31628 .
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-08-17 15:36:24 -05:00
Jack Nagel
92eb96aca0
Use the build accessor rather than metaprogramming
2014-08-16 23:04:48 -05:00
Jack Nagel
281646b089
Define the test_defined? method dynamically
2014-08-16 17:44:22 -05:00
Jack Nagel
c0ef3d1541
Use the keg_only_reason instance method in keg_only?
2014-08-16 15:41:14 -05:00
Mike McQuaid
2d91613d06
fetch: retry the download on a failure.
2014-08-16 08:49:01 +01:00
Jack Nagel
95aef55110
Simplify cxxstdlib_check implementation
...
The cxxstdlib_check method currently only supports one value, so we can
just define the accompanying instance method when necessary. If we ever
add more options we can back it with a data structure.
2014-08-16 02:16:05 -05:00
Jack Nagel
e6498f4dfc
Remove the universal accessor from BuildOptions
...
BuildOptions is now immutable (finally).
2014-08-16 01:39:33 -05:00
Jack Nagel
181654ddaf
Remove two more unnecessary default arguments
2014-08-14 19:58:36 -05:00
xxxajk
1dc384b4c4
Fix mktmp to be generic as-per SUS/BSD.
...
Closes Homebrew/homebrew#31586 .
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-08-14 10:36:07 +01:00
Jack Nagel
c7444d34f7
Use the as_flags method instead of map
2014-08-14 01:00:23 -05:00
Jack Nagel
4c4193e905
Use the Enumerable implementation of include?
2014-08-14 00:03:34 -05:00
Jack Nagel
ae4b9fffd4
Avoid hardcoding the class name
2014-08-13 23:45:48 -05:00
Jack Nagel
edbb219bbd
More idiomatic way to combine arrays
2014-08-13 20:54:49 -05:00
Jack Nagel
2311181b54
Remove Options#concat
2014-08-13 18:16:25 -05:00
Jack Nagel
0d6ceaf86e
Simplify build_argv
2014-08-13 18:16:25 -05:00
Jack Nagel
d443089270
Simplify tab test setup
2014-08-13 17:15:03 -05:00
Jack Nagel
eed8af9b80
Drop unnecessary parens in tests
2014-08-13 17:14:55 -05:00
Jack Nagel
e40143efd5
Drop unnecessary to_a calls in options tests
2014-08-13 11:09:57 -05:00
Jack Nagel
268cd143be
Replace Options.coerce with an alternate constructor
2014-08-13 11:09:57 -05:00
Jack Nagel
094c184b12
Remove unused branches from Options.coerce
2014-08-13 11:09:57 -05:00
Jack Nagel
a980938773
Options is no longer used directly by BuildOptions
2014-08-13 11:09:57 -05:00
Jack Nagel
886c20ddba
Set methods on Options already return Options instances
2014-08-13 11:09:57 -05:00
Jack Nagel
c5a888fb3a
Always pass an Options instance to the BuildOptions constructor
2014-08-13 11:09:57 -05:00
Jack Nagel
5c1c9e6550
Only store strings in the tab object
2014-08-13 11:09:57 -05:00
Mike McQuaid
9f14262d92
Revert "Always pass an Options instance to the BuildOptions constructor"
...
This reverts commit e143bcef259ca76b2124e6e73bd9bdf872418723.
Closes Homebrew/homebrew#31557 .
Closes Homebrew/homebrew#31559 .
Closes Homebrew/homebrew#31561 .
Closes Homebrew/homebrew#31562 .
2014-08-13 08:46:17 +01:00
Mike McQuaid
d4aa7b8df0
Revert "Set methods on Options already return Options instances"
...
This reverts commit 4d1464c246861f7aedc355cb5f6360370d05114e.
2014-08-13 08:45:08 +01:00
Mike McQuaid
1e852a8f3f
Revert "Options is no longer used directly by BuildOptions"
...
This reverts commit 1c05bc0238aa1abf7d5542b8afa11ead2bee66a8.
2014-08-13 08:45:07 +01:00
Mike McQuaid
00d1bb8d12
Revert "Remove unused branches from Options.coerce"
...
This reverts commit cee42c339e7632eab15111e2c4e6c121ace6f9e2.
2014-08-13 08:45:07 +01:00
Mike McQuaid
a61c3615d2
Revert "Replace Options.coerce with an alternate constructor"
...
This reverts commit 8d2ef974a3a87bf4207f71ccb8a7b4776e16a016.
2014-08-13 08:45:06 +01:00
Mike McQuaid
f93a9aafca
Revert "Drop unnecessary to_a calls in options tests"
...
This reverts commit 6f29c36aed9d951499146054a4caca702fa33d1a.
2014-08-13 08:45:04 +01:00
Jack Nagel
445a512379
Drop unnecessary to_a calls in options tests
2014-08-13 00:33:18 -05:00
Jack Nagel
25395c6de6
Replace Options.coerce with an alternate constructor
2014-08-12 23:55:28 -05:00
Jack Nagel
0a2be32d80
Remove unused branches from Options.coerce
2014-08-12 23:55:28 -05:00
Jack Nagel
28bd10551f
Options is no longer used directly by BuildOptions
2014-08-12 20:23:02 -05:00
Jack Nagel
1c49729222
Set methods on Options already return Options instances
2014-08-12 20:19:56 -05:00
Jack Nagel
ecaf1592a0
Always pass an Options instance to the BuildOptions constructor
2014-08-12 20:09:35 -05:00