Caleb Xu
318175cfe2
Utils: add shortened_brew_path
2021-06-15 09:58:46 -04:00
Mike McQuaid
c4d69dd2e9
Revert "fix(vendor-gems): redirect bundler stdout to stderr"
2021-06-07 14:51:07 +01:00
Gibson Fahnestock
07d571bebc
fix(vendor-gems): redirect bundler stdout to stderr
...
When running brew commands and interpreting the output, e.g. running
`brew livecheck --json`, it's necessary to stop other programs Homebrew
happens to execute from writing logging output to stdout. Most programs
don't do this, but `bundle install` does seem to.
To reproduce the issue you can run:
```shell
git -C "$(brew --prefix)" clean -ffdx Library/Homebrew/vendor
stdout=$(HOMEBREW_FORCE_VENDOR_RUBY=1 brew livecheck --newer-only --json --cask $(brew --repo homebrew/cask)/Casks/grid.rb)
echo "^^^ was stderr, >>> is stdout: $stdout"
```
If you run it without this change it will print a bunch of output like
this to the stdout before printing out the livecheck JSON output:
```text
Using bundler 1.17.3
Fetching byebug 11.1.3
Fetching coderay 1.1.3
Installing byebug 11.1.3 with native extensions
Installing coderay 1.1.3
Fetching colorize 0.8.1
Installing colorize 0.8.1
[
# Contents of the JSON block.
]
```
With this change the stdout from `bundle install` will be redirected to
brew's stderr, meaning only the JSON goes to stdout, and the rest goes
to stderr.
2021-06-03 11:18:23 +01:00
Mike McQuaid
d73351251c
Deprecate, disable, delete code for next major/minor version.
...
Do the usual dance for bumping our major/minor version.
2021-04-09 09:30:36 +01:00
Markus Reiter
b6ed8915e5
Add compatibility layer for AbstractDownloadStrategy#fetch.
2021-04-03 20:10:33 +02:00
nandahkrishna
3ce8ef3173
utils: raise UsageError in parse_author!
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2021-04-01 22:22:32 +05:30
nandahkrishna
53a7065bcc
Allow specifying committer for some dev-cmds
2021-04-01 22:22:31 +05:30
nandahkrishna
8e5451df2f
style: use parentheses for assignment in conditions
2021-02-12 18:33:37 +05:30
Bo Anderson
0e732d3917
cmd/update-report: report outdated count & suggest brew upgrade
2021-02-10 15:36:38 +00:00
Misty De Meo
c6dc42fd9d
Utils: fix *_stdout_or_stderr helpers
...
Several calls to ohai and puts were directly changed into calls to
these new functions, but they don't share arity or an API.
The base functions allow arbitrary number of arguments, allowing for
multiline printing that covers both a title and a longer message.
2021-02-05 10:13:44 -08:00
Mike McQuaid
72cb6ffd12
utils: import {ohai,puts}_stdout_or_stderr
...
Fixes #10536
2021-02-05 15:03:31 +00:00
Bo Anderson
b670ab1c7b
Deprecate additional arch functions
2021-02-02 16:19:24 +00:00
nandahkrishna
e2ddf9894a
Refactor brew bump
2021-01-24 19:10:46 +05:30
Seeker
b9854bd4cf
rubocops: add unless_multiple_conditions
2021-01-08 10:33:54 -08:00
Seeker
41e0619de8
utils: add git_repository
2021-01-07 11:45:11 -08:00
Markus Reiter
3db55d13d6
Improve handling of SIGINT.
2020-12-18 16:48:49 +01:00
Mike McQuaid
4bb8becf60
odeprecated: handle deprecated and disabled formulae.
...
It's not useful to spend time complaining about or fixing deprecations
or disables in deprecated or disabled formulae given we already complain
on install and don't run them through CI.
2020-12-15 12:04:29 +00:00
Mike McQuaid
9216d8abe6
rubocop-rails: make fixes.
2020-12-02 10:43:04 +00:00
Markus Reiter
fe2c201d00
Merge pull request #9268 from reitermarkus/type-signatures
...
Add more type signatures.
2020-11-30 15:16:05 +01:00
Markus Reiter
6750448d95
Fix some auto-correctable type errors.
2020-11-29 21:23:54 +01:00
Misty De Meo
7f5a94bbcb
Formula cookbook: document with_env
...
The other syntax for setting `ENV` was added in #9013 ,
but this form remained undocumented.
Fixes #8648 .
2020-11-27 09:08:10 -08:00
Markus Reiter
da9289eff0
Add more type signatures.
2020-11-13 12:26:36 +01:00
EricFromCanada
3768b7a6e9
apidoc: update comment wording, punctuation, formatting
2020-11-06 00:21:02 -05:00
EricFromCanada
dddfbf80fc
apidoc: add/update yard tags
2020-11-06 00:16:35 -05:00
Markus Reiter
24ae318a3d
Move type annotations into files.
2020-10-10 14:59:39 +02:00
nandahkrishna
c1909e80b4
utils/tty: fix TTY handling for stderr
2020-09-17 04:18:13 +05:30
Markus Reiter
0514e2dbba
Move command_help_lines into Help module.
2020-08-24 00:46:33 +02:00
Mike McQuaid
f6e035ec98
Merge pull request #8297 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-0.89.1
...
build(deps): bump rubocop from 0.88.0 to 0.89.1 in /Library/Homebrew
2020-08-19 17:40:32 +01:00
Mike McQuaid
3a91c37e66
Fix RuboCop checks.
2020-08-19 17:12:32 +01:00
Baffour Adu Boampong
ad2809b615
Merge branch 'master' into mlh-outdated-packages
2020-08-10 21:21:09 +00:00
Markus Reiter
490e503b1b
Replace Homebrew.args with Context.
2020-08-06 16:13:14 +02:00
Markus Reiter
75a692d08b
Make ohai, oh1 and odebug use #debug? and verbose? of the current object when possible.
2020-08-06 16:12:52 +02:00
Baffour Adu Boampong
5f19a53195
Refactor bump.rb methods into seperate modules
2020-07-30 22:58:30 +00:00
Baffour Adu Boampong
537a07b42d
Remove duplicate line
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-07-29 13:41:27 +00:00
Baffour Adu Boampong
d7149d1f76
Fix merge conflicts
2020-07-06 03:32:18 +00:00
Baffour Adu Boampong
7a9fbfb6d3
setup and test command
2020-06-30 15:11:11 +00:00
EricFromCanada
e62137133e
docs: fix comment help output
2020-06-25 11:59:42 -04:00
Mike McQuaid
aa81982aba
brew style --fix
2020-06-02 09:49:23 +01:00
Mike McQuaid
bc27e38f18
Remove ARGV.debug?
...
Replace with `Homebrew.args.debug?`.
Part of #5730 .
2020-05-23 14:38:58 +01:00
Mike McQuaid
e33dc9e916
utils: brew style --fix.
2020-05-21 10:15:34 +01:00
Mike McQuaid
3381cbf5c7
Use Homebrew::EnvConfig.
2020-04-07 09:58:26 +01:00
Mike McQuaid
b5165ed7e8
Clarify tap issues should not be reported to Homebrew.
...
Instead, direct people to the actual tap.
2020-03-11 10:57:36 +00:00
Mike McQuaid
eb87651341
Revert "Revert "help: print cli/parser help message if used""
2020-02-02 16:36:59 +01:00
Gautham Goli
acde828a45
ARGV: Replace ARGV.verbose? with Homebrew.args.verbose?
2020-02-02 14:00:04 +01:00
Mike McQuaid
f3afedb4ff
utils#system: improve verbose output.
...
This previously output the hilarious long and unnecessary LOAD_PATH.
2019-11-06 15:25:51 +00:00
Issy Long
341ea60807
Auto-fix Style/RedundantBegin offenses
...
- This also required auto-fixes for Layout/EmptyLinesAroundBlockBody and
Layout/InconsistentIndentation once the auto-fixer had got rid of the
"redundant begin"s.
2019-10-13 16:04:27 +01:00
Markus Reiter
b1d0c61fea
Update Gems.
2019-10-03 09:22:44 +02:00
Markus Reiter
e5899a6101
Move global methods into Kernel module.
...
Otherwise they are not defined inside of subclasses of `DelegateClass`.
2019-08-15 16:39:55 +02:00
Mike McQuaid
c5c59149c4
utils: make redact_secrets handle nil secrets.
...
Fixes #6363 .
2019-08-13 08:15:24 +01:00
Cheng XU
9232ca4508
system_command: allow redacting secrets in the log
...
Add a new argument `secrets` to specify secret tokens, so we can redact them in the log.
2019-07-18 15:06:32 +08:00
