1106 Commits

Author SHA1 Message Date
Markus Reiter
add8885dd8 Add helper method for cask installer to get dependencies. 2019-11-01 20:28:36 +01:00
Markus Reiter
78725740e2 Refactor cask dependency resolution. 2019-10-31 20:20:55 +01:00
Markus Reiter
df3bbd0299 Reduce need for interpolating appdir in casks. 2019-10-24 17:07:30 +02:00
Markus Reiter
54ab3dd7c4 Install pkg before app. 2019-10-24 15:04:01 +02:00
Markus Reiter
e6cfb4a3c2
Merge pull request #6629 from timsly/manpage-artifact
Add Manpage artifact
2019-10-24 13:48:52 +02:00
Tim Masliuchenko
6d1fafae13 Final tweaks 2019-10-24 09:43:59 +03:00
Tim Masliuchenko
87f29857f0 Pass section to the constructor 2019-10-23 18:34:16 +03:00
Tim Masliuchenko
22d821323c Feedbacks 2019-10-23 16:28:00 +03:00
Markus Reiter
1ea1f31d0b
Merge pull request #6634 from reitermarkus/trash
Fix `trash.swift` without arguments.
2019-10-23 12:08:09 +02:00
Markus Reiter
04493e2dde Fix trash.swift without arguments. 2019-10-23 06:59:39 +02:00
L. E. Segovia
a02ef65f68
cask: fix xattr error detection
Fixes Homebrew/homebrew-cask#71209
2019-10-23 01:49:09 +00:00
Tim Masliuchenko
3ef5e06943 Add Manpage artifact 2019-10-22 15:21:49 +03:00
Markus Reiter
7a5e4d1269 Remove User::automation_access?. 2019-10-22 07:38:35 +02:00
Markus Reiter
16b3cb0d71 Skip quarantining symlinks. 2019-10-15 18:32:37 +02:00
Markus Reiter
d24f3c3b99
Merge pull request #6605 from reitermarkus/missing-command-method
Fix missing `command` method.
2019-10-15 18:05:22 +02:00
Markus Reiter
40a0b8b10a Fix missing command method. 2019-10-15 17:39:15 +02:00
L. E. Segovia
ed7327296a
Cask: only quarantine working symlinks
Fixes Homebrew/homebrew-cask#70796
2019-10-14 15:38:41 +00:00
Issy Long
1f6168fe8a
Change regexp.match?(string) to string.match?(regexp) everywhere
- Only try to call `.match?` on strings that aren't nil.
2019-10-13 23:22:51 +01:00
Issy Long
341ea60807
Auto-fix Style/RedundantBegin offenses
- This also required auto-fixes for Layout/EmptyLinesAroundBlockBody and
  Layout/InconsistentIndentation once the auto-fixer had got rid of the
  "redundant begin"s.
2019-10-13 16:04:27 +01:00
Issy Long
b78028b9c2
Auto-fix Performance/RegexpMatch offenses 2019-10-13 16:04:26 +01:00
ytqh
24ef7fa5c8 remove xattr unsupported option in macOS 10.15 2019-10-11 21:18:53 +08:00
Mike McQuaid
9e56a8625d
Merge pull request #6531 from jpninanjohn/master
Show correct message when invalid arguments are passed to brew
2019-10-11 09:30:12 +01:00
Markus Reiter
77412ad14e
Merge pull request #6514 from amyspark/workaround-trash
Cask: refuse to trash root-owned files
2019-10-09 14:01:24 +02:00
Markus Reiter
b6b9cd248c Refactor brew cask style. 2019-10-04 23:43:48 +02:00
Markus Reiter
e351e6b31c
Merge pull request #6482 from alecclarke/run-style-checks-on-test-casks
Include test casks in the cask style check.
2019-10-04 23:15:59 +02:00
Jacob Ford
ea0150f7a3 Make invalid command error language consistent with brew core 2019-10-04 14:27:32 -04:00
L. E. Segovia
eccdc4c253
Cask: address @reitermarkus's comments 2019-10-03 20:21:32 +00:00
L. E. Segovia
1ddafee614
Cask: address @reitermarkus's comments 2019-10-03 20:16:01 +00:00
Ninan John
aed6bc194d Show correct message when invalid arguments are passed to brew 2019-10-03 14:21:24 +05:30
L. E. Segovia
70c49809fe
Cask: typo in trash_paths 2019-10-02 14:09:26 +00:00
L. E. Segovia
b9a3884ebf
Cask: output files requiring sudo to console 2019-10-02 13:36:05 +00:00
L. E. Segovia
aa85bec73e
Fix style issues 2019-10-02 00:25:38 +00:00
L. E. Segovia
caf7df5840
Cask: add doctor check for xattr
CC: Homebrew/homebrew-cask#69660
2019-10-01 11:17:27 +00:00
L. E. Segovia
f980ac82b9
Cask: refuse to trash root-owned files
These files cannot be trashed from CLI without sudo, which trashes them
instead to root's Trash. AppleScript isn't of use here because it will
break Travis (as it will fail when asking for admin permissions).

Fixes homebrew/homebrew-cask#69897
2019-10-01 11:12:23 +00:00
Alec Clarke
45806f6a97 Include test casks in the cask style check.
Currently the tests casks found in "/Homebrew/test/support/fixtures/cask/Casks" and "/Homebrew/test/support/fixtures/third-party/Casks" aren't included in the paths checked when running "brew cask style".

This change includes these test cask paths in the checked paths, and also includes the auto style fixes made by running `brew cask style --fix`.
2019-09-23 08:50:24 -04:00
Markus Reiter
39dabb4171
Merge pull request #6435 from alecclarke/add-cask-blacklist-to-cask-audit
Check blacklisted Casks when auditing.
2019-09-20 17:36:14 +02:00
EricFromCanada
c9a75db27d cask: recommend adoptopenjdk as per #6040 2019-09-18 19:28:44 -04:00
EricFromCanada
de26e491e2 cask: remove extra line break in :discontinued caveat 2019-09-18 19:28:44 -04:00
EricFromCanada
a9b9d4613d cask: return nil instead of "" if no caveats 2019-09-18 19:28:44 -04:00
Alec Clarke
af10d13381 Check blacklisted Casks when auditing.
In some cases, certain Casks shouldn't be resubmitted for specific reasons: difficult to maintain, developers maintain their own version, ...

To make sure these cases are restricted - we can add them to a blacklist and have the blacklist checked as part of the `brew cask audit` steps.
2019-09-17 06:29:46 -07:00
Markus Reiter
d8afed206f Use AppleScript to check if GUI apps are running. 2019-09-15 01:37:04 +02:00
Markus Reiter
7084093d45 Add missing require. 2019-09-13 19:52:43 +02:00
Markus Reiter
f010aa48ff Skip AppleScript actions if Automation Access isn't granted. 2019-09-13 16:35:44 +02:00
Markus Reiter
fca5950748 Remove brew cask automerge. 2019-08-21 11:12:36 +02:00
Markus Reiter
16d2f8264c Use MacOSRequirement for casks. 2019-08-21 06:57:21 +02:00
Markus Reiter
d5cc46f931 Support deleting login items by path. 2019-08-12 23:56:26 +02:00
Jeremy Mayeres
22f43e3670
Remove cask-eid tap from automerge
Since the homebrew-cask-eid tap is no longer in use, it should be removed from the command as well.
2019-08-11 16:23:17 +02:00
Mike McQuaid
41461b2c00
upgrade: tweak --dry-run wording. 2019-07-28 14:50:59 +01:00
Doug Hogan
7f6ef77d0e Address PR comments: remove test and use return ... if 2019-07-27 07:36:11 -07:00
Doug Hogan
55fcd01bed cask/cmd/upgrade: add --dry-run option. 2019-07-26 23:20:56 -07:00