Bo Anderson
0e3f22e1df
dev-cmd/bottle: fix positioning of bottle block in some cases
2020-07-01 23:51:23 +01:00
Rui Chen
8ff1ca644d
disable license check for new formulae
...
return when license is blank
Co-authored-by: Bo Anderson <mail@boanderson.me>
2020-07-01 17:22:07 -04:00
Jonathan Chang
204e56d01e
pr-pull, pr-upload: add --warn-on-upload-failure
2020-07-02 00:11:55 +10:00
Jonathan Chang
21c903c133
pr-pull, pr-upload: use safe_system to call brew
2020-07-01 23:59:07 +10:00
Jonathan Chang
b57290b23f
Merge pull request #7844 from jonchang/signoff-approving-reviews
...
pr-pull: add commit message trailers for pull requests with approved reviews
2020-07-01 19:18:27 +10:00
Lionell
fb4db63e3b
Merge branch 'master' into license
2020-06-30 22:25:17 +08:00
Pranas Ziaukas
455633f7d2
Throttle balena-cli version bumps
...
Discussion in Homebrew/homebrew-core#57082
2020-06-30 12:12:34 +03:00
Lionell
da2a426ec8
update-license-data: use curl_download instead of curl
2020-06-30 15:18:10 +08:00
lionellloh
4dcbe8790f
update-license-data: use of unlink to remove existing file
2020-06-30 01:29:45 +08:00
Rylan Polster
d921e94a2b
rubocop: separate args for shell commands
...
Use `system "foo", "bar"` instead of `system "foo bar"`. Also applies to
`Utils.popen_read` and `Utils.popen_write` commands. RuboCop can
automatically fix these problems.
2020-06-29 13:26:58 -04:00
lionellloh
5b3ac1fcb2
update-license-data: modify arguments when calling methods
2020-06-30 01:14:05 +08:00
lionellloh
074f66f912
write .stdout instead of SystemCommand::Result
2020-06-30 01:08:29 +08:00
Lionell Loh Jian An
da007134c4
Apply suggestions from code review
...
Code review changes
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-06-29 16:20:07 +08:00
Lionell
688a9ade0d
change .nil? to .blank?
2020-06-29 16:12:05 +08:00
Mike McQuaid
61b4e7c414
Merge pull request #7745 from dtrodrigues/bump-pr-dupes
...
bump-formula-pr: search for closed dupe PRs
2020-06-29 08:39:30 +01:00
Jonathan Chang
bada8dd759
pr-pull: add review approval trailers on signoff
2020-06-29 12:53:03 +10:00
Lionell
5f6917ae7c
Merge branch 'master' into license
2020-06-28 02:07:53 +08:00
lionellloh
4d4f6a8fac
audit: remove unnecessary nil assignment
2020-06-28 02:07:32 +08:00
Lionell Loh Jian An
759708fae7
Apply suggestions from code review
...
Code Review Changes
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-06-28 01:54:41 +08:00
Dustin Rodrigues
f684a59fa5
bump-formula-pr: search for closed dupe PRs
2020-06-27 12:50:43 -04:00
Mike McQuaid
58de51f2ce
Merge pull request #7837 from FTLam11/7392-migrate-audit-rules-to-rubocop
...
audit: Move patch checks from brew audit to rubocop
2020-06-27 13:11:51 +01:00
Frank Lam
b2eafdf11d
Remove patch checks from audit
2020-06-27 02:37:57 +08:00
Eric Knibbe
db998860f1
Merge pull request #7831 from EricFromCanada/fix-help-output
...
docs: fixes for help output
2020-06-25 13:08:48 -04:00
Dario Vladovic
519c339261
create: add --crystal option
2020-06-25 18:23:06 +02:00
EricFromCanada
910c85f782
docs: improve commands' help output
2020-06-25 12:01:52 -04:00
lionellloh
6a05e3663a
Remove Homebrew.failed=true
2020-06-25 21:06:29 +08:00
lionellloh
2cf0ac9ed5
update-spdx-data: use a more specific file path
2020-06-25 20:34:06 +08:00
lionellloh
77a8ff51da
single quotes -> double quotes
2020-06-25 19:20:26 +08:00
lionellloh
1b9cbf1bf1
changed method of fetching license data
2020-06-25 19:05:41 +08:00
Lionell
eb38890f3c
change back to open because File.open does not work on URLs
2020-06-25 17:46:28 +08:00
Lionell Loh Jian An
22baff39bc
Apply suggestions from code review
...
Applying style-related suggestions from code review
Co-authored-by: Dario Vladović <d.vladimyr@gmail.com>
2020-06-25 15:36:55 +08:00
Lionell
57fd1fdc7e
Merge branch 'master' into license
2020-06-25 13:42:27 +08:00
lionellloh
0304545d0c
use File.open instead of Kernel.open
2020-06-25 05:46:33 +08:00
lionellloh
fbd5c32d22
bunch of style fixes
2020-06-25 05:46:18 +08:00
lionellloh
37541704b8
update-license-data: style fixes
2020-06-25 05:10:29 +08:00
lionellloh
3f267a8fc9
audit: fix callers to call get_repo_data only if @new_formula
2020-06-25 05:09:56 +08:00
Lionell
4832a5aa05
audit: modified problem statement to match
2020-06-24 20:43:33 +08:00
Lionell Loh Jian An
9845091f4d
Apply suggestions from code review
...
license: code review changes
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-06-24 18:32:53 +08:00
lionellloh
127d67e745
license: update tests and license checking logic
2020-06-23 02:59:55 +08:00
lionellloh
e4e55c5cb3
update-license-data: wrote rspec test and added one more parseable arg
2020-06-23 02:25:46 +08:00
lionellloh
8d7a9d51d3
audit: rename spdx_id to spdx_data
2020-06-23 01:42:24 +08:00
lionellloh
de7edd403d
brew update-license-data: checks if it is outdated. If so, save new ver
2020-06-23 01:39:10 +08:00
Jonathan Chang
2b990aa53c
pr-pull: pass verbose and debug to subcommands
2020-06-22 00:25:57 +10:00
Jonathan Chang
17c20c0e11
pr-pull: dupe logic moved to mirror and pr-upload
2020-06-21 19:55:10 +10:00
Mike McQuaid
6049227c0a
Merge pull request #7771 from alebcay/extract-typo
...
extract: fix typo
2020-06-19 20:00:42 +01:00
Lionell
ec2391100a
Merge branch 'license' of https://github.com/MLH-Fellowship/brew into license
2020-06-19 04:24:39 +08:00
Lionell
4287ea74d1
remove json from gemfile and modified get_repo_data
2020-06-19 04:20:19 +08:00
Lionell Loh Jian An
a58905000c
Update Library/Homebrew/dev-cmd/audit.rb
...
audit license: suppress missing license problem unless it is a new_formula
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-06-19 04:17:35 +08:00
Lionell Loh Jian An
b2cccfcf68
Apply suggestions from code review
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-06-19 04:00:08 +08:00
Lionell Loh Jian An
a0b0c77ee8
audit license: use present instead of blank
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-06-19 03:58:34 +08:00