15379 Commits

Author SHA1 Message Date
Mike McQuaid
38ce994007 Deprecate more requirements.
These are ones that were either already deprecated due to audit rules
or are just a simple `which` with a `default_formula` so should just
be a dependency.
2017-12-23 16:53:25 +00:00
Mike McQuaid
5b178c2892 dependency_collector: cleanup optional system deps 2017-12-23 16:36:33 +00:00
ilovezfs
b40484e87c
Revert "Revert "shims/scm/git: Fix the search for brewed git"" 2017-12-23 03:37:27 -08:00
ilovezfs
0dabb464dd
Revert "shims/scm/git: Fix the search for brewed git" 2017-12-21 15:03:40 -08:00
Mike McQuaid
bd471d6b9b
Merge pull request #3589 from sjackman/shims-scm
shims/scm/git: Fix the search for brewed git
2017-12-21 17:49:18 +00:00
Mike McQuaid
75d032129a
Merge pull request #3592 from sjackman/development-tools-installed
DevelopmentTools.installed?: Use locate
2017-12-21 10:24:35 +00:00
Shaun Jackman
4474ef47f9 DevelopmentTools.installed?: Use locate
Use locate rather than which to search for clang or gcc.
locate searches both $HOMEBREW_PREFIX/bin and /usr/bin.
2017-12-20 22:33:46 -08:00
Shaun Jackman
5c7d2d0bb5 shims/scm/git: Fix the search for brewed git
Search for brewed git in both locations:
$HOMEBREW_PREFIX/Homebrew/Library/Homebrew/shims/scm/../../../../../bin/git
$HOMEBREW_PREFIX/Library/Homebrew/shims/scm/../../../../bin/git
2017-12-20 16:24:22 -08:00
Shaun Jackman
cf27117c46 brew.sh: Use shims/scm/git for HOMEBREW_VERSION
Move the use of git to determine HOMEBREW_VERSION below the
definition of the function git.
2017-12-20 16:16:01 -08:00
Ivars Berzinsh
28a0e445f0 Added info about no_proxy to docs 2017-12-19 10:59:04 +02:00
Mike McQuaid
b4d43e950f
Merge pull request #3401 from DomT4/vendor_or_na
go: various tweaks to recommendations
2017-12-16 13:34:22 +00:00
Vítor Galvão
deb37497e9
Merge pull request #3564 from commitay/revert-https-audit
Partially revert "Add audit check for URL schema"
2017-12-16 12:09:51 +00:00
ilovezfs
806345dfcb
Merge pull request #3581 from MikeMcQuaid/post_install_homebrew_path
post_install: use HOMEBREW_PATH.
2017-12-15 02:29:25 -08:00
Mike McQuaid
65e719db25 post_install: use HOMEBREW_PATH.
Do this instead of appending the `HOMEBREW_PREFIX` as it's more
reliable at finding e.g. keg-only and requirement PATH additions. It's
not ideal as it overrides some environment filtering but the only real
alternative is recreate the entire build environment by shelling out to
`build.rb` in `formula_installer`.
2017-12-15 10:05:43 +00:00
Mike McQuaid
656776d925
Merge pull request #3578 from MikeMcQuaid/tests-no-duplicate-seed-output
tests: don't output seed multiple times.
2017-12-15 09:46:17 +00:00
Mike McQuaid
8ed1425ed7 tests: don't output seed multiple times.
This clutters up the output. Instead, hide it with a RSpec formatter and
generate and output it ourselves.
2017-12-15 09:14:44 +00:00
Mike McQuaid
8410950d14 java_requirement: use popen_read :err option. 2017-12-14 16:44:25 +00:00
Mike McQuaid
cdeb0b1f23 bump-formula-pr: use popen_read :err option. 2017-12-14 16:44:25 +00:00
Mike McQuaid
7a8f61c28c gist-logs: use full path to brew.
This fixes the command with environment filtering enabled.
2017-12-14 16:44:25 +00:00
Mike McQuaid
c912d268f1
Merge pull request #3577 from MikeMcQuaid/python_requirement_tweaks
python_requirement: various tweaks/fixes.
2017-12-14 10:10:06 +00:00
Mike McQuaid
f4e647cbc6 python_requirement: various tweaks/fixes.
- simplify the code by avoiding some unnecessary variables and rename
  functions
- make more stuff private so implementation details don't leak
- make Python 2 binary `python2.7` to handle cases like those in
  https://github.com/Homebrew/homebrew-core/issues/21500
- only set `PYTHONPATH` for system Python; Homebrew's Python doesn't
  need it.
2017-12-14 09:21:26 +00:00
Mike McQuaid
b085da91c3 postinstall: add HOMEBREW_PREFIX/{,s}bin to PATH.
This avoids the need for workarounds such as:
https://github.com/Homebrew/homebrew-core/pull/21688
2017-12-14 09:20:07 +00:00
Mike McQuaid
9a0981e0eb
Merge pull request #3566 from sjackman/path
Do not specify absolute paths to utilities
2017-12-13 08:56:31 +00:00
Mike McQuaid
4b849dacd2
Merge pull request #3573 from DomT4/python_dead_code
python: remove package_available? logic
2017-12-13 08:50:05 +00:00
Dominyk Tiller
5a018f8650
python: remove package_available? logic
It was added in https://github.com/Homebrew/legacy-homebrew/pull/37345 for
a use case discussed in https://github.com/Homebrew/legacy-homebrew/pull/37340
that never seems to have actually emerged. I can find no reference of it
ever having been used, despite it existing for 2+ years here.
2017-12-13 06:16:02 +00:00
Dominyk Tiller
d6ebdf1e62
python: handle env filtering on pth check
Since ENV filtering became the default this has been chucking
erroneous warnings from both `brew doctor` and things like `brew install pygobject`
about needing to run:
```
echo 'import site; site.addsitedir("/usr/local/lib/python2.7/site-packages")' >> /Users/xyz/Library/Python/2.7/lib/python/site-packages/homebrew.pth
```
even though I had Homebrew's `python` installed.
2017-12-13 06:09:37 +00:00
Shaun Jackman
ce85e3b3b5 Remove with_system_path
The method with_system_path is no longer needed,
since environment filtering uses a default PATH.
2017-12-12 09:27:06 -08:00
Shaun Jackman
a4033c7196 Do not specify absolute paths to utilities
Specifying an absolute path to utilities is no longer needed,
since environment filtering uses a default PATH.
2017-12-12 09:25:16 -08:00
commitay
8a63356aed Partially revert "Add audit check for URL schema" 2017-12-12 08:22:23 +10:00
Markus Reiter
3c988c0403 Fix messed up parenthesis. 2017-12-11 23:01:37 +01:00
Mike McQuaid
f42d8acde3
Merge pull request #3559 from MikeMcQuaid/git-describe-1.4.0
brew.sh: latest HOMEBREW_VERSION is 1.4.0
2017-12-11 17:14:42 +00:00
Mike McQuaid
67a6c51606 brew.sh: latest HOMEBREW_VERSION is 1.4.0 2017-12-11 16:43:11 +00:00
Mike McQuaid
5f471ee289 doctor: tell people not to file issues.
This stuff doesn't matter.
2017-12-11 15:27:18 +00:00
Mike McQuaid
236e884511
Merge pull request #3553 from MikeMcQuaid/bump-formula-pr-messages
bump-formula-pr: improve error messages.
2017-12-11 09:44:43 +00:00
Dominyk Tiller
55d9750056
caveats: fix fish caveats under env filtering 2017-12-11 09:16:39 +00:00
Mike McQuaid
1babfb679d bump-formula-pr: improve error messages.
- Be clearer about how URLs/tags/revisions/versions are specified in
  error messages.
- Give a better error message if `hub` isn't configured.
2017-12-11 09:02:41 +00:00
Mike McQuaid
7411da36e5
Merge pull request #3551 from laurent22/master
Mentions how hub needs to be configured
2017-12-11 09:01:59 +00:00
Dominyk Tiller
d70a406fe7
caveats: fix PKG_CONFIG_PATH nudge under env filtering 2017-12-11 06:26:56 +00:00
Mike McQuaid
837ea74f44
Merge pull request #3543 from MikeMcQuaid/remove-env-unsets
Remove some unset/checked environment checks
2017-12-10 17:46:29 +00:00
Mike McQuaid
7466b23d8a
Merge pull request #3529 from MikeMcQuaid/env-filtering-default
Default environment filtering to on for all users.
2017-12-10 17:46:19 +00:00
Mike McQuaid
b41eb9d306
Merge pull request #3510 from MikeMcQuaid/remove-bottle-hooks
hooks/bottles: remove bottle hooks.
2017-12-10 17:46:10 +00:00
Mike McQuaid
46775f556f
Merge pull request #3542 from MikeMcQuaid/xcode-9.2
Xcode 9.2
2017-12-10 17:45:51 +00:00
Laurent Cozic
fd8262ef7d
Mentions how hub needs to be configured
This is to address issue #3531
2017-12-10 11:08:15 +00:00
Mike McQuaid
3c6b1daf2b Revert "formula_installer: tweak dependent requirements."
This reverts commit cc752e97f6dcfb3e58c9e753262926672edeb571.

Fixes #1585.

I will open a new issue for the actual underlying bug here (that
requirements aren't being handled correctly based on the stable/devel
spec used at installation time).
2017-12-09 14:23:34 +00:00
ilovezfs
e57da601d7
Merge pull request #3548 from sjackman/x11
X11Requirement: Inherit from generic class [macOS]
2017-12-08 13:35:17 -08:00
Mike McQuaid
69ab17fc35
Merge pull request #3547 from MikeMcQuaid/force-vendor-ruby-clarify
brew.1: clarify Homebrew's Ruby isn't 2.0 now.
2017-12-08 21:01:45 +00:00
Mike McQuaid
e72fde418b
Merge pull request #3546 from MikeMcQuaid/formula_assertions_ruby_23
formula_assertions: remove Ruby 2.0 compatibility.
2017-12-08 21:01:32 +00:00
Shaun Jackman
020c1adebd X11Requirement: Inherit from generic class [macOS]
Fix the warning: already initialized constant X11Requirement
2017-12-08 10:38:58 -08:00
Mike McQuaid
4eeeb5eac4 brew.1: clarify Homebrew's Ruby isn't 2.0 now.
Make this generic; it doesn't matter what version this is and this will
future proof it.
2017-12-08 16:49:33 +00:00
Mike McQuaid
4fa16c9428 formula_assertions: remove Ruby 2.0 compatibility.
We only support Ruby 2.3, now.
2017-12-08 16:45:41 +00:00