14421 Commits

Author SHA1 Message Date
Markus Reiter
37f3a603ce Use env utility instead of with_env. 2018-07-11 16:46:33 +02:00
Markus Reiter
ae38c5d6d1 Fix SystemCommand PATH. 2018-07-11 15:58:38 +02:00
Markus Reiter
1f5311888e Add failing spec for SystemCommand. 2018-07-11 15:58:38 +02:00
Markus Reiter
4e49e8de0d Fix SystemCommand :path. 2018-07-11 15:58:38 +02:00
Mike McQuaid
2e9d843bb7
Merge pull request #4450 from MikeMcQuaid/no-really-no-beta-support
diagnostic: be clearer about what we support.
2018-07-11 14:48:37 +01:00
Mike McQuaid
33dd2a7e03 diagnostic: be clearer about what we support.
And be even more explicit whose problem it is when things are broken.
2018-07-11 14:12:38 +01:00
Mike McQuaid
c7f3ed46e9
Merge pull request #4449 from MikeMcQuaid/bintray-fallback
global: handle HOMEBREW_BOTTLE_DOMAIN fallback.
2018-07-11 11:44:55 +01:00
Markus Reiter
c51189ae0e
Merge pull request #4363 from reitermarkus/external-cask-commands
Simplify and fix external `brew cask` command detection.
2018-07-11 11:26:40 +02:00
Markus Reiter
98bb073b46
Merge pull request #4265 from claui/fix-pkg-environment
Fix PKG installer environment
2018-07-11 08:25:19 +02:00
Mike McQuaid
f080ebebbb global: handle HOMEBREW_BOTTLE_DOMAIN fallback.
If users have auto-updated then these variables may not be set.
2018-07-10 21:58:20 +01:00
ilovezfs
0aab25bdb3
Merge pull request #4406 from commitay/python-3.7
language/python, docs: updates for python 3.7
2018-07-10 10:10:25 +01:00
ilovezfs
24d7f41258
Merge pull request #4446 from MikeMcQuaid/tab-handle-json-parser-error
tab: if parsing JSON fails output the filename.
2018-07-10 10:08:29 +01:00
ilovezfs
3d3c462bff
tab_spec: fix typo 2018-07-10 08:55:50 +00:00
Mike McQuaid
7cc970fea2 link: refactor, reorder and fix bugs.
The change in #4441 broke the handling of the `elsif`s due to the
change in logic. As every block here has a `next` there's no need to do
an `elsif` in here at all. Additionally, reorder the conditions in here
so you get an appropriate message depending on what you're trying to do.
Finally, tweak some of the messaging to remove things that are ignored
and tell people correct commands to run to link things.
2018-07-10 09:32:42 +01:00
Mike McQuaid
d49566ba06 tab: if parsing JSON fails output the filename.
This should make it easier to debug and resolve things like #4439.
2018-07-10 09:29:26 +01:00
ilovezfs
461b61abac link: fix undefined dep_f 2018-07-09 21:23:25 -07:00
Markus Reiter
4ddb1123d7
Merge pull request #4426 from reitermarkus/refactor-system-command-plist
Simplify `Hbc::SystemCommand::Result#plist`.
2018-07-09 18:30:32 +02:00
Mike McQuaid
2f181b3f41 link: stop unneeded force linking on Mojave/CLT 10.
People are getting in the habit of force-linking things like `zlib` to
fix linking/include issues on Mojave (which doesn't install headers to
`/usr/include` by default). This way lies madness so encourage people to
instead pass the correct compiler flags instead.
2018-07-09 16:09:00 +01:00
commitay
2c5f56d77d audit: ensure bottle is defined 2018-07-08 09:22:58 +10:00
Mike McQuaid
b350fe01df
Merge pull request #4398 from afnanenayet/update-compiler-docs
Update manpage with information about alternative compilers
2018-07-07 13:45:21 +01:00
Mike McQuaid
47b888b80d
Merge pull request #4435 from mistydemeo/fix_mojave_header_package_id
CLT: correct header package bundle ID
2018-07-07 13:44:23 +01:00
Afnan Enayet
84b03c5a50
Merge branch 'master' of github.com:Homebrew/brew into update-compiler-docs 2018-07-06 23:45:37 -04:00
Afnan Enayet
133c3a3c0b
Fix typo
* change `MacOS` -> `macOS`
* regenerate manpages
2018-07-06 23:06:41 -04:00
Misty De Meo
de9d462b76 CLT: correct header package bundle ID 2018-07-06 15:18:35 -07:00
Markus Reiter
fcf8cb24fd Remove unused incremental_hash method. 2018-07-06 23:14:34 +02:00
Markus Reiter
e7f950750e Simplify and fix external brew cask command detection. 2018-07-06 22:04:26 +02:00
Claudia
3dbb735f3c
Fix PKG installer environment
This commit solves an issue where the environment handed to
`/usr/sbin/installer` is not the same as the environment used by the
graphical PKG installer.

This is evident in some post-install scripts, e. g. the
`component-10.pkg/Scripts/postinstall` script in the `dymo-label`
cask. The code says:

```
USER_ID=`id -u ${USER}`

launchctl bootstrap gui/$USER_ID /Library/LaunchAgents/com.dymo.dls.webservice.plist
```

The graphical installer will export e. g. `USER=alice`, and
everything works as intended.

However, `brew cask install` does not override `sudo`’s default,
which is `USER=ROOT`. This violates the assumptions in the script.

This commit fixes the issue by configuring `sudo` to override the
following environment variables with the proper user name:

- `LOGNAME`
- `USER`
- `USERNAME`
2018-07-06 09:38:00 +02:00
Mike McQuaid
4840b688e0
Merge pull request #4429 from MikeMcQuaid/linkage-optional-deps
linkage: fix output of optional dependencies.
2018-07-06 08:12:03 +01:00
Afnan Enayet
9579fadad4
Strip trailing whitespaces
This fixes the rubocop offences, which was blocking Travis
2018-07-05 21:33:29 -04:00
Afnan Enayet
72735aef17
Update documentation and generate manpage
* update references in `--cc` flag, using modern gcc examples
* note that issues should not be filed if `--cc` flag is used
* remove reference to `HOMEBREW_CC` as it should not be exposed to users
* generate manpages using `brew man` with these changes
2018-07-05 17:25:19 -04:00
Afnan Enayet
fd84bcbff7
Merge branch 'master' of github.com:Homebrew/brew into update-compiler-docs 2018-07-05 17:23:09 -04:00
Mike McQuaid
9fff177844
Merge pull request #4430 from MikeMcQuaid/handle-build-dep-reqs
formula_installer: correctly handle build dep reqs.
2018-07-05 21:35:38 +01:00
Mike McQuaid
d9f90deb7c download_strategy: use tar xf.
The flags and separate `-` aren't required on 10.5 which is the oldest
version of macOS we support (and it looks nicer this way).
2018-07-05 20:58:35 +01:00
Mike McQuaid
139fef8e74 formula_installer: correctly handle build dep reqs.
When a build dependency has a requirement it should be ignored when
checking for valid requirements. This requires calculating the
dependencies for a formula again and checking them when calculating
which requirements should be pruned.
2018-07-05 20:51:44 +01:00
Mike McQuaid
adcef59bd9
Merge pull request #4428 from MikeMcQuaid/llvm-clang-cxx11
extend/ENV: support CX11 for LLVM Clang.
2018-07-05 20:31:26 +01:00
Mike McQuaid
f5fbb74aaf linkage: fix output of optional dependencies.
Check the runtime dependencies from the tab when outputting the
`brew linkage` declared vs. undeclared dependencies.
2018-07-05 20:29:19 +01:00
Mike McQuaid
14364bbaee extend/ENV: support CX11 for LLVM Clang.
Fix some checks for `:clang` which should match for either `:clang` or
`:llvm_clang`. Note that's not every check.
2018-07-05 20:15:57 +01:00
Markus Reiter
59b3c76ee6 Remove unneeded quiet_safe_system usage. 2018-07-05 11:54:33 +02:00
Markus Reiter
f8b8186fa7 Reorder downloader.cached_location assignment. 2018-07-05 11:54:32 +02:00
Markus Reiter
5e3bc85527 Remove unnecessary Pathname check. 2018-07-05 11:54:32 +02:00
Markus Reiter
e07eddc391 Simplify Hbc::SystemCommand::Result#plist. 2018-07-05 10:54:35 +02:00
Mike McQuaid
9530af4b57
Merge pull request #4422 from commitay/bottle-cop
bottle_block_cop: remove
2018-07-05 08:44:18 +01:00
Markus Reiter
abd855bdad Refactor staging step for download strategies. 2018-07-05 02:40:49 +02:00
commitay
e3ec061a3a language/python: python 3.7 2018-07-05 10:16:04 +10:00
alexbostock
296dd5ecb2 Fix format of cask JSON output 2018-07-04 15:08:32 +01:00
alexbostock
7e5addfb22 Add version number to cask JSON option
`$ brew cask info --json=v1 <formula>` instead of `$ brew cask info --json <formula>`
2018-07-04 15:03:31 +01:00
commitay
44873fd4c8 bottle_block_cop: remove 2018-07-04 21:25:43 +10:00
Mike McQuaid
0c38ceb6f6
Merge pull request #4411 from commitay/versioned-no-head-spec
audit: disallow unstable specs for versioned formulae
2018-07-04 09:49:49 +01:00
Mike McQuaid
08cbbfab3e
Merge pull request #4418 from reitermarkus/vcs-strategies
Refactor and fix VCS download strategies.
2018-07-04 09:44:14 +01:00
ilovezfs
319baa751f
Merge pull request #4421 from MikeMcQuaid/set-homebrew-temp
config: handle HOMEBREW_TEMP being unset.
2018-07-04 07:34:18 +01:00