admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
31,789 Commits 15 Branches 471 Tags
Commit Graph

514 Commits

Author SHA1 Message Date
Mike McQuaid
22d6af1258
Manual brew style fixes. 2022-06-30 08:56:21 +01:00
Mike McQuaid
2d5eab2e1c
brew style --fix 2022-06-30 08:56:21 +01:00
danielbayley
7d145f5798 Fix Rubocop trailing / bug 2022-04-27 18:42:11 +01:00
Bo Anderson
1c73e25627
uses_from_macos: allow libxcrypt 2022-04-27 15:08:43 +01:00
Issy Long
f8d9a5c2db
rubocops/urls: In regexps, only allow valid hostname characters 
> This regular expression has an unrestricted wildcard '.*' which may cause 'googlecode\.com/files' to be matched anywhere in the URL, outside the hostname.
 2022-04-15 16:45:41 +01:00
Issy Long
aa36b343ca
rubocops/urls: Escape .s in hostnames in regexps 2022-04-15 16:45:25 +01:00
Issy Long
ffe0c18b2a
rubocops/homepage: Escape .s in hostnames in regexps 2022-04-15 15:46:36 +01:00
Bo Anderson
212a9efaf5
rubocops/uses_from_macos: allow keg only berkeley-db 2022-03-30 14:24:10 +01:00
Mike McQuaid
03f7b254e9
rubocops: fix OnOs block checks. 
This wasn't correctly flagging the use of `on_os` in `test do` as
invalid.
 2022-03-29 19:15:03 +01:00
Carlo Cabrera
f05e57f414
Merge pull request #12823 from carlocab/setuptools-audit 
rubocops/text: remove `setuptools` audit
 2022-02-01 16:57:57 +08:00
Mike McQuaid
1486a1ed2a
Merge pull request #12822 from rickmark/master 
Fix for GitHub url ends with ‘.git’ check
 2022-02-01 08:37:57 +00:00
Carlo Cabrera
bc67c05528
rubocops/text: remove setuptools audit 
This currently no longer applies, because we might sometimes need an
older `setuptools` than the one shipped with a Python formula.

This is needed for Homebrew/homebrew-core#93964.
 2022-02-01 15:26:50 +08:00
Rick Mark
dd7a33649f
Update homepage.rb 2022-02-01 00:03:48 -07:00
Roland Crosby
d8df9c2ee9 Allow cargo build --lib 
When building Rust packages that provide libraries but no executable
binaries, `cargo install` doesn't do anything; you need to use `cargo
build` and install any libraries manually. See e.g.
rust-lang/cargo#8294.

Unfortunately, Homebrew's Rubocop "use cargo install *std_cargo_args"
rule, as currently written, blocks all invocations of `cargo build`.
This commit changes that rule to exclude invocations of `cargo build`
that use the `--lib` argument (`--lib` specifies to Cargo that a
package's library targets should be built). This will enable library
packages to be built while retaining the "use cargo install
*std_cargo_args" message for the more common case when a Rust package
provides executable binaries.
 2022-01-31 21:11:22 -05:00
Bevan Kay
8c82ec964f
Update Library/Homebrew/rubocops/cask/url_legacy_comma_separators.rb 
Co-authored-by: Issy Long <issyl0@github.com>
 2022-01-12 10:40:22 +11:00
Bevan Kay
d371547d5a
fix tests 2022-01-12 10:39:38 +11:00
Bevan Kay
7e24930e4e
Update Library/Homebrew/rubocops/cask/url_legacy_comma_separators.rb 
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
 2022-01-11 01:22:22 +11:00
Bevan Kay
22d68fb99b
fix style offences 2022-01-10 21:34:51 +11:00
Bevan Kay
cc2b99c8cf
Add check for url :block 2022-01-10 21:27:20 +11:00
Bevan Kay
d5448ff54a
rubocops (cask/url): add rubocop to use csv instead of before_comma and after_comma in cask 2021-12-31 11:08:47 +11:00
Bo Anderson
9b100cf1cc
rubocops/uses_from_macos: remove gcore 
gcore has been removed from homebrew-core.
 2021-12-13 22:27:06 +00:00
Carlo Cabrera
0f26522fad
rubocops/lines: disallow pyoxidizer as a build/runtime dependency 
PyOxidizer downloads pre-built versions of Rust and Python, and embeds
this Python into the binaries it produces.

This goes against a number of our packaging policies, so let's make sure
formulae in Homebrew/core don't do this.

See Homebrew/homebrew-core#90025.
 2021-11-30 17:36:26 +08:00
Carlo Cabrera
1ffbcc04d4
rubocops/lines: allow OS.foo? in service blocks 
These seem more natural, and I don't think we need to be able to mock
service blocks on other OSs.

See Homebrew/homebrew-core#90091.
 2021-11-28 21:47:21 +08:00
Dawid Dziurla
55244c845b
rubocops/text: forbid "go get" only in install method 2021-11-14 14:04:14 +01:00
Bo Anderson
4836ea0ba2
Remove XQuartz handling 2021-11-05 12:40:22 +00:00
Michka Popoff
1cc7ca33c0
update: migrate everyone from linuxbrew-core to homebrew-core 
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
 2021-10-20 11:01:38 +01:00
Bo Anderson
629dbb7c59
rubocops/urls: allow plain HTTP mirrors 2021-10-01 13:42:05 +01:00
Mike McQuaid
41e94afda5
Fix brew style 
Fixes for https://github.com/Homebrew/brew/pull/12152.

Extracted into a separate PR so this can be merged immediately.
 2021-09-30 10:13:53 +01:00
Bo Anderson
3e4cb206bb
rubocops: silence parser warning 2021-09-23 03:45:15 +01:00
Mike McQuaid
56753c9d08
rubocops/lines: be less strict about OS.{mac,linux}? in taps. 
Fixes #12040.
 2021-09-15 12:23:07 +01:00
Mike McQuaid
6992ad0caa
rubocops/uses_from_macos: remove versioned aliases. 
It makes more sense to use the unversioned formulae with `uses_from_macos`
because macOS isn't shipping multiple versions of this.

If you wish to e.g. pin to a specific version you can do that by specifying the
dependency directly in an `os_linux` block.
 2021-09-14 11:01:42 +01:00
Bo Anderson
861dea9ada
Bump various type strictnesses 2021-09-11 01:00:23 +01:00
Mike McQuaid
365e554f67
Revert "rubocops: allow uses_from_macos openssl@3" 2021-09-09 09:16:59 +01:00
Mike McQuaid
ebc4cce456
rubocops/lines: add some OS cop comments/exceptions. 
Exclude and comment the cases the autocorrect currently doesn't work.

Follow-up from #11955.
 2021-09-08 13:46:01 +01:00
Mike McQuaid
a6e4e195c1
rubocops/lines: recommend on_os/OS.os? based on context. 
Recommend the use of `on_macos` and `on_linux` unless we're in
`def install`, `def post_install` or `test do` in which case recommend
`OS.mac?` and `OS.linux?` instead.
 2021-09-08 13:18:07 +01:00
Jonathan Chang
b463ad0124
rubocops: allow uses_from_macos openssl@3 2021-09-07 11:20:55 -07:00
Mike McQuaid
227a96fd7f
rubocops/lines: remove OS.mac?/OS.linux? check. 
This will be reimplemented in https://github.com/Homebrew/brew/pull/11955
but this allows us to merge the homebrew-core changes before that PR is
merged.

Closes https://github.com/Homebrew/brew/pull/11946
 2021-09-02 13:50:23 +01:00
Sam Ford
ddde0f7589
livecheck: allow inheriting from a formula/cask 2021-08-02 09:12:22 -04:00
Nanda H Krishna
5ccfbcd1d2
Autocorrect style issues with brew style --fix 2021-07-08 12:36:39 +05:30
Dawid Dziurla
d50bd605b8
components_order: allow ignore_missing_libraries in on_os 2021-07-04 18:34:03 +02:00
Carlo Cabrera
92d224f0fc
rubocops/lines: check allowlist for use of ENV.runtime_cpu_detection 
This is implements the first audit discussed in #11608.
 2021-07-01 18:38:54 +01:00
Michael Cho
b44ecaceb7
docs: fix cask doc urls to use docs.brew.sh 2021-06-25 13:20:40 -07:00
Bo Anderson
a06d136d2c
Move Sorbet gems into an optional group 2021-06-11 08:10:30 +01:00
Alexander Bayandin
909a7aea9e
rubocops: allow uses_from_macos "git" 2021-06-08 13:03:25 +01:00
danielnachun
5af7521ab8
components_order: allow keg_only in on_macos/on_linux blocks 2021-05-30 19:03:04 -07:00
Mike McQuaid
321c165bd3
Merge pull request #11350 from Gcenx/audit-fix-xcode-build-check 
audit: Remove SYMROOT
 2021-05-13 13:50:40 +01:00
Dean M Greer
ceeb5ea9ec audit: Remove SYMROOT 
SYMROOT is only a valid argument when -project is used.

xcodebuild has other uses than building Xcode projects.
 2021-05-13 08:07:06 -04:00
Bo Anderson
e5285b5ed8
Add cop for IO.read usage 2021-05-12 13:07:24 +01:00
Bo Anderson
6e2f194e09
rubocops/shell_commands: add cop for shell metacharacters in exec 2021-05-10 16:30:00 +01:00
Carlo Cabrera
0214196b4f
rubocops/uses_from_macos: remove openlibm 
This is not provided by macOS. See

    https://github.com/Homebrew/homebrew-core/pull/76528
 2021-05-03 20:40:39 +01:00