35314 Commits

Author SHA1 Message Date
Mike McQuaid
97d7a5c9b4
Merge pull request #15137 from Homebrew/dependabot/bundler/Library/Homebrew/parser-3.2.2.0
build(deps): bump parser from 3.2.1.1 to 3.2.2.0 in /Library/Homebrew
2023-04-04 18:46:11 +01:00
Issy Long
8adaada399
Merge pull request #15149 from issyl0/more-noisy-on-unknown-cask-methods 2023-04-04 17:54:30 +01:00
Issy Long
53a17b921f
Make --display-failures-only help hidden as it's deprecated
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2023-04-04 17:17:19 +01:00
Issy Long
7cfa544aec
cask/utils: Make more noise when encountering undefined methods
- https://github.com/Homebrew/homebrew-cask/actions/runs/4608585102/jobs/8144571098
  introduced syntax errors for the `mattermost` cask (`autoupdates`
  instead of `auto_updates`), but CI didn't fail so we didn't notice
  until it shipped to users and broke `brew update`.
2023-04-04 17:08:54 +01:00
Mike McQuaid
41e7ee7b51
Merge pull request #15125 from issyl0/rubocops-cask-verified-url-with-path-ending-slash
rubocops/cask: Ensure that "verified" URLs with paths end with "/"
2023-04-04 16:30:09 +01:00
Issy Long
7bb20a3b83
Skip if the URL stanza has only two path components
https://github.com/Homebrew/homebrew-cask-fonts/pull/7336#discussion_r1156325651
2023-04-04 16:11:44 +01:00
Ruoyu Zhong
5c9e073cd5
commands: fix completion descriptions for shell commands too
This was missed in #15146.

Signed-off-by: Ruoyu Zhong <zhongruoyu@outlook.com>
2023-04-04 23:04:13 +08:00
Ruoyu Zhong
4305443c9c
commands: explain change in command description splitting
A comment here would help the reader to understand the need for this
splitting logic, which is not so straightforward.

Addresses review comment in
https://github.com/Homebrew/brew/pull/15146#discussion_r1157361656.

Signed-off-by: Ruoyu Zhong <zhongruoyu@outlook.com>
2023-04-04 22:50:40 +08:00
Mike McQuaid
0048a86673
Merge pull request #15135 from Homebrew/dependabot/bundler/Library/Homebrew/addressable-2.8.2
build(deps): bump addressable from 2.8.1 to 2.8.2 in /Library/Homebrew
2023-04-04 15:37:46 +01:00
Carlo Cabrera
845506ba02
Merge pull request #15146 from ZhongRuoyu/completions-short-desc 2023-04-04 20:29:16 +08:00
Ruoyu Zhong
68b63427c6
commands: fix completion descriptions
Currently, zsh and fish shell completions show incomplete descriptions
for certain commands. For example:

    docs                         -- Open Homebrew's online documentation (https://docs
    rbenv-sync                   -- Create symlinks for Homebrew's installed Ruby versions in ~/

This is because `Commands.command_description` produces incomplete
short descriptions for the commands having a dot (from a URL or a path)
in the first sentence; the dot is misinterpreted as a full stop:

    brew(main):001:0> Commands.command_description("docs", short: true)
    => "Open Homebrew's online documentation (https://docs"
    brew(main):002:0> Commands.command_description("rbenv-sync", short: true)
    => "Create symlinks for Homebrew's installed Ruby versions in ~/"

We can improve the sentence splitting logic by only splitting at dots
either at the end or followed by a whitespace. Now With this change:

    brew(main):001:0> Commands.command_description("docs", short: true)
    => "Open Homebrew's online documentation (https://docs.brew.sh) in a browser"
    brew(main):002:0> Commands.command_description("rbenv-sync", short: true)
    => "Create symlinks for Homebrew's installed Ruby versions in ~/.rbenv/versions"

Signed-off-by: Ruoyu Zhong <zhongruoyu@outlook.com>
2023-04-04 18:39:13 +08:00
BrewTestBot
9217c90bbb
Update RBI files for addressable.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2023-04-04 09:32:44 +00:00
BrewTestBot
1c425c1e6f
brew vendor-gems: commit updates. 2023-04-04 09:25:57 +00:00
BrewTestBot
16e17d63be
Update RBI files for parser.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2023-04-04 09:21:14 +00:00
dependabot[bot]
19c122955c
build(deps): bump addressable from 2.8.1 to 2.8.2 in /Library/Homebrew
Bumps [addressable](https://github.com/sporkmonger/addressable) from 2.8.1 to 2.8.2.
- [Release notes](https://github.com/sporkmonger/addressable/releases)
- [Changelog](https://github.com/sporkmonger/addressable/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sporkmonger/addressable/compare/addressable-2.8.1...addressable-2.8.2)

---
updated-dependencies:
- dependency-name: addressable
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-04-04 09:19:15 +00:00
BrewTestBot
91226a3131
brew vendor-gems: commit updates. 2023-04-04 09:15:32 +00:00
dependabot[bot]
0640dbbe09
build(deps): bump parser from 3.2.1.1 to 3.2.2.0 in /Library/Homebrew
Bumps [parser](https://github.com/whitequark/parser) from 3.2.1.1 to 3.2.2.0.
- [Release notes](https://github.com/whitequark/parser/releases)
- [Changelog](https://github.com/whitequark/parser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/whitequark/parser/compare/v3.2.1.1...v3.2.2.0)

---
updated-dependencies:
- dependency-name: parser
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-04-04 09:11:40 +00:00
Mike McQuaid
7dbe1b4877
Merge pull request #15142 from Homebrew/revert-15112-prof-group
Revert "Split prof gems into their own group"
2023-04-04 10:07:02 +01:00
Mike McQuaid
573b99bd7f
Revert "Include prof gem group in sorbet workflow" 2023-04-04 09:03:39 +01:00
Mike McQuaid
7b336ed8cd
Revert "Split prof gems into their own group" 2023-04-04 08:49:27 +01:00
Mike McQuaid
ae8fc16031
Merge pull request #15134 from dduugg/sorbet-workflow
Include prof gem group in sorbet workflow
2023-04-04 08:41:08 +01:00
Markus Reiter
2222ac628e
Merge pull request #15129 from reitermarkus/livecheck-screensavers
Include screen savers in `:extract_plist` strategy.
2023-04-04 09:39:52 +02:00
Mike McQuaid
81477257ca
Merge pull request #15139 from dduugg/t-unsafe-cleanup
Remove useless T.unsafe wrappers
2023-04-04 08:37:36 +01:00
Markus Reiter
e57143542a
Consider dictionary stanzas in livechecks. 2023-04-04 05:06:58 +02:00
Douglas Eichelberger
79f6c7c7da brew style --fix 2023-04-03 17:35:47 -07:00
Douglas Eichelberger
f3a8241e69 Remove useless T.unsafe wrappers 2023-04-03 17:34:39 -07:00
Markus Reiter
cf3054526a
Use select instead of flat_map. 2023-04-03 20:47:15 +02:00
Douglas Eichelberger
c7db55d01b Include prof gem group in sorbet workflow 2023-04-03 11:43:24 -07:00
Mike McQuaid
a88397096d
Merge pull request #15121 from singingwolfboy/pip-no-build-isolation
Python: allow --no-build-isolation for pip install
2023-04-03 13:14:19 +01:00
Mike McQuaid
6fef708b17
Merge pull request #15120 from apainintheneck/handle-service-run-cmd-string
service: handle string run cmd
2023-04-03 13:02:54 +01:00
Mike McQuaid
7b4c09f41f
Merge pull request #15124 from dduugg/enable-types
Enable types in extensions, etc.
2023-04-03 12:42:21 +01:00
Mike McQuaid
aa894fbfcd
Merge pull request #15127 from issyl0/tap-workflows-bump-actions-cache-version
dev-cmd/tap-new: Use `actions/cache@v3` as v1 is very deprecated
2023-04-03 08:47:16 +01:00
Mike McQuaid
b10ba24c80
Merge pull request #15123 from carlocab/only_dependencies_earlier
install: check for `--only-dependencies` flag earlier
2023-04-03 08:44:38 +01:00
Mike McQuaid
85a1b79154
service: fix typo. 2023-04-03 08:41:21 +01:00
Mike McQuaid
830ec2847b
Merge pull request #15114 from dduugg/ignorable-type
Enable typing in Ignorable
2023-04-03 08:37:34 +01:00
Markus Reiter
6e5ab67838
Consider version of .apps containing installers. 2023-04-03 04:56:37 +02:00
Markus Reiter
cf7a9df923
Include screen savers in :extract_plist strategy. 2023-04-03 03:56:04 +02:00
Douglas Eichelberger
bc588cc04f Fix tests 2023-04-02 16:38:30 -07:00
Issy Long
28f8cbe8da
Handle when the URL has interpolation: use source not str_content
- We see this a lot in real Casks.
2023-04-02 23:39:43 +01:00
Issy Long
41c35986f8
Simplify the 'should not start with https?://' message wording
Co-authored-by: Markus Reiter <me@reitermark.us>
2023-04-02 22:43:57 +01:00
Issy Long
21da074346
Only 'verified' stanzas with 0 or >1 path components should end with "/"
Handle good things like:

```ruby
url "https://example.org/download",
    verified: "example.org/download" # This is fine.
```

And bad things like:

```ruby
url "https://example.org/",
    verified: "example.org" # This should end with a slash.
```
2023-04-02 22:26:23 +01:00
Douglas Eichelberger
4df5a80c73 brew style --fix 2023-04-02 12:25:55 -07:00
Douglas Eichelberger
0079cefc95 Enable types in remaining untyped extensions 2023-04-02 12:24:11 -07:00
Issy Long
17c0eaab25
Fix indentation of verified in url stanza examples 2023-04-02 16:41:29 +01:00
Issy Long
09ce7a1da6
dev-cmd/tap-new: Use actions/cache@v3 as v1 is very deprecated
- We forgot about this workflow when we bumped the versions of our
  actual workflows as part of issue 14692.
2023-04-02 15:43:24 +01:00
Issy Long
b586d97f84
rubocops/cask: Ensure that "verified" URLs with paths end with "/"
- These were being fixed manually[1], so let's make a RuboCop for any
  further occurrences since this is a good rule to enforce[2].

[1] - https://github.com/Homebrew/homebrew-cask/pull/144179#issuecomment-1489857249
[2] - https://github.com/Homebrew/homebrew-cask/pull/80965#issuecomment-616232313
2023-04-02 15:29:53 +01:00
Douglas Eichelberger
6397229f68 Enable types in extensions, etc. 2023-04-01 18:56:42 -07:00
Carlo Cabrera
6c3361e80f
install: check for --only-dependencies flag earlier
Currently, doing `brew install --only-dependencies` with an unlinked
formula does nothing and returns a message saying the formula is already
installed but just not linked.

I think that we should just install the dependencies as requested here
instead of complaining that the formula isn't linked.

Before:

    ❯ brew unlink adplug
    Unlinking /usr/local/Cellar/adplug/2.3.3... 8 symlinks removed.
    ❯ brew install --only-dependencies adplug
    Warning: adplug 2.3.3 is already installed, it's just not linked.
    To link this version, run:
      brew link adplug

After:

    ❯ brew install --only-dependencies adplug
    ==> Fetching dependencies for adplug: libbinio
    ==> Fetching libbinio
    ==> Downloading https://ghcr.io/v2/homebrew/core/libbinio/manifests/1.5
    [snip]

See Homebrew/homebrew-core#127133 for additional context.
2023-04-02 01:39:23 +08:00
Issy Long
c240cf81a4
tests: Remove --display-failures-only from brew audit cmd 2023-04-01 13:44:26 +01:00
David Baumgold
64ff386744 fix tests 2023-04-01 14:32:27 +02:00