Carlo Cabrera
ab4f14b359
utils/analytics: improve accuracy of GitHub Packages download counts
...
`millions_match.captures.first` will typically be a decimal (since it's
matched using `\d+\.\d+`), except we lose accuracy in the `#to_i`
conversion.
Before:
```
❯ brew info --analytics --github-packages-downloads sqlite
==> Analytics
==> install (30 days)
[snip]
==> GitHub Packages Downloads
1,009,898 (30 days)
```
After:
```
❯ brew info --analytics --github-packages-downloads sqlite
==> Analytics
==> install (30 days)
[snip]
==> GitHub Packages Downloads
1,199,898 (30 days)
```
In this case `1.19M` was being rounded down to `1M`.
2024-08-04 05:33:46 +08:00
Bo Anderson
822c84784c
Merge pull request #17951 from Homebrew/fix-shellenv-csh
...
shellenv: fix `MANPATH` and `INFOPATH` handling for [t]csh
2024-08-03 21:16:16 +01:00
BrewTestBot
70fb86846b
brew vendor-gems: commit updates.
2024-08-03 19:20:22 +00:00
dependabot[bot]
f71e30370b
build(deps-dev): bump sorbet in /Library/Homebrew
...
Bumps [sorbet](https://github.com/sorbet/sorbet ) from 0.5.11504 to 0.5.11505.
- [Release notes](https://github.com/sorbet/sorbet/releases )
- [Commits](https://github.com/sorbet/sorbet/commits )
---
updated-dependencies:
- dependency-name: sorbet
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-08-03 19:18:38 +00:00
Carlo Cabrera
3fec77e72a
shellenv: fix MANPATH
and INFOPATH
handling for [t]csh
...
It turns out that control flow in csh is a pain. But we can rely on
`test`, which is thankfully POSIX.
Closes #17949 .
2024-08-04 02:52:14 +08:00
Bo Anderson
4dcd308398
Merge pull request #17945 from Homebrew/debrew-irb-fix
...
debrew/irb: fix errors under Ruby 3.3
2024-08-03 05:11:14 +01:00
Carlo Cabrera
19f837f9a1
Merge pull request #17946 from Homebrew/upgrade-min-version-fix
2024-08-03 12:08:03 +08:00
Bo Anderson
ccbee57232
Portable Ruby 3.3.4_1
2024-08-03 04:31:52 +01:00
Bo Anderson
993a0aec3a
upgrade: fix missed upgrades when an alias is changed to a formula
2024-08-03 01:49:40 +01:00
Bo Anderson
53a547d446
debrew/irb: fix errors under Ruby 3.3
2024-08-03 01:18:22 +01:00
Rylan Polster
afc8c0fa62
Remove redundant unless
...
Co-authored-by: Bo Anderson <mail@boanderson.me>
2024-08-02 19:20:38 -04:00
Rylan Polster
2dff563641
Run brew typecheck --update
2024-08-02 16:03:49 -04:00
Rylan Polster
6badcd929c
Add sorbet vscode configuration
2024-08-02 16:03:49 -04:00
Mike McQuaid
9f260a4490
Merge pull request #17939 from Homebrew/dependabot/bundler/Library/Homebrew/ruby-lsp-0.17.11
2024-08-02 19:39:26 +01:00
dependabot[bot]
13013d53b3
build(deps-dev): bump ruby-lsp in /Library/Homebrew
...
Bumps [ruby-lsp](https://github.com/Shopify/ruby-lsp ) from 0.17.10 to 0.17.11.
- [Release notes](https://github.com/Shopify/ruby-lsp/releases )
- [Commits](https://github.com/Shopify/ruby-lsp/compare/v0.17.10...v0.17.11 )
---
updated-dependencies:
- dependency-name: ruby-lsp
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-08-02 18:28:52 +00:00
Klaus Hipp
f036c2cc1d
rubocops/shared/url_helper: update url audit
2024-08-02 20:00:10 +02:00
Issy Long
870b3423bc
Merge pull request #17937 from khipp/fix-url-audit
...
rubocops/shared/url_helper: fix url audit
2024-08-02 17:01:06 +01:00
Klaus Hipp
6e1ff402f0
rubocops/shared/url_helper: fix url audit
2024-08-02 17:48:00 +02:00
Rylan Polster
e871e8393b
Merge pull request #17934 from Homebrew/vscode-ruby-lsp
2024-08-02 11:30:43 -04:00
Rylan Polster
9ddde17ea5
Add vscode Ruby LSP config and documentation
2024-08-02 10:44:43 -04:00
Mike McQuaid
357e70357c
sbom: don't store runtime dependencies when bottling.
...
In some cases this prevents `:all` bottles when the recursive
dependencies vary. This SBOM is regenerated correctly at pour time.
2024-08-02 11:42:35 +01:00
Issy Long
7bf7030db8
Add autocorrection for the interpolated bin audit
...
- I got bored doing them manually.
- Also now more people can help with letters of the alphabet using `brew style --only=FormulaAuditStrict/Text --fix homebrew/core`.
2024-08-01 22:41:04 +01:00
Issy Long
0872966c27
Avoid double parentheses for eg. (path/here/).rmtree
corrections
2024-08-01 18:28:01 +01:00
Issy Long
7404735654
rubocops/no_fileutils_rmrf: Fix rmtree
on a method returning Pathname
...
- Tidy up the node matchers. Either `FileUtils.rm_rf` or `rm_rf` on a
`Pathname` instance or `self`.
2024-08-01 18:28:01 +01:00
Issy Long
83e21fba11
rubocop/no_fileutils_rmrf: Handle rmtree
as an instance method
2024-08-01 18:28:00 +01:00
Issy Long
0889df837a
Casks use FileUtils.rm_rf
& Pathname.rmtree
still
2024-08-01 18:28:00 +01:00
Issy Long
99c5cc99b5
rubocop/no_fileutils_rmrf: Scope to just formulae and casks
2024-08-01 18:28:00 +01:00
Issy Long
14dd3592dc
rubocop/no_fileutils_rmrf: Discourage Pathname#rmtree
too
...
- This [seems to be](https://ruby-doc.org/3.3.4/exts/pathname/Pathname.html#method-i-rmtree )
equivalent to `FileUtils#rm_r`, so replace it with that.
2024-08-01 18:28:00 +01:00
Issy Long
cc7784605d
rubocop/no_fileutils_rmrf: Reorganize tests
2024-08-01 18:28:00 +01:00
Issy Long
ebd9d183dc
rubocop/no_fileutils_rmrf: Extend to cover FileUtils#rmtree
too
2024-08-01 18:28:00 +01:00
Issy Long
f4e4808553
rubocop/no_fileutils_rmrf: Extend to cover FileUtils#rm_f
too
2024-08-01 18:28:00 +01:00
Issy Long
e6976ae3d1
rubocop: Discourage the use of FileUtils.rm_rf
...
- This cop checks for the use of `FileUtils.rm_rf` and suggests using
`FileUtils.rm_r` because we should know if we couldn't delete a
thing for some reason, not just force it.
2024-08-01 18:27:59 +01:00
Patrick Linnane
885cfb79df
Merge pull request #17927 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-0.5.11504
2024-08-01 09:11:34 -07:00
BrewTestBot
93aa5b0f41
brew vendor-gems: commit updates.
2024-08-01 15:56:59 +00:00
BrewTestBot
192609d75e
brew vendor-gems: commit updates.
2024-08-01 15:56:56 +00:00
dependabot[bot]
2d76921a13
build(deps-dev): bump rexml from 3.3.2 to 3.3.4 in /Library/Homebrew
...
Bumps [rexml](https://github.com/ruby/rexml ) from 3.3.2 to 3.3.4.
- [Release notes](https://github.com/ruby/rexml/releases )
- [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md )
- [Commits](https://github.com/ruby/rexml/compare/v3.3.2...v3.3.4 )
---
updated-dependencies:
- dependency-name: rexml
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-08-01 15:50:50 +00:00
dependabot[bot]
04a9d31b4d
build(deps-dev): bump sorbet in /Library/Homebrew
...
Bumps [sorbet](https://github.com/sorbet/sorbet ) from 0.5.11501 to 0.5.11504.
- [Release notes](https://github.com/sorbet/sorbet/releases )
- [Commits](https://github.com/sorbet/sorbet/commits )
---
updated-dependencies:
- dependency-name: sorbet
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-08-01 15:50:14 +00:00
BrewTestBot
02e90c53eb
brew vendor-gems: commit updates.
2024-07-31 17:08:33 +00:00
dependabot[bot]
6eb7e58bfd
build(deps-dev): bump sorbet in /Library/Homebrew
...
Bumps [sorbet](https://github.com/sorbet/sorbet ) from 0.5.11500 to 0.5.11501.
- [Release notes](https://github.com/sorbet/sorbet/releases )
- [Commits](https://github.com/sorbet/sorbet/commits )
---
updated-dependencies:
- dependency-name: sorbet
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-07-31 17:06:57 +00:00
Patrick Linnane
1af028f18a
Merge pull request #17920 from Homebrew/tapioca-args-fix
2024-07-31 09:53:41 -07:00
Bo Anderson
05d6c06c84
tapioca/compilers/args: remove non-AbstractCommand handling
2024-07-31 17:30:31 +01:00
William Woodruff
9d313b23eb
sandbox: disallow backslashes in path filter names
...
This should really be an allowlist rather than a denylist,
but for the time being this at least prevents someone from
causing an obtuse sandbox error by naming a file something like
"foo\".
Signed-off-by: William Woodruff <william@yossarian.net>
2024-07-31 12:10:51 -04:00
Mike McQuaid
ca22e9ccfa
Merge pull request #17904 from Homebrew/lock_improvements
2024-07-30 18:02:02 +01:00
Patrick Linnane
c609f24efb
Merge pull request #17908 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-0.5.11500
2024-07-30 09:53:58 -07:00
Patrick Linnane
65725edcdd
Merge pull request #17911 from Homebrew/dependabot/bundler/Library/Homebrew/racc-1.8.1
2024-07-30 09:52:03 -07:00
Mike McQuaid
e3a1a9dccf
Improve locking UX
...
My experience recently playing around with our locking behaviour is
that, while mostly seamless and not seen by users, it's leaks
implementation details a bit too heavily.
As a result, the following improvements are in this commit:
- Ensure that, whenever possible, we tell the user the actual command
that is holding a given lock instead of the lock name (an internal
implementation detail)
- Make the locking error output a little more consistent and user
friendly
- Add a `DownloadLock` class to simplify locking downloads
- Add a `HOMEBREW_LOCK_CONTEXT` variable to allow adding additional
context for logging error messages
- Lock paths and leave deciding how this translates to lock names up
to the locking code itself
- Lock the Cellar/Caskroom paths explicitly rather than implicitly
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
2024-07-30 17:51:02 +01:00
BrewTestBot
88eb68b799
Update RBI files for sorbet.
...
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml ) workflow.
2024-07-30 16:43:10 +00:00
BrewTestBot
14553e367f
brew vendor-gems: commit updates.
2024-07-30 16:42:50 +00:00
dependabot[bot]
2876c6bce2
build(deps-dev): bump sorbet in /Library/Homebrew
...
Bumps [sorbet](https://github.com/sorbet/sorbet ) from 0.5.11495 to 0.5.11500.
- [Release notes](https://github.com/sorbet/sorbet/releases )
- [Commits](https://github.com/sorbet/sorbet/commits )
---
updated-dependencies:
- dependency-name: sorbet
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-07-30 09:41:28 -07:00
BrewTestBot
987481a0e4
brew vendor-gems: commit updates.
2024-07-30 16:40:43 +00:00