Bo Anderson
e49a338896
Implement caching for dependency expansion
2021-03-20 16:56:00 +00:00
nandahkrishna
f422b6cdc4
livecheck/strategy: add ElectronBuilder strategy
2021-03-20 15:23:09 +05:30
Bo Anderson
1b61d5a563
Merge pull request #10873 from Bo98/shell_commands_cop
...
Promote shell commands audit to global cop
2021-03-18 20:34:15 +00:00
Bo Anderson
8e98ce69f3
Stricter handling of CLI args
2021-03-18 16:41:57 +00:00
Bo Anderson
20ff68a425
Fix brew style
.
2021-03-17 20:45:44 +00:00
Bo Anderson
9063945b3e
Promote shell commands audit to global cop
2021-03-17 20:45:41 +00:00
Bo Anderson
98b83064ec
Merge pull request #10871 from Bo98/cask_slash_audit
...
test/cask/audit_spec: add test for slashes in versions
2021-03-17 16:41:47 +00:00
Bo Anderson
a8522c6db6
test/cask/audit_spec: add test for slashes in versions
2021-03-17 14:25:50 +00:00
Nanda H Krishna
53f34af1c5
Merge pull request #10845 from nandahkrishna/fix-completions-zsh
...
completions: fix zsh autocompletion issues
2021-03-17 10:55:19 +05:30
Markus Reiter
1a4874dc62
Simplify package uninstallation.
2021-03-16 03:00:14 +01:00
Bo Anderson
acfe9d24d9
Merge pull request #10815 from Bo98/fi-more-perf
...
formula_installer: further reduce dependency calculations
2021-03-15 18:20:03 +00:00
Bo Anderson
fa8b80747a
test/formula_installer_spec: add tests for cyclic deps
2021-03-15 17:51:09 +00:00
nandahkrishna
0e97793f91
test/completions: modify tests for zsh completions
2021-03-14 01:39:14 +05:30
Cassidy Marble
267040e5df
bugfix: Add args and options to lazy url block
2021-03-12 10:26:59 -07:00
nandahkrishna
e64f2d1fd4
test/exceptions_spec: add test for TapFormulaOrCaskUnavailableError
2021-03-12 01:28:20 +05:30
Adrian Ho
548316ecc8
--prefix: shortlist only formulae
2021-03-11 17:32:35 +08:00
Mike McQuaid
61427d6682
Merge pull request #10770 from SeekingMeaning/unless_logical_operators
...
rubocops: use `Style/UnlessLogicalOperators`
2021-03-05 11:45:42 +00:00
Mike McQuaid
9964a4b0a9
Merge pull request #10777 from nandahkrishna/patches-rubocop-autocorrect
...
rubocops/patches: autocorrect some offenses
2021-03-05 11:45:14 +00:00
Bo Anderson
e1da637f9a
test/hardware/cpu_spec: add missing families
2021-03-04 23:50:35 +00:00
Mike McQuaid
e9419dbce7
test/cmd: test Bash logic.
2021-03-04 12:59:43 +00:00
Mike McQuaid
dc1fdc9f8d
Speedup brew --version
.
...
Port `brew --version` to Bash to speed it up.
While we're here:
- remove (now) unused `Tap` Git methods
- use `--quiet` instead of `-q` to be more verbose
Benchmarks:
```
$ hyperfine --min-runs=3 --warmup=2 "git checkout origin/master; brew --version" "git checkout speedup_brew_version; brew --version"
Benchmark #1 : git checkout origin/master; brew --version
Time (mean ± σ): 2.083 s ± 0.004 s [User: 396.8 ms, System: 597.2 ms]
Range (min … max): 2.080 s … 2.088 s 3 runs
Benchmark #2 : git checkout speedup_brew_version; brew --version
Time (mean ± σ): 847.9 ms ± 35.2 ms [User: 100.0 ms, System: 247.9 ms]
Range (min … max): 824.1 ms … 888.3 ms 3 runs
Summary
'git checkout speedup_brew_version; brew --version' ran
2.46 ± 0.10 times faster than 'git checkout origin/master; brew --version'
```
2021-03-04 12:59:42 +00:00
nandahkrishna
d68452f232
rubocops/patches: autocorrect some offenses
2021-03-04 12:36:18 +05:30
Seeker
7e7274aaeb
rubocops: use Style/UnlessLogicalOperators
...
Replaces `Style/UnlessMultipleConditions`
2021-03-03 01:39:11 -08:00
Bo Anderson
a5b12a33c2
utils/gems: use Gem API rather than ENV to set paths
2021-02-27 16:23:28 +00:00
Bo Anderson
6cd1e5e384
Avoid passing around a massive $LOAD_PATH.
...
Portable Ruby crashes if the $LOAD_PATH gets too big.
2021-02-26 18:23:48 +00:00
hyuraku
178ae750b9
utils/github: set default args to search_code
2021-02-26 21:31:30 +09:00
Mike McQuaid
545c568f52
Merge pull request #10693 from MikeMcQuaid/speedup_brew_prefix
...
Speedup `brew --prefix <formula>`
2021-02-26 10:47:51 +00:00
Bo Anderson
06381deef4
Merge pull request #10686 from Bo98/safe_fork-status
...
utils/fork: handle termsig in safe_fork
2021-02-26 04:25:54 +00:00
Mike McQuaid
ca47b47f77
Speedup brew --prefix <formula>
...
This case is _really_ slow even although it's something we encourage
people to run often and build systems often do. The `brew --prefix`
case is really fast because it's just in Bash so: let's pull the
`brew --prefix <formula>` case into Bash too.
This doesn't handle any edge-cases like `--installed` and the formula
detection is pretty simple.
Also, to make this behaviour consistent, never output `Cellar` paths
from the (Ruby) `brew --prefix`; we never want people relying on the
Cellar paths anyway, only output them if the formula wasn't installed
(where, arguably, using a Cellar path is even worse) and the speedup is
worth this deviation in behaviour.
2021-02-25 17:07:28 +00:00
Bo Anderson
f079373d8c
utils/fork: handle termsig in safe_fork
2021-02-25 13:42:44 +00:00
Shaun Jackman
bd75cfc4e0
Merge pull request #10677 from sjackman/sj/pr-upload
...
pr-upload: Upload bottles to Archive.org
2021-02-23 19:06:44 -08:00
Kenneth Chew
edead95768
utils/spdx: correctly detect non-deprecated licenses with plus
2021-02-23 16:28:24 -05:00
Shaun Jackman
0f2c47dbe3
Add test/archive_spec.rb
2021-02-22 18:07:39 -08:00
Issy Long
e143dfdad6
Merge pull request #10658 from issyl0/rubocop-enable-rspec-context-wording
...
rubocop: Enable RSpec/ContextWording cop & fix offenses
2021-02-23 00:14:02 +00:00
Issy Long
7a0effdf6f
Merge pull request #10659 from issyl0/fix-mismatched-test-descriptions
...
test/rubocops: Fix mismatched test descriptions
2021-02-23 00:13:58 +00:00
Issy Long
8dfaad9ac2
Merge pull request #10665 from issyl0/rubocop-enable-rspec-repeated-example-group-description
...
rubocop: Enable RSpec/RepeatedExampleGroupDescription cop & fix offenses
2021-02-23 00:13:54 +00:00
Issy Long
ead84825a6
test: Fix all RSpec/RepeatedExampleGroupDescription offenses
2021-02-21 14:06:24 +00:00
Issy Long
5793be5b86
test: Change more context
s to describe
s for better sentences
...
- We could have added "to" to the `RSpec/ContextWording` list of valid
`context` prefixes, but switching these to `describe` is less special.
2021-02-21 13:31:26 +00:00
Issy Long
dfebf71e26
test/livecheck/skip_conditions_spec: Even better context
wording
...
Co-authored-by: Nanda H. Krishna <nanda.harishankar@gmail.com>
2021-02-20 13:22:47 +00:00
Issy Long
38a427bf0d
test/option_declaration_spec: Align test description with contents
2021-02-20 00:04:05 +00:00
Issy Long
f194b5e983
test/bottle_format_spec: Align test description with contents
2021-02-20 00:03:47 +00:00
Issy Long
83ead25229
rubocop: Disable RSpec/ContextWording
for shared_context
descs
...
- I couldn't figure out a way to start these with "when", "with" or
"without" given where these are in cop descriptions. Three ignored
things out of 150 problems is a good ratio though.
2021-02-19 23:31:17 +00:00
Issy Long
e1ad07190e
rubocop: Fix RSpec/ContextWording
offenses
...
- For some of these I changed `context` to `describe` as it fit better
rather than contriving a "when", "with" or "without", or massively
restructuring the tests.
2021-02-19 23:30:41 +00:00
Dustin Rodrigues
c8e99e5185
python: stop passing no-user flag on installation
2021-02-19 12:49:10 -05:00
Nanda H Krishna
53d840c969
Merge pull request #10635 from nandahkrishna/bump-cask-support
...
dev-cmd/bump: add cask support
2021-02-18 02:35:34 +05:30
nandahkrishna
f7c8810214
utils/github/api: remove 'api' from method names
2021-02-17 23:47:05 +05:30
nandahkrishna
24bb6040a7
dev-cmd/bump: add cask support
2021-02-17 00:42:07 +05:30
nandahkrishna
56e0c3d9e8
Update GitHub API usage
2021-02-15 22:38:27 +05:30
Rylan Polster
79e93f54e2
Ignore more parser warnings
2021-02-14 11:58:05 -05:00
Mike McQuaid
320bccb38d
Merge pull request #10594 from Bo98/consistent-alignment
...
rubocop: use consistent array/hash indentation
2021-02-12 17:29:15 +00:00