17 Commits

Author SHA1 Message Date
Benjamin Bolton
dce6b77ad0
Modify syntax for readability / consistency
leverage map block and guard clause for readability thx @MikeMcQuaid
2021-09-07 10:10:26 -06:00
Benjamin Bolton
a83877660b
Revert "Accept @Rylan12 chained spacing conventions"
This reverts commit 538a5d9e698763e3dc6eeae46535f032a5ff316e.
2021-09-07 07:24:58 -06:00
Benjamin Bolton
538a5d9e69
Accept @Rylan12 chained spacing conventions
Co-authored-by: Rylan Polster <rslpolster@gmail.com>
2021-09-07 07:16:06 -06:00
Benjamin Bolton
0c6266ee60
Only wrap multi-word arguments, add comment 2021-09-02 09:26:13 -06:00
Benjamin Bolton
1532c081f2
Add space character in map (pacify brew style) 2021-09-01 11:46:57 -06:00
Benjamin Bolton
4acb9cf734
Wrap service command parameters in single quotes
Should resolve issues with multi-word arguments, eg:

> Or, if you don't want/need a background service you can just run:
  /opt/homebrew/opt/nginx/bin/nginx -g daemon off;

fails, but 

> Or, if you don't want/need a background service you can just run:
  '/opt/homebrew/opt/nginx/bin/nginx' '-g' 'daemon off;'

succeeds
2021-09-01 11:40:54 -06:00
Carlo Cabrera
4fb06efe81
Fix TMUX env variable filtering
We currently filter out `TMUX`, but this breaks displaying some caveats.
This also enables an alias I use (and improved by @Rylan12):

    brew alias fzp='!id="$(gh pr list -L200 -R github.com/Homebrew/homebrew-core | TMUX=$HOMEBREW_TMUX fzf-tmux -p "90%,50%" --multi | cut -f1)"; [ -n "$id" ] && brew pr-publish --autosquash $id'
2021-05-13 17:05:18 +01:00
Sean Molenaar
4c67a8ce27
caveats: simplify non-plist return
Co-authored-by: Rylan Polster <rslpolster@gmail.com>
2021-05-04 14:36:00 +02:00
Sean Molenaar
0e27ec707b
Update Library/Homebrew/extend/os/mac/caveats.rb
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2021-05-02 15:25:47 +02:00
Sean Molenaar
3ab21cc412
services: replace plist_options :manual with service command 2021-05-01 16:20:47 +02:00
Markus Reiter
24ae318a3d Move type annotations into files. 2020-10-10 14:59:39 +02:00
Mike McQuaid
3a91c37e66
Fix RuboCop checks. 2020-08-19 17:12:32 +01:00
Mike McQuaid
766fc4b301
Fix RuboCop 0.77.0 failures. 2019-11-28 15:10:50 +00:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files. 2019-04-20 13:27:36 +09:00
Mike McQuaid
9fca172d03 Fix HOMEBREW_RUBY_WARNINGS="-w"
Fix various circular requirements, method redefinitions, etc.
2018-04-07 20:28:56 +01:00
Maxim Belkin
dd9415c8d3
remove sneaky empty line 2017-10-16 12:23:27 -05:00
Maxim Belkin
336fbb5db2
caveats: making plist_caveats macOS-only 2017-10-16 11:15:54 -05:00