41363 Commits

Author SHA1 Message Date
Sam Ford
403b0bf3f1
contributions: resolve type errors
This updates the type signature for `#scan_repositories` to address a
runtime type error and to reflect the actual return type.

The logic in `#scan_repositories` to check for unsupported
repositories leads to a type error, as `#ofail` has a void return
type. To resolve this, I moved the repository verification code into
`#run` (after `repos` is defined but before it's used) and used
`#odie`, so the command will exit early with an error.

While I was at it, I updated the type for the `repos` parameter to
not be `nilable`, as it shouldn't be `nil` based on how we're
handling `repos` in `#run`.
2024-07-18 15:40:10 -04:00
Sam Ford
b4b984e968
contributions: move CSV require into #generate_csv
CSV generation is optional, so this moves the related `require` into
the method where `CSV` is used (following a pattern we've used for
other `require` calls throughout `brew`).
2024-07-18 15:40:07 -04:00
Sam Ford
a9f7da36e0
contributions, github: add missing requires
This resolves `unitialized constant` errors in `brew contributions`
(`Tap`, `GitHub`) and `Utils::GitHub` (`Utils::Curl`).

This also preemptively adds some requires to `Utils::GitHub` and
`GitHub::API`, to avoid similar errors.
2024-07-18 12:55:41 -04:00
Sam Ford
61f5e2b698
Merge pull request #17798 from muescha/patch-3
Update Brew-Livecheck.md: add examples for modify version information
2024-07-18 12:43:16 -04:00
Patrick Linnane
97829bb4ed
Merge pull request #17804 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-0.5.11485 2024-07-18 09:40:37 -07:00
Patrick Linnane
db3d5878ea
Merge pull request #17805 from Homebrew/ww/fix-comment 2024-07-18 09:18:52 -07:00
BrewTestBot
91fbb602c5
brew vendor-gems: commit updates. 2024-07-18 16:17:40 +00:00
dependabot[bot]
d7d2ab83e2
build(deps-dev): bump sorbet in /Library/Homebrew
Bumps [sorbet](https://github.com/sorbet/sorbet) from 0.5.11481 to 0.5.11485.
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

---
updated-dependencies:
- dependency-name: sorbet
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-07-18 16:15:51 +00:00
William Woodruff
493450a3ac
attestation: fix comment
Signed-off-by: William Woodruff <william@yossarian.net>
2024-07-18 12:06:37 -04:00
Patrick Linnane
5e5ea1c020
Merge pull request #17791 from Homebrew/sorbet-files-update 2024-07-18 09:02:29 -07:00
Muescha
5ce0124c4b
Update docs/Brew-Livecheck.md - simplify regex
Co-authored-by: Sam Ford <1584702+samford@users.noreply.github.com>
2024-07-18 18:00:59 +02:00
Muescha
3b0488edb4
Update docs/Brew-Livecheck.md - better wording
Co-authored-by: Sam Ford <1584702+samford@users.noreply.github.com>
2024-07-18 17:58:13 +02:00
Muescha
f0f491b417
Update docs/Brew-Livecheck.md - uppercase YAML and quotation
Co-authored-by: Sam Ford <1584702+samford@users.noreply.github.com>
2024-07-18 17:57:50 +02:00
Bo Anderson
8d6ba639c6
Merge pull request #17800 from Homebrew/attestations-bad-config
attestation: handle bad configurations better
2024-07-18 16:53:36 +01:00
Patrick Linnane
d4c6a81fff
Regenerate tapioca RBI
Signed-off-by: Patrick Linnane <patrick@linnane.io>
2024-07-18 08:51:44 -07:00
Carlo Cabrera
7c59ad8e88
Merge pull request #17799 from Homebrew/dependency-alias-fix 2024-07-18 17:41:00 +02:00
Patrick Linnane
2f3076b4ad
Merge pull request #17797 from muescha/patch-2 2024-07-18 08:24:23 -07:00
Bo Anderson
16d547b030
attestation: handle bad configurations better 2024-07-18 16:11:25 +01:00
Patrick Linnane
e3851595f1
Merge pull request #17792 from Homebrew/explain-std_-_args 2024-07-18 08:10:48 -07:00
Bo Anderson
17ccc79857
dependency: fix missed upgrades when an alias is changed to a formula 2024-07-18 15:30:04 +01:00
Muescha
cee029516e
Update Brew-Livecheck.md
fix ruby style guide check
2024-07-18 16:07:26 +02:00
Muescha
8a00f0451b
Update Brew-Livecheck.md: add examples for modify version information
add examples for modify version information
2024-07-18 15:56:43 +02:00
Muescha
56ec4363eb
Update How-To-Open-a-Homebrew-Pull-Request.md: add links to Manpage
add links to Manpage
2024-07-18 15:29:36 +02:00
apainintheneck
75cfa21068 Avoid frozen array errors in brew upgrade
The `Homebrew::CLI::NamedArgs` class often returns frozen arrays so this one cannot
be easily modified in-place here. We just overwrite it instead.

I also updated the `brew reinstall` command logic to match for consistency.

```console
$ brew upgrade gh --verbose --debug
...
/usr/local/Homebrew/Library/Homebrew/brew.rb (Formulary::FromAPILoader): loading gh
/usr/local/Homebrew/Library/Homebrew/brew.rb (Formulary::FromAPILoader): loading gh
Error: can't modify frozen Array: [#<Formula gh (stable) /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/g/gh.rb>]
/usr/local/Homebrew/Library/Homebrew/cmd/upgrade.rb:139:in `delete'
/usr/local/Homebrew/Library/Homebrew/cmd/upgrade.rb:139:in `run'
/usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.3.0/gems/sorbet-runtime-0.5.11481/lib/types/private/methods/call_validation.rb:270:in `bind_call'
/usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.3.0/gems/sorbet-runtime-0.5.11481/lib/types/private/methods/call_validation.rb:270:in `validate_call'
/usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.3.0/gems/sorbet-runtime-0.5.11481/lib/types/private/methods/_methods.rb:277:in `block in _on_method_added'
/usr/local/Homebrew/Library/Homebrew/brew.rb:95:in `<main>'
```
2024-07-17 23:54:50 -07:00
Kevin
4aae003a1a
Merge pull request #17766 from Homebrew/fix-formula-uri-loader
FormulaURILoader: use regex to validate refs before attempting to cast
2024-07-17 20:07:17 -07:00
Ruoyu Zhong
921210dc71
Merge pull request #17790 from Homebrew/sponsors-maintainers-man-completions
Update sponsors.
2024-07-18 10:30:44 +08:00
Patrick Linnane
7b8d0e6b7f
Formula-Cookbook: add std_*_args explanations
Signed-off-by: Patrick Linnane <patrick@linnane.io>
2024-07-17 17:36:51 -07:00
BrewTestBot
2e1cac5d20
sorbet: Update RBI files.
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
2024-07-18 00:21:40 +00:00
BrewTestBot
ba8445cbed
Update sponsors.
Autogenerated by the [sponsors-maintainers-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sponsors-maintainers-man-completions.yml) workflow.
2024-07-18 00:06:29 +00:00
Issy Long
b033119523
utils/github/actions: Bump to Sorbet typed: strict 2024-07-17 18:00:20 -04:00
Issy Long
07f9f3f8e0
utils/github/artifacts: Bump to Sorbet typed: strict 2024-07-17 18:00:20 -04:00
Issy Long
5b84ee0195
utils/tar: Bump to Sorbet typed: strict 2024-07-17 18:00:20 -04:00
Issy Long
3290b7e616
env_config: Bump to Sorbet typed: strict 2024-07-17 16:02:01 -04:00
Issy Long
75b72f2fd9
official_taps: Bump to Sorbet typed: strict 2024-07-17 16:02:01 -04:00
Issy Long
7282b4d7a2
os: Bump to Sorbet typed: strict 2024-07-17 16:01:59 -04:00
Nanda H Krishna
321498c327
Merge pull request #17760 from Homebrew/gh-fix 2024-07-17 15:23:16 -04:00
Nanda H Krishna
6db608f43f
Ensure that the gh formula is sufficiently new 2024-07-17 14:48:53 -04:00
Nanda H Krishna
8839ccfe72
Fix tests for attestations 2024-07-17 14:48:53 -04:00
Nanda H Krishna
81e606007f
Fix type errors 2024-07-17 14:48:52 -04:00
Nanda H Krishna
d2d814414e
cmd/{install,reinstall,upgrade}: ensure that gh is installed 2024-07-17 14:48:52 -04:00
Nanda H Krishna
51ec743d6f
Remove ensure_gh_installed!
Co-authored-by: William Woodruff <william@yossarian.net>
2024-07-17 14:48:52 -04:00
Nanda H Krishna
802eb54e87
Fix tests for attestations 2024-07-17 14:48:50 -04:00
Nanda H Krishna
4d387d285e
Fix type and style errors 2024-07-17 14:46:59 -04:00
Nanda H Krishna
3bb91601fb
Ensure early installation of gh for attestations 2024-07-17 14:46:58 -04:00
Carlo Cabrera
94592054a8
Merge pull request #17787 from Homebrew/dependabot/bundler/Library/Homebrew/rbi-0.1.14 2024-07-17 20:35:13 +02:00
William Woodruff
30e8aa1aac
Merge pull request #17785 from Homebrew/attestation-chdir 2024-07-17 14:31:50 -04:00
dependabot[bot]
e295fe0cbf
build(deps-dev): bump rbi from 0.1.13 to 0.1.14 in /Library/Homebrew
Bumps [rbi](https://github.com/Shopify/rbi) from 0.1.13 to 0.1.14.
- [Release notes](https://github.com/Shopify/rbi/releases)
- [Commits](https://github.com/Shopify/rbi/compare/v0.1.13...v0.1.14)

---
updated-dependencies:
- dependency-name: rbi
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-07-17 18:23:10 +00:00
Bo Anderson
f40330c42d
attestation: avoid touching working directory 2024-07-17 19:18:09 +01:00
Carlo Cabrera
4025df1929
Merge pull request #17786 from Homebrew/git-submodule-uid 2024-07-17 19:12:01 +02:00
Carlo Cabrera
49b27767aa
download_strategy: fix UID handling for Git submodules
Source builds that use Git checkouts with submodules can choke when the
process UID does not match its EUID.

We can fix this by using the `reset_uid` option added in #17782.
2024-07-17 18:59:02 +02:00