Jack Nagel
a9fcefda4e
cleanup: refactor cleanup_cache
2013-05-15 12:57:01 -05:00
Jack Nagel
5b5bb57865
cleanup: rename variable
2013-05-15 12:57:00 -05:00
Jack Nagel
b26c502f79
cleanup: refactor cleanup_formula
2013-05-15 12:57:00 -05:00
Jack Nagel
87a8f9a6ae
cleanup: only map dirs to kegs once
2013-05-15 12:57:00 -05:00
Jack Nagel
daf8c26108
cleanup: use Pathname#rmtree instead of FileUtils
2013-05-15 12:56:59 -05:00
Jack Nagel
b32310c3db
cleanup: use subdirs, avoid .directory? checks
2013-05-15 12:56:59 -05:00
Jack Nagel
bf8bf2e1d1
cleanup: remove redundant condition
...
If f.installed? is true, f.rack.directory? will always be true as well.
2013-05-15 12:56:59 -05:00
Jack Nagel
0c35274bf4
cleanup: rename method for consistency
2013-05-15 12:56:58 -05:00
Jack Nagel
5515d359d5
cleanup: use early return rather than method-spanning conditional
2013-05-15 12:56:58 -05:00
Jack Nagel
8cd331718e
cleanup: factor out unqualified cleanup code
2013-05-15 12:56:58 -05:00
Jack Nagel
c48ac0b982
Methods that end in _formula should only accept a formula
2013-05-15 12:56:57 -05:00
Jack Nagel
132e6a3a8e
audit: fix version audit for Version subclasses
...
The version isn't redundant if a subclass of Version is specified.
2013-05-14 20:17:00 -05:00
Jack Nagel
8b763acc2a
outdated: always do comparisons with a Formula as the receiver
...
It is possible for the object returned by Formula#version to be a
subclass of Version with special behavior, so we want to use that for
the comparison.
2013-05-14 20:11:48 -05:00
Jack Nagel
e0c4fd5b72
test_keg: reduce noise by including FileUtils
2013-05-14 16:29:36 -05:00
Jack Nagel
cf2b0f88e6
test_keg: make mode an ivar
2013-05-14 16:29:36 -05:00
Adam Vandenberg
13c604035b
Retry downloads if a server doesn't support byte ranges
...
If an incomplete download exists, and the HTTP server doesn't support
byte ranges, delete the incomplete download and retry once.
Tested with freeling, whose server does not support byte ranges.
Closes Homebrew/homebrew#19757 .
2013-05-13 07:32:03 -07:00
Jack Nagel
46f8be1d9e
Use Hash#each_value rather than discarding key
2013-05-11 16:06:18 -05:00
Mike McQuaid
ad5c1b81cd
Fix --build-bottle CFLAGS.
...
The CFLAGS were previously not generic enough.
References Homebrew/homebrew#18944 .
References Homebrew/homebrew#19179 .
2013-05-11 12:18:25 +01:00
Jack Nagel
1bf8fbfe9a
info: simplify keg listing
2013-05-10 23:45:36 -05:00
Jack Nagel
2517969585
deps: fix --1 output
...
Fixes Homebrew/homebrew#17550 .
Closes Homebrew/homebrew#19668 .
2013-05-10 23:45:30 -05:00
Jack Nagel
e02d6f2500
info: improve dependency listing
2013-05-10 23:45:06 -05:00
Jack Nagel
2d93935e6a
Add type accessors to Dependencies
2013-05-10 23:45:06 -05:00
Jack Nagel
7629d4485e
Use Enumerable#grep
2013-05-10 23:45:06 -05:00
Jack Nagel
12f4ccd7f3
Refactor Dependency.expand
2013-05-10 23:45:05 -05:00
Jack Nagel
3be67f7252
Reorganize compat
2013-05-10 23:27:28 -05:00
Jack Nagel
290a93ea75
Remove ancient global methods from compat
2013-05-10 23:27:27 -05:00
Mike McQuaid
92ccfc548e
Allow requirements to specify a default formula.
...
This allows default resolution of requirements without user intervention.
Closes Homebrew/homebrew#19627 .
2013-05-10 13:37:41 +01:00
Desmond Brand
ba93e6d363
Overwrite broken symlinks with --overwrite
...
Closes Homebrew/homebrew#19480 .
Signed-off-by: Misty De Meo <mistydemeo@gmail.com>
2013-05-09 09:21:34 -05:00
Misty De Meo
4312f94013
Add gcc-4.0 to fails_with
2013-05-08 09:38:15 -05:00
Jack Nagel
f61a4f8893
doctor: update ruby version check
2013-05-07 19:45:10 -05:00
Jack Nagel
14bc883750
doctor: update git version check
2013-05-07 19:45:10 -05:00
Jack Nagel
66489b70d7
audit: only generate aliases list once
2013-05-07 18:40:14 -05:00
Jack Nagel
fedf9ddae3
audit: only set up the build environment once
2013-05-07 18:39:45 -05:00
Misty De Meo
57534cf7b2
ArchRequirement: takes a single arch
...
Fixes Homebrew/homebrew#19646 .
2013-05-06 22:50:01 -05:00
Jack Nagel
7412a71e9d
Fix type error in conflict_requirement
...
Fixes Homebrew/homebrew#19636 .
2013-05-06 17:49:36 -05:00
Jack Nagel
5bf652ecdd
Avoid extra array allocations
2013-05-06 16:52:26 -05:00
Jack Nagel
b322020338
Reduce allocations in dependency construction
...
By always passing around a single, unnested array rather than splatting
and then defensively flattening and compacting things, we can avoid
allocating a bunch of unnecessary arrays. This gives a performance boost
of roughly 4% when enumerating 2500 formulae, and has the side effect of
cleaning up the dependency API.
2013-05-06 16:08:50 -05:00
Jack Nagel
894a6c9776
TypeError is appropriate here
2013-05-06 16:08:49 -05:00
Jack Nagel
666b48e391
Check Requirement before Dependency
...
It's much more likely that an instance of Requirement is passed.
2013-05-06 16:08:49 -05:00
Jack Nagel
f47e43aa2b
Extract string and class logic from parse_spec
2013-05-06 16:08:49 -05:00
Misty De Meo
9ec3102e57
Formula: fix to_hash output for bottles
2013-05-05 10:58:12 -05:00
Adam Vandenberg
1c12c8b7a2
Add frameworks helper to formula
2013-05-03 11:41:55 -07:00
Jack Nagel
9dd7672ae7
info: re-raise on blacklist miss
2013-05-02 21:34:48 -05:00
Adam Vandenberg
afd2dde474
--env: show HOMEBREW_CC in superenv
...
Closes Homebrew/homebrew#18247 .
2013-05-02 11:36:30 -07:00
Adam Vandenberg
b163ed03e9
info: try blacklist for unknown formula names
...
Closes Homebrew/homebrew#17399 .
2013-04-29 10:12:40 -07:00
Jack Nagel
c2889de323
Avoid capturing groups when unnused
2013-04-27 15:21:06 -05:00
Jack Nagel
364c5c3473
Combine GitHub version regexes
2013-04-27 15:21:05 -05:00
Jack Nagel
16723afaa8
Only remove DS_Store on ENOTEMPTY
2013-04-27 15:21:05 -05:00
Jack Nagel
bffe090b21
Don't test error message
...
Now that we are testing for a custom exception type, we don't need to
make any assertion about the message.
2013-04-27 14:50:35 -05:00
Jack Nagel
9b5cb6cfb6
Allow brew versions to work with underspecified formulae
2013-04-27 14:44:48 -05:00
