15934 Commits

Author SHA1 Message Date
Mike McQuaid
8fdd278cd3
Merge pull request #6031 from iMichka/sudo3
brew: remove sudo call only in docker context
2019-04-19 10:32:22 +09:00
Mike McQuaid
86f43f79ee
Enable/fix optional Ruby frozen string literal usage
Combined with https://github.com/Homebrew/homebrew-test-bot/pull/247
this will test Homebrew's use of frozen strings in CI. After this we
will then enable it for Homebrew developers and eventually all Homebrew
users.
2019-04-19 10:30:41 +09:00
Mike McQuaid
7ab5fef7f2
brew.rb: remove unless ||. 2019-04-19 10:12:03 +09:00
Michka Popoff
49aad7ddb3 brew: remove sudo call only in docker context
Follow up from #6018
2019-04-18 17:16:05 +02:00
Mike McQuaid
892d0ac5fe
style: don’t run shellcheck on specified ruby file. 2019-04-18 21:42:42 +09:00
Mike McQuaid
9e7b98d3e2
Don't check system Ruby is new enough when unnecessary.
We know this is the case in macOS >=10.13.3 so save a Ruby process call.
2019-04-18 21:42:28 +09:00
Mike McQuaid
ef2e297d3b
Disable RubyGems by default.
This speeds up all Ruby invocations where we don't need RubyGems by
around 10%. Where we do need RubyGems: include it manually.
2019-04-18 17:45:03 +09:00
Mike McQuaid
640234caa1
Merge pull request #6030 from MikeMcQuaid/ruby-no-threads
Remove usage of Thread.new
2019-04-18 16:03:18 +09:00
Mike McQuaid
7fbfb02625
Remove usage of Thread.new
I benchmarked these both locally and neither use of `Thread.new`
provides any measurable speedup (and in the `readall` case appears to
slow things down) on my 8 core machine.
2019-04-18 14:46:40 +09:00
Mike McQuaid
1aaffda62f
Merge pull request #6027 from vitorgalvao/remove_to_slashes
hbc: remove all *_to_slashes
2019-04-18 11:59:10 +09:00
Mike McQuaid
4ad8d7608e
Merge pull request #6021 from MikeMcQuaid/argv-cleanup
Update ARGV and CLI parsing
2019-04-17 21:51:27 +01:00
Michka Popoff
f35f17ccf4
Merge pull request #6018 from iMichka/sudo2
brew: remove sudo call
2019-04-17 20:50:06 +02:00
Vítor Galvão
0ee226769a hbc: remove all *_to_slashes 2019-04-17 16:31:35 +01:00
Mike McQuaid
ae63381bd9
cli/parser: use cli/args and tweak freeze behaviour. 2019-04-17 22:16:58 +09:00
Mike McQuaid
e9806b6b55
cli/args: add class to handle arguments. 2019-04-17 22:16:58 +09:00
Mike McQuaid
34a8ab74af
global: provide unpatched ARGV. 2019-04-17 22:16:58 +09:00
Mike McQuaid
e40b171127
Rename cli_parser to cli/parser. 2019-04-17 22:16:50 +09:00
Mike McQuaid
18630c7032
extend/ARGV: remove unused methods. 2019-04-17 21:08:26 +09:00
Mike McQuaid
0b272ad26e
cleanup: don’t cleanup periodic clean file.
Cleaning up this file means that cleanup will run again prematurely.
2019-04-17 21:06:47 +09:00
Mike McQuaid
4d6de005d8
Merge pull request #6025 from MikeMcQuaid/release-notes-stderr
release-notes: use stderr for header output.
2019-04-17 13:04:39 +01:00
Mike McQuaid
f6337c543a
Merge pull request #6023 from MikeMcQuaid/config-no-default-logs
system_config: don’t output default HOMEBREW_LOGS.
2019-04-17 13:04:29 +01:00
Mike McQuaid
8229e592d7
cask/cmd/info_spec: needs network connection.
Tag it accordingly.
2019-04-17 17:34:33 +09:00
Mike McQuaid
b03558e296
system_config: don’t output default HOMEBREW_LOGS.
This cuts down a bit on noise. While we’re here, optimise the checks too.
2019-04-17 17:02:33 +09:00
Mike McQuaid
888c384801
release-notes: use stderr for header output.
This makes the use of `brew release-notes | pbcopy` a bit easier.
2019-04-17 17:00:24 +09:00
Michka Popoff
1c016ecee7 brew: remove sudo call
except for "brew services" command
2019-04-16 20:35:41 +02:00
Mike McQuaid
356f72dcc6
Merge pull request #6012 from amyspark/hotpatch-fix-atomic_write
atomic_write: repair permissions after writing
2019-04-14 10:02:15 +01:00
Mike McQuaid
1281c4a663
Merge pull request #5983 from zachauten/continue-upgrading-casks-after-failure
'brew cask upgrade' will continue upgrading casks after a failure
2019-04-14 10:01:32 +01:00
Mike McQuaid
0750971870
Merge pull request #5893 from reitermarkus/version-unstable
Add `#unstable?` method for cask versions.
2019-04-14 10:00:57 +01:00
Mike McQuaid
3b842ef41f
Merge pull request #6014 from vitorgalvao/caskroom-home
cask home: update to brew.sh
2019-04-14 10:00:15 +01:00
EricFromCanada
e0558dc7c7 trim line breaks 2019-04-13 21:37:48 -04:00
EricFromCanada
89f0fcedbe whitespace fixes 2019-04-13 21:32:04 -04:00
EricFromCanada
15c38a2d8b formatting fixes 2019-04-13 21:29:32 -04:00
EricFromCanada
fa6404e0f5 grammar fixes 2019-04-13 21:29:32 -04:00
Vítor Galvão
82d480eddd cask manpages: update homepage to brew.sh 2019-04-13 19:47:53 +01:00
Vítor Galvão
67ca3d372a cask home cmd: update homepage to brew.sh 2019-04-13 19:47:14 +01:00
L. E. Segovia
f9fcdec795
pathname.rb: style fixes 2019-04-13 17:18:14 +00:00
Zach Auten
41b5b788d5 'brew cask upgrade' will continue upgrading casks after a failure
'cask upgrade' command collects all exceptions thrown
from individual casks during the upgrade process. If
there were more than one cask that raised exceptions
during the upgrade process, a MultipleCaskErrors
exception will be thrown.

Issue #5203
2019-04-12 19:26:33 -04:00
L. E. Segovia
f706fffc6c
atomic_write: repair permissions after writing
This restores the original file uid, gid and permissions separately.
(ActiveSupport does it in a single step - atomically. This is not
useful in our use case because it may lead to ACL changes.)

Fixes #5916
2019-04-12 18:46:57 +00:00
Mike McQuaid
a679ec1cb3
Revert "brew: remove sudo call" 2019-04-12 08:29:07 +01:00
Mike McQuaid
1c655916fe
Merge pull request #5993 from amyspark/drop-unzip-in-macos
Drop unzip usage for Homebrew Cask
2019-04-10 09:08:02 +01:00
L. E. Segovia
c6894a23c1
Only merge extended attributes if required 2019-04-09 21:45:35 +00:00
Carlos Eduardo
f9a67019d6
Improve error message on cask doctor
Add fix command on brew cask doctor in case staging directory is not writable.
2019-04-09 13:08:06 -03:00
Mike McQuaid
9856a6c3bb
Merge pull request #6002 from MikeMcQuaid/xcode-requirement-fix
xcode_requirement: fix Swift compatability check.
2019-04-09 16:22:00 +01:00
Mike McQuaid
426c6e2c3f
xcode_requirement: fix Swift compatability check.
Ensure we're using the full macOS version so that
`MacOS::Xcode.version >= "10.14.4"` can ever be true.
2019-04-09 15:59:27 +01:00
dependabot[bot]
ff76d64a23
Bump rspec-its from 1.2.0 to 1.3.0 in /Library/Homebrew
Bumps [rspec-its](https://github.com/rspec/rspec-its) from 1.2.0 to 1.3.0.
- [Release notes](https://github.com/rspec/rspec-its/releases)
- [Changelog](https://github.com/rspec/rspec-its/blob/master/Changelog.md)
- [Commits](https://github.com/rspec/rspec-its/compare/v1.2.0...v1.3.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-09 10:35:10 +00:00
L. E. Segovia
e09d4336a9
Unzip Casks w/ extended attributes with ditto
Fixes Homebrew/homebrew-cask#61386
2019-04-08 22:54:33 +00:00
Marc Seeger
8457fa5af5
Fix 2nd typo in cleaner.rb 2019-04-08 10:33:49 -07:00
Marc Seeger
4f8489faa1
Fix typo in cleaner.rb
Seems like auto-correct was a bit too eager to fix things :) ?
2019-04-08 10:24:56 -07:00
dependabot[bot]
517a2c7e24
Bump rubocop from 0.67.1 to 0.67.2 in /Library/Homebrew
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.67.1 to 0.67.2.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.67.1...v0.67.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-08 06:34:58 +00:00
Mike McQuaid
b3a6419dc8
Merge pull request #5986 from muescha/patch-1
(cask): change cask template url `'` to `"` to allow string interpolation on version
2019-04-07 08:18:27 +01:00