1033 Commits

Author SHA1 Message Date
Mike McQuaid
c4f72312ce
Fixup brew style failures. 2019-04-30 09:19:18 +01:00
Mike McQuaid
73528b6a08
Freeze more strings
Freeze the results changed in #6072.
2019-04-29 13:02:15 +01:00
Markus Reiter
85c3b55e2b Fix exception in exception. 2019-04-28 15:16:47 +02:00
Mike McQuaid
0d54978ba8
Merge pull request #6036 from MikeMcQuaid/enable-frozen-string-literal
Use FrozenStringLiteralComment instead of flag.
2019-04-22 13:07:08 -07:00
Markus Reiter
ce15622584 Add *_to_slashes methods to compat. 2019-04-20 23:58:48 +02:00
Mike McQuaid
fc6bd2ea1c
Fixup more frozen string handling. 2019-04-20 14:07:29 +09:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files. 2019-04-20 13:27:36 +09:00
Mike McQuaid
d1ea6f38d3
Fix mutable constants violations. 2019-04-19 21:46:20 +09:00
Mike McQuaid
86f43f79ee
Enable/fix optional Ruby frozen string literal usage
Combined with https://github.com/Homebrew/homebrew-test-bot/pull/247
this will test Homebrew's use of frozen strings in CI. After this we
will then enable it for Homebrew developers and eventually all Homebrew
users.
2019-04-19 10:30:41 +09:00
Vítor Galvão
0ee226769a hbc: remove all *_to_slashes 2019-04-17 16:31:35 +01:00
Mike McQuaid
1281c4a663
Merge pull request #5983 from zachauten/continue-upgrading-casks-after-failure
'brew cask upgrade' will continue upgrading casks after a failure
2019-04-14 10:01:32 +01:00
Mike McQuaid
0750971870
Merge pull request #5893 from reitermarkus/version-unstable
Add `#unstable?` method for cask versions.
2019-04-14 10:00:57 +01:00
Mike McQuaid
3b842ef41f
Merge pull request #6014 from vitorgalvao/caskroom-home
cask home: update to brew.sh
2019-04-14 10:00:15 +01:00
EricFromCanada
e0558dc7c7 trim line breaks 2019-04-13 21:37:48 -04:00
EricFromCanada
89f0fcedbe whitespace fixes 2019-04-13 21:32:04 -04:00
EricFromCanada
15c38a2d8b formatting fixes 2019-04-13 21:29:32 -04:00
EricFromCanada
fa6404e0f5 grammar fixes 2019-04-13 21:29:32 -04:00
Vítor Galvão
67ca3d372a cask home cmd: update homepage to brew.sh 2019-04-13 19:47:14 +01:00
Zach Auten
41b5b788d5 'brew cask upgrade' will continue upgrading casks after a failure
'cask upgrade' command collects all exceptions thrown
from individual casks during the upgrade process. If
there were more than one cask that raised exceptions
during the upgrade process, a MultipleCaskErrors
exception will be thrown.

Issue #5203
2019-04-12 19:26:33 -04:00
Mike McQuaid
1c655916fe
Merge pull request #5993 from amyspark/drop-unzip-in-macos
Drop unzip usage for Homebrew Cask
2019-04-10 09:08:02 +01:00
L. E. Segovia
c6894a23c1
Only merge extended attributes if required 2019-04-09 21:45:35 +00:00
Carlos Eduardo
f9a67019d6
Improve error message on cask doctor
Add fix command on brew cask doctor in case staging directory is not writable.
2019-04-09 13:08:06 -03:00
Michael
7ac157703f
change ' to " to allow 2019-04-06 09:30:59 +01:00
Mike McQuaid
51e473891f
cask: improve JSON output consistency.
Replace the use of HOME or HOMEBREW_PREFIX in the output strings with
variable versions. This is particularly useful on formulae.brew.sh.
2019-03-27 15:59:38 +00:00
Markus Reiter
2a3b7d072d Add #unstable? method for cask versions. 2019-03-27 13:48:03 +01:00
Zach Auten
e9b17b8593 Replaced 'unless nil' with 'if' 2019-03-16 12:59:15 -04:00
Zach Auten
75b9eec7ef Renamed print_caveats, updated an info_spec test to macos only 2019-03-11 21:20:02 -04:00
Zach Auten
18a20986e7 Addressed style issues 2019-03-06 18:06:50 -05:00
Zach Auten
dd4daa247f Merge branch 'master' of https://github.com/Homebrew/brew into brew-info-display-casks 2019-03-06 17:56:22 -05:00
Zach Auten
fe643758d7 Updated get_info
- get_info builds info string by appending helper functions
  - removed unnecessary returns
  - fixed indentation in missing_formula
  - reduced size of regex in info_spec
  - missing_formula will indicate when it finds a cask with same name
2019-03-06 00:27:48 -05:00
Markus Reiter
42d90f8bd9 Use same logic for installer script: and uninstall script:. 2019-03-03 06:21:11 +01:00
Zach Auten
330ae8c6fa print_caveats and get_info return heredocs 2019-02-24 21:53:04 -05:00
Zach Auten
ed80b60834 Fixed installation info output and imports 2019-02-21 21:08:57 -05:00
Mike McQuaid
e095da4d01
rubocop: enable Layout/EmptyLineAfterGuardClause. 2019-02-21 12:55:49 +00:00
Mike McQuaid
d64429a736
rubocop: enable Style/IfUnlessModifier. 2019-02-21 12:55:49 +00:00
Zach Auten
554106d2e0 Updated missing formula cask reason
- search_for_cask in missing_formula renamed to is_a_cask_reason
    - is_a_cask calls new getInfo method in cask/cmd/info.rb to return info
      string
    - self.info in info.rb now calls getInfo and puts return value
    - added ohai_title to return the ohai printout for only titles, so that
      ohai printout could be added to the getInfo return string without
      calling puts.
    - refactored ohai to use ohai_title
    - updated info_spec.rb cask info test to be more specific when
      matching stderr.
    - is_a_cask_reason will respect 'silent'
    - refactored print_caveats to return instead of print
2019-02-18 03:33:57 -05:00
Markus Reiter
713453cc2f
Merge pull request #5745 from reitermarkus/cask-edit
Allow editing broken casks.
2019-02-16 10:20:56 +01:00
Markus Reiter
5536432c4f Allow editing broken casks. 2019-02-15 22:05:28 +01:00
Markus Reiter
cd03c0f86d Retry merging once after 5 seconds. 2019-02-15 19:48:12 +01:00
Markus Reiter
68e0c5f904 Check for write access instead of HOMEBREW_DEVELOPER. 2019-02-15 16:27:37 +01:00
Markus Reiter
57fefff942 Add brew cask automerge command. 2019-02-15 16:27:37 +01:00
Markus Reiter
3bf7e5bce5 Remove Cask::Config#write. 2019-02-15 10:09:14 +01:00
Markus Reiter
4c6d0ba069 Rename dirs.json to config.json. 2019-02-15 10:09:14 +01:00
Markus Reiter
bcdb4a3f32 Add Cask::Config::canonicalize. 2019-02-15 10:09:14 +01:00
Markus Reiter
defbf7d74c Don’t ignore other arguments in HOMEBREW_CASK_OPTS. 2019-02-15 10:09:14 +01:00
Markus Reiter
190ff7558a Use saved cask config for reinstall/upgrade/uninstall. 2019-02-15 10:09:14 +01:00
Markus Reiter
fda6e0cab3 Split cask config into three tiers. 2019-02-15 10:09:14 +01:00
Markus Reiter
1e1ce1c471 Save config file for casks. 2019-02-15 10:09:14 +01:00
Markus Reiter
0fcc62db31 Run uninstall rmdir: after uninstalling artifacts. 2019-02-08 01:09:48 +01:00
Markus Reiter
e09eaf5b31 Only use sudo if it is actually needed. 2019-02-07 21:45:48 +01:00