25080 Commits

Author SHA1 Message Date
Sam Ford
466e55c6ab
Bitbucket: Format regex like other strategies 2020-12-20 18:13:51 -05:00
Sam Ford
2ddb71af77
Merge pull request #10054 from hyuraku/livecheck-raise-error
livecheck: raise error if no watchlist
2020-12-20 17:48:23 -05:00
Sam Ford
21b1888388
Bitbucket: Anchor start of regex with protocol 2020-12-20 16:00:08 -05:00
Rylan Polster
194ff38431
Merge pull request #10074 from Rylan12/fix-typo-upgrade
upgrade: fix style in help text
2020-12-20 14:42:59 -05:00
Rylan Polster
bade687f11 upgrade: fix style in help text 2020-12-20 13:45:33 -05:00
Sam Ford
ac459f8e76
Strategy: Temporarily remove response caching
The simple approach here caches all header or body content from
responses, so memory usage continually grows with each fetch. This
becomes more of a notable issue with long livecheck runs (e.g.,
`--tap homebrew/core`).

Instead, we should only cache the header/body for URLs that we know
will be fetched more than once in a given run. Being able to
determine which URLs will be fetched more than once requires
structural changes within livecheck strategies, so this will take a
bit of work to implement.

I've been working on this off and on and I'll introduce a more
sophisticated method of livecheck-wide caching in a later PR. In the
interim time, it's best to remove this caching behavior until I've
finished working on an approach that provides benefits (reducing
duplicate fetches) while minimizing detriments (increased memory
usage).
2020-12-20 12:42:51 -05:00
Markus Reiter
f47c1eae32
Merge pull request #10053 from miccal/shared-audits-update
shared_audits: add xit to GITHUB_PRERELEASE_ALLOWLIST
2020-12-20 09:19:29 +01:00
Sam Ford
29e310c3f8
Merge pull request #9529 from reitermarkus/livecheck-cask-strategies
Add more livecheck strategies for casks.
2020-12-20 02:47:43 -05:00
Sam Ford
99ea95c28d
Sparkle: Expand tests 2020-12-20 01:56:54 -05:00
Sam Ford
c6c303acfe
Sparkle: Rename contents to content 2020-12-20 00:23:22 -05:00
Sam Ford
732e67d5db
Expand livecheck/livecheck tests 2020-12-19 23:45:26 -05:00
Sam Ford
c7080ba812
Expand dev-cmd/livecheck tests 2020-12-19 23:02:42 -05:00
hyuraku
ffc5c3206e
repair message 2020-12-19 22:59:27 -05:00
hyuraku
9f7e471382
livecheck: raise error if no watchlist 2020-12-19 22:59:26 -05:00
Sam Ford
e604cf742b
dev-cmd/livecheck: use safe navigation on #sort_by 2020-12-19 22:59:26 -05:00
Sam Ford
3261bbc0bd
Reorganize livecheck/livecheck test variables 2020-12-19 22:26:37 -05:00
Markus Reiter
91ee5e0a65 Simplify assignment of curl result. 2020-12-20 02:23:30 +01:00
Sam Ford
f299d3ea6e
Strategy#page_headers: Disable debug in curl 2020-12-19 19:34:28 -05:00
Sam Ford
3933b866b6
Sparkle: Align with PageMatch
This inlines the `PRIORITY` and `#match?` logic from `PageMatch`
into `Sparkle` instead of subclassing `PageMatch`. `Sparkle` doesn't
really make sense as a subclass of `PageMatch` (since it functions
in a completely different manner), so it's better to simply copy
over these parts of `PageMatch`. This also helps to separate the
strategies, so any changes to `PRIORITY` or `#match?` in `PageMatch`
won't affect `Sparkle`.
2020-12-19 19:34:28 -05:00
Sam Ford
cc5cd4bf59
HeaderMatch: Align with PageMatch 2020-12-19 19:34:28 -05:00
Markus Reiter
edf6a11be6
Simplify creation of merged_headers. 2020-12-19 19:34:27 -05:00
Markus Reiter
921485c672
Don't print backtrace for “Unable to get versions” error. 2020-12-19 19:34:27 -05:00
Sam Ford
f93ecd7d55
Satisfy brew typecheck and style 2020-12-19 19:34:27 -05:00
Sam Ford
8ea9ec8176
HeaderMatch: Align NICE_NAME with PageMatch 2020-12-19 19:34:27 -05:00
Sam Ford
57995f936f
Sparkle: Remove unnecessary NICE_NAME 2020-12-19 19:34:27 -05:00
Sam Ford
6bcb0fd4b8
HeaderMatch: Add test 2020-12-19 19:34:26 -05:00
Sam Ford
740d5d3bcd
Sparkle: Add test 2020-12-19 19:34:26 -05:00
Sam Ford
9fdc902630
Sparkle: Reorganize methods, etc. 2020-12-19 19:34:26 -05:00
Sam Ford
0148ee870e
Livecheck: Use alphabetical order in symbols array 2020-12-19 19:34:26 -05:00
Sam Ford
8b40d959bf
HeaderMatch: Fix content-disposition regex logic 2020-12-19 19:34:26 -05:00
Sam Ford
7f40198506
Make Strategy#page_headers more general purpose 2020-12-19 19:34:26 -05:00
Sam Ford
1bd2be5e04
Rename page_contents to page_content 2020-12-19 19:34:25 -05:00
Sam Ford
a55686a0e2
Enforce strategy url requirement in latest_version 2020-12-19 19:34:25 -05:00
Sam Ford
f5774c1af4
Sparkle: Use demodulized class name in error text 2020-12-19 19:34:25 -05:00
Markus Reiter
0d7c8c8c61
Revert priority for Git strategy. 2020-12-19 19:34:25 -05:00
Markus Reiter
0fd0b1dad0
Actually cache headers. 2020-12-19 19:34:25 -05:00
Markus Reiter
b8de4e8b21
Simplify strategies. 2020-12-19 19:34:24 -05:00
Markus Reiter
c306577575
Skip Sparkle strategy only if URL is not specified explicitly. 2020-12-19 19:34:24 -05:00
Markus Reiter
71104a27ef
Pass page directly instead of hash containing :page. 2020-12-19 19:34:24 -05:00
Markus Reiter
1a18742366
Pass headers directly instead of hash containing :headers. 2020-12-19 19:34:24 -05:00
Markus Reiter
8fa5a8e832
Don't suggest adding appcast if livecheck exists. 2020-12-19 19:34:24 -05:00
Markus Reiter
3723cd7dec
Remove detection for Sparkle strategy. 2020-12-19 19:34:23 -05:00
Markus Reiter
4aaa2de6c4
Fix syntax. 2020-12-19 19:34:23 -05:00
Markus Reiter
71759035dd
Fix Sparkle detection if content type is missing. 2020-12-19 19:34:23 -05:00
Markus Reiter
75eb6d1780
Add Item for Sparkle strategy. 2020-12-19 19:34:23 -05:00
Markus Reiter
0deceac28c
Allow regex without capture groups. 2020-12-19 19:34:23 -05:00
Markus Reiter
8a583a7aee
Remove args. 2020-12-19 19:34:23 -05:00
Markus Reiter
3a4c7223df
Allow accessing version in livecheck blocks. 2020-12-19 19:34:22 -05:00
Markus Reiter
2a3ee11c07
Fix typo. 2020-12-19 19:34:22 -05:00
Markus Reiter
c58fbe000e
Revert priority of GithubLatest strategy. 2020-12-19 19:34:22 -05:00