24019 Commits

Author SHA1 Message Date
Mike McQuaid
d2dcc41717 os/linux: add more Xcode stubs.
Saw these on a random user report.
2020-09-01 12:49:19 +01:00
Markus Reiter
6994556d19 Don't allow platform in cask descriptions. 2020-09-01 13:18:59 +02:00
Markus Reiter
6d6c59a1fd Simplify .rubocop_rspec.yml. 2020-09-01 12:52:59 +02:00
Markus Reiter
64a533bfdd Fix useless assignment. 2020-09-01 12:52:59 +02:00
Markus Reiter
21d57a0c44 Move RuboCop rules into top-level .rubocop.yml. 2020-09-01 12:52:59 +02:00
Markus Reiter
2b029b2744 Remove need for separate .rubocop_cask.yml. 2020-09-01 12:52:59 +02:00
Mike McQuaid
fecc701ac0
Merge pull request #8555 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-0.5.5883
build(deps): bump sorbet from 0.5.5881 to 0.5.5883 in /Library/Homebrew
2020-09-01 10:40:18 +01:00
dependabot-preview[bot]
dc816252d8
build(deps): bump sorbet from 0.5.5881 to 0.5.5883 in /Library/Homebrew
Bumps [sorbet](https://github.com/sorbet/sorbet) from 0.5.5881 to 0.5.5883.
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-09-01 08:48:40 +00:00
Mike McQuaid
3ee751b3c1
Merge pull request #8554 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-runtime-0.5.5883
build(deps): bump sorbet-runtime from 0.5.5881 to 0.5.5883 in /Library/Homebrew
2020-09-01 09:47:20 +01:00
Mike McQuaid
de3df53a1e
Merge pull request #8553 from MikeMcQuaid/named_args_no_cask_tap
cli/named_args: handle missing cask tap.
2020-09-01 09:45:19 +01:00
Mike McQuaid
55846df2f9
Merge pull request #8552 from Homebrew/dependabot/bundler/Library/Homebrew/minitest-5.14.2
build(deps): bump minitest from 5.14.1 to 5.14.2 in /Library/Homebrew
2020-09-01 08:59:44 +01:00
Mike McQuaid
8a8d4d1fb1
Merge pull request #8551 from Homebrew/dependabot/bundler/docs/minitest-5.14.2
build(deps): bump minitest from 5.14.1 to 5.14.2 in /docs
2020-09-01 08:59:36 +01:00
dependabot-preview[bot]
d38d2e58ef
build(deps): bump sorbet-runtime in /Library/Homebrew
Bumps [sorbet-runtime](https://github.com/sorbet/sorbet) from 0.5.5881 to 0.5.5883.
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-09-01 07:54:45 +00:00
Mike McQuaid
9cbcd64be2
Merge pull request #8545 from Homebrew/tapioca-update
sorbet: update RBI files using Tapioca.
2020-09-01 08:54:17 +01:00
Mike McQuaid
6e1346f991
Merge pull request #8548 from SeekingMeaning/cmd/installed_prefix
install, livecheck: use `opt_or_installed_prefix_keg`
2020-09-01 08:51:42 +01:00
Mike McQuaid
344d8432d2 cli/named_args: handle missing cask tap.
Casks (and indeed formulae) don't always have taps.

Fixes #8535
2020-09-01 08:50:56 +01:00
dependabot-preview[bot]
7360d56c6d
build(deps): bump minitest from 5.14.1 to 5.14.2 in /Library/Homebrew
Bumps [minitest](https://github.com/seattlerb/minitest) from 5.14.1 to 5.14.2.
- [Release notes](https://github.com/seattlerb/minitest/releases)
- [Changelog](https://github.com/seattlerb/minitest/blob/master/History.rdoc)
- [Commits](https://github.com/seattlerb/minitest/compare/v5.14.1...v5.14.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-09-01 05:28:49 +00:00
dependabot-preview[bot]
7a9861dcb8
build(deps): bump minitest from 5.14.1 to 5.14.2 in /docs
Bumps [minitest](https://github.com/seattlerb/minitest) from 5.14.1 to 5.14.2.
- [Release notes](https://github.com/seattlerb/minitest/releases)
- [Changelog](https://github.com/seattlerb/minitest/blob/master/History.rdoc)
- [Commits](https://github.com/seattlerb/minitest/compare/v5.14.1...v5.14.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-09-01 05:22:44 +00:00
Markus Reiter
f260b6e7b9
Merge pull request #8328 from reitermarkus/desc-cop
Improve detection of descriptions starting with cask/formula name.
2020-09-01 05:28:52 +02:00
Markus Reiter
3038ff8726 Improve detection of descriptions starting with cask/formula name. 2020-09-01 02:53:25 +02:00
BrewTestBot
2bac0d802a sorbet: update RBI files using Tapioca.
Autogenerated by [a scheduled GitHub Action](https://github.com/Homebrew/brew/blob/master/.github/workflows/tapioca.yml).
2020-09-01 00:21:39 +00:00
Markus Reiter
f8c3a1bd61
Merge pull request #8540 from reitermarkus/shellcheck-json
Split `check_style_impl` into `run_rubocop` and `run_shellcheck`.
2020-08-31 20:43:51 +02:00
Mike McQuaid
94eb2ad156
Merge pull request #8549 from Rylan12/disable-message-fix-again
fix deprecate! and disable! message
2020-08-31 19:23:15 +01:00
Markus Reiter
18faad0d86
Merge pull request #8546 from Homebrew/dependabot/bundler/Library/Homebrew/codecov-0.2.9
build(deps): bump codecov from 0.2.8 to 0.2.9 in /Library/Homebrew
2020-08-31 20:10:14 +02:00
Seeker
ce90a534da install, livecheck: use opt_or_installed_prefix_keg 2020-08-31 10:34:56 -07:00
Rylan Polster
e7cf1f4497 fix deprecate! and disable! message 2020-08-31 12:45:55 -04:00
Seeker
a48a8722fc
Merge pull request #8525 from SeekingMeaning/cmd/installed_prefix
pull, pr-pull: use `opt_or_installed_prefix_keg`
2020-08-31 09:45:54 -07:00
Mike McQuaid
2a4c9f610e
Merge pull request #8530 from Rylan12/fix-disable-and-deprecate-reasons
Fix disable and deprecate reasons
2.4.16
2020-08-31 17:10:53 +01:00
Dustin Rodrigues
f84f0e8015
Merge pull request #8536 from dtrodrigues/pulumi-blocklist
pypi: add pulumi to the blocklist
2020-08-31 11:59:44 -04:00
dependabot-preview[bot]
902711b3b0
build(deps): bump codecov from 0.2.8 to 0.2.9 in /Library/Homebrew
Bumps [codecov](https://github.com/codecov/codecov-ruby) from 0.2.8 to 0.2.9.
- [Release notes](https://github.com/codecov/codecov-ruby/releases)
- [Changelog](https://github.com/codecov/codecov-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/codecov/codecov-ruby/compare/v0.2.8...v0.2.9)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-31 15:52:15 +00:00
Rylan Polster
4d0a1ff775 deprecate!, disable!: allow symbols for reason 2020-08-31 10:11:08 -04:00
Rylan Polster
842335d47b style: check disable! dates and reasons 2020-08-31 10:11:08 -04:00
Rylan Polster
6162799d63 style: check deprecate! reason 2020-08-31 10:11:08 -04:00
Dustin Rodrigues
13f0b4706f pypi: add pulumi to the blocklist 2020-08-31 10:09:00 -04:00
Mike McQuaid
8db3471ff7
Merge pull request #8180 from nandahkrishna/migrate-livecheck
livecheck migration: add `brew livecheck` developer command
2020-08-31 13:05:50 +01:00
Claudia
246db8a134
Capture stdout during popen_write
Fix tests and fulfill intended semantics by having `popen_write`
transparently capture standard output.
2020-08-31 14:04:49 +02:00
nandahkrishna
e5fe57c1fe
Migrate livecheck to Homebrew/brew
Co-authored-by: Sam Ford <1584702+samford@users.noreply.github.com>
Co-authored-by: Thierry Moisan <thierry.moisan@gmail.com>
Co-authored-by: Dawid Dziurla <dawidd0811@gmail.com>
Co-authored-by: Maxim Belkin <maxim.belkin@gmail.com>
Co-authored-by: Issy Long <me@issyl0.co.uk>
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Co-authored-by: Seeker <meaningseeking@protonmail.com>
2020-08-31 17:08:28 +05:30
Mike McQuaid
44c826eae1
Merge pull request #8544 from nandahkrishna/remove-livecheck-test
livecheck: remove test for livecheck_formulae
2020-08-31 12:33:30 +01:00
nandahkrishna
8151016531
livecheck: remove test for livecheck_formulae 2020-08-31 16:37:37 +05:30
Mike McQuaid
eb09a09b66
Merge pull request #8500 from scpeters/upgrade_check_already_broken_dependents
upgrade: check for already broken dependents
2.4.15
2020-08-31 08:27:26 +01:00
Mike McQuaid
d6d0e3208c
Merge pull request #8531 from SeekingMeaning/formulary/bottle-formula-path
formulary: use formula path when loading from bottle
2020-08-31 08:23:08 +01:00
Mike McQuaid
205d4b5a0d
Merge pull request #8529 from maxim-belkin/remove-unsupported-taps
docs/Interesting-Taps-and-Forks.md: remove unsupported taps
2020-08-31 08:22:10 +01:00
Mike McQuaid
854a139a79
Merge pull request #8533 from Rylan12/deprecate-date-issue
style: fix deprecation date check
2020-08-31 08:16:57 +01:00
Mike McQuaid
30e177f563
Merge pull request #8254 from nandahkrishna/migrate-livecheck-module
livecheck migration: create Homebrew::Livecheck
2020-08-31 08:09:58 +01:00
Markus Reiter
c0f64882f1 Split check_style_impl into run_rubocop and run_shellcheck. 2020-08-31 02:44:05 +02:00
Claudia
772032f18a
Add failing tests for popen_write
When using `popen_write`, the expectation is to return the
standard output of the child process.

This expectation is evident in how `safe_popen_write` is written:

```
  def self.safe_popen_write(*args, **options, &block)
    output = popen_write(*args, **options, &block)
    return output if $CHILD_STATUS.success?

    raise ErrorDuringExecution.new(args, status: $CHILD_STATUS, output: [[:stdout, output]])
  end
```

However, no code has been written to actually *obtain* that output
from the child process. The side effects of that are described in
issue #8244. [1]

[1]: https://github.com/Homebrew/brew/issues/8244

The newly-added tests reveal that `popen_write` only returns the
number 4 instead of the expected standard output.

For example, given a file `foo` with the content `Foo\n`, one test
calls `popen_write` with `cat foo -` and an input of `Bar`.
The expected output would be `Foo\nBar\n` but the actual output is
the number 4 (which is what Ruby’s `IO#write` method returns).
2020-08-30 22:29:46 +02:00
Markus Reiter
7eb1a0969c
Merge pull request #8539 from claui/fix-8538
Print meaningful message on missing formula
2020-08-30 18:15:46 +02:00
Claudia
7d09ddc3b5
Print meaningful message on missing formula
Add an import statement needed for `MissingFormula` to be found.

Fixes #8538.

Reported-by: Nate Whetsell <nathan.whetsell@gmail.com>
2020-08-30 17:43:54 +02:00
Steve Peters
24e7f55a4c Create check_broken_dependents method 2020-08-30 01:24:42 -07:00
Markus Reiter
a39aae887e
Merge pull request #8496 from reitermarkus/debug-git
Properly fix Git error in tests.
2020-08-29 22:13:25 +02:00