Douglas Eichelberger 
							
						 
					 
					
						
						
						
						
							
						
						
							aab04229d1 
							
						 
					 
					
						
						
							
							Code review fixes  
						
						
						
						
					 
					
						2024-02-11 20:27:39 -08:00 
						 
				 
			
				
					
						
							
							
								Douglas Eichelberger 
							
						 
					 
					
						
						
						
						
							
						
						
							5b5cfe89de 
							
						 
					 
					
						
						
							
							Resolve violations from removing hidden.rbi  
						
						
						
						
					 
					
						2024-02-11 20:27:38 -08:00 
						 
				 
			
				
					
						
							
							
								Michael Cho 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							0ff2458952 
							
						 
					 
					
						
						
							
							extend/ENV/shared: effective_arch as public API  
						
						
						
						
					 
					
						2024-01-13 15:26:38 -05:00 
						 
				 
			
				
					
						
							
							
								Mike McQuaid 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							ff404fe5ab 
							
						 
					 
					
						
						
							
							Merge pull request  #16184  from dduugg/rm-try  
						
						... 
						
						
						
						Remove use of ActiveSupport try 
						
						
					 
					
						2023-11-06 13:11:01 +00:00 
						 
				 
			
				
					
						
							
							
								Shu Niu 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							2809678f77 
							
						 
					 
					
						
						
							
							Fix TypeError with gcc compiler in deprecated MacOS  
						
						... 
						
						
						
						In some deprecated MacOS, e.g.10.13 High Sierra, when compiling formulae with --cc=gcc-XX, homebrew will raise "TypeError: Return value: Expected type Symbol, got type String with value".
Convert "other" string to symbol to solve this. 
						
						
					 
					
						2023-11-06 14:08:41 +08:00 
						 
				 
			
				
					
						
							
							
								Douglas Eichelberger 
							
						 
					 
					
						
						
						
						
							
						
						
							00ba09d73d 
							
						 
					 
					
						
						
							
							Remove use of ActiveSupport try  
						
						
						
						
					 
					
						2023-11-05 09:28:19 -08:00 
						 
				 
			
				
					
						
							
							
								Tokarak 
							
						 
					 
					
						
						
						
						
							
						
						
							2133da8597 
							
						 
					 
					
						
						
							
							Set target-cpu through RUSTFLAGS  
						
						
						
						
					 
					
						2023-06-14 17:26:01 +01:00 
						 
				 
			
				
					
						
							
							
								Douglas Eichelberger 
							
						 
					 
					
						
						
						
						
							
						
						
							24cf6076e8 
							
						 
					 
					
						
						
							
							brew style --fix  
						
						
						
						
					 
					
						2023-04-24 20:42:39 -07:00 
						 
				 
			
				
					
						
							
							
								Mike McQuaid 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							612c27cd2d 
							
						 
					 
					
						
						
							
							extend/ENV/shared: use try.  
						
						... 
						
						
						
						`version_suffix` exists (or doesn't) depending on the GCC formula being
available and not loaded from the API. 
						
						
					 
					
						2023-01-25 16:07:23 +00:00 
						 
				 
			
				
					
						
							
							
								Lukas Oberhuber 
							
						 
					 
					
						
						
						
						
							
						
						
							cd9fe97c55 
							
						 
					 
					
						
						
							
							Improve style  
						
						
						
						
					 
					
						2022-07-30 11:10:26 +01:00 
						 
				 
			
				
					
						
							
							
								Lukas Oberhuber 
							
						 
					 
					
						
						
						
						
							
						
						
							c2a95f077f 
							
						 
					 
					
						
						
							
							Compiler -g flag set based on --debug-symbols  
						
						
						
						
					 
					
						2022-07-26 17:18:01 +01:00 
						 
				 
			
				
					
						
							
							
								Lukas Oberhuber 
							
						 
					 
					
						
						
						
						
							
						
						
							d195f22522 
							
						 
					 
					
						
						
							
							Connecting up --debug-symbols flag  
						
						... 
						
						
						
						This connects the calling of dsymutil and the retention of temporary
files. Still need to connect compilation to flag. 
						
						
					 
					
						2022-07-26 12:15:53 +01:00 
						 
				 
			
				
					
						
							
							
								Rylan Polster 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							2e6b6ab3a2 
							
						 
					 
					
						
						
							
							Fix style  
						
						
						
						
					 
					
						2021-12-24 21:15:21 -05:00 
						 
				 
			
				
					
						
							
							
								Mike McQuaid 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							30a65342e8 
							
						 
					 
					
						
						
							
							Deprecate, disable, delete code for Homebrew 3.2.0  
						
						... 
						
						
						
						Do the usual deprecation, disable, delete dance for Homebrew 3.2.0. 
						
						
					 
					
						2021-06-17 11:34:32 +01:00 
						 
				 
			
				
					
						
							
							
								Bo Anderson 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							1e567161d1 
							
						 
					 
					
						
						
							
							ENV/shared: specify which Perl version we want to use  
						
						
						
						
					 
					
						2021-05-10 05:50:02 +01:00 
						 
				 
			
				
					
						
							
							
								Mike McQuaid 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							d73351251c 
							
						 
					 
					
						
						
							
							Deprecate, disable, delete code for next major/minor version.  
						
						... 
						
						
						
						Do the usual dance for bumping our major/minor version. 
						
						
					 
					
						2021-04-09 09:30:36 +01:00 
						 
				 
			
				
					
						
							
							
								Bo Anderson 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							65c03573c6 
							
						 
					 
					
						
						
							
							ENV: fix missing arg for generic OS and correct type sigs  
						
						
						
						
					 
					
						2021-02-26 18:23:48 +00:00 
						 
				 
			
				
					
						
							
							
								Mike McQuaid 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							39b3bcdce4 
							
						 
					 
					
						
						
							
							Undeprecate ENV.O1/ENV.O0  
						
						... 
						
						
						
						These are still used in Homebrew/homebrew-core. The others are either
- default (Os on macOS, O2 on Linux)
- less reliable than the default (O3)
While we're here, also remove an outdated `ncurses_define` comment. 
						
						
					 
					
						2021-02-08 11:11:21 +00:00 
						 
				 
			
				
					
						
							
							
								Mike McQuaid 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							d6957a3acb 
							
						 
					 
					
						
						
							
							Homebrew 3.0.0 deprecations/disables  
						
						
						
						
					 
					
						2021-01-29 19:50:24 +00:00 
						 
				 
			
				
					
						
							
							
								Mike McQuaid 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							6c68e4bcb9 
							
						 
					 
					
						
						
							
							Merge pull request  #10432  from iMichka/shared2  
						
						... 
						
						
						
						ENV.shared: deprecate ncurses_define 
						
						
					 
					
						2021-01-27 08:55:10 +00:00 
						 
				 
			
				
					
						
							
							
								Michka Popoff 
							
						 
					 
					
						
						
						
						
							
						
						
							acb77e71f9 
							
						 
					 
					
						
						
							
							ENV.shared: deprecate ncurses_define  
						
						... 
						
						
						
						This was only used by 2 formuale in homebrew-core.
One formula did not need the flag anymore and the flag was removed
The other formula (rogue) still needs it, the flag was directly
added to the formula.
There is no reason for us to keep this method. 
						
						
					 
					
						2021-01-26 23:09:57 +01:00 
						 
				 
			
				
					
						
							
							
								EricFromCanada 
							
						 
					 
					
						
						
						
						
							
						
						
							6fc116318e 
							
						 
					 
					
						
						
							
							fixes for grammar and wording  
						
						
						
						
					 
					
						2021-01-26 16:19:47 -05:00 
						 
				 
			
				
					
						
							
							
								EricFromCanada 
							
						 
					 
					
						
						
						
						
							
						
						
							571179ff0e 
							
						 
					 
					
						
						
							
							pass second argument to ohai when applicable  
						
						
						
						
					 
					
						2021-01-26 15:36:43 -05:00 
						 
				 
			
				
					
						
							
							
								Seeker 
							
						 
					 
					
						
						
						
						
							
						
						
							fbafaff4fe 
							
						 
					 
					
						
						
							
							rubocop: require braces for Sorbet sig  
						
						
						
						
					 
					
						2021-01-18 16:52:45 -08:00 
						 
				 
			
				
					
						
							
							
								Jonathan Chang 
							
						 
					 
					
						
						
						
						
							
						
						
							1b6fb8f460 
							
						 
					 
					
						
						
							
							ENV/shared: widen type  
						
						
						
						
					 
					
						2020-12-08 20:54:10 +11:00 
						 
				 
			
				
					
						
							
							
								Mike McQuaid 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							9216d8abe6 
							
						 
					 
					
						
						
							
							rubocop-rails: make fixes.  
						
						
						
						
					 
					
						2020-12-02 10:43:04 +00:00 
						 
				 
			
				
					
						
							
							
								Markus Reiter 
							
						 
					 
					
						
						
						
						
							
						
						
							0424940496 
							
						 
					 
					
						
						
							
							Add types for ENV extensions.  
						
						
						
						
					 
					
						2020-11-23 02:06:37 +01:00 
						 
				 
			
				
					
						
							
							
								EricFromCanada 
							
						 
					 
					
						
						
						
						
							
						
						
							3768b7a6e9 
							
						 
					 
					
						
						
							
							apidoc: update comment wording, punctuation, formatting  
						
						
						
						
					 
					
						2020-11-06 00:21:02 -05:00 
						 
				 
			
				
					
						
							
							
								EricFromCanada 
							
						 
					 
					
						
						
						
						
							
						
						
							dddfbf80fc 
							
						 
					 
					
						
						
							
							apidoc: add/update yard tags  
						
						
						
						
					 
					
						2020-11-06 00:16:35 -05:00 
						 
				 
			
				
					
						
							
							
								Markus Reiter 
							
						 
					 
					
						
						
						
						
							
						
						
							24ae318a3d 
							
						 
					 
					
						
						
							
							Move type annotations into files.  
						
						
						
						
					 
					
						2020-10-10 14:59:39 +02:00 
						 
				 
			
				
					
						
							
							
								Markus Reiter 
							
						 
					 
					
						
						
						
						
							
						
						
							e3646c9b4e 
							
						 
					 
					
						
						
							
							Remove unneeded back-references.  
						
						
						
						
					 
					
						2020-09-19 02:03:56 +02:00 
						 
				 
			
				
					
						
							
							
								Markus Reiter 
							
						 
					 
					
						
						
						
						
							
						
						
							276c570c16 
							
						 
					 
					
						
						
							
							Pass individual args explicitly to ENV extensions.  
						
						
						
						
					 
					
						2020-07-28 02:52:45 +02:00 
						 
				 
			
				
					
						
							
							
								Markus Reiter 
							
						 
					 
					
						
						
						
						
							
						
						
							25b3632c4c 
							
						 
					 
					
						
						
							
							Pass args to ENV instead of using global args.  
						
						
						
						
					 
					
						2020-07-25 03:57:43 +02:00 
						 
				 
			
				
					
						
							
							
								Mike McQuaid 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							e5d15c8b19 
							
						 
					 
					
						
						
							
							Merge branch 'master' into argv-cleanup-26  
						
						
						
						
					 
					
						2020-05-23 13:44:42 +01:00 
						 
				 
			
				
					
						
							
							
								Mike McQuaid 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							3588e6a5c6 
							
						 
					 
					
						
						
							
							bottle_arch: ensure a symbol is used when needed.  
						
						... 
						
						
						
						Fixes  #7597 . 
					
						2020-05-19 08:47:59 +01:00 
						 
				 
			
				
					
						
							
							
								Mike McQuaid 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							1c656fb584 
							
						 
					 
					
						
						
							
							Merge pull request  #7538  from MikeMcQuaid/bottle_arch  
						
						... 
						
						
						
						Replace ARGV#bottle_arch with Homebrew.args.bottle_arch 
						
						
					 
					
						2020-05-11 08:46:57 +01:00 
						 
				 
			
				
					
						
							
							
								Mike McQuaid 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							5f721c6986 
							
						 
					 
					
						
						
							
							Cleanup ARGV.include? usage  
						
						... 
						
						
						
						Remove usage where `Homebrew.args` could be used instead or, due to the
`Homebrew.args` parsing, there was dead code that was never executed
(and no-one complained about not working). 
						
						
					 
					
						2020-05-10 15:28:31 +01:00 
						 
				 
			
				
					
						
							
							
								Mike McQuaid 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							07b19cba09 
							
						 
					 
					
						
						
							
							Replace ARGV#bottle_arch with Homebrew.args.bottle_arch  
						
						... 
						
						
						
						Part of https://github.com/Homebrew/brew/issues/5730  
						
						
					 
					
						2020-05-10 15:15:41 +01:00 
						 
				 
			
				
					
						
							
							
								Mike McQuaid 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							20a1199375 
							
						 
					 
					
						
						
							
							Refactor CLI to remove unless args_parsed  
						
						... 
						
						
						
						Refactor the CLI::Args module so it doesn't have different paths to
check arguments depending on whether the arguments have been parsed or
not. Instead, set the values we need from the global ARGV at
first, global initialisation time where they will be thrown away when
the actual arguments are parsed.
To do this some other general refactoring was needed:
- more methods made private when possible
- e.g. `HEAD?` used consistently instead of `head` before arguments
  are parsed.
- formula options are only parsed after named arguments are extracted 
						
						
					 
					
						2020-05-05 17:47:51 +01:00 
						 
				 
			
				
					
						
							
							
								Gautham G 
							
						 
					 
					
						
						
						
						
							
						
						
							b40e33aeb8 
							
						 
					 
					
						
						
							
							ARGV: Deprecate ARGV.cc and replace with Homebrew.args.cc  
						
						
						
						
					 
					
						2020-05-04 11:14:55 +05:30 
						 
				 
			
				
					
						
							
							
								Gautham G 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							b0ac5bab31 
							
						 
					 
					
						
						
							
							ARGV: Deprecate ARGV.build_bottle? and replace with Homebrew.args.build_bottle  
						
						
						
						
					 
					
						2020-04-26 13:28:44 +01:00 
						 
				 
			
				
					
						
							
							
								Mike McQuaid 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							1e265247ca 
							
						 
					 
					
						
						
							
							rubocop: apply autofixes.  
						
						
						
						
					 
					
						2020-03-13 21:16:18 +00:00 
						 
				 
			
				
					
						
							
							
								Issy Long 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							1f6168fe8a 
							
						 
					 
					
						
						
							
							Change regexp.match?(string) to string.match?(regexp) everywhere  
						
						... 
						
						
						
						- Only try to call `.match?` on strings that aren't nil. 
						
						
					 
					
						2019-10-13 23:22:51 +01:00 
						 
				 
			
				
					
						
							
							
								Issy Long 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							341ea60807 
							
						 
					 
					
						
						
							
							Auto-fix Style/RedundantBegin offenses  
						
						... 
						
						
						
						- This also required auto-fixes for Layout/EmptyLinesAroundBlockBody and
  Layout/InconsistentIndentation once the auto-fixer had got rid of the
  "redundant begin"s. 
						
						
					 
					
						2019-10-13 16:04:27 +01:00 
						 
				 
			
				
					
						
							
							
								Issy Long 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							b78028b9c2 
							
						 
					 
					
						
						
							
							Auto-fix Performance/RegexpMatch offenses  
						
						
						
						
					 
					
						2019-10-13 16:04:26 +01:00 
						 
				 
			
				
					
						
							
							
								Mike McQuaid 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							36dbad3922 
							
						 
					 
					
						
						
							
							Add frozen_string_literal to all files.  
						
						
						
						
					 
					
						2019-04-20 13:27:36 +09:00 
						 
				 
			
				
					
						
							
							
								EricFromCanada 
							
						 
					 
					
						
						
						
						
							
						
						
							fa6404e0f5 
							
						 
					 
					
						
						
							
							grammar fixes  
						
						
						
						
					 
					
						2019-04-13 21:29:32 -04:00 
						 
				 
			
				
					
						
							
							
								Mike McQuaid 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							1aa8ad09e2 
							
						 
					 
					
						
						
							
							Deprecate macOS versions below Mavericks  
						
						... 
						
						
						
						And remove all dead/unneeded code. 
						
						
					 
					
						2019-01-27 12:27:47 +00:00 
						 
				 
			
				
					
						
							
							
								Mike McQuaid 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							170c5493a4 
							
						 
					 
					
						
						
							
							Update deprecations  
						
						... 
						
						
						
						- Add some `odeprecated`
- Make some `odeprecated` now `odisabled`
- Remove `odisabled` code.
- Remove old update migrations
- Remove GCC 4.0 compiler
- Remove Tiger-only code
- Remove 32-bit-only code
- Remove use of LD64
- Remove GCC 4.3 - 4.8 support. 
						
						
					 
					
						2019-01-08 19:13:46 +00:00 
						 
				 
			
				
					
						
							
							
								Mike McQuaid 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							7e13b37495 
							
						 
					 
					
						
						
							
							ENV: default CFLAGS to bottle values.  
						
						... 
						
						
						
						This reduces the deviation in compilation flags on a given OS between
users and between bottling/not bottling to provide a consistent
behaviour for debugging and support. 
						
						
					 
					
						2019-01-06 21:27:15 +00:00