admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
20,962 Commits 15 Branches 471 Tags
Commit Graph

17464 Commits

Author SHA1 Message Date
Sean Molenaar
3567892802
Add notibility checks for casks 2020-05-26 14:21:25 +02:00
April Arcus
0b4febceaf fix undefined variable interpolation in tcsh 2020-05-25 10:46:10 -07:00
Issy Long
d14eed6cec
audit: Remove call to deprecated created_pr_comment method 
```
➜ brew audit --online --new-formula --verbose turbogit
turbogit:
  * GitHub repository not notable enough (<30 forks, <30 watchers and <75 stars)
  * GitHub repository too new (<30 days old)
Error: undefined local variable or method `created_pr_comment' for Homebrew:Module
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:148:in `audit'
/usr/local/Homebrew/Library/Homebrew/brew.rb:110:in `<main>'
```

- This was removed in 4f75a77b089e65ff9e03c65d192808aa4ea6842f. We can't
  post PR comments from GitHub Actions CI from forks.
 2020-05-25 13:00:38 +01:00
Issy Long
0cced8e7bd
audit: Fix Regexp for stripping .git from repo URLs 
- [For a formula named
  turbogit](https://github.com/Homebrew/homebrew-core/pull/55208), we
  didn't see any of the notability checks fail CI.
- The repo name was getting truncated to `turb`, which didn't exist, so
  the audit didn't return anything for this check.
- The Regexp to strip `.git` from the end of was not escaping the `.`,
  so it would match anything ending in `git`, not a literal `.git`.
 2020-05-25 12:48:16 +01:00
nandahkrishna
6f37dc4c41
livecheck: modified urls cop 2020-05-24 20:16:44 +05:30
Mike McQuaid
ef95b59ed4
Remove HomebrewArgvExtension 
Fixes #5730
 2020-05-23 19:39:11 +01:00
Mike McQuaid
fd343c0578
cmd/info: fix missing formula reference. 
Fixes #7639
 2020-05-23 16:32:39 +01:00
Mike McQuaid
bc27e38f18
Remove ARGV.debug? 
Replace with `Homebrew.args.debug?`.

Part of #5730.
 2020-05-23 14:38:58 +01:00
Mike McQuaid
e1f3c8d2b3
Merge pull request #7579 from MikeMcQuaid/deprecations 
Update deprecations
 2020-05-23 14:38:10 +01:00
Mike McQuaid
64602bc8ef
Merge branch 'master' into argv-env 2020-05-23 14:10:44 +01:00
Mike McQuaid
183670296f
Merge pull request #7493 from GauthamGoli/argv-cleanup-26 
ARGV: Deprecate ARGV.cc and replace with Homebrew.args.cc
 2020-05-23 14:10:20 +01:00
Mike McQuaid
d5ff4f5327
Remove ARGV.env 
Replace with `Homebrew.args.env`.

Part of #5730.
 2020-05-23 13:49:38 +01:00
Mike McQuaid
e5d15c8b19
Merge branch 'master' into argv-cleanup-26 2020-05-23 13:44:42 +01:00
Mike McQuaid
11cf77be17
formula_installer: prelude before fetch. 
This ensures that dependencies are verified and tapped before they are
fetched. `FormulaInstaller#lock` has been moved into
`FormulaInstaller#install` to avoid locking until necessary.

While we're here, don't compute dependencies before fetching if we're
not going to use them.
 2020-05-23 13:40:13 +01:00
Mike McQuaid
e9d45a6692
Merge pull request #7634 from zmwangx/bump-formula-pr-fix-formula-guessing 
bump-formula-pr: fix forking error when formula is guessed from url
 2020-05-23 13:10:21 +01:00
Zhiming Wang
83fa24741e
bump-formula-pr: fix forking error when formula is guessed from url 
Regression introduced in f90612ccf0db03681dc6cbf6585cca5bc27b84b1 (#6718).

`tap_full_name` returned from `use_correct_linux_tap` has been
required (`GitHub.create_fork(tap_full_name)`), but it was never set when the
formula is guessed from args.url, resulting in an API request to
https://api.github.com/repos//forks which 404s (note the missing :owner/:repo),
and subsequently

    Error: Unable to fork: Not Found!
 2020-05-23 14:20:35 +08:00
Bo Anderson
6b06043289 formula_installer: fix pruning of test deps also marked as build 2020-05-23 00:05:20 +01:00
Mike McQuaid
e10ade758d
Revert "formulary: install tap if needed." 2020-05-22 16:19:30 +01:00
Mike McQuaid
61b48d8557
formulary: install tap if needed. 
This matches what `cask_loader` does and is low risk given we no longer
allow tap pinning.

Fixes #7626
 2020-05-22 14:21:40 +01:00
Mike McQuaid
ca47992a6c
Fix rubocop-performance brew style. 2020-05-22 08:52:26 +01:00
Mike McQuaid
d02b15d31a
brew vendor-gems: commit updates. 2020-05-22 08:30:19 +01:00
dependabot-preview[bot]
bab32515fa
build(deps): bump rubocop-performance in /Library/Homebrew 
Bumps [rubocop-performance](https://github.com/rubocop-hq/rubocop-performance) from 1.5.2 to 1.6.0.
- [Release notes](https://github.com/rubocop-hq/rubocop-performance/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-performance/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-performance/compare/v1.5.2...v1.6.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-05-22 05:34:28 +00:00
Markus Reiter
a7a8569d70
Merge pull request #7607 from reitermarkus/cask-help-usage 
Implement `brew cask help <command>`.
 2020-05-21 21:02:02 +02:00
Mike McQuaid
e33dc9e916
utils: brew style --fix. 2020-05-21 10:15:34 +01:00
dependabot-preview[bot]
abd61f176e
build(deps): bump rubocop from 0.83.0 to 0.84.0 in /Library/Homebrew 
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.83.0 to 0.84.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.83.0...v0.84.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-05-21 08:50:50 +00:00
Mike McQuaid
bb44b71647
Merge pull request #7619 from mathaeus/migrate_vcs_scheme_checks_to_rubocop 
audit: Migrate scheme checks for `cvs`, `bzr`, `hg`, `fossil` and `svn+http` to `Rubocop` + add tests
 2020-05-21 08:22:13 +01:00
Mathäus Zingerle
bb9665ced8 Migrate scheme checks for cvs, bzr, hg, fossil, and svn+http to Rubocop 2020-05-20 20:52:00 -05:00
Bo Anderson
a3f589801f formula_installer: fix build/test reqs not being pruned correctly 
Fixes #7618.
 2020-05-20 23:39:30 +01:00
Bo Anderson
6ac9d43599 formula_installer: fix already-satisfied test deps not being pruned 2020-05-20 13:28:10 +01:00
Mike McQuaid
bfc081ee0b
Merge pull request #7613 from MikeMcQuaid/requirement_test 
formula_installer: fix :test requirement expansion.
 2020-05-20 12:55:55 +01:00
Mike McQuaid
89a0984d42
formula_installer: fix :test requirement expansion. 2020-05-20 12:24:54 +01:00
Mike McQuaid
0ea2c5f15b
os/mac/diagnostic: suggest untapping phinze/cask. 
As seen in https://github.com/Homebrew/brew/issues/7605.
 2020-05-20 10:05:23 +01:00
Mike McQuaid
d254730e78
Merge pull request #7610 from MikeMcQuaid/bad-todo 
audit: remove incorrect TODO.
 2020-05-20 09:41:01 +01:00
Mike McQuaid
ceb3513b86
Merge pull request #7609 from Bo98/include_test-dependents 
Further test dep fixes
 2020-05-20 08:22:57 +01:00
Mike McQuaid
633501ab08
audit: remove incorrect TODO. 
This check can't really be in RuboCop (as it relies on the URL strategy
logic).
 2020-05-20 08:17:14 +01:00
Mike McQuaid
1ebb1c2885
Merge pull request #7580 from tharun208/brew-cask-analytics 
Added analytics for cask info
 2020-05-20 08:06:46 +01:00
Bo Anderson
5b5833c33b dependency: return test deps on all levels 
Filtering for this is now handled properly in places where this function is used.

In some scenarios, we _want_ test deps on more than the first level (Homebrew.args.include_formula_test_deps?).
 2020-05-19 19:17:17 +01:00
Bo Anderson
b8ba083e12 dependencies: fix recursive_includes not handling deps of test deps 2020-05-19 19:14:48 +01:00
Bo Anderson
a2939be08a formula_installer: don't propagate --include-test unless requested 2020-05-19 19:12:47 +01:00
Markus Reiter
7f400d8e4e Fix brew cask <command> --help. 2020-05-19 19:30:46 +02:00
Markus Reiter
6d9a20614a Implement brew cask help <command>. 2020-05-19 19:23:31 +02:00
Tharun
aeede8374f fixed review changes 2020-05-19 21:41:02 +05:30
Mike McQuaid
b2fc8ad7b3
Merge pull request #7585 from hyuraku/brew_doctor-shows-deleted_formulae 
brew doctor shows deleted formulae
 2020-05-19 17:07:32 +01:00
hyuraku
38e0aa8800 change condition 2020-05-19 23:58:33 +09:00
Tharun
84f2edc884 replaced json and used dictionary 2020-05-19 19:35:30 +05:30
Mike McQuaid
8b98ed1f47
Further tweak :test dependency handling 
- ensure that cases where `:build` and `:test` both apply to a
  dependency that we handle it appropriately
- fix reintroduced regression
  (https://github.com/Homebrew/brew/pull/6471#issuecomment-533414923).
  Fixes #6470.
 2020-05-19 14:25:10 +01:00
hyuraku
c263c755aa check tap_path size 2020-05-19 22:22:31 +09:00
Tharun
6a50f31feb fixed proper parsing of mock data for analytics 2020-05-19 17:25:16 +05:30
Tharun
7186600a5c renamed get_formulae_api 2020-05-19 14:59:43 +05:30
Tharun
9e26a451e3 Updated mocking analytics call 2020-05-19 14:58:55 +05:30