29821 Commits

Author SHA1 Message Date
Joe Sweeney
a61cb1a4d0
Set GitHub workflow output correctly
Co-authored-by: Bo Anderson <mail@boanderson.me>
2024-01-25 11:45:20 -05:00
Joseph Sweeney
0b0d9a6066 Add option to retain tmpdir on pr-pull
This option will be used to generate build provenance in the
`publish-commit-bottles.yml` workflow in `Homebrew/homebrew-core`. It
adds a single flag that controls whether or not the temporary directory
where bottles are downloaded is retained.
2024-01-25 10:35:59 -05:00
Mike McQuaid
b855a9eae8
Merge pull request #16071 from Homebrew/pkg_tweaks
workflows/build-pkg: tweak some variables.
2023-10-02 16:55:51 +01:00
Mike McQuaid
def7ab4103
brew.sh: improve/add comment for supported macOSs. 2023-10-02 16:41:51 +01:00
Mike McQuaid
d2f07f884d
Merge pull request #16069 from apainintheneck/handle-name-conflicts-in-to_paths
cli/named_args: better handle name conflicts in #to_paths
2023-10-02 12:45:12 +01:00
apainintheneck
23b277bbd7 cli/named_args: better handle name conflicts in #to_paths
Before we used to evaluate all named arguments as local paths
first. This means that the following could be a name conflict.

$ brew edit src

If there was a local file or directory named src, it would default
to that. Otherwise it would search for a formula/cask with the
same name and return that.

Now it will only default to the local path if the named argument
starts or ends with a slash ('/') or includes a period ('.').
This means that in the event of a name clash with a normal package
name it will default to the package instead of the local file.

It also fixes an edge case where the following would be interpreted
as a tap name.

$ brew edit /src
2023-10-01 15:51:02 -07:00
Mike McQuaid
affc4c01aa
Merge pull request #16068 from J-M0/fish-shellenv
fix `eval (brew shellenv)` from exiting with status 1 in fish
2023-10-01 18:58:57 +01:00
Mike McQuaid
c325404054
Merge pull request #16061 from MikeMcQuaid/sudo_through_sudo_user
Add HOMEBREW_SUDO_THROUGH_SUDO_USER
2023-10-01 16:04:21 +01:00
Mike McQuaid
a0805d8678
Merge pull request #16059 from MikeMcQuaid/whoami
Improve use of `whoami`
2023-10-01 16:04:00 +01:00
James Morris
793831cb93 fix eval (brew shellenv) from exiting with status 1 in fish
fish's `set` doesn't modify the exit status when assigning a variable.
This means that `set -q VAR; or set VAR ...` will return an exit status
of 1 even if the variable is suceessfully set. By switching the commands
to `! set -q VAR; and set VAR ...`, this prevents the 1 from propogating
when running `eval (brew shellenv)`.
2023-09-30 17:39:39 -04:00
Mike McQuaid
eb1355e624
Add HOMEBREW_SUDO_THROUGH_SUDO_USER
This environment variable allows telling Homebrew to use the `SUDO_USER`
variable to `sudo` through that user when Homebrew (Cask) attempts to
run `sudo`.

While we're here, clarify in some messaging that we're running `sudo`
and that that's the password we're asking for; the specific password is
configuration dependent and not the specific password for the user.

Similarly, remove the `Package installers may write to any location`
output; it's kinda spammy and doesn't feel like the right place.
2023-09-29 18:49:44 +01:00
Mike McQuaid
39bbc33a27
Improve use of whoami
If you're e.g. running Homebrew over `sudo`: shelling out to `whoami`
is less effective than just telling people which user you're running
as when we run the check.
2023-09-29 12:32:22 +01:00
Bo Anderson
af7d744af0
Fixes for Ruby 3 2023-09-29 05:25:48 +01:00
Bo Anderson
71f558229a
Test on Ruby 3.1 2023-09-29 04:46:16 +01:00
Bo Anderson
daa49a1323
Install gems automatically on newer Ruby 2023-09-29 01:34:39 +01:00
Bo Anderson
1f86ad4b0f
standalone/load_path: rename to init 2023-09-29 01:26:31 +01:00
Kevin
653f333d73
Revert "service: support multiple sockets in DSL" 2023-09-28 09:58:03 -07:00
Bo Anderson
9bd8087982
readall: check hash generation works 2023-09-28 14:51:45 +01:00
Mike McQuaid
6b01bc1773
Merge pull request #16007 from Bo98/better-readall
Improve performance of `brew readall`
2023-09-28 14:44:21 +01:00
Bo Anderson
0c08a3cccb
Improve performance of Formula#to_hash 2023-09-28 14:07:25 +01:00
Bo Anderson
e4623cc8f4
Improve performance of brew readall 2023-09-28 14:05:09 +01:00
Mike McQuaid
eadbe0f184
Merge pull request #16051 from apainintheneck/expand-paths-in-to-paths
cli/named_args: expand paths in #to_paths
2023-09-28 12:41:32 +01:00
Mike McQuaid
9359f95b64
Merge pull request #16026 from apainintheneck/support-multiple-sockets-in-service-dsl
service: support multiple sockets in DSL
2023-09-28 12:41:08 +01:00
apainintheneck
b1c47969a6 cli/named_args: expand paths in #to_paths
This will make the output clearer for `brew edit --print-path`.
2023-09-27 23:16:20 -07:00
apainintheneck
5fb9f90457 service: prefer symbols over strings in DSL
This is more in keeping with the other DSL methods and Ruby
convention along with the fact that these socket names are
just used internally by launchd.
2023-09-27 22:30:30 -07:00
BrewTestBot
3ddf12e960
sorbet: Update RBI files.
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
2023-09-28 00:25:23 +00:00
Bo Anderson
92d2cec5fa
Merge pull request #16048 from Bo98/pr_upload-group-fix
Gemfile: fix pr_upload group typo
2023-09-27 20:29:36 +01:00
Bo Anderson
44ea3b217d
Gemfile: fix pr_upload group typo 2023-09-27 20:12:47 +01:00
Bo Anderson
22cb5dbf02
utils/gems: redirect bundler output to stderr 2023-09-27 20:05:03 +01:00
Mike McQuaid
4ec5f04e9a
Merge pull request #15953 from Bo98/more-groups
Further split up Gemfile into groups
2023-09-27 19:20:55 +01:00
Mike McQuaid
67fab9ae07
Merge pull request #16046 from Bo98/to_paths-only-fix
cli/named_args: don't interpret `--formula`/`--cask` args as paths
2023-09-27 19:20:26 +01:00
Bo Anderson
ba2ecede1a
cli/named_args: don't interpret --formula/--cask args as paths 2023-09-27 17:56:42 +01:00
Bo Anderson
835ebedd18
dev-cmd/unbottled: speed up dependent fetching 2023-09-27 17:45:29 +01:00
Bo Anderson
3b1c171184
Further split up Gemfile into groups 2023-09-27 17:33:44 +01:00
Mike McQuaid
d799bd449c
Merge pull request #16043 from MikeMcQuaid/cli_parser_env_external_commands
cli/parser: check env var directly if there's no `EnvConfig` method.
2023-09-27 12:50:29 +01:00
Mike McQuaid
c2841e2998
Merge pull request #16042 from MikeMcQuaid/rubocop_no_minitest
rubocop: don't recommend minitest extension.
2023-09-27 12:47:10 +01:00
Mike McQuaid
58f8832a7e
cli/parser: check env var directly if there's no EnvConfig method.
Before this change, external commands, whether official or not, cannot
use the `env:` DSL for `Homebrew::CLI::Parser` without adding their
environment variable to `Homebrew::EnvConfig`.

Instead, if the method is not defined, check the environment variable
directly. This allows `env:` to be used as expected and allows
simplifying some (new) code in e.g. `brew bundle`.
2023-09-27 12:28:24 +01:00
Mike McQuaid
2243edaca3
rubocop: don't recommend minitest extension.
We don't use or need it.
2023-09-27 11:56:11 +01:00
Mike McQuaid
67be775fd9
Merge pull request #16029 from abitrolly/edit-simplify
dev-cmd/edit: Move path specific functions to Pathname
2023-09-27 11:37:47 +01:00
Anatoli Babenia
0c51aea403 Fix typecheck errors 2023-09-27 12:49:37 +03:00
Anatoli Babenia
071a684b25 Replace refinements with local methods 2023-09-27 12:39:03 +03:00
Mike McQuaid
d20bcea146
Merge pull request #16039 from apainintheneck/load-formulae-from-files-in-audit
dev-cmd/audit: load formulae from files
2023-09-27 09:08:48 +01:00
Anatoli Babenia
10a55ec4e1
Rename fail_with_message to raise_with_message! 2023-09-27 08:27:13 +03:00
apainintheneck
5859fcce44 dev-cmd/audit: load formulae from files
This is a test to see if this will fix some flaky checks on CI
that are caused by missing formulae while auditing the core tap.

- https://github.com/Homebrew/brew/issues/16037
2023-09-26 20:37:41 -07:00
Bo Anderson
582049454f
vendor/bundle/ruby: cleanup unneeded files 2023-09-26 18:39:57 +01:00
Mike McQuaid
39f76d6351
Merge pull request #16038 from MikeMcQuaid/brew_env_no_expansion
manpage: note env files do not support expansion.
2023-09-26 13:22:40 +01:00
Mike McQuaid
10c47af8c7
manpage: note env files do not support expansion.
Fixes #16027
2023-09-26 13:09:46 +01:00
Mike McQuaid
9d23bcc871
Merge pull request #16035 from Homebrew/dependabot/bundler/Library/Homebrew/zeitwerk-2.6.12
build(deps): bump zeitwerk from 2.6.11 to 2.6.12 in /Library/Homebrew
2023-09-26 11:57:15 +01:00
Anatoli Babenia
2445b687c6 Use any? to check for warning message and fix brew style 2023-09-26 10:10:47 +03:00
BrewTestBot
4acd736aba
Update RBI files for zeitwerk.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2023-09-25 19:14:08 +00:00