Daiki Mizukami
deaac7ce47
Use Utils::Cp to copy files
...
This replaces `FileUtils.cp` and `system_command! "cp"` with the new
`Utils::Cp` utility where it is expected that the performance
improvement outweighs the cost of the system command invocation.
2024-05-27 12:11:41 +09:00
Mike McQuaid
7e35ae25d5
cask/utils: quieten down when fixing permissions fails.
...
When fixing permissions fails, we should not print the error messages
from e.g. `chmod` unless we are in debug or verbose mode (because we
immediately retry taking ownership `sudo`).
2024-04-01 16:22:42 +01:00
Bo Anderson
011dfc8f45
cask/artifact/moved: fix permission handling when removing directories
2024-03-15 21:31:37 +00:00
Mike McQuaid
ea2892f8ee
brew.rb: handle missing args.
2024-03-07 16:20:20 +00:00
Douglas Eichelberger
26eda5a303
git grep -l '^describe' | xargs gsed -i 's|^describe|RSpec.describe|g'
2024-02-19 13:57:27 +00:00
Bo Anderson
5692c8ecbf
Fix style violations under newer RuboCop
2023-12-14 05:47:12 +00:00
JBYoshi
97b9b61061
Change permission failure from fatal to warning.
2023-05-26 11:13:23 -05:00
JBYoshi
40352cb2da
Make Homebrew check for App Management permissions before updating apps.
2023-05-24 22:11:16 -05:00
Markus Reiter
d7a0e260e8
Improve Cask::Utils.gain_permissions_remove for symlinks.
2023-05-13 03:54:48 +02:00
JBYoshi
b1c7f12fbb
Clean up allow and expect.
2023-05-12 09:57:12 -05:00
JBYoshi
4a3b8923f2
More test cleanup.
2023-05-12 09:52:57 -05:00
JBYoshi
5e23a0563a
Switch base case expect() to allow().
2023-05-11 17:10:41 -05:00
JBYoshi
7a108d3db0
Merge and_call_original instruction into expect() calls.
2023-05-11 17:09:27 -05:00
JBYoshi
84ad387661
Clean up code for feedback.
2023-05-11 13:29:56 -05:00
JBYoshi
a1780c842c
Improve unit test to make sure the sudo version is used.
2023-05-11 12:44:35 -05:00
JBYoshi
2e8232de39
Replace wildcard copy with a loop over children.
...
Fixes one of the errors in https://github.com/orgs/Homebrew/discussions/4498 (specifically "cp: [...].app/*:
No such file or directory").
2023-05-11 11:47:16 -05:00
JBYoshi
a1571702d3
Merge remote-tracking branch 'origin/master' into cask-move-contents
2023-04-25 15:44:29 -05:00
Douglas Eichelberger
9075cbae62
brew style --fix
2023-04-21 09:58:50 -07:00
Douglas Eichelberger
ac1e6ded9a
git grep -l '# typed: false' | xargs gsed -i 's|# typed: false||g'
2023-04-21 09:57:47 -07:00
JBYoshi
9fedaee462
Only keep empty directories when the new version also has them.
2023-04-08 16:13:12 -05:00
JBYoshi
dcc4ae76e8
Also keep app directories with "brew reinstall".
2023-04-04 11:36:27 -05:00
JBYoshi
5c9fa845a8
Add unit test for upgrading.
2023-04-04 10:22:45 -05:00
Issy Long
3a83b5492c
rubocop: Clean up Style/BlockDelimiters excludes and autofix offenses
...
- The defaults of using "do ... end" for multi-line blocks everywhere is
good, better than switching everything to braces everywhere.
2023-03-08 23:54:22 +00:00
Ilya Kulakov
3d16112b14
cask: fix writability check backing up an artifact
2023-01-13 15:30:14 -08:00
Ian Gregory
a715dec49d
Add --adopt switch
...
Allows `brew install` & co. to adopt existing cask artifacts that are
identical to those being installed.
Discussion: #14006
2022-10-21 23:28:51 -04:00
EricFromCanada
6fc116318e
fixes for grammar and wording
2021-01-26 16:19:47 -05:00
Markus Reiter
24ae318a3d
Move type annotations into files.
2020-10-10 14:59:39 +02:00
Markus Reiter
df3bbd0299
Reduce need for interpolating appdir in casks.
2019-10-24 17:07:30 +02:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files.
2019-04-20 13:27:36 +09:00
Markus Reiter
1e1ce1c471
Save config file for casks.
2019-02-15 10:09:14 +01:00
Claudia
5be80a78f6
Use Homebrew-controlled domain for Cask dummy URLs
...
In a number of Cask specs, the value of the `homepage` stanza is currently set
to https://example.com . As of 2018-11-28, the TLS certificate served by
example.com seems to be expired, possibly due to an oversight on ICANN’s side.
While the certificate is certainly going to be renewed soon, it would be
desirable for Homebrew’s test result to be less dependent on ICANN’s actions.
This commit changes the homepages of all test Casks to http://brew.sh , whose
domain and TLS certificate are both controlled by Homebrew.
2018-11-28 20:51:55 +01:00
Markus Reiter
2308f0c571
Skip quitting applications when not logged into GUI.
2018-10-02 16:27:45 +02:00
Mike McQuaid
78eba5b815
Autofix RuboCop RSpec failures
2018-09-20 13:36:42 +01:00
Markus Reiter
a84a1c63db
Rename Hbc module to Cask.
2018-09-06 09:30:52 +02:00
Mike McQuaid
bcb1ec5499
Improve Homebrew/brew line length.
...
Use 124 max line length everywhere. Also, reduce tap max line length to
189 as Homebrew/homebrew-core has that as a maximum now. In future
Homebrew/homebrew-core will also be reduced to 124 maximum line length.
2018-09-02 16:15:09 +01:00
Reto Kromer
456571b15d
fix more insecure protocols
2018-08-06 16:50:42 +02:00
Markus Reiter
28384ba518
Rename Hbc::SystemCommand to SystemCommand.
2018-07-22 21:11:47 +02:00
Mike McQuaid
5e1806e796
test: rubocop-rspec style auto-corrects.
...
There’s too many warnings to start enabling `rubocop-rspec` by default
but let’s at least apply the cleanups it does automatically.
2018-03-25 13:30:37 +01:00
Markus Reiter
6760d26319
Create Hbc::Config class.
2018-01-27 21:47:18 +01:00
Markus Reiter
9bee9ca575
Use “squiggly” heredocs.
2017-10-18 14:39:09 +02:00
Markus Reiter
5cbf8bdaa7
Merge pull request #3283 from reitermarkus/cask-loader
...
Add helper method for Cask fixture paths and refactor CaskLoader.
2017-10-07 18:30:32 +02:00
Markus Reiter
97333df4cb
Add helper method for Cask fixture paths and refactor CaskLoader.
2017-10-07 16:11:25 +02:00
Markus Reiter
e9c587d751
Refactor tests.
2017-10-04 18:52:34 +02:00
Markus Reiter
51a0de6368
Directly save artifacts in DSL.
2017-10-04 18:47:55 +02:00
Markus Reiter
53ecdd843f
Treat every Artifact instance as a single artifact.
2017-09-10 23:12:32 +02:00
Markus Reiter
2ad3a87045
Silence all specs by default.
2017-07-29 20:25:37 +02:00
Markus Reiter
621b67e531
Refactor artifacts.
2017-03-10 09:44:50 +01:00
Markus Reiter
9fc6c7b2be
Move Cask specs into brew tests.
2017-03-05 23:08:14 +01:00
