9707 Commits

Author SHA1 Message Date
Mike McQuaid
a212340cc1 update-report: also migrate Caskroom. 2016-09-19 11:43:11 +01:00
Mike McQuaid
7a9934ffa3 test-bot: brew prune after removing formulae. 2016-09-19 11:24:36 +01:00
Mike McQuaid
8a4f26f952 test-bot: run brew style. 2016-09-19 11:18:10 +01:00
Mike McQuaid
263a8a0b73 style: no args default to Library/Homebrew. 2016-09-19 11:18:10 +01:00
Mike McQuaid
3686243e5a style: don't require HOMEBREW_DEVELOPER to fix. 2016-09-19 11:18:09 +01:00
Mike McQuaid
e79f62b2ea style: allow passing taps as arguments. 2016-09-19 11:18:09 +01:00
Mike McQuaid
515f7b5255 Unify .rubocopy.yml files. 2016-09-19 11:18:09 +01:00
Mike McQuaid
569dbf4d05 utils: skip migration of broken formulae symlinks.
Closes https://github.com/Homebrew/homebrew-core/issues/4973
2016-09-19 10:40:18 +01:00
Mike McQuaid
a2f19f0a67 update-report: tweak migration messaging
References #1023.
2016-09-19 09:52:13 +01:00
Mike McQuaid
a09799f25a os/mac: fall back to old environment.
Can't see how this could ever happen but let's safe-guard it just in
case (as ilovezfs saw it).
2016-09-19 09:17:35 +01:00
Mike McQuaid
6e1312d4a1 Merge pull request #1011 from MikeMcQuaid/migrate-legacy-repository-everyone
update-report: migrate everyone to new repository.
2016-09-19 09:05:14 +01:00
Mike McQuaid
167af26a24 Merge pull request #1019 from MikeMcQuaid/macos-rename
Use new "macOS" naming where appropriate.
2016-09-19 08:17:36 +01:00
Mike McQuaid
7e7a714505 Merge pull request #1021 from MikeMcQuaid/update-migration-remove-cask
update-report: remove cask dir after migration.
2016-09-19 08:16:26 +01:00
Mike McQuaid
954de55323 Merge pull request #1022 from MikeMcQuaid/keg-prune-linked
keg: only prune var/homebrew/linked.
2016-09-19 08:16:13 +01:00
Mike McQuaid
e4fb2ce3bd Merge pull request #1015 from MikeMcQuaid/relocate-repository
Relocate HOMEBREW_REPOSITORY when necessary.
2016-09-19 08:14:44 +01:00
Mike McQuaid
ac31a6518e keg: only prune var/homebrew/linked.
`var/homebrew` is too broad and ends up deleting and recreating the
locks directory repeatedly.
2016-09-18 21:52:42 +01:00
Mike McQuaid
d0204207ed update-report: remove cask dir after migration.
This will hang around otherwise due to e.g. running `bundle install` in
here once.
2016-09-18 21:42:44 +01:00
Mike McQuaid
42e9782dd6 update-report: cleanup git harder in migration.
Before stashing also try to cancel any current merge, rebase and
reset. This will prevent any data loss but also make the stash more
likely to succeed.
2016-09-18 20:25:18 +01:00
Mike McQuaid
027d8923f2 Merge pull request #1018 from MikeMcQuaid/update-migration-create-cellar
update-report: also create Cellar on migration.
2016-09-18 20:18:53 +01:00
Mike McQuaid
132ed2bcd5 Merge pull request #1016 from MikeMcQuaid/migrate-handle-more-symlink-fails
update-report: handle directory not existing.
2016-09-18 20:18:42 +01:00
Mike McQuaid
3f9cce0a03 Use new "macOS" naming where appropriate.
Not quite a mass replacement as I've used OS X and Mac OS X where
describing specific older versions and added compatibility methods
for things in the DSL.
2016-09-18 19:57:19 +01:00
Mike McQuaid
fc04d8f4f6 update-report: also create Cellar on migration.
Just on the off chance it doesn't exist (i.e. no-one has installed
anything yet or you're a `test-bot` that's run `git clean -xdf`
recently)
2016-09-18 19:32:29 +01:00
Mike McQuaid
3551977fb3 test-bot: uninstall all formula on cleanup.
Need to do this manually now that we can't rely on `git clean -xdf` to
do it for us.
2016-09-18 19:30:00 +01:00
Mike McQuaid
ee0fb3e999 update-report: handle directory not existing.
This shouldn't be possible to occur after #1013 but it makes sense to
add it anyway.
2016-09-18 16:55:59 +01:00
Mike McQuaid
997ccb044d Relocate HOMEBREW_REPOSITORY when necessary.
Now that the default from the installer, our CI and soon all users
is `/usr/local/Homebrew` it's a lot easier to check if there's
references to it (as we cannot look for `/usr/local` as it's a too
commonly hardcoded path).
2016-09-18 16:31:58 +01:00
Mike McQuaid
89ebffadec update-report: create top-level directories later.
Otherwise if they are created and empty they may be removed again
before we try to create the `/usr/local/bin/brew` symlink.
2016-09-18 16:06:49 +01:00
Mike McQuaid
72d0154454 update-report: migrate everyone to new repository.
Also migrate people without `HOMEBREW_DEVELOPER` set to the new
location.
2016-09-18 15:44:06 +01:00
Mike McQuaid
e20467971e Merge pull request #963 from MikeMcQuaid/migrate-repository
update-report: migrate /usr/local repository.
2016-09-18 15:41:04 +01:00
Mike McQuaid
ad466452de Merge pull request #1007 from MikeMcQuaid/update-remote-ref
update.sh: turn origin/branch into a variable.
2016-09-18 15:32:44 +01:00
Mike McQuaid
0a09ae30f8 update-report: migrate /usr/local repository.
Migrate a HOMEBREW_REPOSITORY and HOMEBREW_PREFIX of `/usr/local` so
that the HOMEBREW_REPOSITORY is now in `/usr/local/Homebrew`. This gives
us more flexibility on changing the repository layout in future and
avoids putting junk in `/usr/local` when not necessary (e.g. our
`README.md`).
2016-09-18 13:49:02 +01:00
Mike McQuaid
d70841db2b update.sh: turn origin/branch into a variable.
Rather than repeating origin multiple times.
2016-09-18 13:45:32 +01:00
Mike McQuaid
59b7f16bfd Merge pull request #989 from MikeMcQuaid/rubocop-final
Rubocop: apply auto-corrections and don't use hash-rockets
2016-09-18 13:28:15 +01:00
ilovezfs
56541001a4 Merge pull request #1003 from zmwangx/utils-pathname-to-string
utils: convert formula name from pathname to string
2016-09-17 23:08:49 -07:00
Zhiming Wang
79261148e6 Merge pull request #982 from zmwangx/dumb-term-in-test
formula: set TERM to dumb during test
2016-09-18 00:06:18 -04:00
Zhiming Wang
58b17a0cfc
utils: convert formula name from pathname to string
`name` is passed as argument to Formulary.factory which could later be
downcased at formulary.rb:349, but Pathname doesn't have a downcase
method. Converting `name` to String as it should be fixes the problem.

Fixes #1000.
2016-09-17 23:55:28 -04:00
Mike McQuaid
295e937f27 utils: create missing kegs directories if needed. 2016-09-17 19:23:42 +01:00
Mike McQuaid
eb23a39701 utils: remove bad symlink if it already exists. 2016-09-17 19:02:36 +01:00
Mike McQuaid
5b8329b1c1 Merge pull request #992 from MikeMcQuaid/migrate-legacy-symlinks-harder
Improve legacy symlink migration.
2016-09-17 18:58:00 +01:00
Mike McQuaid
241d7b991b Improve legacy symlink migration.
Read the old symlinks and migrate them across rather than assuming a
unlink/link will work fine (as users have conflicts.)
2016-09-17 18:50:25 +01:00
Mike McQuaid
1bdbb0f462 Improve rescue nesting. 2016-09-17 17:01:04 +01:00
ilovezfs
390bcf413b no_weak_imports: always check for support
ENV.no_weak_imports should be a no-op when Xcode doesn't support the
feature to avoid breaking builds with <= Xcode 7.
2016-09-17 08:29:47 -07:00
Mike McQuaid
69e4ad9809 Add Rubocop TODO list. 2016-09-17 16:14:14 +01:00
Mike McQuaid
3982950e61 rubocop --auto-correct all hash-rocket usage. 2016-09-17 16:14:13 +01:00
Mike McQuaid
6693915399 rubocop --auto-correct all remaining files.
But remove some manual `.freeze`s on constants that shouldn't be
constants.
2016-09-17 16:14:13 +01:00
Mike McQuaid
8f1ae3b28b Move LinkedKegs migration.
Move the `LinkedKegs` migration into `utils.rb` so it can also be called
from `brew.rb` on startup.
2016-09-17 15:00:46 +01:00
Mike McQuaid
224794c761 Merge pull request #984 from MikeMcQuaid/support-sierra
os/mac: officially support Sierra.
2016-09-17 14:09:18 +01:00
Mike McQuaid
e3fe2704eb Merge pull request #983 from MikeMcQuaid/update-force-linkedkegs-migration
Always run LinkedKegs migration (if needed).
2016-09-17 13:29:23 +01:00
Mike McQuaid
8aa18510c4 Always run LinkedKegs migration (if needed).
Ensure that `brew update` always runs the LinkedKegs migration if needed
as it may not have been run by `brew update` if it was using `--preinstall` or
a `git pull` etc.

Also, if the old paths still exist: just use them instead.

Finally, always try to unlink/unpin before link/pin.

Fixes https://github.com/Homebrew/homebrew-core/issues/4918.
2016-09-17 13:25:32 +01:00
Mike McQuaid
43d8b969db os/mac: officially support Sierra.
We have a GM, a bunch of bottles and CI setup.
2016-09-17 12:59:32 +01:00
Mike McQuaid
b1903c1a4a test-bot: generate coverage reports on Sierra.
We may have two Sierra nodes available which could speed up this
relatively slow operation.
2016-09-17 12:55:46 +01:00