Douglas Eichelberger
ccfc8bfbe6
Remove :final from Requirement#satisfied? sig
2024-11-24 15:49:49 -08:00
Douglas Eichelberger
33d9267d7d
Enforce finalized sorbet methods
2024-11-21 18:34:11 -08:00
Douglas Eichelberger
820d320835
Remove and refactor rspec-its use
2024-03-17 22:47:37 -07:00
Douglas Eichelberger
e7e4ecc405
Change return type
2024-02-19 13:29:49 -08:00
Douglas Eichelberger
26eda5a303
git grep -l '^describe' | xargs gsed -i 's|^describe|RSpec.describe|g'
2024-02-19 13:57:27 +00:00
Douglas Eichelberger
2255b9d43d
Enable verify_partial_doubles
2024-02-19 13:57:27 +00:00
Bo Anderson
43e5352074
test/requirement_spec: use stub_const
2024-01-08 18:41:32 +00:00
Douglas Eichelberger
9075cbae62
brew style --fix
2023-04-21 09:58:50 -07:00
Douglas Eichelberger
ac1e6ded9a
git grep -l '# typed: false' | xargs gsed -i 's|# typed: false||g'
2023-04-21 09:57:47 -07:00
Bo Anderson
93647e5c98
requirement: require instances to use a subclass
2022-08-31 19:17:55 +01:00
Issy Long
6b76fd012a
Fix (auto-correct) RuboCop RSpec/BeNil offenses
2022-03-01 00:10:10 +00:00
Issy Long
5793be5b86
test: Change more contexts to describes for better sentences
...
- We could have added "to" to the `RSpec/ContextWording` list of valid
`context` prefixes, but switching these to `describe` is less special.
2021-02-21 13:31:26 +00:00
Issy Long
e1ad07190e
rubocop: Fix RSpec/ContextWording offenses
...
- For some of these I changed `context` to `describe` as it fit better
rather than contriving a "when", "with" or "without", or massively
restructuring the tests.
2021-02-19 23:30:41 +00:00
Rylan Polster
af40e072b0
style: remove RSpec/NamedSubject violations
2021-02-01 20:30:51 -05:00
EricFromCanada
ec17dfbfcd
requirements: drop unused "cli/args" requirement
2020-11-07 11:01:21 -05:00
Markus Reiter
24ae318a3d
Move type annotations into files.
2020-10-10 14:59:39 +02:00
Markus Reiter
05365b5542
Pass args more explicitly in FormulaInstaller.
2020-07-30 03:21:12 +02:00
Markus Reiter
25b3632c4c
Pass args to ENV instead of using global args.
2020-07-25 03:57:43 +02:00
Mike McQuaid
eb9a31b52b
requirement_spec: use describe correctly.
2019-09-27 15:27:21 +01:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files.
2019-04-20 13:27:36 +09:00
Mike McQuaid
5e1806e796
test: rubocop-rspec style auto-corrects.
...
There’s too many warnings to start enabling `rubocop-rspec` by default
but let’s at least apply the cleanups it does automatically.
2018-03-25 13:30:37 +01:00
Mike McQuaid
b70b5429d0
Deprecate default_formula Requirement DSL
...
This has been a nightmare in terms of the complexity to our dependency
system and the whack-a-mole required on bugs. If a Requirement resolves
to a Formula it should just use `depends_on "formula"` instead. This
matches the effective behaviour all users of bottles (the vast majority
of users and installs) and what we're doing in Homebrew/homebrew-core.
2018-01-14 13:27:43 +00:00
Mike McQuaid
c843fd2f12
requirement: prepend rather than append PATH.
...
Otherwise this ends up behind e.g. `/usr/bin` so is pretty useless.
2017-11-03 14:50:17 +00:00
Josh Soref
a337620d97
spelling: omitted
2017-09-10 16:38:28 +00:00
Markus Reiter
3cdf8f938a
Use scoped RSpec matchers.
2017-05-15 17:23:40 +02:00
Mike McQuaid
ba3c46d24f
More deprecations.
...
Deprecate more methods. Internal APIs have been verified to be unused
elsewhere and removed. External APIs have had deprecation methods added.
Existing deprecations have been either upgraded to produce warnings or
no longer deprecated and the reasoning documented.
2017-04-22 16:28:07 +01:00
Markus Reiter
f85d3d1f7f
Convert Requirement test to spec.
2017-02-12 22:06:44 +01:00
