94 Commits

Author SHA1 Message Date
Mike McQuaid
a1dc809f5b
bin/brew: don't filter GitHub Actions variables. 2020-08-07 10:19:00 +01:00
Mike McQuaid
6d9e2d444d
Big Sur fixes
- Make missing SDKs message more clear.
- Always refer to Big Sur as 11.0 (even on Intel).
2020-07-28 16:56:55 +01:00
Mike McQuaid
fa760a2f26
Fix brew style. 2020-07-07 13:12:37 +01:00
Bo Anderson
9297b18aa6 Add SDK availability diagnostic 2020-07-01 16:07:14 +01:00
Mike McQuaid
0ea2c5f15b
os/mac/diagnostic: suggest untapping phinze/cask.
As seen in https://github.com/Homebrew/brew/issues/7605.
2020-05-20 10:05:23 +01:00
Mike McQuaid
2b224a66a5
os/mac/diagnostic: check for deprecated cask taps.
We keep seeing users popping up with these (#7449) so advise an untap.
2020-05-08 09:18:55 +01:00
Mike McQuaid
3381cbf5c7
Use Homebrew::EnvConfig. 2020-04-07 09:58:26 +01:00
Mike McQuaid
e9aba2efb6
Require and provide portable Ruby 2.6.3. 2019-10-10 15:53:16 +01:00
Mike McQuaid
cf34e1bec8
os/mac/diagnostic: allow Ruby 2.6.3 on Catalina. 2019-10-08 17:17:28 +01:00
Mike McQuaid
b567ed738e Remove Azure Pipelines CI. 2019-08-20 08:48:32 +01:00
Mike McQuaid
e1c00f2358
os/mac/diagnostic: allow use of GitHub Actions CI.
We will be migrating Homebrew/brew to use this in the near future.
2019-08-15 20:45:48 +01:00
Mike McQuaid
bc3a4c1897
diagnostic: tweak frozen string handling. 2019-04-23 23:05:28 -07:00
follower
2064b30fce
Fix check_for_unsupported_macos() on outdated releases
Recent commit 36dbad3922 to default to frozen string literals (via `frozen_string_literal`) broke `check_for_unsupported_macos()` on outdated releases--due to attempted modification of a frozen string literal.

This breaks `install` and `doctor`.

It's like the change wasn't tested on an unsupported outdated release or something... :D

Adding a `+` prefix is apparently one way around this issue according to https://stackoverflow.com/questions/37799296/what-does-the-comment-frozen-string-literal-true-do#37799399. The change worked for me.
2019-04-24 15:02:13 +12:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files. 2019-04-20 13:27:36 +09:00
EricFromCanada
15c38a2d8b formatting fixes 2019-04-13 21:29:32 -04:00
EricFromCanada
fa6404e0f5 grammar fixes 2019-04-13 21:29:32 -04:00
Mike McQuaid
e095da4d01
rubocop: enable Layout/EmptyLineAfterGuardClause. 2019-02-21 12:55:49 +00:00
Mike McQuaid
9b5ab7fbb7
Merge pull request #5598 from MikeMcQuaid/odeprecated-odisabled
Update deprecations and cleanup
2019-01-27 12:13:26 +00:00
Mike McQuaid
ce9856efca
os/mac/diagnostic: detect Bitdefender.
This has caused us multiple hard-to-diagnose issues so let's complain
about it in `brew doctor`.
2019-01-25 20:16:35 +00:00
Mike McQuaid
eed1444d61
Update deprecations and cleanup
- Move `odeprecated` to `odisabled`
- Remove `odisabled`
- Enable automatic cleanup on install/reinstall/upgrade.
2019-01-23 21:57:40 +00:00
Mike McQuaid
589ed8e17c
Tweak diagnostic checks
- Make `gist-logs` perform more checks
- Don't complain about a non-/usr/local install at install time unless
  actually building from source.
- Show more checks output on a build error
- Improve naming of checks methods
2019-01-21 19:23:31 +00:00
Mike McQuaid
3a0e0dca36
Output more warnings on unsupported configurations 2019-01-21 13:58:03 +00:00
Mike McQuaid
c3a46bc570
os/mac/diagnostic: remove some old/unneeded checks. 2019-01-21 12:40:12 +00:00
Mike McQuaid
e10d61b81b
Merge pull request #5447 from jonchang/linux-doctor
doctor: check supported versions of glibc and kernel [Linux]
2019-01-02 19:11:05 +00:00
Jonathan Chang
9db92a0203
Revert "Revert "diagnostic: share prefix check"" 2019-01-01 18:11:59 -08:00
Jonathan Chang
c32283e5be diagnostic: use universal pull request message 2019-01-01 15:48:00 -08:00
Mike McQuaid
61fa59e95b
Remove Travis CI specific code
We’re no longer using this for our CI so this is no longer necessary.

Also, migrate `brew tap-new` to use Azure pipelines.
2018-12-30 21:13:24 +00:00
Jonathan Chang
0a5fed1938
Revert "diagnostic: share prefix check" 2018-12-29 14:31:39 -08:00
Jonathan Chang
0d0eac8078 diagnostic: share prefix check 2018-12-27 11:23:18 -08:00
Mike McQuaid
6c49c878cd
os/mac/diagnostic: output non-default Xcode prefix.
This should help people find it when this is a fatal error (and they
don't look at `brew config`).
2018-11-28 14:25:36 +00:00
EricFromCanada
81e2fbd032 docs: update instructions for OS X < 10.9 2018-11-14 16:44:35 -05:00
Mike McQuaid
566b5b45ef
os/mac/diagnostic: don't complain about Xcode version on Azure.
It hasn't been updated yet and we want to be able to update the Xcode
versions for everyone else.
2018-09-30 11:10:19 +01:00
Mike McQuaid
59c858a8e8
Cleanup Travis and CI configuration.
Use the environment variables set by `brew test-bot`. Eventually we'll
disable Travis CI running CodeCov so move `TRAVIS` references to
`HOMEBREW_TRAVIS_CI` so it doesn't need whitelisted.

Also, fix `azure-pipelines.yml` so it's testing the correct version of
Homebrew/brew (the one checked out in the `pwd`).
2018-09-19 15:01:33 +01:00
Markus Reiter
e9b9ea49a1 Update to RuboCop 0.59.1. 2018-09-17 03:45:59 +02:00
Mike McQuaid
e06f8a8beb
Rename Homebrew-Cask to Homebrew Cask. 2018-09-04 09:56:57 +01:00
Misty De Meo
0cd8427405
Diagnostic: remove need for headers on 10.14 2018-08-08 10:45:48 -07:00
Mike McQuaid
e1eb7dd3e3 Use Ruby 2.3.7
Fixes #4459.
2018-07-13 08:22:33 +01:00
Mike McQuaid
33dd2a7e03 diagnostic: be clearer about what we support.
And be even more explicit whose problem it is when things are broken.
2018-07-11 14:12:38 +01:00
Misty De Meo
e5212d74a6 Diagnostic: require CLT headers on 10.14 2018-06-13 17:24:32 -07:00
Maxim Belkin
e5435dfeb7
Cross-platform diagnostics. 2018-05-14 04:44:15 -05:00
Mike McQuaid
9fca172d03 Fix HOMEBREW_RUBY_WARNINGS="-w"
Fix various circular requirements, method redefinitions, etc.
2018-04-07 20:28:56 +01:00
Mike McQuaid
1376b9e41c diagnostic: remove missing check. 2018-04-02 19:31:36 +01:00
Mike McQuaid
7095738d1d Remove config/doctor checks we no longer need
A bunch of these were needed before superenv, environment filtering or
on now long-unsupported versions of macOS.
2018-04-02 09:40:39 +01:00
Mike McQuaid
6b9ca5dbf5 Remove some unset/checked environment checks
These will be redundant once environment filtering is on by default
in #3529.
2017-12-08 16:33:33 +00:00
Mike McQuaid
fb6cf0c3f8 More environment filtering fixes
- Make `brew pull` pass through Git environment variables
- Whitelist all `TRAVIS_` variables.
2017-11-27 10:48:03 +00:00
Mike McQuaid
cd0db51343 diagnostic: check if Xcode needs CLT installed.
Require the CLT on all but the latest version of macOS to avoid the
continuous workarounds for SDK weirdness.
2017-11-17 21:35:49 +00:00
Mike McQuaid
5241d07474 environment filtering: pass through TRAVIS vars.
We use these internally so let's map them to `HOMEBREW_` variables.
2017-11-13 10:01:54 +00:00
Mike McQuaid
2ad1799308 os/mac/diagnostic: fix XQuartz message.
Fixes #3434.
2017-11-07 07:39:10 +00:00
Mike McQuaid
8c6defd9cf diagnostic: simplify version checks. 2017-11-05 15:39:43 +00:00
Markus Reiter
9bee9ca575 Use “squiggly” heredocs. 2017-10-18 14:39:09 +02:00