admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
35,092 Commits 15 Branches 471 Tags
Commit Graph

28379 Commits

Author SHA1 Message Date
BrewTestBot
a0224f0621
brew vendor-gems: commit updates. 2023-03-27 19:03:22 +00:00
dependabot[bot]
e0cc764a3f
build(deps): bump rubocop-ast from 1.27.0 to 1.28.0 in /Library/Homebrew 
Bumps [rubocop-ast](https://github.com/rubocop/rubocop-ast) from 1.27.0 to 1.28.0.
- [Release notes](https://github.com/rubocop/rubocop-ast/releases)
- [Changelog](https://github.com/rubocop/rubocop-ast/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-ast/compare/v1.27.0...v1.28.0)

---
updated-dependencies:
- dependency-name: rubocop-ast
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-03-27 18:57:50 +00:00
Mike McQuaid
91251d5739
Merge pull request #15059 from dduugg/type-cleanup 
Enable typing in Homebrew::Cleanup
 2023-03-27 17:45:01 +01:00
Douglas Eichelberger
a7b80532bf Code review changes 2023-03-27 09:28:27 -07:00
Mike McQuaid
cf6614b50e
Merge pull request #15061 from reitermarkus/keyboard-layout 
Add `keyboard_layout` stanza.
 2023-03-27 14:54:46 +01:00
Bevan Kay
68584ac7a7
dsl: pass #{arch} to flight blocks 2023-03-27 11:28:59 +11:00
Markus Reiter
140d444462
Merge pull request #15056 from reitermarkus/fetch-arch 
Allow fetching for different arch.
 2023-03-26 17:28:38 +02:00
Markus Reiter
c38f0c3aae
Fix typecheck. 2023-03-26 09:26:36 +02:00
Markus Reiter
471ce0b880
Use keyboard_layout stanza in livecheck. 2023-03-26 08:14:24 +02:00
Markus Reiter
3da305fa80
Add keyboard_layout stanza. 2023-03-26 08:14:24 +02:00
Douglas Eichelberger
eaeceda31e Enable typing in Homebrew::Cleanup 2023-03-25 13:16:11 -07:00
Issy Long
d43ba7c306
Merge pull request #15013 from issyl0/rubocops-cask-no-overrides 2023-03-25 13:44:19 +00:00
Markus Reiter
5e52d415a9
Allow fetching for different arch. 2023-03-25 11:56:09 +01:00
Nanda H Krishna
c271a9ae75
Merge pull request #15054 from Homebrew/dependabot/bundler/Library/Homebrew/rspec-sorbet-1.9.2 
build(deps): bump rspec-sorbet from 1.9.1 to 1.9.2 in /Library/Homebrew
 2023-03-24 15:35:23 -04:00
BrewTestBot
70b55ffbb5
Update RBI files for connection_pool. 
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
 2023-03-24 19:18:25 +00:00
BrewTestBot
5bd839c132
Update RBI files for rspec-sorbet. 
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
 2023-03-24 19:16:45 +00:00
BrewTestBot
0c583a0b7d
brew vendor-gems: commit updates. 2023-03-24 19:12:37 +00:00
BrewTestBot
95bd2c002b
brew vendor-gems: commit updates. 2023-03-24 19:11:17 +00:00
dependabot[bot]
1ed5f828e4
build(deps): bump connection_pool in /Library/Homebrew 
Bumps [connection_pool](https://github.com/mperham/connection_pool) from 2.3.0 to 2.4.0.
- [Release notes](https://github.com/mperham/connection_pool/releases)
- [Changelog](https://github.com/mperham/connection_pool/blob/main/Changes.md)
- [Commits](https://github.com/mperham/connection_pool/compare/v2.3.0...v2.4.0)

---
updated-dependencies:
- dependency-name: connection_pool
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-03-24 19:08:48 +00:00
dependabot[bot]
f5909de3bd
build(deps): bump rspec-sorbet from 1.9.1 to 1.9.2 in /Library/Homebrew 
Bumps [rspec-sorbet](https://github.com/samuelgiles/rspec-sorbet) from 1.9.1 to 1.9.2.
- [Release notes](https://github.com/samuelgiles/rspec-sorbet/releases)
- [Changelog](https://github.com/samuelgiles/rspec-sorbet/blob/master/CHANGELOG.md)
- [Commits](https://github.com/samuelgiles/rspec-sorbet/commits/v1.9.2)

---
updated-dependencies:
- dependency-name: rspec-sorbet
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-03-24 19:07:41 +00:00
Mike McQuaid
a0eb5ebec7
formulary: require service. 
This is used in this file.
 2023-03-24 09:23:09 +00:00
Mike McQuaid
fad8deda56
Merge pull request #15046 from issyl0/rubocop-method-parameter-pr 
rubocop: Remove the final `Naming/MethodParameterName` exceptions: `pr`
 2023-03-24 08:51:49 +00:00
Kevin
86c518e2d7
Merge pull request #15007 from apainintheneck/add-service-block-to-formula-api 
Add service block to formula api
 2023-03-23 17:30:04 -07:00
Issy Long
61dc026fcc
rubocop: Remove the final Naming/MethodParameterName exceptions: pr 
- Core RuboCop didn't want this shortening upstreamed, but that's OK!
 2023-03-24 00:29:42 +00:00
Issy Long
e4156909d4
Only take overrideable stanzas into account 
- This skips over stanza names that are not overrideable in `on_*`
  blocks, with the positive side effect that `on_*` blocks themselves
  aren't in the list so we can get rid of another conditional.
- Stanzas overrideable in blocks are defined in `Cask::DSL` by each of
  the methods calling `set_unique_stanza`.
 2023-03-23 18:59:29 +00:00
Mike McQuaid
253dca568c
Revert "move cask/cmd/reinstall" 2023-03-23 17:06:42 +00:00
Mike McQuaid
8f9caa3427
Merge pull request #15040 from hyuraku/move_cask/cmd/reinstall 
move `cask/cmd/reinstall`
 2023-03-23 16:31:01 +00:00
hyuraku
6a5ed3497e repair the options 2023-03-24 00:42:10 +09:00
Mike McQuaid
95a8c3f638
Add brew install --skip-post-install 
Will be needed by `brew test-bot`.
 2023-03-23 15:22:27 +00:00
hyuraku
ca3520e379 repair Cask#Reinstall::reinstall_casks 2023-03-23 23:39:58 +09:00
Issy Long
d4d413db62
String interpolations in regexps should also be allowed 
- This came up in Cask `simply-fortran`:

```
Scanning /opt/homebrew/Library/Taps/homebrew/homebrew-cask/Casks/simply-fortran.rb
send_node: s(:send, nil, :arch), send_node.parent: s(:begin,
  s(:send, nil, :arch)), send_node.parent.parent: (regexp
  (str "href=.*?simplyfortran[._-]v?(\\d+(?:\\.\\d+)+)")
  (begin
    (send nil :arch))
  (str "\\.dmg")
  (regopt :i))
Casks/simply-fortran.rb:2:3: C: Cask/NoOverrides: Do not use a top-level arch stanza as the default. Add it to an on_{system} block instead.
Use :or_older or :or_newer to specify a range of macOS versions.

  arch arm: "-arm64", intel: "-x86_64"
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected
```
 2023-03-23 13:55:00 +00:00
hyuraku
75c867e296 move cask/cmd/reinstall_spec to cask/reinstall_spec 2023-03-23 22:50:28 +09:00
hyuraku
31e49d96af move cask/cmd/reinstall to cask/reinstall 2023-03-23 22:50:03 +09:00
Issy Long
c1de3dfb90
Fix string interpolation detection again to be even broader 
- My approach wasn't quite good enough. Replace it with what RuboCop
  itself does to detect all forms of string interpolation.
 2023-03-23 13:17:09 +00:00
Mike McQuaid
e75b983686
cmd/update-report: fix ordering. 
New formulae/casks were shown as removed and vice versa.

Fixes #15036
 2023-03-23 08:48:48 +00:00
apainintheneck
6ccf21c2c9 Merge branch 'master' into add-service-block-to-formula-api 2023-03-22 20:06:32 -07:00
apainintheneck
801ee5e474 Address feedback 
- style nits
- better comments for tests that are not idempotent
- moved appdir placeholder constant to global.rb
 2023-03-22 19:43:49 -07:00
Issy Long
0889593e2a
Another failing test for a real Cask, version.csv.first interpolated 2023-03-23 00:02:17 +00:00
Issy Long
e66226aefc
Fix skipping of livecheck block contents in on_* blocks 
- This passes the previously failing test for `on_*` blocks with
  `livecheck` blocks with multiple stanzas inside them (eg `url` and
  `strategy`) that weren't being correctly skipped because we weren't
  detecting high enough up the ancestry.
 2023-03-22 23:17:32 +00:00
Issy Long
991e5f2f9c
Failing test for mishandling contents of livecheck blocks in on_* 
- The Cask `little-snitch4` in `Homebrew/homebrew-cask-versions` was
  failing and it took me a while to figure out _how_. Add a test for
  easier further debugging (and to prevent breakage once the bug is
  fixed).

```
❯ brew tests --only=rubocops/cask/no_overrides
Randomized with seed 29917
1 process for 1 spec, ~ 1 spec per process
F

Failures:

  1) RuboCop::Cop::Cask::NoOverrides when there are livecheck blocks within `on_*` blocks, ignore their contents does not report any offenses
     Failure/Error: DEFAULT_FAILURE_NOTIFIER = lambda { |failure, _opts| raise failure }
       expected `[#<RuboCop::Cop::Offense:0x000000012de636c8 @severity=#<RuboCop::Cop::Severity:0x000000012de636a0 @name=:convention>, @location=#<Parser::Source::Range (string) 244...273>, @message="Do not use a top-level `url` stanza as the default. Add it to an `on_{system}` block instead.\nUse `:or_older` or `:or_newer` to specify a range of macOS versions.\n", @cop_name="Cask/NoOverrides", @status=:unsupported, @corrector=nil>].empty?` to be truthy, got false
     Shared Example Group: "does not report any offenses" called from ./test/rubocops/cask/no_overrides_spec.rb:77
     # ./test/rubocops/cask/shared_examples/cask_cop.rb:24:in `expect_no_offenses'
     # ./test/rubocops/cask/shared_examples/cask_cop.rb:7:in `block (2 levels) in <module:CaskCop>'

Took 2 seconds
Tests Failed
```
 2023-03-22 21:41:28 +00:00
Issy Long
b82c5f1d36
Fix detection of string interpolation 
- This was almost there but not quite and the lack of tests lulled me into a false sense of security.
 2023-03-22 19:13:47 +00:00
Douglas Eichelberger
65d858da12
Merge pull request #15025 from dduugg/enable-unpack-strategy-types 
Enable UnpackStrategy types
 2023-03-22 12:06:12 -07:00
Douglas Eichelberger
9ba677f6d4
Update Library/Homebrew/extend/pathname.rb 
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
 2023-03-22 10:04:53 -07:00
Mike McQuaid
7ad3306e68
Merge pull request #15003 from issyl0/audit-for-keg_only-HOMEBREW_PREFIX 
formula_auditor: Having `HOMEBREW_PREFIX` in `keg_only` reasons is bad
 2023-03-22 14:13:33 +00:00
Issy Long
10b1af8b29
formula_auditor: Appease RuboCop with another &. 2023-03-22 13:54:43 +00:00
Issy Long
21f38ca3af
formula_auditor: Correct safe navigation positioning 
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
 2023-03-22 13:43:33 +00:00
Mike McQuaid
dea9da6139
Merge pull request #15033 from dduugg/enable-types 
Enable more typing
 2023-03-22 13:30:08 +00:00
Adrian Ho
ff42a4e3b7 update*: check shim output 
The shims _Should Not Fail_, but [when bugs happen](https://github.com/orgs/Homebrew/discussions/4331), they just cause confusing errors.
 2023-03-22 18:03:47 +08:00
apainintheneck
e83a2562bb Update service and formulary specs 2023-03-22 00:01:58 -07:00
apainintheneck
bc85857e13 service: make serialization non-recursive 
This helps with type annotations and makes it easier to
reason about the code as well.
 2023-03-21 23:20:49 -07:00