8436 Commits

Author SHA1 Message Date
Zhiming Wang
9f072a92d5
config: set TMPDIR, TEMP and TMP to HOMEBREW_TEMP
TMPDIR, TEMP and TMP (when set) are not whitelisted for writing in
sandbox.rb, which could result in sandbox violations when programs
attempt to write to these locations.

Setting TMPDIR, TEMP and TMP to HOMEBREW_TEMP (which defaults to /tmp
when not set) works around the aforementioned problem and also improves
uniformity in the locations of tempfiles created during Homebrew
operations.

Caveat: Non-matching HOMEBREW_TEMP and TMPDIR could lead to undesirable
side effects in certain cases, e.g., emacsclient not being able to find
an existing server (whose socket lives in $TMPDIR/emacs$UID/) when
launched through brew edit.
2016-08-24 12:59:57 +08:00
Mike McQuaid
31052a924f Merge pull request #782 from MikeMcQuaid/weak-imports-opt-in
Make -no_weak_imports opt-in.
2016-08-22 12:02:16 +01:00
Mike McQuaid
602fb0e575 Make -no_weak_imports opt-in.
The experiment to add `-no_weak_imports` unconditionally has been a bit
of a failure. It's broken more than it's fixed and I don't think we can
have this as a default for Xcode 8.

Add `ENV.no_weak_imports` to be used by formulae authors and make
`ENV.no_weak_imports a no-op (for now).

We may reconsider this behaviour in future.
2016-08-22 10:39:38 +01:00
Mike McQuaid
74cdfe491f Revert "diagnostic: ignore duplicated brew-cask commands" 2016-08-22 10:28:03 +01:00
Markus Reiter
21ac7de20c Merge pull request #771 from reitermarkus/dummy-containers
Forgot renaming `cab-container`.
2016-08-22 09:54:52 +02:00
Markus Reiter
7b8bae710e Use ThreadError to break loop. 2016-08-22 08:57:47 +02:00
Markus Reiter
ff30a303c8 Update Cask’s Gemfile. 2016-08-22 06:40:25 +02:00
Markus Reiter
61b38bdf1e Remove man generation from Cask’s Rakefile. 2016-08-22 03:31:30 +02:00
Markus Reiter
84820f2c5a Refactor .editorconfig. 2016-08-22 02:59:50 +02:00
Markus Reiter
66b7cd350e Remove non-existing directories from Cask’s .simplecov. 2016-08-22 02:31:39 +02:00
Markus Reiter
a98015192b Move Cask man page to root. 2016-08-22 01:49:12 +02:00
Markus Reiter
978567f9fd Rename cab-container to container-cab. 2016-08-22 00:32:13 +02:00
Mike McQuaid
acd0877de4 Merge pull request #772 from reitermarkus/shutup-helper
Refactor `shutup`.
2016-08-21 11:31:16 +01:00
Mike McQuaid
7c83d44115 Merge pull request #769 from MikeMcQuaid/go-deps-permit-weak-imports
build: permit weak imports in Go reverse deps.
2016-08-21 11:21:47 +01:00
Markus Reiter
39e9506557 Refactor shutup. 2016-08-21 05:07:38 +02:00
Mike McQuaid
7c7e2d00af Merge pull request #768 from MikeMcQuaid/cask-man
Make "brew man" also generate Cask's manpage.
2016-08-20 16:57:03 +01:00
Mike McQuaid
3c65298519 build: permit weak imports in Go reverse deps.
Go makes extensive use of weak imports so we need to allow them when
building Go-using software.

Closes https://github.com/Homebrew/homebrew-core/issues/4047.
2016-08-20 16:45:02 +01:00
Mike McQuaid
665783cba4 Make "brew man" also generate Cask's manpage.
Also, check in this manpage, adjust the Rakefile and remove the old one.

Fixes #731.
2016-08-20 16:36:34 +01:00
Martin Afanasjew
bb4d168c48 Merge pull request #760 from jasonkarns/bump-formula-pr-return-to-branch
bump-formula-pr: return to starting branch
2016-08-20 11:36:43 +02:00
Martin Afanasjew
27d9e450ff Merge pull request #757 from jasonkarns/bump-formula-pr-upstream
bump-formula-pr now creates non-tracking branches
2016-08-20 11:35:08 +02:00
Mike McQuaid
7b1c5f0d86 Merge pull request #764 from reitermarkus/remove-load-path-warning
Remove LOAD_PATH warning from Hbc::CLI::Doctor.
2016-08-20 08:47:11 +01:00
Mike McQuaid
df3dc9bb26 Merge pull request #765 from reitermarkus/caskroom-tap
Install Cask’s default tap if untapped.
2016-08-20 08:46:53 +01:00
Markus Reiter
0dd3203187 Install Cask’s default tap if untapped. 2016-08-20 07:02:23 +02:00
Markus Reiter
efc01c9d5d Remove LOAD_PATH warning from Hbc::CLI::Doctor. 2016-08-20 06:43:12 +02:00
Markus Reiter
0dc79d1881 Dummy Caffeine app. 2016-08-20 06:14:57 +02:00
Markus Reiter
f036cc0bc5 Dummy Adobe Air app. 2016-08-20 06:14:57 +02:00
Markus Reiter
3d0e7a572f Dummy Transmission app. 2016-08-20 06:14:57 +02:00
Markus Reiter
7f2248408c Normalize asset names. 2016-08-20 06:14:57 +02:00
Jason Karns
f40fd1df90 bump-formula-pr: return to starting branch
After branching, bumping, pushing, and pr-ing; return to whatever branch
was originally checked out.

In most cases, I'd imagine users to want to continue receiving tap
updates from master. However, after using bump-formula-pr, the tap in
which the formula was bumped is left on the working branch that was
doing the bumping and pull-request. After opening the PR, we should
return to whatever branch the user originally had checked out – most
likely master. (But git allows us to just say "previous branch" by using
`-`)
2016-08-19 15:59:55 -04:00
Markus Reiter
4a42561ab1 Remove Cask developer scripts. 2016-08-19 19:17:44 +02:00
Andrew Janke
5d603c3e8f separate build and test logs 2016-08-19 12:27:37 -04:00
Mike McQuaid
893c80d3ba Merge pull request #741 from tdsmith/weak-imports-opt-in
Add permit_weak_imports directive
2016-08-19 16:19:56 +01:00
Jason Karns
07efe1e771 bump-formula-pr now creates non-tracking branches
Without `--no-track`, some git setups may automatically set
`origin/master` as the tracked upstream for the newly created branch.
This upstream is what hub defaults as --head when opening PRs. By not
allowing git to set `origin/master` as upstream, hub can then use the
proper --head for the PR.

Since hub still needs to know what --head is intended to be, we can set
the branch's upstream when pushing: with the --set-upstream option.

Fixes #755
2016-08-19 10:50:51 -04:00
Mike McQuaid
105d7aa534 Merge pull request #752 from MikeMcQuaid/diagnostic-ignore-duplicate-brew-cask
diagnostic: ignore duplicated `brew-cask` commands
2016-08-19 15:11:33 +01:00
Xu Cheng
893582b89f Merge pull request #749 from vladshablinsky/fix_commit
download_strategy: check if commit nil
2016-08-19 21:16:52 +08:00
Mike McQuaid
ff8d22f3b3 diagnostic: ignore duplicated brew-cask commands
These are intentionally duplicated for now until the Cask migration is
complete.
2016-08-19 14:14:18 +01:00
Mike McQuaid
bd1ded93ec Merge pull request #725 from AnastasiaSulyagina/move-cask
Move Cask core code to Homebrew
2016-08-19 13:38:09 +01:00
AnastasiaSulyagina
092e2797e1 edits 2016-08-19 14:50:27 +03:00
AnastasiaSulyagina
e81f4ab7de init 2016-08-19 14:50:14 +03:00
Mike McQuaid
9967bc99f0 Merge pull request #731 from MikeMcQuaid/rename-bottle-revision
Rename bottle's revision to rebuild.
2016-08-19 12:15:00 +01:00
Vlad Shablinsky
b7a17ba345 download_strategy: check if commit nil 2016-08-19 12:32:20 +02:00
Andrew Janke
954445634c separate build and test logs 2016-08-19 01:04:32 -04:00
Dominyk Tiller
6442cb3032
xcode: update expected clang for macOS 10.12 2016-08-19 01:59:33 +01:00
ilovezfs
a5dac52d10 audit: fix suggested GitHub pull request URLs
Closes #746.

Signed-off-by: ilovezfs <ilovezfs@icloud.com>
2016-08-18 15:16:14 -07:00
ilovezfs
ef2674b812 Merge pull request #744 from ilovezfs/extensionless
version: fix parsing of URLs ending with version
2016-08-18 12:42:23 -07:00
Mike McQuaid
27ecf588c7 Rename bottle's revision to rebuild. 2016-08-18 17:32:35 +01:00
Mike McQuaid
e83da4c8e6 audit: tweak "remove revision" message clarity.
Reference the revision value so it's more obvious that this does not
refer to e.g. a SCM revision.
2016-08-18 15:04:51 +01:00
Mike McQuaid
8137b80a20 audit: audit version_scheme.
Reuse the existing `revision` method that was made more generic.
2016-08-18 15:04:51 +01:00
Mike McQuaid
41f6334b5b audit: make audit_revision more generic.
This will allow it to be used for checking other attributes too.
2016-08-18 15:04:51 +01:00
Mike McQuaid
eea0da362b audit: ensure correct version_scheme placement. 2016-08-18 15:04:51 +01:00