admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
27,429 Commits 15 Branches 471 Tags
Commit Graph

196 Commits

Author SHA1 Message Date
Mike McQuaid
af278b15de
cli/parser: add formulae method. 
This removes the coupling on args.formulae before it has been parsed.
 2020-05-10 15:10:36 +01:00
Mike McQuaid
38bd4e6d10
Merge pull request #7521 from MikeMcQuaid/fix-options 
cli: fix options handling.
 2020-05-07 11:14:27 +01:00
Mike McQuaid
c91f397605
cli: fix options handling. 
Fix breaking options on taps again (second time in two weeks, sob).

To avoid doing this again: also add a test for this case (that I've
verified would have caught these cases).
 2020-05-07 10:33:02 +01:00
Mike McQuaid
85a9fc4abe
cli/args: cleanup weird style. 
This got autofixed by RuboCop but looks weird.
 2020-05-07 10:02:34 +01:00
Mike McQuaid
20a1199375
Refactor CLI to remove unless args_parsed 
Refactor the CLI::Args module so it doesn't have different paths to
check arguments depending on whether the arguments have been parsed or
not. Instead, set the values we need from the global ARGV at
first, global initialisation time where they will be thrown away when
the actual arguments are parsed.

To do this some other general refactoring was needed:
- more methods made private when possible
- e.g. `HEAD?` used consistently instead of `head` before arguments
  are parsed.
- formula options are only parsed after named arguments are extracted
 2020-05-05 17:47:51 +01:00
Mike McQuaid
9324a85955
cli: readability improvements. 
- Rename `cmdline_args` to `argv` to make it more obvious where they
  come from.
- Make the `if args_parsed` early return into `unless args_parsed` to
  (hopefully) make it clearer that this is not the "normal" case and
  to not check `argv` unless arguments haven't been parsed.
 2020-05-04 12:42:29 +01:00
Gautham G
b0ac5bab31
ARGV: Deprecate ARGV.build_bottle? and replace with Homebrew.args.build_bottle 2020-04-26 13:28:44 +01:00
Gautham G
676ebf7419
ARGV: Deprecate ARGV.force_bottle? 2020-04-20 16:45:43 +01:00
Mike McQuaid
af8091a279
Remove ARGV_WITHOUT_MONKEY_PATCHING 
Our usage of `ARGV` will go away soon enough and maintaining state
between `ARGV` and `ARGV_WITHOUT_MONKEY_PATCHING` is futile.

Fixes #7397
 2020-04-20 10:27:14 +01:00
Mike McQuaid
2bbcab5615
Merge pull request #7333 from GauthamGoli/argv-cleanup-21 
cli/args: Make build_from_source public instance method
 2020-04-19 13:23:34 +01:00
Mike McQuaid
8d868b739c
cli/args: simplify initialisation. 
Move some logic from `CLI::Parser` to `CLI::Args` to simplify and make
more consistent the initialisation process.
 2020-04-18 21:14:35 +01:00
Mike McQuaid
bff0a90b37
cli/args: fix formulae_paths. 
The `Pathname`s don't have `name`s to `uniq`.
 2020-04-15 16:27:22 +01:00
Mike McQuaid
5366da76fd
cli/args: add formulae_paths helper. 
This allows getting the formulae passed as arguments while not having
to read the file or raising an exception on invalid syntax.
 2020-04-14 14:20:43 +01:00
Gautham G
b05c72b98b cli/args: Make build_from_source public instance method 2020-04-12 19:12:16 +05:30
Gautham G
2bdbca1280 Revert "Merge pull request #7289 from Homebrew/revert-7279-argv-cleanup-18" 
This reverts commit 64fd839c955b3c32855067d26fed7daf65183877, reversing
changes made to 6f50801b37b7d829afc37da76d2ef0a1ac1c9f5f.
 2020-04-11 18:50:24 +05:30
Mike McQuaid
3381cbf5c7
Use Homebrew::EnvConfig. 2020-04-07 09:58:26 +01:00
Gautham Goli
ad7e1d48a5
Revert "ARGV: Deprecate ARGV.build_formula_from_source? and ARGV.build_from_source?" 2020-04-05 23:01:57 +05:30
Gautham G
602cb7e636 ARGV: Deprecate ARGV.build_formula_from_source? and ARGV.build_from_source? 2020-04-05 16:47:47 +05:30
Mike McQuaid
8975dfb6ff
Merge pull request #7238 from Homebrew/dependabot/bundler/Library/Homebrew/unf_ext-0.0.7.7 
build: bump unf_ext from 0.0.7.6 to 0.0.7.7 in /Library/Homebrew
 2020-03-29 19:36:51 +01:00
Gautham G
7ad6dab288 ARGV: Deprecate ARGV.collect_build_args 2020-03-28 21:00:59 +05:30
Dawid Dziurla
6c5109be7a
cli/parser: chomp '=' from comma_array flag name 2020-03-16 15:02:43 +01:00
Mike McQuaid
1e265247ca
rubocop: apply autofixes. 2020-03-13 21:16:18 +00:00
Mike McQuaid
66155ea370
cli/parser: add named/min_named helpers. 2020-03-05 09:25:14 +00:00
Mike McQuaid
f13b0513ea
cli/parser: avoid using remaining. 2020-03-04 17:27:01 +00:00
Mike McQuaid
4d9e117430
args: avoid using remaining. 2020-03-04 17:26:38 +00:00
Mike McQuaid
2bf990bb29
cli/args: add no_named? helper. 2020-03-04 17:26:15 +00:00
Mike McQuaid
8a9dcad2c7
Move more command handling logic to commands.rb. 2020-02-02 17:05:45 +01:00
Mike McQuaid
eb87651341
Revert "Revert "help: print cli/parser help message if used"" 2020-02-02 16:36:59 +01:00
Gautham Goli
acde828a45 ARGV: Replace ARGV.verbose? with Homebrew.args.verbose? 2020-02-02 14:00:04 +01:00
Gautham Goli
685a6b4da6 ARGV: Replace usages of ARGV.named with Homebrew.args.named 2019-12-18 20:38:21 +05:30
EricFromCanada
aea6d79d21 option parser: check for extra named args 2019-12-15 00:04:45 -05:00
Gautham Goli
2b95755afe CLI::Args: Make processed_options read-only 2019-12-11 16:36:23 +05:30
Gautham Goli
28e62b52d1 cli_args: Remove cyclic dependency on ARGV 2019-12-11 16:36:23 +05:30
Gautham Goli
22e25dd593 argv: move formulae to cli/args 2019-12-11 16:36:23 +05:30
Zach Auten
fd429d0d75 Moved kegs from ARGV to args.rb 2019-11-09 11:56:47 -05:00
Gautham Goli
e88f6b9da9 args: Add passthrough method and tests 2019-09-26 10:33:40 +05:30
Gautham Goli
d18b122272 cli_args: Fix options_only and flags_only 2019-09-22 20:28:43 +05:30
Mike McQuaid
963cc556d4
Revert "argv: move options_only to cli/args" 2019-09-13 09:34:43 +01:00
Mike McQuaid
7df0292f9b
Revert "argv: move flags_only to cli/args" 2019-09-13 09:12:26 +01:00
Gautham Goli
c7681c4287 argv: move flags_only to cli/args 2019-09-09 14:51:36 +05:30
Gautham Goli
4586632855 argv: move options_only to cli/args 2019-09-07 21:32:50 +05:30
EricFromCanada
2477773259 man: include global options with customized descriptions 2019-08-25 23:59:47 -04:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files. 2019-04-20 13:27:36 +09:00
Mike McQuaid
ae63381bd9
cli/parser: use cli/args and tweak freeze behaviour. 2019-04-17 22:16:58 +09:00
Mike McQuaid
e9806b6b55
cli/args: add class to handle arguments. 2019-04-17 22:16:58 +09:00
Mike McQuaid
e40b171127
Rename cli_parser to cli/parser. 2019-04-17 22:16:50 +09:00