Sam Ford
f23d0ce373
livecheck: convert head-only strings to Versions
...
`brew livecheck` currently gives a Sorbet type error when run on a
HEAD-only formula: `Parameter 'version': Expected type Version, got
type String with value "c06c10d"`. This happens because the `current`
and `latest` values are strings but `LivecheckVersion#create` expects
a `Version` object.
This addresses the issue by creating a `Version` object from the
related commit strings. This ensures that the type of these variables
is more uniform, which makes them easier to reason about.
2024-07-25 10:23:39 -04:00
Sharon Azriel
31f4570cc2
[livecheck] Help to check head only formulae
2024-07-25 10:22:05 -04:00
Mike McQuaid
266ed1426b
Merge pull request #17857 from samford/contributions-reorder-requires
2024-07-25 15:21:03 +01:00
Issy Long
928bf87f59
Merge pull request #17856 from Homebrew/not-all-bin-interpolation-is-bad
2024-07-25 15:09:38 +01:00
Sam Ford
a6e61fd664
contributions, github: reorder requires
...
Per feedback to https://github.com/Homebrew/brew/pull/17806 , this
moves some `require` statements in `dev-cmd/contributions.rb` and
`Utils::GitHub` into the methods that need them.
2024-07-25 10:02:18 -04:00
Mike McQuaid
0f0e2c7bd9
Merge pull request #17854 from Homebrew/version_unsafe
2024-07-25 13:51:08 +01:00
Issy Long
38bb463aad
Interpolated shell_output("#{bin}/foo -v"), for example, is fine
...
- This would be weird to change because it's a string not a pathname passed to `shell_output`.
- I had misunderstood https://github.com/Homebrew/brew/pull/17826#discussion_r1690806375 .
2024-07-25 13:28:00 +01:00
Mike McQuaid
5bdd19d3eb
cli/named_args: improve missing_formula requires.
...
Let's make these more tightly scoped instead.
2024-07-25 12:54:03 +01:00
Mike McQuaid
be01b6ea64
version: use T.unsafe for https://srb.help/7019
...
In some configurations, Sorbet gets upset by the `version.to_json` call
in `Library/Homebrew/version.rb`. This is because Sorbet's splat
support is lacking and it cannot handle the `*options` argument when it
does not know the size.
2024-07-25 12:14:06 +01:00
Mike McQuaid
b31cfe8a85
Merge pull request #17840 from Homebrew/forbid-path-installs
2024-07-25 11:48:30 +01:00
Issy Long
ac973535ee
Merge pull request #17826 from Homebrew/no-interpolated-bin
...
rubocops/text: Enforce `bin/"formula"` instead of `"#{bin}/formula"`
2024-07-25 11:39:20 +01:00
Bo Anderson
10cbf191dc
Add env to disable finding packages from paths
2024-07-25 11:37:44 +01:00
Issy Long
a6596c969f
Test the shell_output single string edge case
2024-07-25 10:41:13 +01:00
Bo Anderson
5edcaf3f06
Merge pull request #17774 from branchvincent/std_npm_args
...
formula: add `std_npm_args`
2024-07-25 05:41:19 +01:00
Bo Anderson
eda3039b2d
Merge pull request #17852 from Homebrew/software-spec-error-clarify
...
software_spec: remove confusing missing version error
2024-07-25 04:47:54 +01:00
Bo Anderson
e6348b186f
Merge pull request #17851 from Homebrew/misconfigured-nss-fix
...
utils/github/api: handle systems with misconfigured NSS
2024-07-25 04:47:43 +01:00
Bo Anderson
a4b65647ae
Merge pull request #17844 from samford/version-loosen-debian-regex
...
version: loosen Debian orig tarball regex
2024-07-25 04:47:32 +01:00
Ruoyu Zhong
fa63211acf
Merge pull request #17850 from Homebrew/repository-prefix-fix
...
cmd/--repository: fix homebrew- prefix handling
2024-07-25 09:54:37 +08:00
Bo Anderson
d39a3a3030
Merge pull request #17788 from Homebrew/more-sorbet-strict
...
sorbet: Bump more files to `typed: strict`
2024-07-25 02:23:23 +01:00
Bo Anderson
bbdf52cdc6
software_spec: remove confusing missing version error
2024-07-25 02:17:27 +01:00
Bo Anderson
40ca1de617
utils/github/api: handle systems with misconfigured NSS
2024-07-25 01:57:06 +01:00
Bo Anderson
38987be01f
cmd/--repository: fix homebrew- prefix handling
2024-07-25 01:42:53 +01:00
Patrick Linnane
e44adc2c50
Merge pull request #17849 from bevanjkay/rosetta-regression
2024-07-24 17:09:28 -07:00
Bevan Kay
b633dfd5a5
cask/dsl/caveats: fix conditional
2024-07-25 09:40:29 +10:00
Issy Long
6ad0ebd5b4
env_config: Tighten hash types some more
...
Co-authored-by: Bo Anderson <mail@boanderson.me>
2024-07-24 23:16:58 +01:00
Issy Long
ace23ce735
Make the bin starts_with method its own thing as it needs more args
...
- I couldn't get
https://docs.rubocop.org/rubocop-ast/node_pattern.html#param_name-for-named-parameters
to work like it said it should (bad syntax in the node_matcher, apart
from with `bin = false` which RuboCop complained about boolean args not
being named), so here's a workaround.
2024-07-24 22:41:26 +01:00
Issy Long
3713939e0d
rubocops/text: Include dashed binaries in bin/ interpolation check
...
- Previously this only included the formula name.
- But, for example in tests, we have "#{bin}/ansible-test",
not just "#{bin}/ansible". So handle that too.
- I decided to make the error message better by extracting the
binary name from the interpolation, but I'm not sure it was worth it.
```
$ brew audit --strict ansible
ansible
* line 580, col 29: Use `bin/"ansible-test"` instead of `"#{bin}/ansible-test"`
Error: 1 problem in 1 formula detected.
```
2024-07-24 22:19:38 +01:00
Patrick Linnane
cc32d08c41
Merge pull request #17846 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-0.5.11493
2024-07-24 10:55:34 -07:00
BrewTestBot
446d0f7b44
brew vendor-gems: commit updates.
2024-07-24 17:44:01 +00:00
dependabot[bot]
054101529e
build(deps-dev): bump sorbet in /Library/Homebrew
...
Bumps [sorbet](https://github.com/sorbet/sorbet ) from 0.5.11492 to 0.5.11493.
- [Release notes](https://github.com/sorbet/sorbet/releases )
- [Commits](https://github.com/sorbet/sorbet/commits )
---
updated-dependencies:
- dependency-name: sorbet
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-07-24 17:42:25 +00:00
Sam Ford
2cd95d482d
version: loosen Debian orig tarball regex
...
The regex to match Debian `orig` tarballs uses the standard regex for
versions like `1.2.3` but it won't match versions without a dot. The
`lcrack` formula uses a date-based version in the filename
(`lcrack_20040914.orig.tar.gz`) and `mkcue` uses a single number
(`mkcue_1.orig.tar.gz`), so we have to use a manual `version` in
these formulae.
This updates the regex to use the looser `NUMERIC_WITH_OPTIONAL_DOTS`
pattern, which will also match the aforementioned versions. I tested
this by checking versions of formulae before/after this change and
confirming that they remain the same after removing the `version`
calls from related formulae.
2024-07-24 11:39:09 -04:00
Carlo Cabrera
cfb4bf7670
Merge pull request #17841 from Homebrew/debrew-disable
2024-07-24 12:45:15 +02:00
Bo Anderson
93dbb9593d
Add env to disable Debrew
2024-07-24 06:16:18 +01:00
Bo Anderson
8e8ce4a2f7
Merge pull request #17835 from Homebrew/system_command-ebadf
...
system_command: fix EBADF on Ctrl+C
2024-07-23 20:32:35 +01:00
Carlo Cabrera
a0bd54c9a6
Merge pull request #17836 from Homebrew/git-advice
2024-07-23 20:45:11 +02:00
Bo Anderson
1ce88d4992
cmd/update: silence git advice where possible
2024-07-23 18:54:05 +01:00
Bo Anderson
5ab907f2fa
system_command: fix EBADF on Ctrl+C
2024-07-23 18:48:42 +01:00
William Woodruff
7b90452349
Merge pull request #17834 from Homebrew/attestation-backfill-404
2024-07-23 12:41:09 -04:00
Bo Anderson
131b930d89
attestation: only fallback to backfill on 404
2024-07-23 16:59:52 +01:00
Patrick Linnane
f56747b6c4
Merge pull request #17832 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-0.5.11492
2024-07-23 08:24:06 -07:00
Ruoyu Zhong
4285ca6b9f
Merge pull request #17830 from Homebrew/dependabot/bundler/Library/Homebrew/public_suffix-6.0.1
...
build(deps): bump public_suffix from 6.0.0 to 6.0.1 in /Library/Homebrew
2024-07-23 23:04:16 +08:00
BrewTestBot
688b16ee4c
brew vendor-gems: commit updates.
2024-07-23 14:54:21 +00:00
BrewTestBot
35a5ddb51d
brew vendor-gems: commit updates.
2024-07-23 14:52:58 +00:00
dependabot[bot]
da2045045c
build(deps-dev): bump sorbet in /Library/Homebrew
...
Bumps [sorbet](https://github.com/sorbet/sorbet ) from 0.5.11491 to 0.5.11492.
- [Release notes](https://github.com/sorbet/sorbet/releases )
- [Commits](https://github.com/sorbet/sorbet/commits )
---
updated-dependencies:
- dependency-name: sorbet
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-07-23 14:51:36 +00:00
dependabot[bot]
db367007a1
build(deps): bump public_suffix from 6.0.0 to 6.0.1 in /Library/Homebrew
...
Bumps [public_suffix](https://github.com/weppos/publicsuffix-ruby ) from 6.0.0 to 6.0.1.
- [Changelog](https://github.com/weppos/publicsuffix-ruby/blob/main/CHANGELOG.md )
- [Commits](https://github.com/weppos/publicsuffix-ruby/compare/v6.0.0...v6.0.1 )
---
updated-dependencies:
- dependency-name: public_suffix
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-07-23 14:50:44 +00:00
Bo Anderson
feaa98f0bd
Merge pull request #17829 from Homebrew/apache-attic
...
download_strategy: fix handling of Apache projects moved to Attic
2024-07-23 15:47:32 +01:00
Bo Anderson
577f99baac
download_strategy: fix handling of Apache projects moved to Attic
2024-07-23 15:27:37 +01:00
Issy Long
96400e01e1
rubocops/text: Enforce bin/"formula" instead of "#{bin}/formula"
2024-07-23 12:43:15 +01:00
Issy Long
fdb661e2b9
cask/info: Bump to Sorbet typed: strict
2024-07-22 22:11:17 +01:00
Patrick Linnane
6b4e7bb2d0
Merge pull request #17824 from Homebrew/dependabot/github_actions/ruby/setup-ruby-1.188.0
2024-07-22 08:27:08 -07:00
