Sean Molenaar
3567892802
Add notibility checks for casks
2020-05-26 14:21:25 +02:00
Issy Long
d14eed6cec
audit: Remove call to deprecated created_pr_comment method
...
```
➜ brew audit --online --new-formula --verbose turbogit
turbogit:
* GitHub repository not notable enough (<30 forks, <30 watchers and <75 stars)
* GitHub repository too new (<30 days old)
Error: undefined local variable or method `created_pr_comment' for Homebrew:Module
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:148:in `audit'
/usr/local/Homebrew/Library/Homebrew/brew.rb:110:in `<main>'
```
- This was removed in 4f75a77b089e65ff9e03c65d192808aa4ea6842f. We can't
post PR comments from GitHub Actions CI from forks.
2020-05-25 13:00:38 +01:00
Issy Long
0cced8e7bd
audit: Fix Regexp for stripping .git from repo URLs
...
- [For a formula named
turbogit](https://github.com/Homebrew/homebrew-core/pull/55208 ), we
didn't see any of the notability checks fail CI.
- The repo name was getting truncated to `turb`, which didn't exist, so
the audit didn't return anything for this check.
- The Regexp to strip `.git` from the end of was not escaping the `.`,
so it would match anything ending in `git`, not a literal `.git`.
2020-05-25 12:48:16 +01:00
Mike McQuaid
e1f3c8d2b3
Merge pull request #7579 from MikeMcQuaid/deprecations
...
Update deprecations
2020-05-23 14:38:10 +01:00
Mike McQuaid
ca47992a6c
Fix rubocop-performance brew style.
2020-05-22 08:52:26 +01:00
Mathäus Zingerle
bb9665ced8
Migrate scheme checks for cvs, bzr, hg, fossil, and svn+http to Rubocop
2020-05-20 20:52:00 -05:00
Mike McQuaid
633501ab08
audit: remove incorrect TODO.
...
This check can't really be in RuboCop (as it relies on the URL strategy
logic).
2020-05-20 08:17:14 +01:00
Mathäus Zingerle
82ba0475ad
audit: Port version checks that do not rely on Formula state to RuboCop and add tests
2020-05-18 10:12:13 -05:00
Mike McQuaid
4f75a77b08
Update deprecations
...
Add more deprecations, disable deprecations and remove disabled code.
2020-05-18 13:50:46 +01:00
vidusheeamoli
f851688541
audit: Port audit_keg_only to rubocop and add tests
...
audit: add test
audit: fixed test
audit: added another test case
audit: fix test
audit: fix test
audit: fix keg only
2020-05-05 10:47:49 +05:30
Bo Anderson
b619e31457
dev-cmd/audit: fix false openssl@1.1 versioned formula audit
2020-04-22 01:00:35 +01:00
Mike McQuaid
8eed72cd8b
Move file mode audit to RuboCop.
2020-04-18 15:44:24 +01:00
Mike McQuaid
8cb90595b3
dev-cmd/audit: add TODOs for RuboCop migrations.
2020-04-18 15:30:53 +01:00
Mike McQuaid
3546c39581
audit: remove trailing newline check.
...
This is already done by the default RuboCop configuration.
2020-04-18 15:30:53 +01:00
Mike McQuaid
5e2351cde6
dev-cmd/audit: add --skip-style option.
...
This will allow `brew style` and `brew audit` to be run separately
without providing duplicates.
Additionally, run RuboCop style rules when `--strict` isn't provided and
remove a confusing reference to `style`.
2020-04-16 08:24:38 +01:00
Alexander Bayandin
5088eff96b
audit: add draft release detection
2020-04-15 15:04:10 +01:00
Mike McQuaid
4fb649cad1
cmd, dev-cmd: use args.formulae_paths.
...
This makes these commands robust to invalid syntax.
2020-04-14 14:21:38 +01:00
Mike McQuaid
d52e870b07
rubocop: remove NewFormulaAudit.
...
This is no longer used anywhere.
2020-04-13 16:01:26 +01:00
Mike McQuaid
2200b1ed40
Merge pull request #7231 from hyuraku/audit_github-prerelease_or_not
...
audit whether GitHub prerelease or not
2020-04-13 09:09:20 +01:00
Jonathan Chang
e6e5571a07
audit: fix keg_only check
2020-04-13 14:19:58 +10:00
Mike McQuaid
afa5713e63
audit: cleanup prerelease detection.
2020-04-12 14:51:49 +01:00
Mike McQuaid
6ea6db9026
dev-cmd/audit: test presence of formulae in lists.
2020-04-12 14:17:06 +01:00
Mike McQuaid
373650d00d
KegOnlyReason: add reason helpers, rename valid.
2020-04-12 13:12:02 +01:00
hyuraku
5578845e3f
repair regex condition
2020-04-12 20:23:43 +09:00
hyuraku
399caa007c
chnage how to extract owner and tag
2020-04-02 23:44:55 +09:00
hyuraku
40871a9782
repair style
2020-04-02 00:32:09 +09:00
hyuraku
e89be06447
change how to get tag
2020-04-02 00:13:58 +09:00
Mike McQuaid
8975dfb6ff
Merge pull request #7238 from Homebrew/dependabot/bundler/Library/Homebrew/unf_ext-0.0.7.7
...
build: bump unf_ext from 0.0.7.6 to 0.0.7.7 in /Library/Homebrew
2020-03-29 19:36:51 +01:00
hyuraku
6f622cd525
audit whether GitHub prerelease ot not
2020-03-28 16:57:47 +09:00
Tom Schoonjans
6f7302e4bc
keg_only_whitelist: add libsigc++@2
2020-03-27 08:01:01 +00:00
Michka Popoff
cdb9d0fbe4
Revert "Merge pull request #7203 from hyuraku/audit_whether_prerelease-or-not"
...
This reverts commit 081f6cdcd514396b1d396ce7d0eb40291a1a317c, reversing
changes made to 12d3a2a2d269e0a26565eb3e63552803f826f366.
This fails on some formulae with:
Error: Not Found
See:
https://github.com/Homebrew/homebrew-core/pull/52031
2020-03-22 23:53:59 +01:00
Mike McQuaid
081f6cdcd5
Merge pull request #7203 from hyuraku/audit_whether_prerelease-or-not
...
audit whether prerelease or not
2020-03-22 17:28:35 +00:00
hyuraku
fa80296ab4
repair notation
2020-03-22 23:25:13 +09:00
hyuraku
a6fcc94249
repair style
2020-03-22 22:18:00 +09:00
hyuraku
f6b260d7c4
audit whether prerelease or not
2020-03-22 22:00:32 +09:00
Sam Ford
e835ccb5cc
audit: throttle awscli@1 instead of awscli
2020-03-15 21:25:21 -04:00
Mike McQuaid
78140cef4a
Merge pull request #7073 from alexreg/issue-7068
...
audit: ignore group write bit
2020-03-06 14:08:45 +00:00
Alexander Regueiro
68047abc0e
audit: ignore group write bit
2020-03-05 23:01:41 +00:00
Mike McQuaid
e3ac94fc5d
dev-cmd: use more and cleanup new args APIs.
2020-03-05 09:40:15 +00:00
Michka Popoff
c46a30b575
brew: remove most traces of python@2
2020-02-17 22:38:24 +01:00
Jonathan Chang
bcb8f4da5f
Merge pull request #6903 from jonchang/audit-core-wording
...
audit: add "homebrew/core" for relevant checks
2020-01-08 15:53:45 -05:00
Jonathan Chang
779304df68
audit: add "homebrew/core" for relevant checks
2020-01-08 15:38:48 -05:00
Mike McQuaid
4efc1276b3
dev-cmd/audit: make git audit only --new-formula only.
...
Useful in e.g. https://github.com/Homebrew/homebrew-core/pull/46550 to
avoid repeatedly triggering a failing audit.
2020-01-08 12:12:26 +00:00
Gautham Goli
959b88266d
ARGV: Replace usages of ARGV.resolved_formulae with Homebrew.args
2020-01-02 13:56:19 +00:00
Gautham Goli
685a6b4da6
ARGV: Replace usages of ARGV.named with Homebrew.args.named
2019-12-18 20:38:21 +05:30
EricFromCanada
f0270a585c
desc/audit: remove messages obviated by new arg parser
2019-12-13 15:23:38 -05:00
Mike McQuaid
96e0686d78
Merge pull request #6778 from bayandin/audit-check-resources-uniq-name
...
dev-cmd/audit: check resource name does not match formula name
2019-11-26 16:25:47 +00:00
Tom Schoonjans
e704bf7184
audit: add libepoxy 1.5.4 to whitelist
2019-11-26 10:26:17 +00:00
Alexander Bayandin
349f37be68
dev-cmd/audit: check resource name does not match formula name
2019-11-26 01:02:27 +00:00
George Waters
8221e32ad4
Fix Audit check for env :std
...
When performing a strict audit of a formula in the core tap, it was
possible that the check for `env :std` would not happen.
2019-11-13 20:33:43 -05:00
