3828 Commits

Author SHA1 Message Date
Jack Nagel
113125d394 Remove Version#to_a alias
Exposing this as "to_a" was a mistake, versions are not arrays and it
causes incorrect behavior when splatted or using Kernel#Array(). Use the
more correct name "tokens" instead.
2013-06-14 18:37:27 -05:00
Adam Vandenberg
ca10e5005a Fix pretty names 2013-06-14 14:47:16 -07:00
Adam Vandenberg
8739eeab7d Move pretty_name into MacOS::Version
Closes Homebrew/homebrew#20507.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2013-06-14 13:36:20 -07:00
Jack Nagel
5539c97191 Fix another constant reference 2013-06-14 11:49:00 -05:00
Jack Nagel
a463398a8b Fix constant reference 2013-06-14 11:09:53 -05:00
Jack Nagel
eee5a09202 Favor compound if over compound unless 2013-06-14 10:34:20 -05:00
Jack Nagel
9427704176 Use ||= instead of unless 2013-06-14 10:34:20 -05:00
Jack Nagel
e73f869d84 Remove outdated comment 2013-06-14 10:34:20 -05:00
Jack Nagel
381255adec Assign this inline 2013-06-14 10:34:19 -05:00
Jack Nagel
3252f9a2c9 Delete rather than assign nil 2013-06-14 10:34:19 -05:00
Jack Nagel
723f7ed111 Simplify nested conditional 2013-06-14 10:34:19 -05:00
Jack Nagel
4e4a5af731 Use has_key? rather than accessing the value 2013-06-14 10:34:18 -05:00
Jack Nagel
020a505970 Rename single-letter variable 2013-06-14 10:34:18 -05:00
Jack Nagel
a458555ccb Make flag lists into constants 2013-06-14 10:34:18 -05:00
Jack Nagel
7d6371cd19 ENV: clean up set_cpu_flags and set_cpu_cflags usage 2013-06-14 10:34:18 -05:00
Jack Nagel
50db35e5d3 Use Hardware::CPU module 2013-06-14 10:34:17 -05:00
Jack Nagel
dc454aad92 Freeze optimization flags hash rather than duping it 2013-06-14 10:34:17 -05:00
Jack Nagel
4498db7887 Xcode 4.6.3 2013-06-13 18:22:28 -05:00
Adam Vandenberg
313134fbe3 ScriptFileFormula: remove override warning
Closes Homebrew/homebrew#20445.
2013-06-13 09:34:43 -07:00
Clemens Gruber
fc649af17a superenv: apply apr-1-config fix to 10.8+
Fixes Homebrew/homebrew#20417.
Closes Homebrew/homebrew#20474.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2013-06-13 11:33:16 -05:00
Simon Sigurdhsson
776c08490f Fix bug in brew list --pinned
Pinned formulae which were pinned at a previous version but then upgraded
would not be listed by `brew list --pinned`. This is due to the good old
"File.exist? thinks broken symlinks don't exist" gotcha, so the test in
the select block in list_pinned has been changed to check if the pin file
exists _or_ is a symlink.

Closes Homebrew/homebrew#20423.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2013-06-13 10:22:03 -05:00
Adam Vandenberg
7f9e4e11a3 Update fetch bash completion
Also complete --devel and the formula's install options.
2013-06-12 15:58:12 -07:00
Jack Nagel
0f314f9808 Remove unused variable 2013-06-12 17:25:29 -05:00
Jack Nagel
630aa27c56 Rename variables for clarity 2013-06-12 14:48:17 -05:00
Jack Nagel
5482092bd0 Extract search_taps method 2013-06-12 14:48:17 -05:00
Jack Nagel
e0fba99699 Pull tap list into a constant 2013-06-12 14:48:17 -05:00
Jack Nagel
c30f00c37c Remove use of global variable 2013-06-12 14:48:17 -05:00
Jack Nagel
d1a1a3b031 Rename method 2013-06-12 14:48:16 -05:00
Jack Nagel
1d1c292bcb Extract query construction 2013-06-12 14:48:16 -05:00
Jack Nagel
90768d03d2 Use inspect instead of escaping quotes 2013-06-12 14:48:16 -05:00
Jack Nagel
13a2ceef5c Move require out of method 2013-06-12 12:23:45 -05:00
Misty De Meo
d23ce833d7 Add pkg-config files for 10.9
Seems to be that 10.9 needs the same ones as 10.8.

Fixes Homebrew/homebrew#20436.
2013-06-12 09:51:22 -05:00
Jack Nagel
2045217a68 install: remove overcautious array manipulation 2013-06-12 09:02:20 -05:00
Jack Nagel
5369199df3 Fix version misdetection from fa582cb9ac65 2013-06-11 17:34:21 -05:00
Jack Nagel
fdaea3189d Check method existence rather than Ruby version 2013-06-11 17:05:44 -05:00
Jack Nagel
28b9790dbd FormulaInstaller: ensure locks are always released 2013-06-11 15:35:30 -05:00
Clemens Gruber
15626b38ca Recognize OS X 10.9 and Xcode 5.0
Closes Homebrew/homebrew#20410.
Closes Homebrew/homebrew#20401.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2013-06-11 10:20:23 -05:00
Jack Nagel
652e0982f0 Add doctor check for OS X > 10.8 2013-06-11 10:18:24 -05:00
Misty De Meo
ef054a2d02 doctor: add check for osx-gcc-installer
This might not detect all cases, but should detect the two most
common ones.
2013-06-11 08:13:24 -05:00
Jack Nagel
580eea89be Cast deps to formula before passing them to superenv
Dependency names retain the "tap prefix", e.g. the "homebrew/dupes"
part of "homebrew/dupes/zlib". However formula objects do not, and this
is desired because we do not record the tap name as part of the
installation prefix.

So we need to ensure the correct dep names are passed to superenv,
otherwise it will not add the correct directories to various environment
variables.
2013-06-10 17:38:52 -05:00
Jack Nagel
784c9670f1 Add failing test for a misdetected version 2013-06-10 14:55:23 -05:00
Jack Nagel
f1df7f208f info: remove unreachable code 2013-06-09 15:32:08 -05:00
Jack Nagel
1d265e5a0a Check respond_to? instead of inline rescue 2013-06-09 15:31:40 -05:00
Jack Nagel
a1e30cdd3a Update Formula#to_hash for tweaked conflicts implementation 2013-06-09 15:20:36 -05:00
Jack Nagel
8b9a3a560f Separate formula conflicts from requirements
Closes Homebrew/homebrew#20357.
2013-06-09 13:45:25 -05:00
Samuel John
33cae6ac42 PythonInstalled: Fix libdir for Python 3.x 2013-06-09 20:37:30 +02:00
Jack Nagel
d28deee516 deps: move recursive_deps_tree into Homebrew module 2013-06-09 12:59:42 -05:00
Matt Torok
14e3c77f60 Updated brew graph
Changed 'graph' command to show only installed by default. Prettified
resulting graph.

By default, the `brew graph` command would output a dependency graph for every
formula it knew about. Now it only outputs a dependency graph the for formulas
installed. If you want to see the graph for all formulas, use `brew graph
--all`.

Additionally, the old version of the graph command would filter out any
formulas without depdency connections. The updated version now only does this
if calculating dependencies for all formulas via the `--all` flag.

Finally, the resulting graph has been redesigned to be simpler to read. All
formulas which have no other formulas depending on them (i.e., root nodes) are
aligned to the left. They are also outlined in a light grey box, which is
labelled "Safe to Remove". As implied, all of the formulas in this box can be
safely removed without breaking other installed formulas; all formulas outside
this box have at least one installed formula depending on them. This new graph
style is surpressed if the `--all` flag is used.

Closes Homebrew/homebrew#18282.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2013-06-09 08:21:44 -07:00
Adam Vandenberg
a60eed48bc Remove adamv-alt references.
Closes Homebrew/homebrew#20364.
2013-06-09 07:32:06 -07:00
Adam Vandenberg
4c9ac19e87 Consolidate sudo checks.
Closes Homebrew/homebrew#20318.
2013-06-08 20:44:56 -07:00