34183 Commits

Author SHA1 Message Date
Mike McQuaid
933cf0bd78
Merge pull request #14628 from dduugg/upgrade-type
Enable typing in Homebrew::Upgrade
2023-02-15 14:58:32 +00:00
Mike McQuaid
8570cb9729
Merge pull request #14630 from dduugg/type-requirement
Enable typing in Requirement classes
2023-02-15 14:55:23 +00:00
Douglas Eichelberger
7fb87abefd
Enable typing in Homebrew::Upgrade 2023-02-15 14:24:58 +00:00
Douglas Eichelberger
4deb4c1813
Enable typing in Requirement classes 2023-02-15 14:22:03 +00:00
Issy Long
43a88cbd97
dev-cmd/contributions: Appease RuboCop 2023-02-15 14:04:05 +00:00
Issy Long
44edad85bc
dev-cmd/contributions: Add a grand total row to the CSV
```
$ brew contributions issyl0 --csv
The user issyl0 has made 1203 contributions in all time.
user,repo,commits,coauthorships,signoffs,total
issyl0,brew,333,13,0,346
issyl0,core,473,24,326,823
issyl0,cask,4,0,0,4
issyl0,aliases,0,0,0,0
issyl0,autoupdate,1,0,0,1
issyl0,bundle,14,2,0,16
issyl0,command-not-found,1,0,0,1
issyl0,test-bot,3,0,0,3
issyl0,services,9,0,0,9
issyl0,cask-drivers,0,0,0,0
issyl0,cask-fonts,0,0,0,0
issyl0,cask-versions,0,0,0,0
issyl0,*,*,*,*,1203
```
2023-02-15 14:00:05 +00:00
Issy Long
9aad9d011b
dev-cmd/contributions: Add a per-repo total column to the CSV
```
$ brew contributions issyl0 --csv
The user issyl0 has made 1202 contributions in all time.
user,repo,commits,coauthorships,signoffs,total
issyl0,brew,332,13,0,345
issyl0,core,473,24,326,823
issyl0,cask,4,0,0,4
issyl0,aliases,0,0,0,0
issyl0,autoupdate,1,0,0,1
issyl0,bundle,14,2,0,16
issyl0,command-not-found,1,0,0,1
issyl0,test-bot,3,0,0,3
issyl0,services,9,0,0,9
issyl0,cask-drivers,0,0,0,0
issyl0,cask-fonts,0,0,0,0
issyl0,cask-versions,0,0,0,0
```
2023-02-15 13:58:49 +00:00
Sean Molenaar
50e9247da4
fix: add better keys and fuller values to influxDB analytics 2023-02-15 14:12:05 +01:00
Issy Long
2719c345ab
dev-cmd/contributions: CSV output of queried repos; shorter sentence
- This gives users of this command a `--csv` option to pass to... you guessed
  it, generate a CSV that's `pbcopy`able elsewhere, for more granular
  breakdowns of where a person contributed.
- Inspiration was taken from the mockup in
  https://github.com/Homebrew/brew/issues/13642#issuecomment-1254535251
  but without the extra dependency of the TerminalTable gem.
- Always print a condensed "total contributions" sentence.

Output:

```
$ brew contributions issyl0
The user issyl0 has made 1201 contributions in all time.

$ brew contributions issyl0 --csv
user,repo,commits,coauthorships,signoffs
issyl0,brew,331,13,0
issyl0,core,473,24,326
issyl0,cask,4,0,0
issyl0,aliases,0,0,0
issyl0,autoupdate,1,0,0
issyl0,bundle,14,2,0
issyl0,command-not-found,1,0,0
issyl0,test-bot,3,0,0
issyl0,services,9,0,0
issyl0,cask-drivers,0,0,0
issyl0,cask-fonts,0,0,0
issyl0,cask-versions,0,0,0
```
2023-02-15 12:47:10 +00:00
Carlo Cabrera
42a2a8e5c7
Merge pull request #14633 from gromgit/patch-1
docs: no more homedir installs
2023-02-15 20:36:35 +08:00
Mike McQuaid
d87c7d718f
Merge pull request #14580 from carlocab/closed-prs
formula_auditor: allow references to merged PRs
2023-02-15 12:10:03 +00:00
Adrian Ho
5d826390c7
docs: no more homedir installs
Capability removed via https://github.com/Homebrew/install/pull/702
2023-02-15 12:05:09 +00:00
Mike McQuaid
08c6b4556d
Merge pull request #14616 from reitermarkus/audit-cask-version
Add audit for versions containing colons or slashes.
2023-02-15 11:59:59 +00:00
Carlo Cabrera
72d8a50e7a
Disallow references to PRs that are closed but not merged 2023-02-15 16:18:48 +08:00
Carlo Cabrera
82a3af6ce1
Merge pull request #14640 from carlocab/homebrew-env-vars
bin/brew: refine generation of `HOMEBREW_*` env vars
2023-02-15 15:55:27 +08:00
Mike McQuaid
17f19a85fe
Merge pull request #14637 from Bo98/api-git-clone 2023-02-15 07:25:46 +00:00
Mike McQuaid
56adf8cd3d
Merge pull request #14635 from Bo98/api-analytics 2023-02-15 07:21:16 +00:00
Bo Anderson
efc5088f85
formulary: fix git clone handling for API formulae 2023-02-15 05:31:23 +00:00
Bo Anderson
7ef0c48362
Fix analytics handling when core/cask taps are untapped 2023-02-15 05:31:08 +00:00
Carlo Cabrera
6f63be411b
bin/brew: refine generation of HOMEBREW_* env vars
We inherit some variables from the user's environment but prefix them
with `HOMEBREW_`. This is the case for (1) variables documented in the
manpage and also for some (2) variables used internally by `brew`.

We currently treat both types identically, but we should not. In
particular, we allow users to override type (1), but we don't want to do
this for type (2).

This was partially fixed in f4103e5d61526cfbf7f31540ba45ec171adc452e,
but that fix did not go far enough. Some variables that the user should
not be allowed to override can still be overridden.

This change completes the partial fix and refactors the code so that
we're less likely to mistakenly conflate the two types of variables in
the future.
2023-02-15 13:27:02 +08:00
Bo Anderson
f2c9db2626
Merge pull request #14638 from Bo98/ci-fix
test/cask/cask_spec: fix test
2023-02-15 05:26:59 +00:00
Bo Anderson
6e1b9ddb49
test/cask/cask_spec: fix test 2023-02-15 04:59:07 +00:00
Bo Anderson
724e3e646a
Merge pull request #14622 from Bo98/prefix.sh-api
prefix.sh: support API mode
2023-02-15 02:34:27 +00:00
Bo Anderson
0cfa7bddef
Merge pull request #14631 from Homebrew/sorbet-files-update
sorbet: Update RBI files.
2023-02-15 02:33:05 +00:00
BrewTestBot
7af0425793
sorbet: Update RBI files.
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
2023-02-15 00:30:37 +00:00
Mike McQuaid
c87090e1a0
Merge pull request #14627 from MikeMcQuaid/master
cask/cask: fix non-absolute home error.
2023-02-14 17:43:14 +00:00
Mike McQuaid
1d61b219db
cask/cask: fix non-absolute home error.
Needs a leading slash to avoid `File.expand.path` complaining about non-absolute home.
2023-02-14 17:22:18 +00:00
Mike McQuaid
98f5213954
Merge pull request #14615 from MikeMcQuaid/generating_hash_appdir
Overhaul Formula/Cask JSON generation
2023-02-14 15:02:19 +00:00
Mike McQuaid
237eec8ef8
Overhaul Formula/Cask JSON generation
- Use constants for placeholders
- Monkeypatch to set `HOMEBREW_PREFIX` consistently to placeholder
- Use environment variable to set `Dir.home` consistently to placeholder
- Use `appdir` short-circuit to set `Cask#appdir` consistently to placeholder
- Use `Cask.generating_hash!` to enable "generating mode" with these patches
- Fix `Formula#caveats` from JSON

Fixes #14505
Fixes #14595
2023-02-14 14:19:40 +00:00
Mike McQuaid
66c9d5f2af
Merge pull request #14620 from Kentzo/sudo-env
sudo: pass env variables without /usr/bin/env
2023-02-14 14:13:37 +00:00
Mike McQuaid
9725e764f5
system_command: fix typo. 2023-02-14 13:02:59 +00:00
Mike McQuaid
cedd4d33e4
Merge pull request #14570 from s4nji/patch-1
Update documentation for `brew install` and FAQ regarding `HOMEBREW_NO_INSTALL_FROM_API`
2023-02-14 12:38:20 +00:00
Sanjito Kurniawan
c7b8b3a989
docs/FAQ: correct an entry regarding simple formula edit
Co-authored-by: Kevin <apainintheneck@gmail.com>
2023-02-14 12:04:37 +00:00
Sanjito Kurniawan
2daae5e84d
edit: add HOMEBREW_NO_INSTALL_FROM_API warning. 2023-02-14 12:04:10 +00:00
Mike McQuaid
e0ba9a1249
Merge pull request #14617 from Bo98/api-reqs-oldname
formulary: support requirements, aliases etc from API
2023-02-14 11:54:55 +00:00
Issy Long
990170927a
Merge pull request #14597 from issyl0/contributions-add-signoffs
dev-cmd/contributions: Count commit signoffs, too
2023-02-14 11:37:08 +00:00
Mike McQuaid
72071f290e
Merge pull request #14623 from dduugg/type-api
Enabling typing in Homebrew::API module
2023-02-14 11:31:37 +00:00
Mike McQuaid
70db4bc723
Merge pull request #14621 from Bo98/api-uses_from_macos-fix
formulary: fix uses_from_macos handling on macOS
2023-02-14 11:24:44 +00:00
Mike McQuaid
d0d83cc03f
Merge pull request #14614 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-ast-1.26.0
build(deps): bump rubocop-ast from 1.24.1 to 1.26.0 in /Library/Homebrew
2023-02-14 11:17:44 +00:00
Mike McQuaid
8aa495b19b
Merge pull request #14618 from Bo98/maximum-req-name-fix
formula: fix `to_hash` tampering with requirement names
2023-02-14 11:14:51 +00:00
Issy Long
abe23fb249
dev-cmd/contributions: Add up different contribution types for a total
❯ brew contributions mikemcquaid
mikemcquaid directly authored 23766 commits, co-authored 241 commits, and signed-off 6730 commits across all Homebrew repos in all time. Total: 30737.
2023-02-14 10:51:13 +00:00
Mike McQuaid
aa7a543344
Merge pull request #14613 from MikeMcQuaid/improve_autotapping
Improve homebrew/{core,cask} autotapping.
2023-02-14 10:30:09 +00:00
Mike McQuaid
4c8ed77302
Improve homebrew/{core,cask} autotapping.
Don't automatically tap these when running a developer command that's
not using the API.

Fixes #14606
2023-02-14 09:54:24 +00:00
Mike McQuaid
0e2c13bdfd
Merge pull request #14611 from apainintheneck/stop-including-flight-block-source-in-json
Stop including flight block source in json
2023-02-14 09:37:15 +00:00
Ilya Kulakov
9ff7ceb563 sudo: pass env variables without /usr/bin/env
Using /usr/bin/env as a frontend for the actual command
prevents sudoers from restricting allowed commands and configuring
detailed command environment.
2023-02-13 22:10:35 -08:00
Bo Anderson
ca32473a67
prefix.sh: support API mode 2023-02-14 05:51:11 +00:00
Douglas Eichelberger
95742f4cfd Enabling typing in Homebrew::API module 2023-02-13 21:33:04 -08:00
apainintheneck
39c6f7d6fb Stop including *flight block source in cask API
Originally we were going to try and load the *flight blocks from the API
but we ended up going with downloading the caskfile for the subset of
casks that need this functionality for consisty's sake.

This reverts the following commits from most recent to oldest:
- ffc74a51fb32b66a4cd8bc41dbd076dd23d9100e
- e5616e94fe42505434c330be35eeafef2739944f
- d1490c3d5c087d00f2bca1787cce331202b195c5
- 7ca5a5d9a71a73f21bbb8555a38048f027bee89b
- 2d5d132713d0701d02d5ff33e9918812d13d2a83

It also changes how *flight blocks are handled in `.to_h`.
Essentially, when *flight blocks exist they are just included
as a hash of the artifact to nil to indicate that they exist.

More information isn't necessary since we don't evaluate
the current source code in the *flight artifacts that
we get from the API.
2023-02-13 21:22:18 -08:00
Bo Anderson
7c1b642035
formulary: fix uses_from_macos handling on macOS 2023-02-14 04:07:51 +00:00
Bo Anderson
9b26bf9b92
formulary: support requirements, aliases etc from API 2023-02-14 03:32:56 +00:00