Mike McQuaid
a19a1d377a
Merge pull request #8237 from MikeMcQuaid/more-workflows-cleanup
...
Cleanup more GitHub Actions usage
2020-08-07 08:53:04 +01:00
Claudia
8864287cf2
Fix “wrong number of arguments” error
...
This commit fixes an error introduced in 6c964d4a78, which would
surface on certain install/reinstall/upgrade failures.
Example:
```
==> Patching
patching file default_out.txt
Hunk #2 FAILED at 11.
1 out of 2 hunks FAILED -- saving rejects to file default_out.txt.rej
Error: wrong number of arguments (given 3, expected 2)
/usr/local/Homebrew/Library/Homebrew/reinstall.rb:77:in `restore_backup'
/usr/local/Homebrew/Library/Homebrew/reinstall.rb:52:in `block in reinstall_formula'
/usr/local/Homebrew/Library/Homebrew/utils.rb:377:in `ignore_interrupts'
/usr/local/Homebrew/Library/Homebrew/reinstall.rb:52:in `rescue in reinstall_formula'
/usr/local/Homebrew/Library/Homebrew/reinstall.rb:10:in `reinstall_formula'
/usr/local/Homebrew/Library/Homebrew/cmd/reinstall.rb:71:in `block in reinstall'
/usr/local/Homebrew/Library/Homebrew/cmd/reinstall.rb:65:in `each'
/usr/local/Homebrew/Library/Homebrew/cmd/reinstall.rb:65:in `reinstall'
/usr/local/Homebrew/Library/Homebrew/brew.rb:112:in `<main>'
```
2020-08-07 08:57:54 +02:00
Markus Reiter
56ed27af15
Merge pull request #8187 from reitermarkus/args-verbose-debug
...
Remove usages of `Homebrew.args.verbose?` and `Homebrew.args.debug?`.
2020-08-06 20:55:24 +02:00
Mike McQuaid
3e4da13934
Cleanup more GitHub Actions usage
...
Increase consistency between workflows, use more of our actions and
`@main`.
2020-08-06 19:35:39 +01:00
Seeker
36c7a3f27f
bump-formula-pr, utils/pypi: tweak log messages
2020-08-06 11:31:56 -07:00
Seeker
6ecef73131
test: add spdx spec
2020-08-06 11:14:24 -07:00
Seeker
753b8621df
utils: add SPDX module
2020-08-06 10:16:23 -07:00
Seeker
c5d3a4a0ed
Merge pull request #8225 from SeekingMeaning/cask/create/new-style
...
cask/create: update template to match new style
2020-08-06 10:11:48 -07:00
Seeker
a3fa266bf4
Merge pull request #8223 from SeekingMeaning/bump-formula-pr/exact-match
...
bump-formula-pr: only check closed PRs for exact match
2020-08-06 09:52:01 -07:00
Seeker
3a2dc79153
cask/create: update template to match new style
2020-08-06 09:39:07 -07:00
Markus Reiter
1535892818
Don't deprecate Homebrew.args.value
yet.
2020-08-06 16:28:07 +02:00
Markus Reiter
5d3881e1ab
Don't skip RuboCop on non-existent ARGV
methods.
2020-08-06 16:28:07 +02:00
Markus Reiter
536c963274
Deprecate global Homebrew.args
.
2020-08-06 16:14:07 +02:00
Markus Reiter
6524802079
Pass remaining args to Help
.
2020-08-06 16:13:14 +02:00
Markus Reiter
490e503b1b
Replace Homebrew.args
with Context
.
2020-08-06 16:13:14 +02:00
Markus Reiter
9d6350037f
Use try
instead of send
.
2020-08-06 16:13:14 +02:00
Markus Reiter
62671b1703
Remove wrong test.
2020-08-06 16:13:14 +02:00
Markus Reiter
bace9ecc34
Pass verbose?
to Formula#verify_download_integrity
.
2020-08-06 16:13:14 +02:00
Markus Reiter
6c964d4a78
Pass verbose?
to Keg#link
, Keg#unlink
and Keg#optlink
.
2020-08-06 16:12:52 +02:00
Markus Reiter
e9d8f09da1
Pass debug?
, quiet?
and verbose?
to FormulaInstaller
.
2020-08-06 16:12:52 +02:00
Markus Reiter
5db764f3cb
Pass debug?
and verbose?
in brew style
.
2020-08-06 16:12:52 +02:00
Markus Reiter
5caafe413e
Pass debug?
to Formula#brew
and Formula#run_test
.
2020-08-06 16:12:52 +02:00
Markus Reiter
75a692d08b
Make ohai
, oh1
and odebug
use #debug?
and verbose?
of the current object when possible.
2020-08-06 16:12:52 +02:00
Markus Reiter
add10377b8
Pass debug?
and verbose?
to Cleaner
.
2020-08-06 16:12:52 +02:00
Markus Reiter
26688145f0
Don't use global Homebrew.args
in brew.rb
.
2020-08-06 16:12:52 +02:00
Markus Reiter
7926f7fc82
Pass args.verbose?
to BuildError#dump
.
2020-08-06 16:12:52 +02:00
Markus Reiter
57fa48b758
Remove unneeded call to #shutup!
in spec.
2020-08-06 16:12:52 +02:00
Markus Reiter
2dce2ace2c
Pass args.verbose?
to Bintray
.
2020-08-06 16:12:52 +02:00
Mike McQuaid
51ff5eb401
Merge pull request #8219 from Homebrew/dependabot/bundler/docs/dnsruby-1.61.4
...
build(deps): bump dnsruby from 1.61.3 to 1.61.4 in /docs
2020-08-06 15:02:47 +01:00
Mike McQuaid
5edd58109b
Merge pull request #8235 from MikeMcQuaid/cleanup-steps
...
workflows/tests: cleanup steps.
2020-08-06 14:39:29 +01:00
Mike McQuaid
5c5607271c
Merge pull request #8236 from MikeMcQuaid/tap-info-comma
...
cmd/tap-info: improve comma usage.
2020-08-06 14:37:30 +01:00
Mike McQuaid
b23d2f02a8
workflows/tests: cleanup steps.
...
Set up Homebrew should handle both the Git and Ruby setup for us (and
do so faster).
2020-08-06 14:02:47 +01:00
Mike McQuaid
99bff13cbb
cmd/tap-info: improve comma usage.
...
Broken in https://github.com/Homebrew/brew/pull/8230 .
2020-08-06 14:00:56 +01:00
Mike McQuaid
a9f5925cdf
Merge pull request #8230 from MikeMcQuaid/tap-pin
...
Remove more tap pinning code.
2020-08-06 12:49:47 +01:00
Mike McQuaid
fb0a6338b1
Remove more tap pinning code.
...
This was deprecated and removed a while ago.
2020-08-06 12:24:10 +01:00
Mike McQuaid
4f502daf90
Merge pull request #8234 from Homebrew/revert-8216-deprecate-global-args
...
Revert "Deprecate global `Homebrew.args`."
2020-08-06 11:44:14 +01:00
Mike McQuaid
8d884e7c3b
Merge pull request #8221 from MikeMcQuaid/homebrew-actions
...
workflows/tests: use setup-homebrew GitHub Action.
2020-08-06 11:26:27 +01:00
Mike McQuaid
e514ec823d
Merge pull request #8232 from miccal/cask_upgrade
...
cask/cmd/upgrade: output cask upgrades on new line
2020-08-06 11:19:28 +01:00
Mike McQuaid
fab1009c00
Revert "Deprecate global Homebrew.args
."
2020-08-06 11:09:20 +01:00
Mike McQuaid
b0d26b0dcf
workflows/tests: use setup-homebrew GitHub Action.
...
This allows more code reuse.
2020-08-06 10:55:18 +01:00
Mike McQuaid
c761c04e26
Merge pull request #8231 from MikeMcQuaid/audit-tap
...
audit: add --tap argument.
2020-08-06 10:54:14 +01:00
miccal
3b2a7a0340
cask/cmd/upgrade: output cask upgrades on new line
2020-08-06 17:25:46 +08:00
Mike McQuaid
6ea3fd0513
Merge pull request #8227 from miccal/brew_upgrade_change
...
cask/cmd/update: output message consistency
2020-08-06 09:56:10 +01:00
Mike McQuaid
25db878902
Merge pull request #8229 from MikeMcQuaid/casks-consistency
...
Handle casks in commands more consistently.
2020-08-06 09:50:12 +01:00
Mike McQuaid
a3b4ea0443
audit: add --tap argument.
...
This allows auditing a single tap (so is useful for `test-bot`).
2020-08-06 09:43:02 +01:00
Mike McQuaid
ced084bd49
Handle casks in commands more consistently.
...
- Ensure the usage documentation always mentions casks when appropriate
- Use --formulae or --casks consistently
- Provide --formulae and --casks switches to upgrade
- Mark more switches as conflicting
2020-08-06 09:25:45 +01:00
miccal
a4f676c556
cask/cmd/update: output message consistency
2020-08-06 16:16:44 +08:00
Seeker
c066bc154c
bump-formula-pr: only check closed PRs for exact match
2020-08-05 12:52:01 -07:00
Seeker
ab9b15caeb
Merge pull request #8222 from SeekingMeaning/bump-formula-pr/fix
...
bump-formula-pr: fix check_all_pull_requests
2020-08-05 12:37:07 -07:00
Markus Reiter
12d8f02a33
Merge pull request #8216 from reitermarkus/deprecate-global-args
...
Deprecate global `Homebrew.args`.
2020-08-05 21:10:48 +02:00