Mike McQuaid
1ebb1c2885
Merge pull request #7580 from tharun208/brew-cask-analytics
...
Added analytics for cask info
2020-05-20 08:06:46 +01:00
Tharun
aeede8374f
fixed review changes
2020-05-19 21:41:02 +05:30
Tharun
84f2edc884
replaced json and used dictionary
2020-05-19 19:35:30 +05:30
Tharun
6a50f31feb
fixed proper parsing of mock data for analytics
2020-05-19 17:25:16 +05:30
Tharun
9e26a451e3
Updated mocking analytics call
2020-05-19 14:58:55 +05:30
Mike McQuaid
0e9897c86d
Merge pull request #7577 from vidusheeamoli/add-byebug
...
Set up Byebug debugger
2020-05-19 08:27:53 +01:00
Tharun
6e543f7289
Updated test with stubing cask analytics call
2020-05-18 20:46:43 +05:30
Mathäus Zingerle
82ba0475ad
audit: Port version checks that do not rely on Formula
state to RuboCop and add tests
2020-05-18 10:12:13 -05:00
Mike McQuaid
4f75a77b08
Update deprecations
...
Add more deprecations, disable deprecations and remove disabled code.
2020-05-18 13:50:46 +01:00
vidusheeamoli
4f1e9f44a1
set up byebug debugger
2020-05-18 16:28:43 +05:30
Tharun
4aba04556e
Updated tests
2020-05-17 02:55:07 +05:30
nandahkrishna
a4f9a66406
livecheck: add component order rubocop
2020-05-15 19:00:14 +05:30
Shaun Jackman
133ee7966d
shell: Use .profile unless .bash_profile exists
2020-05-13 09:30:02 -07:00
Mike McQuaid
08a9f0e1c0
Use FormulaInstaller#fetch before #prelude.
2020-05-11 09:38:26 +01:00
Michelle Nguyen
2264c08cee
Fetch formula resources before unlinking during upgrade.
...
Fixes #6374 .
2020-05-11 09:37:56 +01:00
Mike McQuaid
35e487064e
Merge pull request #7537 from MikeMcQuaid/cli_parser_formulae
...
Replace ARGV#flags_only with Homebrew.args.flags_only
2020-05-11 08:47:12 +01:00
nandahkrishna
77e74e7e69
Adding livecheck Formula DSL
2020-05-11 09:41:13 +05:30
Mike McQuaid
fa0d454817
Replace ARGV#flags_only with Homebrew.args.flags_only
...
Take two on https://github.com/Homebrew/brew/pull/7490
2020-05-10 15:12:25 +01:00
Mike McQuaid
c91f397605
cli: fix options handling.
...
Fix breaking options on taps again (second time in two weeks, sob).
To avoid doing this again: also add a test for this case (that I've
verified would have caught these cases).
2020-05-07 10:33:02 +01:00
Mike McQuaid
60c9472b14
rubocop_rspec: disable RSpec/FilePath.
...
We keep adding to the list of exceptions and this fails if it isn't run
in the right directory.
2020-05-05 15:50:10 +01:00
Mike McQuaid
316da98140
Merge pull request #7503 from Bo98/since-fix
...
os/mac/software_spec: fix argument error in valid use case
2020-05-05 09:10:33 +01:00
vidusheeamoli
f851688541
audit: Port audit_keg_only to rubocop and add tests
...
audit: add test
audit: fixed test
audit: added another test case
audit: fix test
audit: fix test
audit: fix keg only
2020-05-05 10:47:49 +05:30
Bo Anderson
16141e7eff
os/mac/software_spec: fix argument error in valid use case
2020-05-04 17:16:39 +01:00
Mike McQuaid
e1f3b0b971
Merge pull request #7500 from MikeMcQuaid/deps_args_spec
...
deps_spec: check args.
2020-05-04 13:28:13 +01:00
Mike McQuaid
f567302ebf
deps_spec: check args.
2020-05-04 12:59:56 +01:00
Mike McQuaid
ae353ff42e
Revert "ARGV: Deprecate ARGV.flags_only and replace with Homebrew.args.flags_only"
2020-05-04 11:12:25 +01:00
Gautham G
b40e33aeb8
ARGV: Deprecate ARGV.cc and replace with Homebrew.args.cc
2020-05-04 11:14:55 +05:30
Gautham G
66ac96acde
ARGV: Depercate ARGV.flags_only and replace with Homebrew.args.flags_only
2020-05-03 13:55:51 +05:30
Mike McQuaid
b2571d42eb
Merge pull request #7484 from MikeMcQuaid/cleanup-sandbox
...
Cleanup Sandbox code
2020-05-02 14:16:09 +01:00
Mike McQuaid
40ec8e69cc
Cleanup Sandbox code
...
Remove unused code and methods.
2020-05-02 13:45:04 +01:00
Gautham G
38c24d134c
ARGV: Deprecate ARGV.casks and replace with Homebrew.args.casks
2020-05-02 13:21:16 +05:30
Gautham G
f6abc6fe19
ARGV: Deprecate ARGV.formulae, replace with Homebrew.args.formulae
2020-05-01 22:50:59 +05:30
Mike McQuaid
e6dffdd006
Merge pull request #7458 from Bo98/uses_since
...
software_spec: add uses_from_macos since bound
2020-05-01 12:53:59 +01:00
Mike McQuaid
e8a29a2d72
Merge pull request #7440 from FTLam11/FTLam11-#7432-add-json-option-to-brew-cask-outdated
...
Add JSON support for brew cask outdated, fixes #7432
2020-04-29 11:40:22 +01:00
Bo Anderson
eb303dd654
software_spec: add uses_from_macos since bound
2020-04-28 16:45:32 +01:00
Claudia
c85df70757
Fix flaw in Cask test helper
...
This commit fixes a flaw in the Cask test helper, causing the broken `Cask::Config` test to actually fail.
The flaw occurred while patching the `Cask::Config::DEFAULT_DIRS` hash.
While the original hash uses strings as values, the patched one used
`Pathname` values, masking a broken `Cask::Config::from_json` test.
Now the broken test fails like it should.
2020-04-27 15:09:36 +02:00
Claudia
cad8be3278
Add broken test, revealing test helper flaw
...
This commit adds a broken test, which is meant to expose a flaw in the
constructor of `Cask::Config`.
That (broken) test still passes because there’s also a flaw in our
test helper code.
The helper flaw happens to neutralize the `Cask::Config` flaw.
2020-04-27 15:00:22 +02:00
Claudia
dd3267ece0
Add test for JSON-based cask config loader
...
Previously, the JSON-based cask config loader was untested.
This commit changes the interface to accept a string, making the loader
easier to test. The commit also adds a test.
2020-04-27 14:54:56 +02:00
Frank Lam
dabbfe3e3e
Fix linter offenses
2020-04-26 21:31:21 +08:00
Frank Lam
f2fa2c5d30
Add JSON support to brew cask outdated
...
* brew outdated already has JSON support, now users and tools can get
similar results with brew cask outdated --json
2020-04-26 21:13:19 +08:00
Claudia
374f788a3c
cask/config_spec: add failing test
...
We recently added a new global artifact and then updated a cask to
make use of that new artifact. This caused a number of `brew cask`
commands to fail for users who had the cask installed before the
artifact was added.
This commit adds test cases for that failure mode.
See also:
- https://github.com/Homebrew/brew/pull/7286#issuecomment-613376568
- https://discourse.brew.sh/t/cask-definition-is-invalid-invalid-mdimporter-stanza-key-not-found-mdimporterdir
2020-04-21 18:26:51 +02:00
Alexander Bayandin
bd24f5a45e
bintray: fix package creation
2020-04-21 14:36:01 +01:00
Mike McQuaid
fb0fa419ab
cask/cmd/upgrade_spec: remove more flaky tests.
2020-04-20 16:45:44 +01:00
Mike McQuaid
c4fed07d34
Merge pull request #7401 from dawidd6/pr-upload
...
Add pr-upload command
2020-04-20 16:33:06 +01:00
Dawid Dziurla
3dd5a7465d
add pr-upload command
2020-04-20 13:37:05 +02:00
Mike McQuaid
cddc67b451
rubocops/uses_from_macos: update list.
...
Also, provide details on how to update this in future and split it into
two.
Fixes #7396
2020-04-20 10:36:42 +01:00
Mike McQuaid
75c74e4674
cask/cmd/upgrade_spec: remove flaky test.
2020-04-20 09:25:16 +01:00
Mike McQuaid
8eed72cd8b
Move file mode audit to RuboCop.
2020-04-18 15:44:24 +01:00
Mike McQuaid
8a0e6a1603
test/cask/cmd/upgrade_spec: remove flaky test.
...
This is the second flaky test removed in this file. Tempting to just
remove the whole file if there's more.
2020-04-18 14:37:10 +01:00
Mike McQuaid
5e2351cde6
dev-cmd/audit: add --skip-style option.
...
This will allow `brew style` and `brew audit` to be run separately
without providing duplicates.
Additionally, run RuboCop style rules when `--strict` isn't provided and
remove a confusing reference to `style`.
2020-04-16 08:24:38 +01:00