3482 Commits

Author SHA1 Message Date
Markus Reiter
df3bbd0299 Reduce need for interpolating appdir in casks. 2019-10-24 17:07:30 +02:00
Markus Reiter
e6cfb4a3c2
Merge pull request #6629 from timsly/manpage-artifact
Add Manpage artifact
2019-10-24 13:48:52 +02:00
Tim Masliuchenko
91ddb6e53d Cleanup specs 2019-10-24 14:22:13 +03:00
Tim Masliuchenko
87f29857f0 Pass section to the constructor 2019-10-23 18:34:16 +03:00
Tim Masliuchenko
22d821323c Feedbacks 2019-10-23 16:28:00 +03:00
Markus Reiter
04493e2dde Fix trash.swift without arguments. 2019-10-23 06:59:39 +02:00
Markus Reiter
299bb1c25f
Merge pull request #6628 from reitermarkus/automation-access
Remove `User::automation_access?`.
2019-10-22 20:52:37 +02:00
Tim Masliuchenko
3ef5e06943 Add Manpage artifact 2019-10-22 15:21:49 +03:00
Mike McQuaid
cddf402365
Merge pull request #6620 from scpeters/must_exist_frameworks
os/mac/keg: Frameworks -> MUST_EXIST_DIRECTORIES
2019-10-22 09:15:51 +01:00
Markus Reiter
7a5e4d1269 Remove User::automation_access?. 2019-10-22 07:38:35 +02:00
Steven Peters
1ad0addbc8 spec_helper: always remove Frameworks 2019-10-21 12:27:39 -07:00
Steven Peters
875bfbc8d3 spec_helper: workaround for removing Frameworks 2019-10-20 22:47:46 -07:00
Cheng XU
163ef284d2
brew test: more fixes for ARM
On ARMv7, the arch name is armv7l instead of armv7. So update the bottle
file name accordingly.
2019-10-19 15:20:35 +08:00
Cheng XU
c98b77fd3e
cpu_spec: fix for ARM 2019-10-18 15:33:28 +08:00
Cheng XU
f0e848b3e0
fixtures: add testball bottle for ARM
Also fix the absolute link used by testball_bottle-0.1.intel_macintosh.bottle.tar.gz
2019-10-18 15:30:24 +08:00
Mike McQuaid
8a93230c15
test/cask: remove disabled functionality tests. 2019-10-15 09:52:33 +01:00
Mike McQuaid
02ded996a4
formulary_spec: remove deprecated tap-pin usage. 2019-10-15 09:13:11 +01:00
Mike McQuaid
1b4fdc17f4
Raise deprecation exceptions in tests
Previously tests which hit `odeprecated` would print warnings but not
always raise exceptions or fail. Combine this with the ability to have
`odeprecated` to turn into `odisabled` on certain dates and you have
tests that may fail just on the clock changing (this is bad).

Instead, ensure that tests always raise deprecations as exceptions so
that new deprecations will have their tests handled immediately.
2019-10-15 08:52:42 +01:00
Issy Long
1f6168fe8a
Change regexp.match?(string) to string.match?(regexp) everywhere
- Only try to call `.match?` on strings that aren't nil.
2019-10-13 23:22:51 +01:00
Issy Long
fed1bbe029
Disable Metrics/LineLength for long URL lines in patches_spec.rb
- The final two `brew style` offenses were for Metrics/LineLength where
  parsing the GitHub diff URL as a regex took 119/118 lines.
- This disables the cop for each of those long, problematic lines, and
  re-enables them straight afterwards, else they'd apply to the whole file
  from the first occurrence onwards, which we probably don't want?
- I wondered about increasing the LineLength limit to 119 or 120, but
  it appears to have been set for a justifiable reason in 80d75bc0d8.
2019-10-13 16:04:37 +01:00
Issy Long
341ea60807
Auto-fix Style/RedundantBegin offenses
- This also required auto-fixes for Layout/EmptyLinesAroundBlockBody and
  Layout/InconsistentIndentation once the auto-fixer had got rid of the
  "redundant begin"s.
2019-10-13 16:04:27 +01:00
Issy Long
b78028b9c2
Auto-fix Performance/RegexpMatch offenses 2019-10-13 16:04:26 +01:00
Mike McQuaid
0d068341fc
Merge pull request #6467 from EricFromCanada/uses_from_macos-json
Expose `uses_from_macos` list in formula API
2019-10-11 09:28:01 +01:00
Jacob Middag
c6cb20a768
Fix frozen string bug 2019-10-11 09:34:43 +02:00
Mike McQuaid
a1a0569f75
Merge pull request #6578 from dawidd6/audit-uses-from-macos
audit: replace depends_on with uses_from_macos
2019-10-10 19:20:17 +01:00
Dawid Dziurla
86feb5a9de
audit: replace depends_on with uses_from_macos 2019-10-10 17:59:32 +02:00
Mike McQuaid
2d51b8189b
test: disable some tests on Linux portable ruby. 2019-10-10 16:17:06 +01:00
Mike McQuaid
e3ee64a5fd
Ruby 2.6.3 brew tests fixes 2019-10-10 16:17:06 +01:00
Mike McQuaid
69c1b4fcf9
subversion_spec: fix svnadmin calls on Linux.
Ensure that we only use `xcrun` on Catalina or newer.
2019-10-10 10:45:22 +01:00
Mike McQuaid
8a8fc68264
Ruby 2.6.3 brew tests fixes 2019-10-08 17:39:31 +01:00
David O'Trakoun
960b8b659c
Support for zsh ZDOTDIR, FIX #6533
- Add test spec with ZDOTDIR set and unset
2019-10-06 12:40:18 -04:00
Markus Reiter
e719744248 Refactor brew style. 2019-10-05 00:20:06 +02:00
Markus Reiter
b6b9cd248c Refactor brew cask style. 2019-10-04 23:43:48 +02:00
Markus Reiter
a49282c318 Simplify return value logic. 2019-10-04 23:39:26 +02:00
Markus Reiter
7f39d333bc Move assert_success to SystemCommand::Result. 2019-10-04 23:39:25 +02:00
Markus Reiter
e351e6b31c
Merge pull request #6482 from alecclarke/run-style-checks-on-test-casks
Include test casks in the cask style check.
2019-10-04 23:15:59 +02:00
Markus Reiter
b1d0c61fea Update Gems. 2019-10-03 09:22:44 +02:00
Mike McQuaid
eb9a31b52b
requirement_spec: use describe correctly. 2019-09-27 15:27:21 +01:00
Gautham Goli
e88f6b9da9 args: Add passthrough method and tests 2019-09-26 10:33:40 +05:30
EricFromCanada
f6ef26a127 Fix OS version logic for uses_from_macos 2019-09-23 13:00:58 -04:00
Alec Clarke
45806f6a97 Include test casks in the cask style check.
Currently the tests casks found in "/Homebrew/test/support/fixtures/cask/Casks" and "/Homebrew/test/support/fixtures/third-party/Casks" aren't included in the paths checked when running "brew cask style".

This change includes these test cask paths in the checked paths, and also includes the auto style fixes made by running `brew cask style --fix`.
2019-09-23 08:50:24 -04:00
Gautham Goli
d18b122272 cli_args: Fix options_only and flags_only 2019-09-22 20:28:43 +05:30
Alec Clarke
af10d13381 Check blacklisted Casks when auditing.
In some cases, certain Casks shouldn't be resubmitted for specific reasons: difficult to maintain, developers maintain their own version, ...

To make sure these cases are restricted - we can add them to a blacklist and have the blacklist checked as part of the `brew cask audit` steps.
2019-09-17 06:29:46 -07:00
Markus Reiter
d8afed206f Use AppleScript to check if GUI apps are running. 2019-09-15 01:37:04 +02:00
Markus Reiter
f010aa48ff Skip AppleScript actions if Automation Access isn't granted. 2019-09-13 16:35:44 +02:00
Mike McQuaid
963cc556d4
Revert "argv: move options_only to cli/args" 2019-09-13 09:34:43 +01:00
Mike McQuaid
7df0292f9b
Revert "argv: move flags_only to cli/args" 2019-09-13 09:12:26 +01:00
Gautham Goli
c7681c4287 argv: move flags_only to cli/args 2019-09-09 14:51:36 +05:30
Gautham Goli
4586632855 argv: move options_only to cli/args 2019-09-07 21:32:50 +05:30
Sean Molenaar
8cb833f7da
Audit bitbucket.com repositories 2019-09-05 20:56:25 +02:00