Jan Viljanen
96e5b8d9b1
fix rubocop offences
2018-10-16 22:44:07 +02:00
Mike McQuaid
4def45f499
utils/github_spec: use author that exists.
2018-10-15 14:15:08 -07:00
Markus Reiter
2308f0c571
Skip quitting applications when not logged into GUI.
2018-10-02 16:27:45 +02:00
Mike McQuaid
78eba5b815
Autofix RuboCop RSpec failures
2018-09-20 13:36:42 +01:00
Shaun Jackman
f6093961ef
Add Homebrew::DEFAULT_PREFIX for Linux
...
The default prefix is /usr/local on macOS
and /home/linuxbrew/.linuxbrew on Linux.
2018-09-11 09:57:08 -07:00
William Woodruff
367629d289
utils: Use JSON to marshal child errors
...
Replaces our serialization of child process
errors via Marshal with JSON, preventing
unintentional or malicious code execution outside
of the build sandbox.
Additionally, adds tests for the new behavior.
2018-09-04 11:03:32 -04:00
Mike McQuaid
ec9e45a8f0
tests: handle file leaks and SVN test prompt.
...
- Ignore files that are generated by `brew tests`
- Make the SVN tests work without prompting for GitHub's SSL certificate
2018-09-02 13:43:58 +01:00
Markus Reiter
0b80aea75d
Use https:// URLs.
2018-08-06 23:39:12 +02:00
Markus Reiter
8ae284e871
Use SystemCommand for curl.
2018-08-01 01:04:42 +02:00
ilovezfs
cd2b85c40f
Revert "Use SystemCommand for curl."
2018-07-29 21:45:04 -07:00
Markus Reiter
355df64d93
Use SystemCommand for curl.
2018-07-29 01:23:33 +02:00
Andrew Janke
e0a8a79921
Style fixes for Rubocop 0.57.1
2018-06-30 19:40:14 -04:00
Maxim Belkin
e5435dfeb7
Cross-platform diagnostics.
2018-05-14 04:44:15 -05:00
Mike McQuaid
ae5e904c08
Only read curlrc if HOMEBREW_CURLRC is set.
...
This reverses the previous, incorrect order.
2018-04-09 15:43:03 -07:00
Mike McQuaid
99b89e4866
Merge pull request #4022 from stefansundin/disable-curlrc
...
Tell curl to not use .curlrc
2018-04-08 16:37:49 -07:00
Mike McQuaid
d331c47de0
diagnostic: remove check_user_curlrc check.
2018-04-08 16:07:21 -07:00
Mike McQuaid
9fca172d03
Fix HOMEBREW_RUBY_WARNINGS="-w"
...
Fix various circular requirements, method redefinitions, etc.
2018-04-07 20:28:56 +01:00
Stefan Sundin
0ec47813f1
Prevent .curlrc from being loaded.
2018-04-06 14:13:26 -07:00
Mike McQuaid
5e1806e796
test: rubocop-rspec style auto-corrects.
...
There’s too many warnings to start enabling `rubocop-rspec` by default
but let’s at least apply the cleanups it does automatically.
2018-03-25 13:30:37 +01:00
Mike McQuaid
cb6828dbe6
Merge pull request #3925 from maxim-belkin/git_remote_exists_bool
...
append ? to git_remote_exists
2018-03-15 08:20:14 +00:00
Maxim Belkin
c99cfd1591
add ? to svn_remote_exist
2018-03-14 16:55:45 -05:00
Maxim Belkin
f984701c29
append ? to git_remote_exist
2018-03-14 16:30:45 -05:00
Mike McQuaid
83cca40fc9
RuboCop 0.53.0 manual fixes.
2018-03-08 14:10:02 +00:00
Shaun Jackman
d70d91cf2a
test/utils/svn: Requires svn to succeed
2018-02-15 13:50:09 -08:00
joshua stein
7388acb86e
Tty: if HOMEBREW_NO_COLOR env var is present, disable color
...
bin/brew will recognize NO_COLOR variable and copy it to
HOMEBREW_NO_COLOR
2018-02-12 14:19:25 -06:00
Mike McQuaid
0d53831b90
Merge pull request #3515 from sjackman/popen
...
Utils.popen_read: Nonexistent program should fail
2017-12-03 09:23:01 +00:00
Shaun Jackman
7adee6d62f
Utils.popen_read: Nonexistent program should fail
...
Ensure that $CHILD_STATUS.success? is false when the command does not exist.
2017-12-02 15:52:01 -08:00
Shaun Jackman
7c6d2c95f6
Fix a test failure when svn is not installed
2017-12-02 09:04:42 -08:00
Josh Soref
b9a33b03a4
spelling: parameters
2017-09-10 16:39:18 +00:00
Viktor Szakats
a6d1ddf326
git_spec.rb: use HTTPS for Git remote test
2017-09-07 08:02:05 +00:00
Mike McQuaid
3bb98714af
Merge pull request #2955 from mansimarkaur/git_tests
...
Added tests for utils/git
2017-09-02 15:53:32 +01:00
Misty De Meo
156bca7dfb
Merge pull request #2950 from mansimarkaur/svn
...
Added tests for utils/svn
2017-08-29 15:08:05 -07:00
mansimarkaur
784250d550
Used already existing clear_git_available_cache to remove @git
2017-08-29 22:53:10 +05:30
mansimarkaur
db28126b4a
Used clear_anonymous_os_prefix_ci_cache to remove @anonymous_os_prefix_ci
2017-08-29 16:24:19 +05:30
mansimarkaur
59f3c661a3
Used ENV.delete to remove set ENV vars
2017-08-29 16:24:19 +05:30
mansimarkaur
a4d8d7ba57
Added tests for report_build_error
2017-08-29 16:24:19 +05:30
mansimarkaur
2660f5ae3e
Added tests for report and report_event
2017-08-29 16:24:19 +05:30
mansimarkaur
a4d4da64aa
Added tests for os_prefix_ci
2017-08-29 16:24:19 +05:30
mansimarkaur
d533973395
Used clear_svn_version_cache to remove @svn
2017-08-29 16:16:17 +05:30
mansimarkaur
53be6bb4bd
Added check for svn availability
2017-08-29 16:16:17 +05:30
mansimarkaur
cf96d8d970
Improved tests for svn_available?
2017-08-29 16:16:17 +05:30
mansimarkaur
13fb14a95f
Added tests fir utils/svn
2017-08-29 16:16:17 +05:30
mansimarkaur
c695dffd37
Added clear git version cache method
2017-08-27 01:23:32 +05:30
mansimarkaur
372a422305
Added tests for ensure_git_installed when git is available or homebrew/core is unavailable
2017-08-27 01:23:32 +05:30
mansimarkaur
abe78ebb8e
Removed shutup
2017-08-27 01:23:32 +05:30
mansimarkaur
4f0f55a774
Used system command to run git commands
2017-08-27 01:23:32 +05:30
mansimarkaur
660617a35b
Added tests for Utils
2017-08-27 01:23:32 +05:30
mansimarkaur
657b6ef7fb
Added tests for git_available?
2017-08-27 01:23:32 +05:30
mansimarkaur
d91036e891
Added tests for last_revision_commit_of_file
2017-08-27 01:23:32 +05:30
Ben Muschol
564a06dfbb
Fix typo in spec
2017-08-17 13:44:18 -04:00
