Mike McQuaid
80d75bc0d8
Homebrew/.rubocop: tweak rules.
...
Adjust the rules based on the current codebase. Remove various enable,
disables and default values that are unnecessary. Add more comments
explaining why. Make minor changes needed to enable a few more rules.
2018-09-02 20:15:09 +01:00
Mike McQuaid
bcb1ec5499
Improve Homebrew/brew line length.
...
Use 124 max line length everywhere. Also, reduce tap max line length to
189 as Homebrew/homebrew-core has that as a maximum now. In future
Homebrew/homebrew-core will also be reduced to 124 maximum line length.
2018-09-02 16:15:09 +01:00
commitay
e4049b3005
Merge pull request #4775 from commitay/cargo-install
...
text_cop: update `cargo build` cop
2018-08-30 08:03:42 +10:00
commitay
0ce583964e
text_cop: update cargo build cop
2018-08-29 23:06:53 +10:00
Markus Reiter
444e3d2a78
Add $LOAD_PATH for RuboCop cops.
2018-08-29 01:44:47 +02:00
Jonathan Chang
ca59377a90
audit: add autocorrect and tests for test checks
2018-08-16 12:43:50 -04:00
Jonathan Chang
5f981a8722
tests: add test for test calls audit cop
2018-08-16 12:43:13 -04:00
Dominyk Tiller
f1779248de
Merge pull request #4625 from DomT4/please_stop_evading_the_audit
...
class_cop: tighten test audit
2018-08-08 16:32:28 +01:00
Dominyk Tiller
7d5f0df71d
class_cop_spec: add tests for tighter test audit
2018-08-07 03:46:37 +01:00
Markus Reiter
0b80aea75d
Use https:// URLs.
2018-08-06 23:39:12 +02:00
Dominyk Tiller
525300b9cd
formula_desc_cop_spec: add whitespace tests
2018-08-06 19:31:30 +01:00
Dominyk Tiller
9d7f872ad6
formula_desc_cop_spec: tweak for new whitespace check
2018-08-06 19:15:31 +01:00
Markus Reiter
7762ce32aa
Use more descriptive heredoc names.
2018-07-11 18:15:30 +02:00
commitay
44873fd4c8
bottle_block_cop: remove
2018-07-04 21:25:43 +10:00
commitay
4dba9fddf1
components_redundancy: audit stable do without a head or devel spec
2018-07-03 11:56:31 +10:00
Markus Reiter
fdb2406b20
Add failing spec for DependencyOrder cop.
2018-06-11 04:21:06 +02:00
commitay
3329a9f6d8
text_cop: require cargo to use install instead of build
2018-06-10 16:42:19 +10:00
commitay
490dc9118e
text_cop: require dep ensure to use -vendor-only
2018-06-08 00:42:57 +10:00
commitay
1a4340161c
options_cop: formula -> formulae
2018-06-02 16:56:55 +10:00
commitay
9d55fed15f
audit: new formulae should not have options
2018-05-22 19:39:14 +10:00
Gautham Goli
efec2fa0c5
lines_cop: Add deprected options audit for depends_on
2018-05-06 15:42:51 +05:30
ilovezfs
ae6ae30857
Merge pull request #4110 from commitay/desc_cop
...
formula_desc_cop desclength: make non-strict
2018-04-25 06:01:42 -07:00
Mike McQuaid
9089ea4df3
Merge pull request #4109 from commitay/components_redundancy_cop
...
components_redundancy_cop: make non-strict
2018-04-25 08:32:35 +01:00
Mike McQuaid
56124f2918
Merge pull request #4108 from commitay/urls_cop_pypi
...
urls_cop pypiurls: make non-strict
2018-04-25 08:32:30 +01:00
commitay
156451bd4b
formula_desc_cop desclength: make non-strict
2018-04-25 16:38:40 +10:00
commitay
1b7e6f7eb2
urls_cop pypiurls: make non-strict
2018-04-25 12:18:22 +10:00
commitay
9e24cb9c62
components_redundancy_cop: make non-strict
2018-04-25 07:58:01 +10:00
commitay
1d3ed256a0
components_order_cop: make non-strict
2018-04-24 19:32:53 +10:00
Kevin Abel
1b22e16a08
rubocop: Fix audit for dependency order with multiple tags
...
Dependencies that have multiple tags (`[:build, :test]`) get sorted into
multiple locations resulting in the cop always reporting an offense
regardless of order.
2018-03-28 20:54:39 -05:00
Gautham Goli
09f343d496
rubocop: Add cop to check depends_on order and tests
2018-03-01 12:32:25 +05:30
Mike McQuaid
f9b6407110
lines_cop: deprecate 'needs :openmp'.
2017-12-30 20:56:55 +00:00
Mike McQuaid
d54e670a64
requirements: move more to compat.
2017-12-30 20:56:55 +00:00
Mike McQuaid
b4d43e950f
Merge pull request #3401 from DomT4/vendor_or_na
...
go: various tweaks to recommendations
2017-12-16 13:34:22 +00:00
Gautham Goli
fb85ed01bc
lines_cop: Convert ARGV audit to negative look ahead
2017-12-02 17:03:11 +05:30
Mike McQuaid
872bd4f703
Merge pull request #3395 from GauthamGoli/parameters-audit-regex-fix
...
lines_cop: Update regex patterns to prevent false positives
2017-11-03 17:48:09 +00:00
Dominyk Tiller
bff4762d36
text_cop_spec: update go get tests
2017-10-31 01:01:42 +00:00
Gautham Goli
f648dd03ff
lines_cop: Update regex patterns to prevent false positives
2017-10-29 23:40:04 +05:30
Isabell Long
640b1e9dcb
formula_desc_cop: ensure no full stops at the end of desc
...
- This was a suggestion by Mike McQuaid in my `homebrew-core` audit
description PR. Based on ilovezfs's incantation `grep -r -E 'desc
".*\."' *.rb`, some formulae descriptions do end in full stops. (My
initial assessment of this failed to account for the fact that
descriptions are strings and so end in `"`.)
- Add an autocorrect for this cop, too.
2017-10-29 15:19:31 +00:00
Markus Reiter
7e970216a3
Refactor and fix RuboCop specs.
2017-10-24 19:39:40 +02:00
Gautham Goli
7b2fab8ec5
Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1
2017-10-21 13:53:44 +05:30
Gautham Goli
ee35d65867
lines_cop: Refactor to multiple cops and fix style violations
2017-10-21 12:50:49 +05:30
Gautham Goli
bdc7eba4b3
Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1
2017-10-21 01:48:00 +05:30
Markus Reiter
9bee9ca575
Use “squiggly” heredocs.
2017-10-18 14:39:09 +02:00
Mike McQuaid
1d40061c69
Merge pull request #3291 from JCount/lines-cop-fix-wine-universal-binary
...
lines_cop: add ENV.universal_binary audit exemption for wine
2017-10-18 10:32:34 +01:00
JCount
85fa79b5cf
lines_cop_spec: improve language in universal_binary and build tests
2017-10-15 10:36:51 -04:00
JCount
ca52eee2ad
lines_cop_spec: add test for ENV.universal_binary audit exemption for wine
2017-10-15 10:26:03 -04:00
Dominyk Tiller
29070e5cbe
formula_desc_cop_spec: add empty string test
2017-10-14 02:50:08 +01:00
Gautham Goli
7fa51f71f1
Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1
2017-10-13 19:50:46 +05:30
Markus Reiter
9795195726
Fix RuboCop tests.
2017-10-07 23:30:47 +02:00
Gautham Goli
626cb6ca91
audit: Add more tests for FormulaAudit/Miscellaneous cop
2017-09-18 18:03:54 +05:30
