375 Commits

Author SHA1 Message Date
Mike McQuaid
667c2b8804
Merge pull request #8382 from Bo98/startup-speedup
Lazily require some heavy files
2020-08-21 17:11:39 +01:00
Markus Reiter
15279d78b7
Merge pull request #8370 from miccal/cask_symlinked
cask/artifact/symlinked: do not overwrite files or symbolic links
2020-08-20 21:03:19 +02:00
Bo Anderson
e3372e2a14 Lazily require some heavy files 2020-08-20 02:05:17 +01:00
Mike McQuaid
3a91c37e66
Fix RuboCop checks. 2020-08-19 17:12:32 +01:00
William Ma
3918e13070 cask --cache: Deprecate command 2020-08-18 10:37:29 -04:00
miccal
5a74f1d971 binary_spec: fix test 2020-08-18 04:19:48 +08:00
Sean Molenaar
5d38cd7296
cask/list: fix artifact list 2020-08-14 23:12:17 +02:00
William Ma
2f68aad417 home: Deprecate brew cask home 2020-08-14 11:02:30 -04:00
Markus Reiter
3b2a9c3b55
Merge pull request #8335 from waldyrious/show-cask-descs-in-info-command
Show cask description in `brew cask info` command
2020-08-14 00:52:27 +02:00
Waldir Pimenta
53932185e6 Show cask description as None if not present 2020-08-13 22:21:10 +01:00
Waldir Pimenta
619af6a723 Show cask description in brew cask info command 2020-08-13 22:21:10 +01:00
Waldir Pimenta
efbfb90c42 Use cask with name for basic info command test
Also add non-dummy URL in the test fixture, to match the name, version, etc.
2020-08-13 22:21:10 +01:00
Markus Reiter
b48bc316e0 Use CLI::Parser for cask commands. 2020-08-13 05:15:15 +02:00
Markus Reiter
9ea1dcf4ca Fix auditing of cask languages. 2020-08-12 00:45:01 +02:00
Markus Reiter
0d9e28d305 Don't warn about version designation in cask-versions tap. 2020-08-11 21:42:21 +02:00
Markus Reiter
549cd5b471 Ensure new casks have a description. 2020-08-10 19:51:03 +02:00
Markus Reiter
8a32954940 Move cask/all to just cask. 2020-08-09 01:34:07 +02:00
Waldir Pimenta
ffed8fdbb3 Add a desc stanza to the cask DSL 2020-08-08 23:02:23 +01:00
Seeker
3a2dc79153 cask/create: update template to match new style 2020-08-06 09:39:07 -07:00
Markus Reiter
5cf7ffd93e Make Cask::Auditor return a Hash with warnings and errors. 2020-07-28 09:50:15 +02:00
Mike McQuaid
25db60ebbb
Unify (mostly) Homebrew code style
Make the Homebrew/cask and Homebrew/homebrew-core style more closely
match the rest of Homebrew.

To accomplish this:
- Run `brew cask style` to ensure we don't break style there when
  making changes or upgrading RuboCop in Homebrew/brew.
- Fix the HomepageMatchesUrl cop to better handle weird input.
- Remove the now unneeded `.rubocop_shared.yml`
- Fix the cask fixtures with `brew cask style --fix`.
- Share more style between Homebrew/brew, casks and formulae.
2020-07-27 12:57:40 +01:00
Markus Reiter
365d2b214e Remove useless spec. 2020-07-22 01:09:14 +02:00
Markus Reiter
8d148b1fbc Remove special-casing of MacOS::languages. 2020-07-22 01:09:14 +02:00
Markus Reiter
ee09df8db3 Move Download from Auditor into Audit. 2020-07-22 01:09:14 +02:00
Sean Molenaar
832073a3c7
cask: add list --json 2020-07-10 21:05:12 +02:00
Mike McQuaid
4398e7bf79
Revert "cask/pkg_spec: remove flaky test."
This reverts commit 924af100b73d24dffb2199fa46ae118e8b3bbb29.
2020-06-29 09:50:51 +01:00
Mike McQuaid
2ee93a2476
Revert "remove flaky cask upgrade test"
This reverts commit 626f9406b1987932382814bc7d7cae3b41b771f4.
2020-06-29 09:50:43 +01:00
Mike McQuaid
a9877088ea
Revert "test/cask/cmd/upgrade_spec: remove flaky test."
This reverts commit 8a0e6a1603ce823eb66cc183a692f722668d9c67.
2020-06-29 09:50:36 +01:00
Mike McQuaid
cc0ea9aec3
Revert "cask/cmd/upgrade_spec: remove flaky test."
This reverts commit 75c74e4674d3f6a85c4afce79a6096bcc5cca9fc.
2020-06-29 09:50:29 +01:00
Mike McQuaid
af2c57dbeb
Revert "cask/cmd/upgrade_spec: remove more flaky tests."
This reverts commit fb0fa419abc750bf33695a396244b9cffbea1554.
2020-06-29 09:50:18 +01:00
Mike McQuaid
ac0665daff
Refer to default branch in links with HEAD
Anywhere we can use `blob/master` we can use `blob/HEAD` instead. This
will make life easier if we ever rename our default branch in future
(once/if Git and GitHub provides the necessary tooling to do so).
2020-06-25 11:38:40 +01:00
Sean Molenaar
523c24684d
cask: audit locales 2020-06-16 11:41:06 +02:00
Sean Molenaar
d64afece81
Merge pull request #7690 from SMillerDev/cask/audit/token
cask: codify the token rules
2020-06-16 11:40:25 +02:00
Sean Molenaar
4a24908fe4
cask: codify the token rules 2020-06-11 19:34:36 +02:00
Issy Long
8eba9b86ab
Change occurrences of "blacklist" to "denylist" or "disallow"
- Depending on context, I've gone for either "denylist" or "disallow"
  here. "Disallow" for things in sentences, or actions, and "denylist"
  for list of things.
2020-06-06 22:38:33 +01:00
Sean Molenaar
3567892802
Add notibility checks for casks 2020-05-26 14:21:25 +02:00
Tharun
aeede8374f fixed review changes 2020-05-19 21:41:02 +05:30
Tharun
84f2edc884 replaced json and used dictionary 2020-05-19 19:35:30 +05:30
Tharun
6a50f31feb fixed proper parsing of mock data for analytics 2020-05-19 17:25:16 +05:30
Tharun
9e26a451e3 Updated mocking analytics call 2020-05-19 14:58:55 +05:30
Tharun
6e543f7289 Updated test with stubing cask analytics call 2020-05-18 20:46:43 +05:30
Tharun
4aba04556e Updated tests 2020-05-17 02:55:07 +05:30
Mike McQuaid
e8a29a2d72
Merge pull request #7440 from FTLam11/FTLam11-#7432-add-json-option-to-brew-cask-outdated
Add JSON support for brew cask outdated, fixes #7432
2020-04-29 11:40:22 +01:00
Claudia
cad8be3278
Add broken test, revealing test helper flaw
This commit adds a broken test, which is meant to expose a flaw in the
constructor of `Cask::Config`.

That (broken) test still passes because there’s also a flaw in our
test helper code.

The helper flaw happens to neutralize the `Cask::Config` flaw.
2020-04-27 15:00:22 +02:00
Claudia
dd3267ece0
Add test for JSON-based cask config loader
Previously, the JSON-based cask config loader was untested.
This commit changes the interface to accept a string, making the loader
easier to test. The commit also adds a test.
2020-04-27 14:54:56 +02:00
Frank Lam
dabbfe3e3e
Fix linter offenses 2020-04-26 21:31:21 +08:00
Frank Lam
f2fa2c5d30
Add JSON support to brew cask outdated
* brew outdated already has JSON support, now users and tools can get
similar results with brew cask outdated --json
2020-04-26 21:13:19 +08:00
Claudia
374f788a3c
cask/config_spec: add failing test
We recently added a new global artifact and then updated a cask to
make use of that new artifact. This caused a number of `brew cask`
commands to fail for users who had the cask installed before the
artifact was added.

This commit adds test cases for that failure mode.

See also:
- https://github.com/Homebrew/brew/pull/7286#issuecomment-613376568
- https://discourse.brew.sh/t/cask-definition-is-invalid-invalid-mdimporter-stanza-key-not-found-mdimporterdir
2020-04-21 18:26:51 +02:00
Mike McQuaid
fb0fa419ab
cask/cmd/upgrade_spec: remove more flaky tests. 2020-04-20 16:45:44 +01:00
Mike McQuaid
75c74e4674
cask/cmd/upgrade_spec: remove flaky test. 2020-04-20 09:25:16 +01:00