49 Commits

Author SHA1 Message Date
BrewTestBot
fc0ae875e3 sorbet: update RBI files using Tapioca.
Autogenerated by [a scheduled GitHub Action](https://github.com/Homebrew/brew/blob/master/.github/workflows/tapioca.yml).
2020-08-23 12:10:55 +00:00
Markus Reiter
b90290b18c Refactor and document Bottles. 2020-08-23 04:44:57 +02:00
BrewTestBot
0cfb3982f2 sorbet: update RBI files using Tapioca.
Autogenerated by [a scheduled GitHub Action](https://github.com/Homebrew/brew/blob/master/.github/workflows/tapioca.yml).
2020-08-22 17:39:15 +00:00
BrewTestBot
deffac58cd sorbet: update RBI files using Tapioca.
Autogenerated by [a scheduled GitHub Action](https://github.com/Homebrew/brew/blob/master/.github/workflows/tapioca.yml).
2020-08-22 16:06:04 +00:00
BrewTestBot
872365b4f7 sorbet: update RBI files using Tapioca.
Autogenerated by [a scheduled GitHub Action](https://github.com/Homebrew/brew/blob/master/.github/workflows/tapioca.yml).
2020-08-21 15:54:45 +00:00
vidusheeamoli
c7ce119633 sorbet: solve typecheck errors. 23 => 15 errors 2020-08-11 02:53:10 +05:30
Issy Long
1921a4e4ee
sorbet: Regenerate RBI hidden-definitions
- [The docs](https://sorbet.org/docs/rbi#the-hidden-definition-rbi) say
  we have to do this whenever gems are bumped.
2020-08-09 12:07:57 +01:00
Issy Long
7ce5b20858
sorbet: Regenerate Tapioca gem RBIs (excluding JSON) 2020-08-09 12:07:02 +01:00
vidusheeamoli
9ddf587c32 sorbet/cli.rbi: add method 2020-08-01 00:39:35 +05:30
vidusheeamoli
e8dbbc2975 sorbet: update hidden definitions 2020-08-01 00:33:27 +05:30
vidusheeamoli
5da00dcd77 srb/tapioca: update rbi of recently bumped gems 2020-08-01 00:32:05 +05:30
vidusheeamoli
1ba6d187e6 sorbet/homebrew.rbi: solve fetch.rb type error
Latest changes to fetch.rb introduced 2 new type errors.
These changes in sorbet/rbi/homebrew.rbi resolves those errors.
2020-07-26 21:09:34 +05:30
vidusheeamoli
791774691a sorbet: update hidden definitions 2020-07-26 21:06:46 +05:30
vidusheeamoli
b98fb1fcbb srb/tapioca: update rbi of recently bumped gems 2020-07-26 21:04:49 +05:30
Issy Long
fdbb2ac16a
Merge pull request #7985 from vidusheeamoli/utils-inreplace-to-true
sorbet: set utils/inreplace.rb to true
2020-07-26 10:37:30 +01:00
vidusheeamoli
c27916cd87 srb/inreplace.rbi: add method signatures 2020-07-26 13:32:17 +05:30
vidusheeamoli
fd382d2ecd srb: set utils/inreplace.rb to true and refactor
- Sorbet gives preference to class methods over methods defined in
  included modules, hence Sorbet was unavailable to resolve the
definition of the gsub! method.
- The gsub! method in StringInreplaceExtension conflicts with the definition in String.
- This PR refactors the call to the gsub! method so that a custom object
  is exposed instead of a string.
2020-07-26 12:43:31 +05:30
vidusheeamoli
3d0a68cf54 sorbet: add cli/args.rb to true 2020-07-23 22:30:05 +05:30
vidusheeamoli
637de8b48e sorbet: add compat files to true
Set the following files to true in sorbet/files.yaml:
- ./compat/extend/nil.rb
- ./compat/extend/string.rb
- ./compat/formula.rb
- ./compat/os/mac.rb
2020-07-22 23:43:02 +05:30
Issy Long
87628d3cc8
Merge pull request #8057 from vidusheeamoli/set-files-to-true
sorbet: set multiple files to true
2020-07-22 08:12:54 +01:00
vidusheeamoli
8d82aa8c3a sorbet: set multiple files to true
Set the following files to true in sorbet/files.yaml:
- ./fetch.rb
- ./formula_pin.rb
- ./hardware.rb
- ./help.rb
- ./language/go.rb
- ./language/java.rb
- ./language/perl.rb
- ./messages.rb
2020-07-22 09:52:43 +05:30
vidusheeamoli
ab4e956390 sorbet: update hidden definitions 2020-07-21 23:50:24 +05:30
vidusheeamoli
9658f011f2 srb/tapioca: update rbi of recently bumped gems 2020-07-21 23:47:42 +05:30
vidusheeamoli
775f5f88ea sorbet: set os.rb to true 2020-07-18 00:36:59 +05:30
Issy Long
2536f0a09f
Merge pull request #7946 from vidusheeamoli/utils-user-to-true
sorbet: set utils/user.rb to true
2020-07-11 17:55:44 +01:00
vidusheeamoli
9799f32506 sorbet: set utils/user.rb to true 2020-07-11 01:04:22 +05:30
vidusheeamoli
ca97f93bd4 sorbet: set utils/shebang.rb to true 2020-07-09 23:22:48 +05:30
vidusheeamoli
5d91491a93 sorbet: set utils/link.rb to true 2020-07-09 23:18:51 +05:30
Issy Long
2c3b2f68cd
Revert #7933 ("sorbet: set utils/git.rb to true")
- My refactoring of #7933 went wrong in that the tests passed for `brew
  extract` and my manual testing, but both forgot about third-party taps
  exist, so that functionality broke as follows (courtesy of Misty).

  Before:

  ```
  # Git.last_revision_commit_of_files("/usr/local/Homebrew", ["LICENSE.txt", "README.md"])
  => ["ac0665d", ["README.md"]]
  ```

  After:

  ```
  # Git.last_revision_commit_of_files("/usr/local/Homebrew", ["LICENSE.txt", "README.md"])
  => [nil, []]
  ```

- While we think about how to do splats in Sorbet, revert this so
  that users are able to `brew extract` from third party taps again.

- A TODO for later in a separate PR is to write a test for `brew
  extract` that tests the behaviour of third-party taps.

---

- Reverted this manually because the GitHub UI couldn't do it.
- Arguably I didn't need to remove the RBI file, but it's easier to have
  everything gone for now and then revert this revert in future once we
  have a strategy for dealing with splats in Sorbet than have
  inconsistency.
2020-07-09 08:18:38 +01:00
vidusheeamoli
79ac3875d5 sorbet: set utils/notability.rb to true 2020-07-08 23:38:42 +05:30
Issy Long
eee17fd1b5
Merge pull request #7933 from vidusheeamoli/utils-gem-to-true
sorbet: set utils/git.rb to true
2020-07-08 18:45:21 +01:00
vidusheeamoli
76a2e69990 sorbet: set utils/git.rb to true
(cherry picked from commit 44a04adb1de430066af73a65766eb644c0f5bd41)
2020-07-08 22:34:26 +05:30
vidusheeamoli
c8c8839ba2 sorbet: update hidden definitions
srb/tapioca: update rbi of recently bumped gems
2020-07-08 01:03:54 +05:30
vidusheeamoli
1d2e68d184 srb/tapioca: update rbi of recently bumped gems 2020-07-08 00:38:34 +05:30
vidusheeamoli
eef039ff41 sorbet: update hidden definitions 2020-07-03 11:52:15 +05:30
vidusheeamoli
59abfed56d srb/tapioca: update rbi of recently bumped gems 2020-07-03 11:52:15 +05:30
vidusheeamoli
5fe38ad7a0 srb: set utils files to true
Set utils/bottles.rb, utils/shell.rb and utils/svn.rb to true so that
type errors in these files may be reported by Sorbet

(cherry picked from commit fd3db131b0da78169fdff2031180a2bebe3cbb84)
2020-07-03 00:51:08 +05:30
vidusheeamoli
89605d2c6f sorbet/files.yaml: set utils/tty.rb to true 2020-07-02 16:05:54 +05:30
vidusheeamoli
087ee9ab6c sorbet: update hidden definitions 2020-06-30 13:06:52 +05:30
vidusheeamoli
6134af3108 srb/tapioca: update rbi of recently bumped gems 2020-06-30 13:04:13 +05:30
vidusheeamoli
0f9319cc43 sorbet: update hidden definitions 2020-06-25 03:14:32 +05:30
vidusheeamoli
715cb744a0 srb/tapioca: update rbi of recently bumped gems 2020-06-25 03:12:07 +05:30
vidusheeamoli
d6e587453e srb: resolve error 4015. 25 errors => 18 errors 2020-06-22 16:33:44 +05:30
vidusheeamoli
53858e2201 Check in new definitions to Sorbet
New files were created after the last Sorbet update.
New definitions were added to hidden-definitions and rbi/todo was
updated
2020-06-22 16:04:02 +05:30
vidusheeamoli
5b877cdd96 gitignore: add sorbet/errors.txt 2020-06-17 22:19:54 +05:30
vidusheeamoli
4b8745f32b srb: resolve error 4010. 28 errors=> 25 errors
Sorbet was reporting errors (error code: 4010) on the auto-generated tapioca RBI files.
Since sorbet-typed has a good enough RBI for json hence we can exclude json from tapioca generation using the --exclude flag.
2020-06-17 22:18:54 +05:30
vidusheeamoli
e22f628a2b tapioca: init and sync. 145 errors => 28 errors 2020-06-14 11:40:07 +05:30
vidusheeamoli
54cd4d3209 sorbet/files.yaml: set typed sigil from ignore to false 2020-06-14 11:29:36 +05:30
vidusheeamoli
9b380dcde5 add the sorbet directory 2020-06-12 02:13:13 +05:30