3989 Commits

Author SHA1 Message Date
Mike McQuaid
044f4d947b Tweak preserve link status on reinstall/upgrade.
Treat a `brew install` command as normal i.e. link by default unless
keg-only and only specify whether a keg should be linked when upgrading
or reinstalling. Also, adjust the naming accordingly so it's more
obvious that this is the case.
2017-07-30 21:44:43 +01:00
Mike McQuaid
7ec0505200 Preserve link status on reinstall/upgrade.
This means if a user has manually `brew unlink` or `brew link --force`d
something then that status will be preserved after they `brew upgrade`
or `brew reinstall` that formula.

This generally should make things that are keg-only by default easier
to swallow.
2017-07-30 16:20:32 +01:00
Mike McQuaid
b8611bd988 formula_installer: simplify callers.
There's a bunch of duplication going on that's not really necessary.
2017-07-28 15:27:47 +01:00
Mike McQuaid
baa61f5a6e Use https for all docs.brew.sh links.
May as well use the more secure link when possible.
2017-07-27 15:59:37 +01:00
Gautham Goli
086e540231 Add a rubocop config file to control cops' execution in audit and style 2017-07-18 20:23:03 +05:30
Gautham Goli
5b3231ea0a style: disable NewFormulaAudit cops' execution by default unless specified 2017-07-15 22:40:26 +05:30
Mike McQuaid
4ca2efb12d Merge pull request #2876 from VonUniGE/patch-1
Update documentation of brew install syntax to match its actual behav…
2017-07-13 21:22:55 +01:00
VonUniGE
7957e1a721 Add a suitable explanatory line 2017-07-11 23:43:28 +02:00
Tim Marinin
156e19c6dc Display "Use brew upgrade foo instead" when calling update with args
So the user could just copy-paste the command.
2017-07-10 12:30:58 +03:00
VonUniGE
16496a0b0f Update documentation of brew install syntax to match its actual behavior. 2017-07-08 00:22:18 +02:00
Mike McQuaid
81dbc29566 Merge pull request #2853 from GauthamGoli/disable-strict-cops-brew-style
style: Don't run FormulaAuditStrict cops when `brew style foo` cmd is executed
2017-07-07 15:43:55 +01:00
Gautham Goli
e9dfa736bf style: Don't run FormulaAuditStrict cops when brew style some_formula cmd is executed 2017-07-03 12:54:04 +05:30
Mike McQuaid
2b3717a5a0 Merge pull request #2842 from GauthamGoli/audit_only_cops_option
audit: Don't run audit methods when `--only-cops` option is passed
2017-07-02 14:45:29 +01:00
Gautham Goli
8c167b23cc audit: Don't run audit methods when --only-cops is passed 2017-06-30 20:25:12 +05:30
Markus Reiter
3b4ee58c49 Refactor using Forwardable and DelegateClass. 2017-06-28 09:25:31 +02:00
Markus Reiter
19cf6dcb3f 🔨 Fix sorting on APFS. 2017-06-20 15:44:54 +02:00
Matthew Strax-Haber
0dca037446 Fix outdated --repository man documentation 2017-06-15 18:25:16 -07:00
Mike McQuaid
ed9942fbd1 Merge pull request #2769 from MikeMcQuaid/rubocop-no-perl-backrefs
rubocop: don’t allow Perl regex backrefs.
2017-06-12 16:47:28 +01:00
Mike McQuaid
021cef4b2b Autocorrect Rubocop Style/SpecialGlobalVars. 2017-06-12 09:11:42 +01:00
Mike McQuaid
7a0aff1080 Autocorrect Rubocop Style/PerlBackrefs. 2017-06-10 20:23:20 +03:00
Mike McQuaid
18fb81906e reinstall: keg.rmtree isn't a method. 2017-06-08 16:24:55 +03:00
Mike McQuaid
838bb38b3e reinstall: remove partially installed keg.
Previously if a `brew reinstall` was Ctrl-Cd after some files had been
installed it wouldn't try to remove the partially installed keg and the
renaming of the backed-up keg would fail. Alternatively, remove the
partially installed keg as if it has been Ctrl-Cd or otherwise failed
then it's not desirable to keep it.
2017-06-07 15:58:13 +01:00
Bob W. Hogg
51e83cdf91 cmd/reinstall: Fix reinstallation of formulae without bottles
Reinstallation of non-bottled formulae was failing because it
used a deprecated method.

Signed-off-by: Bob W. Hogg <rwhogg@linux.com>
2017-06-05 18:35:43 -07:00
Mike McQuaid
54e01d76db Merge pull request #2599 from peternewman/patch-1
Fix internal links on the manpage
2017-06-04 11:52:13 +01:00
Mike McQuaid
9e17e44b3e Change manpage internal links in correct location. 2017-06-04 11:12:56 +01:00
Markus Reiter
7c0a3a1233 Fix rubocop in brew audit. 2017-06-03 23:50:31 +02:00
Mike McQuaid
34670f9b22 Merge pull request #2720 from MikeMcQuaid/install-cask-env-filtering
install: fix cask install with env filtering.
2017-06-03 10:00:27 +01:00
Markus Reiter
8d514ae8f0 Merge pull request #2716 from reitermarkus/re-revert
Re-revert "Fix operator spacing."
2017-06-03 00:49:06 +02:00
Mike McQuaid
8d2794212f search: don’t exclude Caskroom results even if tapped.
As they are not shown in the normal `brew search` output.
2017-06-02 22:19:04 +01:00
Mike McQuaid
5dc11c6b93 install: fix cask install with env filtering.
With `HOMEBREW_ENV_FILTERING` simply running `brew` is not sufficient
to find `brew cask` so the full path needs to be passed.
2017-06-02 22:17:18 +01:00
Markus Reiter
2d6ae61314 Re-revert "Fix operator spacing." 2017-06-02 19:22:05 +02:00
ilovezfs
197392b56d Revert "Fix operator spacing." 2017-06-01 04:06:40 -07:00
Markus Reiter
d34ba7395b Fix operator spacing. 2017-05-31 19:53:41 +02:00
Misty De Meo
587f338daa
vendor-install: use Ruby as a sha256 fallback
But still prefer shasum/sha256sum where present.
2017-05-30 18:48:55 -07:00
Mike McQuaid
7a38bab333 Fixup all RuboCop warnings. 2017-05-29 18:43:18 +01:00
Mike McQuaid
4356016b4a Use parallel RuboCop
This requires updating to Rubocop 0.49.0 which will require some fixes
to rules, in Homebrew/brew and Homebrew/homebrew-core but opening this
for now so I remember.
2017-05-29 18:42:02 +01:00
Markus Reiter
d700a5ba18 Use Formatter::pluralize where possible. 2017-05-29 17:50:13 +02:00
Mike McQuaid
c2cb2c7868 Merge pull request #2682 from MikeMcQuaid/improve-installed-messaging
Improve some `brew install` messaging.
2017-05-29 09:15:15 +01:00
Markus Reiter
54c4580871 Use XDG_CACHE_HOME for RuboCop. 2017-05-29 01:31:38 +02:00
Mike McQuaid
ef59a751f4 Improve some brew install messaging.
Improve the messaging around `brew install` when there's a possible user
action such as an `upgrade` or `link` and don't tell people to
`install --force` when it's unnecessary.

While I did this, tweak the output and function usage in a couple of
related places.

Some example output before this change:
```
Warning: openssl is a keg-only and another version is linked to opt.
Use `brew install --force` if you want to install this version
Warning: mysql@5.6 is a keg-only and another version is linked to opt.
Use `brew install --force` if you want to install this version
Warning: analog-6.0_1 already installed
Warning: bash-completion@2-2.5 already installed, it's just not linked.
```

Some example output after this change:
```
Error: openssl 1.0.2k is already installed
To upgrade to 1.0.2l, run `brew upgrade openssl`
Warning: mysql@5.6 5.6.36_1 is already installed
Warning: analog 6.0_1 is already installed
Warning: bash-completion@2 2.5 is already installed, it's just not linked.
You can use `brew link bash-completion@2` to link this version.
```
2017-05-27 10:15:37 +01:00
Misty De Meo
6453c81dac
vendor-install: fix array syntax for old bash 2017-05-23 18:39:35 -07:00
Misty De Meo
b8fee7fe4d
vendor-install: check -x on output of which
This works around older versions of `which`, which return a
string on failure.
2017-05-23 18:36:25 -07:00
Markus Reiter
df1864ee43 Add CLI::Options DSL. 2017-05-22 02:51:17 +02:00
Markus Reiter
f0dc1d96c5 Merge pull request #2537 from reitermarkus/pathname-to_str
Remove `to_s` from some `Pathname`s.
2017-05-18 09:39:07 +02:00
Mike McQuaid
2b726383f1 info: fix conflicts formatting. 2017-05-16 10:05:05 +01:00
Mike McQuaid
aeaf9af711 Merge pull request #2470 from johnhawkinson/conflicts-info
Display formula conflict reasons
2017-05-16 08:45:45 +01:00
Mike McQuaid
8e2198ff01 info: tweak conflicts output code. 2017-05-15 10:40:07 +01:00
John Hawkinson
33d4c95a28 info: use more string interpolation 2017-05-14 15:09:01 -04:00
Markus Reiter
5828eefd01 Remove to_s from some Pathnames. 2017-05-08 13:37:28 +02:00
Mike McQuaid
57db2e539e Revert "Merge pull request #2597 from MikeMcQuaid/vendor-gems"
This reverts commit 3e4547f52e7ebec633f8bfefc8a396d944edf908, reversing
changes made to 6edf9382bcc1240ad6f97c8b752cfe56cef9965d.
2017-05-07 17:28:39 +01:00