admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
22,820 Commits 15 Branches 471 Tags
Commit Graph

456 Commits

Author SHA1 Message Date
Jack Nagel
c0eb8a3bc8 doctor: warn about wide terminals 
A terminal width of 262 or greater can trigger a buffer overflow in
curl's progress bar code, resulting in a segfault and aborted downloads.
Warn about this.

cf Homebrew/homebrew#8521.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2011-11-10 20:47:17 -06:00
Jack Nagel
e7947f4f92 doctor: minor grammatical fix 
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2011-11-10 19:49:26 -06:00
Jack Nagel
9a9846814f doctor: correctly detect CLICOLOR_FORCE 
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2011-10-18 20:10:57 -05:00
Jack Nagel
d73df34bc6 doctor: check git version 
Checking out over HTTP/HTTPS from GitHub requires git 1.6.6, as GitHub
only allows Smart HTTP transport.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2011-10-10 18:20:50 -05:00
Jack Nagel
2f85acfeb2 doctor: warn about expired SSL certs on Leopard 
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2011-10-03 13:57:33 -05:00
Jack Nagel
9bce115e9a doctor: remove redundant sentence 
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2011-09-27 23:35:30 -05:00
Jack Nagel
d817e5e51e doctor: only check git status if repository exists 
Closes Homebrew/homebrew#7722.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2011-09-19 21:49:29 -05:00
Adam Vandenberg
3898010309 doctor: restore some line breaks 2011-09-16 10:05:11 -07:00
Jack Nagel
627a8463a6 doctor: be more robust about git status check 
`git status -s` would spit out "fatal: not a git repository" when not in
HOMEBREW_PREFIX or a child directory of HOMEBREW_PREFIX. Specify a
git-dir and work-tree to fix this.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2011-09-11 11:12:08 -05:00
Max Howell
c959b37227 The doctor notices modifications to Homebrew core 
Refs Homebrew/homebrew#7525.
 2011-09-09 09:24:16 +01:00
Max Howell
b145d075c1 Check that /usr/bin/cc exists in brew doctor 
Refs Homebrew/homebrew#7454.
 2011-09-07 12:18:28 +01:00
Daemian Mack
74ee65466c Fix typo in brew doctor 
Fixes Homebrew/homebrew#7383.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2011-09-02 10:00:15 -05:00
Adam Vandenberg
80335bba74 add brew doctor check for spaces in Xcode path 2011-09-01 09:39:31 -07:00
Max Howell
c0653d7581 Improved no-errors output 2011-08-31 15:38:21 +01:00
Max Howell
bfabfe77dd Only report PATH order diagnosis if conflicts are found 
Rationale: brew doctor shouldn't give warnings for a default install. And this particular warning only applies for a small subset of formula: the ones that are "dupes".

If we get reported issues that prove this was a mistake we will revert it.
 2011-08-31 15:38:11 +01:00
Max Howell
0aca152f23 Check for missing deps as part of brew doctor 2011-08-31 15:36:29 +01:00
Adam Vandenberg
6666494551 brew doctor: do not check TMPDIR if it is not set 2011-08-07 10:01:52 -07:00
Max Howell
cb049409e5 Fix brew doctor if sbin directory doesn't exist 2011-08-02 14:45:03 +01:00
Adam Vandenberg
733e280e61 fix doctor on 10.5 2011-07-30 22:24:19 -07:00
Max Howell
76745610ec Emphasise the consequence of not installing to /usr/local 2011-07-29 15:21:10 +01:00
Max Howell
01a779655c Writability for /usr/local is no longer required 
Provided the user installed with our installer anyway. It creates all the directories that Homebrew will need during its life thus negating the need for root writability.
 2011-07-29 14:56:59 +01:00
Max Howell
36ce83fd8d Don't mention the sbin PATH issue unless files are there 
Because the new installer will always create /usr/local/sbin. Because we must keep /usr/local root:wheel unless we want to be considered bad citizens.
 2011-07-29 14:54:42 +01:00
risk
a10aa12f29 check for a valid $TMPDIR path in brew doctor 
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
 2011-07-28 19:50:39 -07:00
Adam Vandenberg
e2b21b0b4a Fix brew doctor when no Xcode is detected. 2011-07-26 16:01:30 -07:00
Jack Nagel
5b06a27e99 doctor: be more forgiving about GREP_OPTIONS 
Currently, `brew doctor` complains about GREP_OPTIONS being set,
regardless of its value. The cmake formula, for which this check was
introduced, is more specific about what actually makes it fail.

GREP_OPTIONS='--color=auto' will not cause the build to fail, so don't
warn about this.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
 2011-07-25 16:25:44 -07:00
Brant Bobby
113eaf26e4 Fix typo in brew doctor command 
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
 2011-07-22 11:47:13 -07:00
Charlie Sharpsteen
fbff2ee853 Retire check for GCC 4.0 under XCode 4.x 
XCode 4.x only includes GCC 4.2. Therefore, having `brew doctor` report that
GCC 4.0 is missing only spreads fear, uncertainty and doubt over a situation
that is status quo.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
 2011-07-21 08:10:33 -07:00
Mislav Marohnić
f0eab140f8 doctor: don't report wrong location of autoconf if it's missing 
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
 2011-07-10 12:18:55 -07:00
Adam Vandenberg
cee1003782 brew-doctor: use String.start_with? 2011-06-19 21:32:54 -07:00
Les Hill
0d44609dfb doctor: check /usr/local for writablity 
- Airfoil during the install of InstantOn changes /usr/local to
  root:wheel ownership

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
 2011-06-19 09:46:57 -07:00
Adam Vandenberg
b15be6965d brew-doctor: do not complain about trailing slashes 2011-06-07 13:18:00 -07:00
Mislav Marohnić
04b90610a3 the doctor command exits with status "1" if there are warnings 
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
 2011-06-03 21:16:02 -07:00
Mislav Marohnić
129b80fb9b simplify the $stdout hijack in doctor command 
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
 2011-06-03 21:15:58 -07:00
Mislav Marohnić
bcb8fcf6dc fix doctor command in case Cellar dir doesn't yet exist 
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
 2011-06-03 21:15:55 -07:00
Adam Vandenberg
884048c52a brew-doctor: only check sbin if it exists 2011-06-02 09:27:11 -07:00
Adam Vandenberg
7e132a8c46 brew doctor: update autoconf message 2011-05-26 22:19:22 -07:00
Adam Vandenberg
3718a60c90 brew doctor: find suspicious git newline configs 2011-05-12 08:47:51 -07:00
Adam Vandenberg
d44a0561ea brew doctor: check for stray .la files 2011-05-12 08:10:47 -07:00
Adam Vandenberg
8fea11e764 brew doctor: warn about Mono and CMake 2011-05-12 07:24:10 -07:00
Adam Vandenberg
f4cd85aa49 brew doctor: add check for stray .pc files 2011-05-09 17:23:35 -07:00
Adam Vandenberg
f253cf3b10 brew doctor: check for stray static libs too 
CMake will pick up static libs in /usr/local.
 2011-05-05 09:40:03 -07:00
Adam Vandenberg
d7b50a5820 brew doctor: hard-code full path to mount command 2011-04-29 09:15:39 -07:00
Adam Vandenberg
66110c78e7 brew doctor: add check for GREP_OPTIONS 2011-04-04 09:21:44 -07:00
Adam Vandenberg
29ac3efe2e brew doctor: update expat check 
Apaprently both expat.framework and libexpat.framework exist
and interfere with CMake.
 2011-04-04 08:48:42 -07:00
Adam Vandenberg
2decef8c36 Fix CLICOLOR_FORCE check 2011-04-01 13:42:12 -07:00
Adam Vandenberg
4a4186c583 brew doctor - only check unique path folders 2011-03-29 12:45:54 -07:00
Adam Vandenberg
8c7ac47c85 brew doctor - add check for CLICOLOR_FORCE 2011-03-28 11:57:57 -07:00
Adam Vandenberg
9f8432bfcf brew doctor - reword stray dylib message 2011-03-28 11:51:59 -07:00
Adam Vandenberg
3fcacb041d brew doctor - also check permisisons on share 2011-03-28 11:48:45 -07:00
Mike McQuaid
80f98a1a19 Don't make brew doctor complain about Xcode 4. 2011-03-14 21:00:51 +00:00